[GitHub] [doris] zhannngchen commented on pull request #19562: [fix](storage) query with __DORIS_VERSION_COL__ predicate may not work as expect

2023-05-18 Thread via GitHub
zhannngchen commented on PR #19562: URL: https://github.com/apache/doris/pull/19562#issuecomment-1553909026 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] github-actions[bot] commented on pull request #19850: [FIX](Array)fix be master comapitible with fe1.2

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19850: URL: https://github.com/apache/doris/pull/19850#issuecomment-1553909244 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] amorynan commented on pull request #19850: [FIX](Array)fix be master comapitible with fe1.2

2023-05-18 Thread via GitHub
amorynan commented on PR #19850: URL: https://github.com/apache/doris/pull/19850#issuecomment-1553909564 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] github-actions[bot] commented on pull request #19764: [fix-test](client-cache) Replace ThriftClientImpl* with smart pointer

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19764: URL: https://github.com/apache/doris/pull/19764#issuecomment-1553910386 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #19099: [performance](stream-load) use vector instead of skiplist when insert agg keys

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19099: URL: https://github.com/apache/doris/pull/19099#issuecomment-1553910586 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #19850: [FIX](Array)fix be master comapitible with fe1.2

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19850: URL: https://github.com/apache/doris/pull/19850#issuecomment-1553911061 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #19850: [FIX](Array)fix be master comapitible with fe1.2

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19850: URL: https://github.com/apache/doris/pull/19850#issuecomment-1553911082 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] yiguolei commented on a diff in pull request #19758: [refactor](exec) replace the single pointer with an array of 'conjuncts' in ExecNode

2023-05-18 Thread via GitHub
yiguolei commented on code in PR #19758: URL: https://github.com/apache/doris/pull/19758#discussion_r1198482832 ## be/src/olap/reader.h: ## @@ -153,7 +154,7 @@ class TabletReader { // limit of rows for read_orderby_key size_t read_orderby_key_limit = 0;

[GitHub] [doris] github-actions[bot] commented on pull request #19736: [fix](merge-on-write) return error st if check_pk_in_pre_segments failed

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19736: URL: https://github.com/apache/doris/pull/19736#issuecomment-1553917141 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #19846: [Chore](build) fix typo in build.sh

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19846: URL: https://github.com/apache/doris/pull/19846#issuecomment-1553917433 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #19846: [Chore](build) fix typo in build.sh

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19846: URL: https://github.com/apache/doris/pull/19846#issuecomment-1553917415 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] CalvinKirs closed pull request #19834: [refactor](routineload)Refactored routineload to improve scalability

2023-05-18 Thread via GitHub
CalvinKirs closed pull request #19834: [refactor](routineload)Refactored routineload to improve scalability URL: https://github.com/apache/doris/pull/19834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [doris] jackwener opened a new pull request, #19851: [minor](Nereids): add toString() for LogicalProperties

2023-05-18 Thread via GitHub
jackwener opened a new pull request, #19851: URL: https://github.com/apache/doris/pull/19851 # Proposed changes Issue Number: close #xxx ## Problem summary add toString() for LogicalProperties ## Checklist(Required) * [ ] Does it affect the original behavior

[GitHub] [doris] jackwener commented on pull request #19851: [minor](Nereids): add toString() for LogicalProperties

2023-05-18 Thread via GitHub
jackwener commented on PR #19851: URL: https://github.com/apache/doris/pull/19851#issuecomment-1553924514 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] github-actions[bot] commented on pull request #19752: [Enhancement](meta) Show remote data usage via SHOW DATA #19533

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19752: URL: https://github.com/apache/doris/pull/19752#issuecomment-1553924718 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] yiguolei commented on a diff in pull request #19758: [refactor](exec) replace the single pointer with an array of 'conjuncts' in ExecNode

2023-05-18 Thread via GitHub
yiguolei commented on code in PR #19758: URL: https://github.com/apache/doris/pull/19758#discussion_r1198490395 ## be/src/service/point_query_executor.h: ## @@ -89,7 +89,7 @@ class Reusable { TupleDescriptor* tuple_desc() { return _desc_tbl->get_tuple_descriptor(0); }

[GitHub] [doris] yiguolei commented on a diff in pull request #19758: [refactor](exec) replace the single pointer with an array of 'conjuncts' in ExecNode

2023-05-18 Thread via GitHub
yiguolei commented on code in PR #19758: URL: https://github.com/apache/doris/pull/19758#discussion_r1198490998 ## be/src/vec/exec/format/orc/vorc_reader.h: ## @@ -90,7 +90,7 @@ struct OrcPredicate { }; struct LazyReadContext { -VExprContext* vconjunct_ctx = nullptr; +

[GitHub] [doris] hqx871 commented on pull request #19371: [feature](array-type) Unique table support array value (#17024)

2023-05-18 Thread via GitHub
hqx871 commented on PR #19371: URL: https://github.com/apache/doris/pull/19371#issuecomment-1553925835 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] yiguolei commented on a diff in pull request #19758: [refactor](exec) replace the single pointer with an array of 'conjuncts' in ExecNode

2023-05-18 Thread via GitHub
yiguolei commented on code in PR #19758: URL: https://github.com/apache/doris/pull/19758#discussion_r1198491472 ## be/src/vec/exec/format/parquet/vparquet_group_reader.cpp: ## @@ -97,7 +97,7 @@ RowGroupReader::RowGroupReader(io::FileReaderSPtr file_reader, RowGroupReader::~Ro

[GitHub] [doris] BiteTheDDDDt commented on pull request #19824: [Feature](aggregation) add agg_state define and ddl support

2023-05-18 Thread via GitHub
BiteThet commented on PR #19824: URL: https://github.com/apache/doris/pull/19824#issuecomment-1553926464 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] github-actions[bot] commented on pull request #19845: [Fix](inverted index) add datev2/datetimev2 for inverted index column type

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19845: URL: https://github.com/apache/doris/pull/19845#issuecomment-1553927114 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] morningman commented on pull request #19842: [refactor](cluster)(step-2) remove cluster related to Backend

2023-05-18 Thread via GitHub
morningman commented on PR #19842: URL: https://github.com/apache/doris/pull/19842#issuecomment-1553927161 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] BiteTheDDDDt commented on pull request #19738: [Chore](build) change CMAKE_CXX_STANDARD from 17 to 20

2023-05-18 Thread via GitHub
BiteThet commented on PR #19738: URL: https://github.com/apache/doris/pull/19738#issuecomment-1553927594 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] amorynan commented on pull request #19830: [Improve](complex-type)improve array/map/struct creating and function with decimalv3

2023-05-18 Thread via GitHub
amorynan commented on PR #19830: URL: https://github.com/apache/doris/pull/19830#issuecomment-1553928273 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] hqx871 commented on pull request #19371: [feature](array-type) Unique table support array value (#17024)

2023-05-18 Thread via GitHub
hqx871 commented on PR #19371: URL: https://github.com/apache/doris/pull/19371#issuecomment-1553928272 > Hi @hqx871 , this feature is not tested and missing document. We need first add them on master, and merge it to branch 1.2 only if it pass the test. Sorry so late for your question

[GitHub] [doris] github-actions[bot] commented on pull request #19738: [Chore](build) change CMAKE_CXX_STANDARD from 17 to 20

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19738: URL: https://github.com/apache/doris/pull/19738#issuecomment-1553929025 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] bobhan1 commented on pull request #19822: [refactor-WIP](TaskWorkerPool) add specific classes for PUSH, PUBLIC_…

2023-05-18 Thread via GitHub
bobhan1 commented on PR #19822: URL: https://github.com/apache/doris/pull/19822#issuecomment-1553929965 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] github-actions[bot] commented on pull request #19822: [refactor-WIP](TaskWorkerPool) add specific classes for PUSH, PUBLIC_…

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19822: URL: https://github.com/apache/doris/pull/19822#issuecomment-1553930770 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] xinyiZzz commented on a diff in pull request #19802: [feature-wip](resouce-group) Supports memory soft isolation of resource group

2023-05-18 Thread via GitHub
xinyiZzz commented on code in PR #19802: URL: https://github.com/apache/doris/pull/19802#discussion_r1198495835 ## be/src/util/mem_info.cpp: ## @@ -144,6 +146,8 @@ bool MemInfo::process_minor_gc() { // TODO add freed_mem SegmentLoader::instance()->prune(); +freed

[GitHub] [doris] xinyiZzz commented on a diff in pull request #19802: [feature-wip](resouce-group) Supports memory soft isolation of resource group

2023-05-18 Thread via GitHub
xinyiZzz commented on code in PR #19802: URL: https://github.com/apache/doris/pull/19802#discussion_r1198496049 ## be/src/util/mem_info.cpp: ## @@ -187,6 +191,8 @@ bool MemInfo::process_full_gc() { } } +freed_mem += tg_soft_memory_limit_gc(_s_process_minor_gc

[GitHub] [doris] deadlinefen commented on pull request #19764: [fix-test](client-cache) Replace ThriftClientImpl* with smart pointer

2023-05-18 Thread via GitHub
deadlinefen commented on PR #19764: URL: https://github.com/apache/doris/pull/19764#issuecomment-1553932737 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [doris] eldenmoon opened a new pull request, #19852: [Doc](point query) Modify the document to add constraints and limitat…

2023-05-18 Thread via GitHub
eldenmoon opened a new pull request, #19852: URL: https://github.com/apache/doris/pull/19852 …ions for optimizing high-concurrency point queries. # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required)

[GitHub] [doris] eldenmoon commented on pull request #19852: [Doc](point query) Modify the document to add constraints and limitat…

2023-05-18 Thread via GitHub
eldenmoon commented on PR #19852: URL: https://github.com/apache/doris/pull/19852#issuecomment-1553933314 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] xiaokang commented on pull request #19843: [test](inverted index) add testcases for inverted index on different datatypes

2023-05-18 Thread via GitHub
xiaokang commented on PR #19843: URL: https://github.com/apache/doris/pull/19843#issuecomment-1553934552 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] gaojunjie03 opened a new issue, #19853: can not cast from origin type org.apache.doris.catalog.MultiRowType@59087c43 to target type=VARCHAR(255)

2023-05-18 Thread via GitHub
gaojunjie03 opened a new issue, #19853: URL: https://github.com/apache/doris/issues/19853 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version 1.2.0 ### Wha

[GitHub] [doris] github-actions[bot] commented on pull request #19237: [Feature](compaction) wip: single replica compaction

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19237: URL: https://github.com/apache/doris/pull/19237#issuecomment-1553937390 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] HappenLee commented on pull request #19789: [feature](profile)Add the filtering information of the Bloom filter in profile.

2023-05-18 Thread via GitHub
HappenLee commented on PR #19789: URL: https://github.com/apache/doris/pull/19789#issuecomment-1553939110 do not add useless blackspace -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [doris] is-shidian commented on issue #19516: [Enhancement] insert large int to char

2023-05-18 Thread via GitHub
is-shidian commented on issue #19516: URL: https://github.com/apache/doris/issues/19516#issuecomment-1553941754 Hello, I'm new to here . Could I have a try? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [doris] HappenLee commented on a diff in pull request #19789: [feature](profile)Add the filtering information of the Bloom filter in profile.

2023-05-18 Thread via GitHub
HappenLee commented on code in PR #19789: URL: https://github.com/apache/doris/pull/19789#discussion_r1198505795 ## be/src/vec/exec/scan/new_olap_scan_node.cpp: ## @@ -642,4 +642,32 @@ bool NewOlapScanNode::_is_key_column(const std::string& key_name) { return res != _olap_

[GitHub] [doris] HappenLee commented on a diff in pull request #19789: [feature](profile)Add the filtering information of the Bloom filter in profile.

2023-05-18 Thread via GitHub
HappenLee commented on code in PR #19789: URL: https://github.com/apache/doris/pull/19789#discussion_r1198505971 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -1603,11 +1604,21 @@ uint16_t SegmentIterator::_evaluate_short_circuit_predicate(uint16_t* vec_sel_ro

[GitHub] [doris] HappenLee commented on a diff in pull request #19789: [feature](profile)Add the filtering information of the Bloom filter in profile.

2023-05-18 Thread via GitHub
HappenLee commented on code in PR #19789: URL: https://github.com/apache/doris/pull/19789#discussion_r1198506477 ## be/src/vec/exec/scan/new_olap_scan_node.cpp: ## @@ -642,4 +642,32 @@ bool NewOlapScanNode::_is_key_column(const std::string& key_name) { return res != _olap_

[GitHub] [doris] kaka11chen commented on a diff in pull request #19758: [refactor](exec) replace the single pointer with an array of 'conjuncts' in ExecNode

2023-05-18 Thread via GitHub
kaka11chen commented on code in PR #19758: URL: https://github.com/apache/doris/pull/19758#discussion_r1198508320 ## be/src/vec/exec/format/orc/vorc_reader.h: ## @@ -90,7 +90,7 @@ struct OrcPredicate { }; struct LazyReadContext { -VExprContext* vconjunct_ctx = nullptr; +

[GitHub] [doris] Gabriel39 commented on pull request #19801: [Bug](DecimalV3) fix decimalv3 functions

2023-05-18 Thread via GitHub
Gabriel39 commented on PR #19801: URL: https://github.com/apache/doris/pull/19801#issuecomment-1553948803 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] zddr opened a new pull request, #19854: [feature-wip](MTMV) support multi catalog

2023-05-18 Thread via GitHub
zddr opened a new pull request, #19854: URL: https://github.com/apache/doris/pull/19854 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. support multi catalog ## Checklist(Required) * [ ] Does it affect the origina

[GitHub] [doris] github-actions[bot] commented on pull request #19801: [Bug](DecimalV3) fix decimalv3 functions

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19801: URL: https://github.com/apache/doris/pull/19801#issuecomment-1553950210 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] zddr commented on pull request #19854: [feature-wip](MTMV) support multi catalog

2023-05-18 Thread via GitHub
zddr commented on PR #19854: URL: https://github.com/apache/doris/pull/19854#issuecomment-1553950332 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [doris] kaka11chen commented on a diff in pull request #19758: [refactor](exec) replace the single pointer with an array of 'conjuncts' in ExecNode

2023-05-18 Thread via GitHub
kaka11chen commented on code in PR #19758: URL: https://github.com/apache/doris/pull/19758#discussion_r1198511513 ## be/src/vec/exec/format/parquet/vparquet_group_reader.h: ## @@ -77,7 +77,7 @@ class RowGroupReader { }; struct LazyReadContext { -VExprContext*

[GitHub] [doris] dataroaring opened a new pull request, #19855: [improvement](stacktrace) do not captute stack trace for txn

2023-05-18 Thread via GitHub
dataroaring opened a new pull request, #19855: URL: https://github.com/apache/doris/pull/19855 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Ha

[GitHub] [doris] Tanya-W commented on pull request #19838: [fix](schema change) Change table state to NORMAL by SchemaChangeJob instead of SchemaChangeHandler

2023-05-18 Thread via GitHub
Tanya-W commented on PR #19838: URL: https://github.com/apache/doris/pull/19838#issuecomment-1553953681 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] github-actions[bot] commented on pull request #19827: [Fix](planner)fix type incompatible after fold constant by be on 1.1

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19827: URL: https://github.com/apache/doris/pull/19827#issuecomment-1553955759 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #19827: [Fix](planner)fix type incompatible after fold constant by be on 1.1

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19827: URL: https://github.com/apache/doris/pull/19827#issuecomment-1553955780 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] qidaye merged pull request #19846: [Chore](build) fix typo in build.sh

2023-05-18 Thread via GitHub
qidaye merged PR #19846: URL: https://github.com/apache/doris/pull/19846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apach

[doris] branch master updated (609b20bd02 -> a0c3ebeeab)

2023-05-18 Thread jianliangqi
This is an automated email from the ASF dual-hosted git repository. jianliangqi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 609b20bd02 [Feature](planner) use partial update in update from & delete from (#19262) add a0c3ebeeab [Chore

Error while running github feature from .asf.yaml in doris!

2023-05-18 Thread Apache Infrastructure
An error occurred while running github feature in .asf.yaml!: You can only have a maximum of 10 external triage collaborators, please contact vp-in...@apache.org to request an exception. - To unsubscribe, e-mail: commits-unsub

[GitHub] [doris] qidaye merged pull request #19820: [explain](point query) modify explain for SHORT-CIRCUIT query

2023-05-18 Thread via GitHub
qidaye merged PR #19820: URL: https://github.com/apache/doris/pull/19820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apach

[doris] branch master updated (a0c3ebeeab -> cf7083d58b)

2023-05-18 Thread jianliangqi
This is an automated email from the ASF dual-hosted git repository. jianliangqi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from a0c3ebeeab [Chore](build) fix typo in build.sh (#19846) add cf7083d58b [explain](point query) modify explain

Error while running github feature from .asf.yaml in doris!

2023-05-18 Thread Apache Infrastructure
An error occurred while running github feature in .asf.yaml!: You can only have a maximum of 10 external triage collaborators, please contact vp-in...@apache.org to request an exception. - To unsubscribe, e-mail: commits-unsub

[GitHub] [doris] github-actions[bot] commented on pull request #19845: [Fix](inverted index) add datev2/datetimev2 for inverted index column type

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19845: URL: https://github.com/apache/doris/pull/19845#issuecomment-1553958130 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] yiguolei commented on a diff in pull request #19759: [improvement](session variable) add max execution time session variabe like mysql and add setter attributes in variables

2023-05-18 Thread via GitHub
yiguolei commented on code in PR #19759: URL: https://github.com/apache/doris/pull/19759#discussion_r1198516648 ## fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java: ## @@ -367,6 +368,14 @@ public class SessionVariable implements Serializable, Writable { @V

[GitHub] [doris] yiguolei commented on a diff in pull request #19759: [improvement](session variable) add max execution time session variabe like mysql and add setter attributes in variables

2023-05-18 Thread via GitHub
yiguolei commented on code in PR #19759: URL: https://github.com/apache/doris/pull/19759#discussion_r1198516921 ## fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java: ## @@ -367,6 +368,14 @@ public class SessionVariable implements Serializable, Writable { @V

[GitHub] [doris] BiteTheDDDDt commented on pull request #19791: [Bug](function) fix function in get wrong result when input const column

2023-05-18 Thread via GitHub
BiteThet commented on PR #19791: URL: https://github.com/apache/doris/pull/19791#issuecomment-1553959409 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] wangbo commented on pull request #19659: [test](executor)add crud regression test for resource group

2023-05-18 Thread via GitHub
wangbo commented on PR #19659: URL: https://github.com/apache/doris/pull/19659#issuecomment-1553959871 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] github-actions[bot] commented on pull request #19791: [Bug](function) fix function in get wrong result when input const column

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19791: URL: https://github.com/apache/doris/pull/19791#issuecomment-1553960311 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] yiguolei commented on a diff in pull request #19845: [Fix](inverted index) add datev2/datetimev2 for inverted index column type

2023-05-18 Thread via GitHub
yiguolei commented on code in PR #19845: URL: https://github.com/apache/doris/pull/19845#discussion_r1198522025 ## fe/fe-common/src/main/java/org/apache/doris/catalog/Type.java: ## @@ -149,6 +149,10 @@ public abstract class Type { numericDateTimeTypes = Lists.newArrayLi

[GitHub] [doris] yiguolei commented on pull request #19847: [improvement](exchange) data stream sender stop sending data to receiver if it returns eos early

2023-05-18 Thread via GitHub
yiguolei commented on PR #19847: URL: https://github.com/apache/doris/pull/19847#issuecomment-1553967364 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] zy-kkk opened a new pull request, #19856: [improvement](jdbc catalog) set oceanbase mysql mode jdbc param `useCursorFetch` default true

2023-05-18 Thread via GitHub
zy-kkk opened a new pull request, #19856: URL: https://github.com/apache/doris/pull/19856 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has uni

[GitHub] [doris] yiguolei commented on a diff in pull request #19847: [improvement](exchange) data stream sender stop sending data to receiver if it returns eos early

2023-05-18 Thread via GitHub
yiguolei commented on code in PR #19847: URL: https://github.com/apache/doris/pull/19847#discussion_r1198523822 ## be/src/vec/sink/vdata_stream_sender.cpp: ## @@ -494,15 +517,32 @@ Status VDataStreamSender::open(RuntimeState* state) { return Status::OK(); } +std::vector:

[GitHub] [doris] xinyiZzz commented on a diff in pull request #19802: [feature-wip](resouce-group) Supports memory soft isolation of resource group

2023-05-18 Thread via GitHub
xinyiZzz commented on code in PR #19802: URL: https://github.com/apache/doris/pull/19802#discussion_r1198523830 ## be/src/runtime/task_group/task_group.cpp: ## @@ -132,17 +148,23 @@ void TaskGroup::remove_mem_tracker_limiter(std::shared_ptr me } int64_t TaskGroup::memory_li

[GitHub] [doris] yiguolei commented on a diff in pull request #19847: [improvement](exchange) data stream sender stop sending data to receiver if it returns eos early

2023-05-18 Thread via GitHub
yiguolei commented on code in PR #19847: URL: https://github.com/apache/doris/pull/19847#discussion_r1198523994 ## be/src/vec/sink/vdata_stream_sender.h: ## @@ -160,6 +161,10 @@ class VDataStreamSender : public DataSink { Status channel_add_rows(Channels& channels, int num_

[GitHub] [doris] morrySnow opened a new pull request, #19857: [fix](Nereids) drop table before create table in window function test

2023-05-18 Thread via GitHub
morrySnow opened a new pull request, #19857: URL: https://github.com/apache/doris/pull/19857 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has

[GitHub] [doris] morrySnow commented on pull request #19857: [fix](Nereids) drop table before create table in window function test

2023-05-18 Thread via GitHub
morrySnow commented on PR #19857: URL: https://github.com/apache/doris/pull/19857#issuecomment-1553970932 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] dataroaring commented on pull request #19099: [performance](stream-load) use vector instead of skiplist when insert agg keys

2023-05-18 Thread via GitHub
dataroaring commented on PR #19099: URL: https://github.com/apache/doris/pull/19099#issuecomment-1553971330 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] zy-kkk commented on pull request #19856: [improvement](jdbc catalog) set oceanbase mysql mode jdbc param `useCursorFetch` default true

2023-05-18 Thread via GitHub
zy-kkk commented on PR #19856: URL: https://github.com/apache/doris/pull/19856#issuecomment-1553971469 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] amorynan commented on pull request #19830: [Improve](complex-type)improve array/map/struct creating and function with decimalv3

2023-05-18 Thread via GitHub
amorynan commented on PR #19830: URL: https://github.com/apache/doris/pull/19830#issuecomment-1553973475 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] github-actions[bot] commented on pull request #19659: [test](executor)add crud regression test for resource group

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19659: URL: https://github.com/apache/doris/pull/19659#issuecomment-1553973910 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #19659: [test](executor)add crud regression test for resource group

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19659: URL: https://github.com/apache/doris/pull/19659#issuecomment-1553973927 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] csun5285 commented on pull request #19237: [Feature](compaction) wip: single replica compaction

2023-05-18 Thread via GitHub
csun5285 commented on PR #19237: URL: https://github.com/apache/doris/pull/19237#issuecomment-1553978947 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris-thirdparty] adonis0147 opened a new pull request, #73: [chore] Fix the compilation errors on macOS (arm64)

2023-05-18 Thread via GitHub
adonis0147 opened a new pull request, #73: URL: https://github.com/apache/doris-thirdparty/pull/73 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [doris] wangbo commented on a diff in pull request #19802: [feature-wip](resouce-group) Supports memory soft isolation of resource group

2023-05-18 Thread via GitHub
wangbo commented on code in PR #19802: URL: https://github.com/apache/doris/pull/19802#discussion_r1198534222 ## be/src/util/mem_info.cpp: ## @@ -215,6 +221,52 @@ bool MemInfo::process_full_gc() { return false; } +int64_t MemInfo::tg_hard_memory_limit_gc() { +std::ve

[GitHub] [doris] wangbo commented on a diff in pull request #19802: [feature-wip](resouce-group) Supports memory soft isolation of resource group

2023-05-18 Thread via GitHub
wangbo commented on code in PR #19802: URL: https://github.com/apache/doris/pull/19802#discussion_r1198536864 ## be/src/util/mem_info.cpp: ## @@ -215,6 +221,52 @@ bool MemInfo::process_full_gc() { return false; } +int64_t MemInfo::tg_hard_memory_limit_gc() { +std::ve

[GitHub] [doris] morningman merged pull request #19759: [improvement](session variable) add max execution time session variabe like mysql and add setter attributes in variables

2023-05-18 Thread via GitHub
morningman merged PR #19759: URL: https://github.com/apache/doris/pull/19759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[doris] branch master updated: [improvement](session variable) add max execution time session variabe like mysql and add setter attributes in variables (#19759)

2023-05-18 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 9c86cad4ec [improvement](session variable) ad

Error while running github feature from .asf.yaml in doris!

2023-05-18 Thread Apache Infrastructure
An error occurred while running github feature in .asf.yaml!: You can only have a maximum of 10 external triage collaborators, please contact vp-in...@apache.org to request an exception. - To unsubscribe, e-mail: commits-unsub

[GitHub] [doris] github-actions[bot] commented on pull request #19831: [fix](Nereids) normalize repeat generate push down project with error nullable

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19831: URL: https://github.com/apache/doris/pull/19831#issuecomment-1553996292 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #19831: [fix](Nereids) normalize repeat generate push down project with error nullable

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19831: URL: https://github.com/apache/doris/pull/19831#issuecomment-1553996323 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] Gabriel39 commented on pull request #19641: [DRAFT](decimalv3) test auto conversion

2023-05-18 Thread via GitHub
Gabriel39 commented on PR #19641: URL: https://github.com/apache/doris/pull/19641#issuecomment-1554003033 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] github-actions[bot] commented on pull request #19641: [DRAFT](decimalv3) test auto conversion

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19641: URL: https://github.com/apache/doris/pull/19641#issuecomment-1554004872 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] jackwener merged pull request #19831: [fix](Nereids) normalize repeat generate push down project with error nullable

2023-05-18 Thread via GitHub
jackwener merged PR #19831: URL: https://github.com/apache/doris/pull/19831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[doris] branch master updated: [fix](Nereids) normalize repeat generate push down project with error nullable (#19831)

2023-05-18 Thread jakevin
This is an automated email from the ASF dual-hosted git repository. jakevin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 92c6a3c53b [fix](Nereids) normalize repeat gener

Error while running github feature from .asf.yaml in doris!

2023-05-18 Thread Apache Infrastructure
An error occurred while running github feature in .asf.yaml!: You can only have a maximum of 10 external triage collaborators, please contact vp-in...@apache.org to request an exception. - To unsubscribe, e-mail: commits-unsub

[GitHub] [doris] BiteTheDDDDt commented on pull request #19738: [Chore](build) change CMAKE_CXX_STANDARD from 17 to 20

2023-05-18 Thread via GitHub
BiteThet commented on PR #19738: URL: https://github.com/apache/doris/pull/19738#issuecomment-1554008910 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] BiteTheDDDDt commented on pull request #19791: [Bug](function) fix function in get wrong result when input const column

2023-05-18 Thread via GitHub
BiteThet commented on PR #19791: URL: https://github.com/apache/doris/pull/19791#issuecomment-1554017880 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] airborne12 commented on a diff in pull request #19845: [Fix](inverted index) add datev2/datetimev2 for inverted index column type

2023-05-18 Thread via GitHub
airborne12 commented on code in PR #19845: URL: https://github.com/apache/doris/pull/19845#discussion_r1198561232 ## fe/fe-common/src/main/java/org/apache/doris/catalog/Type.java: ## @@ -149,6 +149,10 @@ public abstract class Type { numericDateTimeTypes = Lists.newArray

[GitHub] [doris] github-actions[bot] commented on pull request #19791: [Bug](function) fix function in get wrong result when input const column

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19791: URL: https://github.com/apache/doris/pull/19791#issuecomment-1554023073 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] jackwener merged pull request #19851: [minor](Nereids): add toString() for LogicalProperties

2023-05-18 Thread via GitHub
jackwener merged PR #19851: URL: https://github.com/apache/doris/pull/19851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[doris] branch master updated: [minor](Nereids): add toString() for LogicalProperties (#19851)

2023-05-18 Thread jakevin
This is an automated email from the ASF dual-hosted git repository. jakevin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new fcffb1d3de [minor](Nereids): add toString() for

Error while running github feature from .asf.yaml in doris!

2023-05-18 Thread Apache Infrastructure
An error occurred while running github feature in .asf.yaml!: You can only have a maximum of 10 external triage collaborators, please contact vp-in...@apache.org to request an exception. - To unsubscribe, e-mail: commits-unsub

[GitHub] [doris] hqx871 opened a new pull request, #19858: lru support evict expired entries

2023-05-18 Thread via GitHub
hqx871 opened a new pull request, #19858: URL: https://github.com/apache/doris/pull/19858 # Proposed changes Lru cache support evict expired entries. ## Problem summary When the LRUCache is full and there are slow queries which scan a lot of bytes, the LRUCache may have side eff

[GitHub] [doris] hqx871 commented on pull request #19858: lru support evict expired entries

2023-05-18 Thread via GitHub
hqx871 commented on PR #19858: URL: https://github.com/apache/doris/pull/19858#issuecomment-1554052825 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] github-actions[bot] commented on pull request #19858: [Improvement](Cache) lru support evict expired entries

2023-05-18 Thread via GitHub
github-actions[bot] commented on PR #19858: URL: https://github.com/apache/doris/pull/19858#issuecomment-1554055027 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

<    1   2   3   4   5   6   >