yiguolei commented on code in PR #19759: URL: https://github.com/apache/doris/pull/19759#discussion_r1198516921
########## fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java: ########## @@ -367,6 +368,14 @@ public class SessionVariable implements Serializable, Writable { @VariableMgr.VarAttr(name = QUERY_TIMEOUT) public int queryTimeoutS = 300; + // The global max_execution_time value provides the default for the session value for new connections. + // The session value applies to SELECT executions executed within the session that include + // no MAX_EXECUTION_TIME(N) optimizer hint or for which N is 0. + // https://dev.mysql.com/doc/refman/5.7/en/server-system-variables.html + // So that it is == query timeout in doris + @VariableMgr.VarAttr(name = MAX_EXECUTION_TIME, fuzzy = true, setter = "setMaxExecutionTimeMS") + public int maxExecutionTimeMS = -1; Review Comment: Not need. Because I did not update this value when user change query_timeout. I only change query timeout when user update max_execution_time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org