[GitHub] [doris] zhangstar333 commented on a diff in pull request #15339: [enhancement](aggregate-function) enhance aggregate funtion collect and add group_array aliases

2023-02-17 Thread via GitHub
zhangstar333 commented on code in PR #15339: URL: https://github.com/apache/doris/pull/15339#discussion_r1109413017 ## be/src/vec/aggregate_functions/aggregate_function_collect.h: ## @@ -49,18 +49,16 @@ struct AggregateFunctionCollectSetData { data_set.insert(assert_cas

[GitHub] [doris] github-actions[bot] commented on pull request #16850: [improvement](vec) avoid creating a new column while filtering mutable columns

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16850: URL: https://github.com/apache/doris/pull/16850#issuecomment-1434271403 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] dlimeng opened a new issue, #16873: [Bug] Doris1.2.2 jdbc Catalog connects to sqlserve unable to query

2023-02-17 Thread via GitHub
dlimeng opened a new issue, #16873: URL: https://github.com/apache/doris/issues/16873 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version doris : 1.2.2 sqlserv

[GitHub] [doris] zhangstar333 commented on a diff in pull request #15339: [enhancement](aggregate-function) enhance aggregate funtion collect and add group_array aliases

2023-02-17 Thread via GitHub
zhangstar333 commented on code in PR #15339: URL: https://github.com/apache/doris/pull/15339#discussion_r1109418237 ## docs/en/docs/sql-manual/sql-functions/aggregate-functions/collect_list.md: ## @@ -30,9 +30,8 @@ under the License. `ARRAY collect_list(expr)` -Returns an a

[GitHub] [doris] github-actions[bot] commented on pull request #16626: [fix](struct-type) forbid struct-type to be distributed key/aggregation key and add more tests

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16626: URL: https://github.com/apache/doris/pull/16626#issuecomment-1434277696 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #16626: [fix](struct-type) forbid struct-type to be distributed key/aggregation key and add more tests

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16626: URL: https://github.com/apache/doris/pull/16626#issuecomment-1434277749 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #16564: [feature](merge-on-write) add DCHECK in compaction to detect data inconsistency

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16564: URL: https://github.com/apache/doris/pull/16564#issuecomment-1434278746 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16784: [enhancement](profile) add profile for json& csv file converting to doris column

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16784: URL: https://github.com/apache/doris/pull/16784#issuecomment-1434279768 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16564: [feature](merge-on-write) add DCHECK in compaction to detect data inconsistency

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16564: URL: https://github.com/apache/doris/pull/16564#issuecomment-1434281724 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16790: [regression](struct-type) add more regression tests for struct and map type

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16790: URL: https://github.com/apache/doris/pull/16790#issuecomment-1434284269 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #16790: [regression](struct-type) add more regression tests for struct and map type

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16790: URL: https://github.com/apache/doris/pull/16790#issuecomment-1434284327 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16870: [fix][nereids] Fix signatures of some window functions

2023-02-17 Thread via GitHub
github-actions[bot] commented on code in PR #16870: URL: https://github.com/apache/doris/pull/16870#discussion_r1109476755 ## be/src/exec/base_scanner.cpp: ## @@ -250,6 +265,28 @@ std::move(column_ptr), slot_desc->get_data_type_ptr(), slot_desc->col_name()));

[GitHub] [doris] yixiutt opened a new pull request, #16874: [improvement](MOW) move update_delete_bitmap out of txn lock

2023-02-17 Thread via GitHub
yixiutt opened a new pull request, #16874: URL: https://github.com/apache/doris/pull/16874 # Proposed changes update_delete_bitmap will cost a lot of time and lock here is unnecessary, txn_lock is used to lock load info ## Problem summary Describe your changes. ##

[GitHub] [doris] github-actions[bot] commented on pull request #16874: [improvement](MOW) move update_delete_bitmap out of txn lock

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16874: URL: https://github.com/apache/doris/pull/16874#issuecomment-1434335345 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16874: [improvement](MOW) move update_delete_bitmap out of txn lock

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16874: URL: https://github.com/apache/doris/pull/16874#issuecomment-1434336576 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16861: [Fix](inverted index) fix compound directory unlock problem

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16861: URL: https://github.com/apache/doris/pull/16861#issuecomment-1434351812 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16803: [fix](cooldown) Use `pending_remote_rowsets` to avoid deleting rowset files being uploaded

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16803: URL: https://github.com/apache/doris/pull/16803#issuecomment-1434355126 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] hello-stephen commented on pull request #16803: [fix](cooldown) Use `pending_remote_rowsets` to avoid deleting rowset files being uploaded

2023-02-17 Thread via GitHub
hello-stephen commented on PR #16803: URL: https://github.com/apache/doris/pull/16803#issuecomment-1434360158 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.63 seconds stream load tsv: 470 seconds loaded 74807831229 Bytes, about 151 MB/s

[GitHub] [doris] wsjz commented on a diff in pull request #16602: [feature-wip](iceberg) add dlf and glue catalog impl for iceberg catalog

2023-02-17 Thread via GitHub
wsjz commented on code in PR #16602: URL: https://github.com/apache/doris/pull/16602#discussion_r1109504544 ## fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/dlf/client/DLFCachedClientPool.java: ## @@ -0,0 +1,78 @@ +// Licensed to the Apache Software Foundation (AS

[GitHub] [doris] jacktengg opened a new pull request, #16875: [improvement](memory) fix possible double free in vcollect iterator

2023-02-17 Thread via GitHub
jacktengg opened a new pull request, #16875: URL: https://github.com/apache/doris/pull/16875 # Proposed changes Issue Number: close #xxx ## Problem summary ``` std::list cumu_children; int i = 0; for (const auto& child : _childr

[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1434365937 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16875: [improvement](memory) fix possible double free in vcollect iterator

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16875: URL: https://github.com/apache/doris/pull/16875#issuecomment-1434366196 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] wsjz commented on a diff in pull request #16602: [feature-wip](iceberg) add dlf and glue catalog impl for iceberg catalog

2023-02-17 Thread via GitHub
wsjz commented on code in PR #16602: URL: https://github.com/apache/doris/pull/16602#discussion_r1109508493 ## fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/dlf/client/DLFCachedClientPool.java: ## @@ -0,0 +1,78 @@ +// Licensed to the Apache Software Foundation (AS

[GitHub] [doris] yangzhg opened a new issue, #16876: [Feature] Add submitter and comments to load job

2023-02-17 Thread via GitHub
yangzhg opened a new issue, #16876: URL: https://github.com/apache/doris/issues/16876 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description Submitter informatio

[GitHub] [doris] FreeOnePlus opened a new pull request, #16877: [docs](docs)Fix FE config max_running_txn_num_per_db default value

2023-02-17 Thread via GitHub
FreeOnePlus opened a new pull request, #16877: URL: https://github.com/apache/doris/pull/16877 # Proposed changes max_running_txn_num_per_db old default value:100 fix change:1000 ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does i

[GitHub] [doris] github-actions[bot] commented on pull request #16875: [improvement](memory) fix possible double free in vcollect iterator

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16875: URL: https://github.com/apache/doris/pull/16875#issuecomment-1434369655 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] yangzhg opened a new pull request, #16878: [Feature](load) Add submitter and comments to load job

2023-02-17 Thread via GitHub
yangzhg opened a new pull request, #16878: URL: https://github.com/apache/doris/pull/16878 # Proposed changes Issue Number: close #16876 ## Problem summary Add submitter and comments to load job ## Checklist(Required) * [ ] Does it affect the original behavi

[GitHub] [doris-thirdparty] morningman opened a new pull request, #38: [fix] skip unsupported auth method

2023-02-17 Thread via GitHub
morningman opened a new pull request, #38: URL: https://github.com/apache/doris-thirdparty/pull/38 sometimes the auths may contain unsupported auth method, such as OAUTHBEARER. should skip it and try next method. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [doris] github-actions[bot] commented on pull request #16878: [Feature](load) Add submitter and comments to load job

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16878: URL: https://github.com/apache/doris/pull/16878#issuecomment-1434378185 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] deaftstill opened a new issue, #16879: [Bug] 在同时执行几个insert语句时,be节点挂掉

2023-02-17 Thread via GitHub
deaftstill opened a new issue, #16879: URL: https://github.com/apache/doris/issues/16879 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version doris-1.2.0-rc04

[GitHub] [doris] liaoxin01 commented on a diff in pull request #16832: [fix](merge-on-write) fix that be may coredump when sequence column is null

2023-02-17 Thread via GitHub
liaoxin01 commented on code in PR #16832: URL: https://github.com/apache/doris/pull/16832#discussion_r1109524064 ## be/src/olap/rowset/segment_v2/segment_writer.cpp: ## @@ -389,6 +388,22 @@ std::string SegmentWriter::_full_encode_keys( return encoded_keys; } +void Segmen

[GitHub] [doris] github-actions[bot] commented on pull request #16832: [fix](merge-on-write) fix that be may coredump when sequence column is null

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16832: URL: https://github.com/apache/doris/pull/16832#issuecomment-1434383760 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] hello-stephen commented on pull request #16869: [Improvement](jsonb) add suport for JSONB type for arrow

2023-02-17 Thread via GitHub
hello-stephen commented on PR #16869: URL: https://github.com/apache/doris/pull/16869#issuecomment-1434384614 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.4 seconds stream load tsv: 473 seconds loaded 74807831229 Bytes, about 150 MB/s

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16818: [Improvement](parquet-reader) Optimize and refactor parquet reader to improve performance.

2023-02-17 Thread via GitHub
github-actions[bot] commented on code in PR #16818: URL: https://github.com/apache/doris/pull/16818#discussion_r1109529424 ## be/src/vec/columns/column_string.h: ## @@ -280,6 +280,98 @@ class ColumnString final : public COWHelper { } } +#define MAX_STRINGS_OVERFL

[GitHub] [doris] github-actions[bot] commented on pull request #16878: [Feature](load) Add submitter and comments to load job

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16878: URL: https://github.com/apache/doris/pull/16878#issuecomment-1434397999 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] HappenLee opened a new pull request, #16880: [RegressionTest](Pipeline) Fix pipeline failed in regression test

2023-02-17 Thread via GitHub
HappenLee opened a new pull request, #16880: URL: https://github.com/apache/doris/pull/16880 # Proposed changes regression-test/suites/inverted_index_p0/test_add_drop_index_with_data.groovy ![image](https://user-images.githubusercontent.com/10553413/219611956-4ca5d0d1-3fc5-

[GitHub] [doris] github-actions[bot] commented on pull request #16880: [RegressionTest](Pipeline) Fix pipeline failed in regression test

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16880: URL: https://github.com/apache/doris/pull/16880#issuecomment-1434403701 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16818: [Improvement](parquet-reader) Optimize and refactor parquet reader to improve performance.

2023-02-17 Thread via GitHub
github-actions[bot] commented on code in PR #16818: URL: https://github.com/apache/doris/pull/16818#discussion_r1109553766 ## be/src/vec/exec/format/parquet/fix_length_dict_decoder.hpp: ## @@ -0,0 +1,531 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mo

[GitHub] [doris] SaintBacchus opened a new issue, #16881: [Feature] Decouple the schema order and the order key to make table created easier

2023-02-17 Thread via GitHub
SaintBacchus opened a new issue, #16881: URL: https://github.com/apache/doris/issues/16881 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description As an example o

[GitHub] [doris] BePPPower opened a new pull request, #16882: [Enhencement](csv reader) Optimize csv reader

2023-02-17 Thread via GitHub
BePPPower opened a new pull request, #16882: URL: https://github.com/apache/doris/pull/16882 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has

[GitHub] [doris-spark-connector] gnehil opened a new pull request, #69: [feature] support datev2/datatimev2/decimalv3/jsonb type

2023-02-17 Thread via GitHub
gnehil opened a new pull request, #69: URL: https://github.com/apache/doris-spark-connector/pull/69 # Proposed changes support datev2/datatimev2/decimalv3/jsonb type Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(

[GitHub] [doris-spark-connector] JNSimba closed pull request #69: [feature] support datev2/datatimev2/decimalv3/jsonb type

2023-02-17 Thread via GitHub
JNSimba closed pull request #69: [feature] support datev2/datatimev2/decimalv3/jsonb type URL: https://github.com/apache/doris-spark-connector/pull/69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [doris] luzhijing commented on a diff in pull request #16866: [typo](docs)Modify some document label errors

2023-02-17 Thread via GitHub
luzhijing commented on code in PR #16866: URL: https://github.com/apache/doris/pull/16866#discussion_r1109591140 ## docs/en/docs/advanced/best-practice/compaction.md: ## @@ -34,6 +34,9 @@ Appropriately adjusting the compaction strategy can greatly improve load and que ## Ver

[GitHub] [doris] jackwener opened a new pull request, #16883: [fix](Nereids): fix SemiJoinLogicalJoinTransposeProject.

2023-02-17 Thread via GitHub
jackwener opened a new pull request, #16883: URL: https://github.com/apache/doris/pull/16883 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [x] Does it affect the original behavior * [x] Has

[GitHub] [doris] github-actions[bot] commented on pull request #16877: [docs](docs)Fix FE config max_running_txn_num_per_db default value

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16877: URL: https://github.com/apache/doris/pull/16877#issuecomment-1434455131 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] yagagagaga opened a new pull request, #16884: [typo](docs)supplement the document content

2023-02-17 Thread via GitHub
yagagagaga opened a new pull request, #16884: URL: https://github.com/apache/doris/pull/16884 # Proposed changes Issue Number: close #xxx ## Problem summary The original document is too simple, so I made some additions. ## Checklist(Required) * [ ] Does it a

[GitHub] [doris] github-actions[bot] commented on pull request #16877: [docs](docs)Fix FE config max_running_txn_num_per_db default value

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16877: URL: https://github.com/apache/doris/pull/16877#issuecomment-1434455178 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #16868: [typo](doc)collect_set function documentation added 1.2 label

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16868: URL: https://github.com/apache/doris/pull/16868#issuecomment-1434457771 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #16868: [typo](doc)collect_set function documentation added 1.2 label

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16868: URL: https://github.com/apache/doris/pull/16868#issuecomment-1434457847 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #16819: [refactor](Nereids): remove local sort

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16819: URL: https://github.com/apache/doris/pull/16819#issuecomment-1434459788 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #16819: [refactor](Nereids): remove local sort

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16819: URL: https://github.com/apache/doris/pull/16819#issuecomment-1434459858 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] luzhijing commented on a diff in pull request #16746: [docs](doc) Add autobucket doc

2023-02-17 Thread via GitHub
luzhijing commented on code in PR #16746: URL: https://github.com/apache/doris/pull/16746#discussion_r1109615042 ## docs/zh-CN/docs/advanced/autobucket.md: ## @@ -0,0 +1,169 @@ +--- +{ +"title": "自动分桶", +"language": "zh-CN" +} +--- + + + +# 背景 + +用户经常设置不合适的bucket,导致各种问题,

[GitHub] [doris] dataroaring merged pull request #16792: Revert "[test](pipeline) Run nereids cases in p1/p2 (#16130)"

2023-02-17 Thread via GitHub
dataroaring merged PR #16792: URL: https://github.com/apache/doris/pull/16792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

[GitHub] [doris] morrySnow merged pull request #16819: [refactor](Nereids): remove local sort

2023-02-17 Thread via GitHub
morrySnow merged PR #16819: URL: https://github.com/apache/doris/pull/16819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[doris] branch master updated: [refactor](Nereids) remove local sort (#16819)

2023-02-17 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new fd5d7d6097 [refactor](Nereids) remove local so

[GitHub] [doris] luzhijing commented on a diff in pull request #16884: [typo](docs)supplement the document content

2023-02-17 Thread via GitHub
luzhijing commented on code in PR #16884: URL: https://github.com/apache/doris/pull/16884#discussion_r1109620995 ## docs/zh-CN/docs/sql-manual/sql-functions/aggregate-functions/grouping.md: ## @@ -25,25 +25,82 @@ under the License. --> ## GROUPING -### description - Synt

[GitHub] [doris] TangSiyang2001 commented on a diff in pull request #15339: [enhancement](aggregate-function) enhance aggregate funtion collect and add group_array aliases

2023-02-17 Thread via GitHub
TangSiyang2001 commented on code in PR #15339: URL: https://github.com/apache/doris/pull/15339#discussion_r1109628442 ## be/src/vec/aggregate_functions/aggregate_function_collect.h: ## @@ -49,18 +49,16 @@ struct AggregateFunctionCollectSetData { data_set.insert(assert_c

[GitHub] [doris] morrySnow commented on a diff in pull request #16783: [enhancement](nereids)add a session variable to control join reorder algorithm

2023-02-17 Thread via GitHub
morrySnow commented on code in PR #16783: URL: https://github.com/apache/doris/pull/16783#discussion_r1109627278 ## fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/batch/NereidsRewriteJobExecutor.java: ## @@ -103,9 +103,13 @@ public NereidsRewriteJobExecutor(CascadesConte

[GitHub] [doris] airborne12 opened a new pull request, #16885: [Fix](inverted index) fix inverted index bkd reader memory leak problem

2023-02-17 Thread via GitHub
airborne12 opened a new pull request, #16885: URL: https://github.com/apache/doris/pull/16885 # Proposed changes Issue Number: close #xxx ## Problem summary Original implementation of get_bkd_reader's raw pointer usage may cause memory leak problem, use shared_ptr to avo

[GitHub] [doris] BiteTheDDDDt opened a new pull request, #16886: [Enchancement](function) remove unused params on aggregate function

2023-02-17 Thread via GitHub
BiteThet opened a new pull request, #16886: URL: https://github.com/apache/doris/pull/16886 # Proposed changes remove all unused params on aggregate function ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the origin

[GitHub] [doris] luzhijing merged pull request #16868: [typo](doc)collect_set function documentation added 1.2 label

2023-02-17 Thread via GitHub
luzhijing merged PR #16868: URL: https://github.com/apache/doris/pull/16868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[doris] branch master updated (fd5d7d6097 -> ea0e090a77)

2023-02-17 Thread luzhijing
This is an automated email from the ASF dual-hosted git repository. luzhijing pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from fd5d7d6097 [refactor](Nereids) remove local sort (#16819) add ea0e090a77 collect_set function documentation add

[GitHub] [doris] github-actions[bot] commented on pull request #16885: [Fix](inverted index) fix inverted index bkd reader memory leak problem

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16885: URL: https://github.com/apache/doris/pull/16885#issuecomment-1434485803 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] yagagagaga commented on a diff in pull request #16884: [typo](docs)supplement the document content

2023-02-17 Thread via GitHub
yagagagaga commented on code in PR #16884: URL: https://github.com/apache/doris/pull/16884#discussion_r1109642877 ## docs/zh-CN/docs/sql-manual/sql-functions/aggregate-functions/grouping.md: ## @@ -25,25 +25,82 @@ under the License. --> ## GROUPING -### description - Syn

[GitHub] [doris] yagagagaga commented on a diff in pull request #16884: [typo](docs)supplement the document content

2023-02-17 Thread via GitHub
yagagagaga commented on code in PR #16884: URL: https://github.com/apache/doris/pull/16884#discussion_r1109644590 ## docs/zh-CN/docs/sql-manual/sql-functions/aggregate-functions/grouping.md: ## @@ -25,25 +25,82 @@ under the License. --> ## GROUPING -### description - Syn

[GitHub] [doris] yagagagaga commented on a diff in pull request #16884: [typo](docs)supplement the document content

2023-02-17 Thread via GitHub
yagagagaga commented on code in PR #16884: URL: https://github.com/apache/doris/pull/16884#discussion_r1109644910 ## docs/zh-CN/docs/sql-manual/sql-functions/aggregate-functions/grouping.md: ## @@ -25,25 +25,82 @@ under the License. --> ## GROUPING -### description - Syn

[GitHub] [doris] github-actions[bot] commented on pull request #16885: [Fix](inverted index) fix inverted index bkd reader memory leak problem

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16885: URL: https://github.com/apache/doris/pull/16885#issuecomment-1434489527 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] hello-stephen commented on pull request #16861: [Fix](inverted index) fix compound directory unlock problem

2023-02-17 Thread via GitHub
hello-stephen commented on PR #16861: URL: https://github.com/apache/doris/pull/16861#issuecomment-1434497825 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.24 seconds stream load tsv: 472 seconds loaded 74807831229 Bytes, about 151 MB/s

[GitHub] [doris] github-actions[bot] commented on pull request #16777: [feature] Make VUnionNode support conjecture logic

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16777: URL: https://github.com/apache/doris/pull/16777#issuecomment-1434498207 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] hello-stephen commented on pull request #16875: [improvement](memory) fix possible double free in vcollect iterator

2023-02-17 Thread via GitHub
hello-stephen commented on PR #16875: URL: https://github.com/apache/doris/pull/16875#issuecomment-1434509900 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.3 seconds stream load tsv: 475 seconds loaded 74807831229 Bytes, about 150 MB/s

[GitHub] [doris] dataroaring commented on pull request #16842: [chore](build) add a build type named DEBUG_O3

2023-02-17 Thread via GitHub
dataroaring commented on PR #16842: URL: https://github.com/apache/doris/pull/16842#issuecomment-1434518982 > ```shell > ```shell > BUILD_TYPE=DEBUG EXTRA_CXX_FLAGS=-O3 ./run- > ``` > > > > > > > > > > >

[GitHub] [doris] dataroaring closed pull request #16842: [chore](build) add a build type named DEBUG_O3

2023-02-17 Thread via GitHub
dataroaring closed pull request #16842: [chore](build) add a build type named DEBUG_O3 URL: https://github.com/apache/doris/pull/16842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [doris] github-actions[bot] commented on pull request #16866: [typo](docs)Modify some document label errors

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16866: URL: https://github.com/apache/doris/pull/16866#issuecomment-1434526288 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #16866: [typo](docs)Modify some document label errors

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16866: URL: https://github.com/apache/doris/pull/16866#issuecomment-1434526343 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #16878: [Feature](load) Add submitter and comments to load job

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16878: URL: https://github.com/apache/doris/pull/16878#issuecomment-1434527874 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16884: [typo](docs)supplement the document content

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16884: URL: https://github.com/apache/doris/pull/16884#issuecomment-1434527999 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #16884: [typo](docs)supplement the document content

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16884: URL: https://github.com/apache/doris/pull/16884#issuecomment-1434528048 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #16878: [Feature](load) Add submitter and comments to load job

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16878: URL: https://github.com/apache/doris/pull/16878#issuecomment-1434531040 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] zhilaohu32 commented on issue #3906: 官方有微信群或者QQ群吗,建一个,方便大家交流

2023-02-17 Thread via GitHub
zhilaohu32 commented on issue #3906: URL: https://github.com/apache/doris/issues/3906#issuecomment-1434536044 > 有微信群,可以加我微信 morningman-cmy 我希望加入这个群,可以是我申请添加您的微信没有通过 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [doris] github-actions[bot] commented on pull request #16878: [Feature](load) Add submitter and comments to load job

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16878: URL: https://github.com/apache/doris/pull/16878#issuecomment-1434547010 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16689: [Enchancement](merge-on-write) check the correctness of rowid conversion after compaction

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16689: URL: https://github.com/apache/doris/pull/16689#issuecomment-143480 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16689: [Enchancement](merge-on-write) check the correctness of rowid conversion after compaction

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16689: URL: https://github.com/apache/doris/pull/16689#issuecomment-1434557941 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16886: [Enchancement](function) remove unused params on aggregate function

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16886: URL: https://github.com/apache/doris/pull/16886#issuecomment-1434562839 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16859: [fix](merge-on-write) The delete bitmap of the currently imported rowset is not persistent

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16859: URL: https://github.com/apache/doris/pull/16859#issuecomment-1434563787 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16810: [enhance](cooldown)skip follow cooldown once failed to do follow cooldown

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16810: URL: https://github.com/apache/doris/pull/16810#issuecomment-1434567999 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] chenlinzhong closed pull request #16639: [Improvement](brpc) Using a thread pool for RPC service avoiding std::mutex block brpc::bthread

2023-02-17 Thread via GitHub
chenlinzhong closed pull request #16639: [Improvement](brpc) Using a thread pool for RPC service avoiding std::mutex block brpc::bthread URL: https://github.com/apache/doris/pull/16639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [doris] chenlinzhong closed issue #16634: [Enhancement] replace brpc bthread with pthead

2023-02-17 Thread via GitHub
chenlinzhong closed issue #16634: [Enhancement] replace brpc bthread with pthead URL: https://github.com/apache/doris/issues/16634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [doris] yiguolei merged pull request #16880: [RegressionTest](Pipeline) Fix pipeline failed in regression test

2023-02-17 Thread via GitHub
yiguolei merged PR #16880: URL: https://github.com/apache/doris/pull/16880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] branch master updated: [RegressionTest](Pipeline) Fix pipeline failed in regression test (#16880)

2023-02-17 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new fda4afecf5 [RegressionTest](Pipeline) Fix pipel

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16776: [Feature](map-type) Support stream load and fix some bugs for map type

2023-02-17 Thread via GitHub
github-actions[bot] commented on code in PR #16776: URL: https://github.com/apache/doris/pull/16776#discussion_r1109765169 ## be/test/olap/rowset/rowset_tree_test.cpp: ## @@ -255,11 +255,13 @@ int r = strcmp(s1.c_str(), s2.c_str()); switch (op) {

[GitHub] [doris] github-actions[bot] commented on pull request #16639: [Improvement](brpc) Using a thread pool for RPC service avoiding std::mutex block brpc::bthread

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16639: URL: https://github.com/apache/doris/pull/16639#issuecomment-1434604807 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16861: [Fix](inverted index) fix compound directory unlock problem

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #16861: URL: https://github.com/apache/doris/pull/16861#issuecomment-1434606513 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #15339: [enhancement](aggregate-function) enhance aggregate funtion collect and add group_array aliases

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1434607988 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #15339: [enhancement](aggregate-function) enhance aggregate funtion collect and add group_array aliases

2023-02-17 Thread via GitHub
github-actions[bot] commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1434608312 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[doris] branch master updated: [typo](docs)Modify some document label errors (#16866)

2023-02-17 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new adc42600b4 [typo](docs)Modify some document lab

[GitHub] [doris] yiguolei merged pull request #16866: [typo](docs)Modify some document label errors

2023-02-17 Thread via GitHub
yiguolei merged PR #16866: URL: https://github.com/apache/doris/pull/16866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] yiguolei merged pull request #16877: [docs](docs)Fix FE config max_running_txn_num_per_db default value

2023-02-17 Thread via GitHub
yiguolei merged PR #16877: URL: https://github.com/apache/doris/pull/16877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] yiguolei merged pull request #16884: [typo](docs)supplement the document content

2023-02-17 Thread via GitHub
yiguolei merged PR #16884: URL: https://github.com/apache/doris/pull/16884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] branch master updated (90ae8dcf01 -> d5c393f413)

2023-02-17 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 90ae8dcf01 [typo](docs)supplement the document content (#16884) add d5c393f413 [docs](docs)Fix FE config max_run

[doris] branch master updated: [typo](docs)supplement the document content (#16884)

2023-02-17 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 90ae8dcf01 [typo](docs)supplement the document

  1   2   >