github-actions[bot] commented on code in PR #16776:
URL: https://github.com/apache/doris/pull/16776#discussion_r1109765169
##########
be/test/olap/rowset/rowset_tree_test.cpp:
##########
@@ -255,11 +255,13 @@
int r = strcmp(s1.c_str(), s2.c_str());
switch (op) {
case BOUND_LESS_THAN:
- if (r == 0) continue; // pass through.
+ if (r == 0) continue;
+ [[fallthrough]];
case BOUND_LESS_EQUAL:
return std::pair<string, string>(std::min(s1, s2),
std::max(s1, s2));
case BOUND_GREATER_THAN:
- if (r == 0) continue; // pass through.
+ if (r == 0) continue;
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (r == 0) { continue;
}
```
##########
be/test/olap/rowset/rowset_tree_test.cpp:
##########
@@ -255,11 +255,13 @@ TEST_F(TestRowsetTree, TestTreeRandomized) {
int r = strcmp(s1.c_str(), s2.c_str());
switch (op) {
case BOUND_LESS_THAN:
- if (r == 0) continue; // pass through.
+ if (r == 0) continue;
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (r == 0) { continue;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
