morningman commented on code in PR #16036:
URL: https://github.com/apache/doris/pull/16036#discussion_r1103753667
##
fe/fe-core/src/main/java/org/apache/doris/catalog/PartitionInfo.java:
##
@@ -76,13 +76,16 @@ public class PartitionInfo implements Writable {
// so we defer
morningman commented on PR #16036:
URL: https://github.com/apache/doris/pull/16036#issuecomment-1426968706
And please add some regression test for this feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
github-actions[bot] commented on PR #16643:
URL: https://github.com/apache/doris/pull/16643#issuecomment-1426970724
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
github-actions[bot] commented on PR #16643:
URL: https://github.com/apache/doris/pull/16643#issuecomment-1426970731
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
yiguolei merged PR #16643:
URL: https://github.com/apache/doris/pull/16643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apa
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 0701ce1d71 [docs](docs)Fix Docker documentation
morningman commented on code in PR #14063:
URL: https://github.com/apache/doris/pull/14063#discussion_r1103756592
##
fe/fe-core/src/main/java/org/apache/doris/httpv2/controller/BaseController.java:
##
@@ -296,6 +296,6 @@ protected long checkLongParam(String strParam) {
}
yiguolei merged PR #16499:
URL: https://github.com/apache/doris/pull/16499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apa
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 4e814a7bbc [enhance](community): polish PULL_RE
morningman commented on code in PR #16073:
URL: https://github.com/apache/doris/pull/16073#discussion_r1103758624
##
gensrc/thrift/FrontendService.thrift:
##
@@ -483,6 +483,7 @@ struct TLoadTxnBeginRequest {
10: optional i64 timeout
11: optional Types.TUniqueId request
dataroaring merged PR #16641:
URL: https://github.com/apache/doris/pull/16641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 6a8fc35b78 [Bug](Cooldown) fix load balance
morningman merged PR #16622:
URL: https://github.com/apache/doris/pull/16622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.a
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 78a958467f [improvement](Load) Make broker lo
dataroaring merged PR #16343:
URL: https://github.com/apache/doris/pull/16343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.
dataroaring closed issue #16301: [Enhancement] insert into timeout easily
URL: https://github.com/apache/doris/issues/16301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new cf739e7496 [Enhancement](Stmt) Set insert_in
ByteYue opened a new pull request, #16644:
URL: https://github.com/apache/doris/pull/16644
# Proposed changes
Issue Number: close #xxx
When doing clone task, the logic would early exit if the missed version is
empty. But the tablet meta is not set with the newly replica id inside t
SaintBacchus opened a new issue, #16645:
URL: https://github.com/apache/doris/issues/16645
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no
similar issues.
### Version
master
### W
github-actions[bot] commented on PR #16644:
URL: https://github.com/apache/doris/pull/16644#issuecomment-1426979268
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #16644:
URL: https://github.com/apache/doris/pull/16644#issuecomment-1426985470
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
github-actions[bot] commented on PR #16644:
URL: https://github.com/apache/doris/pull/16644#issuecomment-1426985477
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #16640:
URL: https://github.com/apache/doris/pull/16640#issuecomment-1426990378
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #16644:
URL: https://github.com/apache/doris/pull/16644#issuecomment-1426991620
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
wangbo commented on issue #16392:
URL: https://github.com/apache/doris/issues/16392#issuecomment-1426991990
How about link related PR/issue to the item in the list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
github-actions[bot] commented on PR #16640:
URL: https://github.com/apache/doris/pull/16640#issuecomment-1426994874
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
morningman commented on code in PR #16073:
URL: https://github.com/apache/doris/pull/16073#discussion_r1103793147
##
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/TokenManager.java:
##
@@ -0,0 +1,133 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// o
caiconghui opened a new pull request, #16646:
URL: https://github.com/apache/doris/pull/16646
# Proposed changes
Issue Number: close #xxx
## Problem summary
when enable_system_metrics is false, we should not use system_metrics any
more
## Checklist(Required)
*
github-actions[bot] commented on PR #16646:
URL: https://github.com/apache/doris/pull/16646#issuecomment-1427025018
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #16646:
URL: https://github.com/apache/doris/pull/16646#issuecomment-1427025028
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
github-actions[bot] commented on PR #16646:
URL: https://github.com/apache/doris/pull/16646#issuecomment-1427025033
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #16588:
URL: https://github.com/apache/doris/pull/16588#issuecomment-1427027661
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
github-actions[bot] commented on PR #16588:
URL: https://github.com/apache/doris/pull/16588#issuecomment-1427027668
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #16073:
URL: https://github.com/apache/doris/pull/16073#issuecomment-1427029647
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #16569:
URL: https://github.com/apache/doris/pull/16569#issuecomment-1427040894
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #14063:
URL: https://github.com/apache/doris/pull/14063#issuecomment-1427051793
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on code in PR #14063:
URL: https://github.com/apache/doris/pull/14063#discussion_r1103816731
##
be/src/util/network_util.cpp:
##
@@ -39,22 +39,38 @@
namespace doris {
InetAddress::InetAddress(struct sockaddr* addr) {
-this->addr = *(struct s
caiconghui merged PR #16646:
URL: https://github.com/apache/doris/pull/16646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.a
This is an automated email from the ASF dual-hosted git repository.
caiconghui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 1de4e312cc [fix](metric) Fix be core when set
github-actions[bot] commented on code in PR #14063:
URL: https://github.com/apache/doris/pull/14063#discussion_r1103818977
##
be/src/util/network_util.cpp:
##
@@ -39,22 +39,38 @@
namespace doris {
InetAddress::InetAddress(struct sockaddr* addr) {
-this->addr = *(struct s
morningman opened a new pull request, #16647:
URL: https://github.com/apache/doris/pull/16647
# Proposed changes
Issue Number: close #xxx
## Problem summary
When querying `information_schema` database, BE will call FE RPC
to get schema info such as db name list, table
github-actions[bot] commented on PR #16588:
URL: https://github.com/apache/doris/pull/16588#issuecomment-1427074590
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
morningman opened a new pull request, #16648:
URL: https://github.com/apache/doris/pull/16648
# Proposed changes
Issue Number: close #xxx
## Problem summary
Add new property "dynamic_partition.storage_medium" for creating dynamic
partition table.
Sometimes user may se
hello-stephen commented on PR #16647:
URL: https://github.com/apache/doris/pull/16647#issuecomment-1427082673
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.9 seconds
stream load tsv: 478 seconds loaded 74807831229 Bytes, about 149
MB/s
github-actions[bot] commented on PR #16588:
URL: https://github.com/apache/doris/pull/16588#issuecomment-1427086898
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
platoneko commented on code in PR #16641:
URL: https://github.com/apache/doris/pull/16641#discussion_r1103844641
##
be/src/olap/task/engine_clone_task.cpp:
##
@@ -537,7 +539,8 @@ Status EngineCloneTask::_finish_incremental_clone(Tablet*
tablet,
platoneko commented on code in PR #16644:
URL: https://github.com/apache/doris/pull/16644#discussion_r1103845854
##
be/src/olap/task/engine_clone_task.cpp:
##
@@ -98,6 +98,12 @@ Status EngineCloneTask::_do_clone() {
if (missed_versions.empty()) {
LOG(INFO)
github-actions[bot] commented on PR #16588:
URL: https://github.com/apache/doris/pull/16588#issuecomment-1427092956
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] closed pull request #10802: [enhancement][protocol] support
proxy protocol
URL: https://github.com/apache/doris/pull/10802
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
starocean999 merged PR #16477:
URL: https://github.com/apache/doris/pull/16477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris
github-actions[bot] commented on PR #16477:
URL: https://github.com/apache/doris/pull/16477#issuecomment-1427192249
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
github-actions[bot] commented on PR #16477:
URL: https://github.com/apache/doris/pull/16477#issuecomment-1427192258
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
This is an automated email from the ASF dual-hosted git repository.
starocean999 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 80c1a99ef6 [enhance](Nereids): refactor Joi
ByteYue commented on code in PR #16644:
URL: https://github.com/apache/doris/pull/16644#discussion_r1103915390
##
be/src/olap/task/engine_clone_task.cpp:
##
@@ -98,6 +98,12 @@ Status EngineCloneTask::_do_clone() {
if (missed_versions.empty()) {
LOG(INFO) <<
ByteYue commented on code in PR #16641:
URL: https://github.com/apache/doris/pull/16641#discussion_r1103917449
##
be/src/olap/task/engine_clone_task.cpp:
##
@@ -537,7 +539,8 @@ Status EngineCloneTask::_finish_incremental_clone(Tablet*
tablet,
morningman commented on PR #16617:
URL: https://github.com/apache/doris/pull/16617#issuecomment-1427198926
Please amend your PR title and add describe in your PR comment.
And I suggest to wait #14063 merge
--
This is an automated message from the Apache Git Service.
To respond to the me
github-actions[bot] commented on PR #16644:
URL: https://github.com/apache/doris/pull/16644#issuecomment-1427198978
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
yangzhg commented on PR #16571:
URL: https://github.com/apache/doris/pull/16571#issuecomment-1427210636
After supporting authentication and https, can the internal access to these
ports in doris still work normally?
--
This is an automated message from the Apache Git Service.
To respond t
morningman commented on code in PR #16639:
URL: https://github.com/apache/doris/pull/16639#discussion_r1103927268
##
be/src/service/internal_service.cpp:
##
@@ -286,125 +334,134 @@ Status PInternalServiceImpl::_exec_plan_fragment(const
std::string& ser_request,
}
}
-voi
morningman commented on PR #16639:
URL: https://github.com/apache/doris/pull/16639#issuecomment-1427216658
Please also update this document:
https://doris.apache.org/zh-CN/docs/dev/admin-manual/maint-monitor/monitor-metrics/metrics
--
This is an automated message from the Apache Git Se
morningman merged PR #16073:
URL: https://github.com/apache/doris/pull/16073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.a
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
from 80c1a99ef6 [enhance](Nereids): refactor JoinReorder code. (#16477)
add f41a2055d3 [feature](Load)Remove user/p
github-actions[bot] commented on PR #16073:
URL: https://github.com/apache/doris/pull/16073#issuecomment-1427219077
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #16073:
URL: https://github.com/apache/doris/pull/16073#issuecomment-1427219036
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
stalary closed pull request #16583: [Feature](ES): Es support sort node
pushdown limit and date type
URL: https://github.com/apache/doris/pull/16583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
stalary commented on PR #16633:
URL: https://github.com/apache/doris/pull/16633#issuecomment-1427223082
Can you add some regression-test case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
morningman commented on code in PR #16533:
URL: https://github.com/apache/doris/pull/16533#discussion_r1103931880
##
fe/fe-core/src/main/java/org/apache/doris/system/BeSelectionPolicy.java:
##
@@ -49,6 +49,8 @@ public class BeSelectionPolicy {
public boolean preferComputeNo
dataroaring commented on code in PR #16639:
URL: https://github.com/apache/doris/pull/16639#discussion_r1103931956
##
be/src/util/doris_metrics.cpp:
##
@@ -197,6 +230,37 @@ DorisMetrics::DorisMetrics() :
_metric_registry(_s_registry_name) {
_server_metric_entity = _metric_
morningman commented on code in PR #16483:
URL: https://github.com/apache/doris/pull/16483#discussion_r1101221897
##
docs/zh-CN/docs/data-operate/import/import-way/mysql-load-manual.md:
##
@@ -0,0 +1,119 @@
+---
+{
+"title": "MySql load",
+"language": "zh-CN"
+}
+---
+
+
yixiutt commented on code in PR #16605:
URL: https://github.com/apache/doris/pull/16605#discussion_r1103935888
##
be/src/olap/rowset/segment_v2/column_reader.cpp:
##
@@ -210,6 +210,10 @@ Status ColumnReader::read_page(const
ColumnIteratorOptions& iter_opts, const Pag
opts.
yixiutt commented on PR #16605:
URL: https://github.com/apache/doris/pull/16605#issuecomment-1427231123
> Add a DCHECK for the type variable to make sure we used the right decoder?
>
> ```
> if constexpr (USED_IN_DICT_ENCODING) {
> auto type = decode_fixed32_le((const
chenlinzhong commented on code in PR #16639:
URL: https://github.com/apache/doris/pull/16639#discussion_r1103937266
##
be/src/common/config.h:
##
@@ -35,8 +35,10 @@ CONF_Int32(be_port, "9060");
// port for brpc
CONF_Int32(brpc_port, "8060");
-// the number of bthreads for br
AshinGau opened a new pull request, #16649:
URL: https://github.com/apache/doris/pull/16649
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
* [x] Does it affect the original behavior
* [x] Has u
github-actions[bot] commented on PR #16610:
URL: https://github.com/apache/doris/pull/16610#issuecomment-1427233760
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
chenlinzhong commented on code in PR #16639:
URL: https://github.com/apache/doris/pull/16639#discussion_r1103938276
##
be/src/service/internal_service.cpp:
##
@@ -1097,9 +1208,8 @@ void
PInternalServiceImpl::multiget_data(google::protobuf::RpcController* contro
chenlinzhong commented on code in PR #16639:
URL: https://github.com/apache/doris/pull/16639#discussion_r1103938347
##
be/src/service/internal_service.cpp:
##
@@ -423,200 +480,233 @@ void
PInternalServiceImpl::tablet_fetch_data(google::protobuf::RpcController* co
SaintBacchus commented on code in PR #16533:
URL: https://github.com/apache/doris/pull/16533#discussion_r1103938399
##
fe/fe-core/src/main/java/org/apache/doris/system/BeSelectionPolicy.java:
##
@@ -49,6 +49,8 @@ public class BeSelectionPolicy {
public boolean preferCompute
eldenmoon commented on code in PR #16639:
URL: https://github.com/apache/doris/pull/16639#discussion_r1103940279
##
be/src/service/internal_service.cpp:
##
@@ -423,200 +480,233 @@ void
PInternalServiceImpl::tablet_fetch_data(google::protobuf::RpcController* co
dataroaring merged PR #16615:
URL: https://github.com/apache/doris/pull/16615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.
HappenLee opened a new pull request, #16650:
URL: https://github.com/apache/doris/pull/16650
# Proposed changes
Remove unless virtual function call in `HashMethodSingleLowNullableColumn`
Before：
Query group by in clickbench 0.82s
After：
Query group by in cli
yongjinhou commented on PR #16571:
URL: https://github.com/apache/doris/pull/16571#issuecomment-1427239627
> maybe add some test case is more better.
Currently, there are no unit tests for http interface, I'll add one later.
--
This is an automated message from the Apache Git Servic
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
from f41a2055d3 [feature](Load)Remove user/password in properties for mysql
load to avoid double auth. (#16073)
a
github-actions[bot] commented on PR #14063:
URL: https://github.com/apache/doris/pull/14063#issuecomment-1427240495
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #16650:
URL: https://github.com/apache/doris/pull/16650#issuecomment-1427242086
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
yixiutt commented on code in PR #16607:
URL: https://github.com/apache/doris/pull/16607#discussion_r1103944601
##
be/src/common/config.h:
##
@@ -270,6 +270,10 @@ CONF_Bool(enable_low_cardinality_optimize, "true");
CONF_mBool(enable_compaction_checksum, "false");
// whether dis
LemonLiTree opened a new pull request, #16651:
URL: https://github.com/apache/doris/pull/16651
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Ha
github-actions[bot] commented on PR #16651:
URL: https://github.com/apache/doris/pull/16651#issuecomment-1427250572
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #16651:
URL: https://github.com/apache/doris/pull/16651#issuecomment-1427250521
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
yiguolei opened a new pull request, #16652:
URL: https://github.com/apache/doris/pull/16652
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has u
github-actions[bot] commented on PR #16652:
URL: https://github.com/apache/doris/pull/16652#issuecomment-1427262424
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #16588:
URL: https://github.com/apache/doris/pull/16588#issuecomment-1427264127
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
BiteThet commented on code in PR #16650:
URL: https://github.com/apache/doris/pull/16650#discussion_r1103953424
##
be/src/vec/common/columns_hashing.h:
##
@@ -227,11 +227,11 @@ struct HashMethodSingleLowNullableColumn : public
SingleColumnMethod {
HashMethodSingleLowNu
github-actions[bot] commented on PR #16612:
URL: https://github.com/apache/doris/pull/16612#issuecomment-1427267419
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #16612:
URL: https://github.com/apache/doris/pull/16612#issuecomment-1427267380
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
chenlinzhong commented on code in PR #16639:
URL: https://github.com/apache/doris/pull/16639#discussion_r1103954749
##
be/src/service/internal_service.cpp:
##
@@ -423,200 +480,233 @@ void
PInternalServiceImpl::tablet_fetch_data(google::protobuf::RpcController* co
github-actions[bot] commented on PR #16652:
URL: https://github.com/apache/doris/pull/16652#issuecomment-1427270720
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
github-actions[bot] commented on PR #16652:
URL: https://github.com/apache/doris/pull/16652#issuecomment-1427270750
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
morrySnow merged PR #16612:
URL: https://github.com/apache/doris/pull/16612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.ap
This is an automated email from the ASF dual-hosted git repository.
morrysnow pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
from 91c4d1cade [Feature-WIP](inverted index) step 1 for supporting range
predicate pushing down to inverted index (#166
chenlinzhong commented on code in PR #16639:
URL: https://github.com/apache/doris/pull/16639#discussion_r1103956391
##
be/src/service/internal_service.cpp:
##
@@ -423,200 +480,233 @@ void
PInternalServiceImpl::tablet_fetch_data(google::protobuf::RpcController* co
1 - 100 of 173 matches
Mail list logo
