[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #16650: [Opt](Hash) Deduce virtual function call is null at in single nullable column

[via GitHub]

BiteTheDDDDt commented on code in PR #16650:
URL: https://github.com/apache/doris/pull/16650#discussion_r1103953424


##########
be/src/vec/common/columns_hashing.h:
##########
@@ -227,11 +227,11 @@ struct HashMethodSingleLowNullableColumn : public 
SingleColumnMethod {
     HashMethodSingleLowNullableColumn(const ColumnRawPtrs& 
key_columns_nullable,
                                       const Sizes& key_sizes, const 
HashMethodContextPtr& context)
             : Base(get_nested_column(key_columns_nullable[0]), key_sizes, 
context),
-              key_columns(key_columns_nullable) {}
+              key_column(reinterpret_cast<const 
ColumnNullable*>(key_columns_nullable[0])) {}

Review Comment:
   Maybe it is better to use `assert_cast` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org