[GitHub] [doris] wangshuo128 commented on a diff in pull request #12416: [feature](Nereids) Support OneRowRelation and EmptyRelation

2022-09-07 Thread GitBox
wangshuo128 commented on code in PR #12416: URL: https://github.com/apache/doris/pull/12416#discussion_r964443875 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/PhysicalOneRowRelation.java: ## @@ -0,0 +1,112 @@ +// Licensed to the Apache Software Found

[GitHub] [doris] wangshuo128 commented on a diff in pull request #12416: [feature](Nereids) Support OneRowRelation and EmptyRelation

2022-09-07 Thread GitBox
wangshuo128 commented on code in PR #12416: URL: https://github.com/apache/doris/pull/12416#discussion_r964458881 ## fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/UnboundOneRowRelation.java: ## @@ -0,0 +1,121 @@ +// Licensed to the Apache Software Foundation (ASF) u

[GitHub] [doris] zhengshiJ opened a new pull request, #12420: [fix](nereids) fix uncorrelated subquery error

2022-09-07 Thread GitBox
zhengshiJ opened a new pull request, #12420: URL: https://github.com/apache/doris/pull/12420 # Proposed changes Issue Number: close #xxx ## Problem summary When the current non-correlated subquery is executed, an error will be reported that the corresponding column canno

[GitHub] [doris] zhengshiJ closed pull request #12420: [fix](nereids) fix uncorrelated subquery error

2022-09-07 Thread GitBox
zhengshiJ closed pull request #12420: [fix](nereids) fix uncorrelated subquery error URL: https://github.com/apache/doris/pull/12420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [doris] zhengshiJ opened a new pull request, #12421: [fix](nereids) fix uncorrelated subquery can't get the correct result

2022-09-07 Thread GitBox
zhengshiJ opened a new pull request, #12421: URL: https://github.com/apache/doris/pull/12421 # Proposed changes Issue Number: close #xxx ## Problem summary When the current non-correlated subquery is executed, an error will be reported that the corresponding column canno

[GitHub] [doris] bingfenglai commented on issue #12278: Communications link failure. Can not read response from server. Expected to read 4 bytes, read 0 bytes before connection was unexpectedly lost.

2022-09-07 Thread GitBox
bingfenglai commented on issue #12278: URL: https://github.com/apache/doris/issues/12278#issuecomment-1238999646 We encountered the same situation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [doris] yangzhg closed issue #11990: [Enhancement] Add elt function for doris.

2022-09-07 Thread GitBox
yangzhg closed issue #11990: [Enhancement] Add elt function for doris. URL: https://github.com/apache/doris/issues/11990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] yangzhg merged pull request #12321: [Function](ELT)Add elt function for doris

2022-09-07 Thread GitBox
yangzhg merged PR #12321: URL: https://github.com/apache/doris/pull/12321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apac

[doris] branch master updated (f2923f9180 -> 09b45f2b71)

2022-09-07 Thread yangzhg
This is an automated email from the ASF dual-hosted git repository. yangzhg pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from f2923f9180 [Refactor](Nereids) Simplify get input and output slots for plan/expression. (#12356) add 09b45f2b71

[GitHub] [doris] AshinGau opened a new pull request, #12422: [feature-wip](parquet-reader) bug fix, create compress codec before parsing dictionary

2022-09-07 Thread GitBox
AshinGau opened a new pull request, #12422: URL: https://github.com/apache/doris/pull/12422 # Proposed changes ## Fix three bugs: ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [x] No - [ ] I don't know 2. Has unit tes

[GitHub] [doris] dujl commented on pull request #12188: [improvement](spark-load)Spark load supports version 3.x, default supports 3.2.2

2022-09-07 Thread GitBox
dujl commented on PR #12188: URL: https://github.com/apache/doris/pull/12188#issuecomment-1239010649 > Some ideas to supoort the multi-version spark engine in spark load: > > 1. The spark load module is relatively independent and has the characteristics of low update frequency. S

[GitHub] [doris] Kikyou1997 closed pull request #12226: [fix](planner) Fix wrong plan of SQL with cross join and aggreagate

2022-09-07 Thread GitBox
Kikyou1997 closed pull request #12226: [fix](planner) Fix wrong plan of SQL with cross join and aggreagate URL: https://github.com/apache/doris/pull/12226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [doris] Kikyou1997 opened a new pull request, #12423: [fix](nereids) Fix the wrong logic of the binding of TimestampArithmetic

2022-09-07 Thread GitBox
Kikyou1997 opened a new pull request, #12423: URL: https://github.com/apache/doris/pull/12423 # Proposed changes Issue Number: noissue ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes

[GitHub] [doris] Kikyou1997 commented on pull request #12423: [fix](nereids) Fix the wrong logic of the binding of TimestampArithmetic

2022-09-07 Thread GitBox
Kikyou1997 commented on PR #12423: URL: https://github.com/apache/doris/pull/12423#issuecomment-1239018268 @morrySnow @englefly @jackwener -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [doris] carlvinhust2012 opened a new pull request, #12424: [fix](array-type) fix the invalid format load for stream load

2022-09-07 Thread GitBox
carlvinhust2012 opened a new pull request, #12424: URL: https://github.com/apache/doris/pull/12424 # Proposed changes 1. this pr is used to fix the invalid format load for stream load. 2. before the change , we will get the error when we load the invalid array format. 3. after this

[GitHub] [doris] ningbing commented on issue #12278: Communications link failure. Can not read response from server. Expected to read 4 bytes, read 0 bytes before connection was unexpectedly lost.

2022-09-07 Thread GitBox
ningbing commented on issue #12278: URL: https://github.com/apache/doris/issues/12278#issuecomment-1239032065 @stalary @ChPi 这个问题有进展吗?我们想实现通过JDBC自定义insert into Doris,按照你们官网的jdbc的例子,也是提示上面的错误。。应该是驱动,或者哪个环节跟你们的不一样。。但是我们无法定位这个问题,麻烦帮忙看下如何解决。(另外,我们不熟的Doris服务是正常的,通过Dbware等客户端,是可以正常访问的) -- This

[GitHub] [doris] morrySnow commented on a diff in pull request #12421: [fix](nereids) fix uncorrelated subquery can't get the correct result

2022-09-07 Thread GitBox
morrySnow commented on code in PR #12421: URL: https://github.com/apache/doris/pull/12421#discussion_r964499341 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalAssertNumRows.java: ## @@ -59,7 +60,8 @@ public AssertNumRowsElement getAssertNumRowsEl

[doris-website] branch master updated: update manifest.json (#86)

2022-09-07 Thread jiafengzheng
This is an automated email from the ASF dual-hosted git repository. jiafengzheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris-website.git The following commit(s) were added to refs/heads/master by this push: new 2fc9b77fd76 update manifest.json (#

[GitHub] [doris-website] hf200012 merged pull request #86: update manifest.json

2022-09-07 Thread GitBox
hf200012 merged PR #86: URL: https://github.com/apache/doris-website/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[GitHub] [doris] yixiutt opened a new pull request, #12427: [enhancement](tcmalloc) disable tcmalloc.aggressive_memory_decommit

2022-09-07 Thread GitBox
yixiutt opened a new pull request, #12427: URL: https://github.com/apache/doris/pull/12427 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes

[GitHub] [doris] 924060929 commented on a diff in pull request #12421: [fix](nereids) fix uncorrelated subquery can't get the correct result

2022-09-07 Thread GitBox
924060929 commented on code in PR #12421: URL: https://github.com/apache/doris/pull/12421#discussion_r964502766 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalAssertNumRows.java: ## @@ -59,7 +60,8 @@ public AssertNumRowsElement getAssertNumRowsEl

[GitHub] [doris] wsjz opened a new pull request, #12428: [feature-wip](parquet-reader) page index bug fix

2022-09-07 Thread GitBox
wsjz opened a new pull request, #12428: URL: https://github.com/apache/doris/pull/12428 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes

[GitHub] [doris] jackwener merged pull request #12396: [fix](Nereids)lowest cost plan map do not be merged when do group merge

2022-09-07 Thread GitBox
jackwener merged PR #12396: URL: https://github.com/apache/doris/pull/12396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[doris] branch master updated (09b45f2b71 -> 40f481049a)

2022-09-07 Thread jakevin
This is an automated email from the ASF dual-hosted git repository. jakevin pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 09b45f2b71 [Function](ELT)Add elt function (#12321) add 40f481049a [fix](Nereids)lowest cost plan map do not be m

[GitHub] [doris] yangzhg merged pull request #12276: [enhancement](spark-load)support dynamic set env

2022-09-07 Thread GitBox
yangzhg merged PR #12276: URL: https://github.com/apache/doris/pull/12276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apac

[doris] branch master updated: [enhancement](spark-load)support dynamic set env (#12276)

2022-09-07 Thread yangzhg
This is an automated email from the ASF dual-hosted git repository. yangzhg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 941bda5a20 [enhancement](spark-load)support dyna

[GitHub] [doris] TaoZex opened a new issue, #12429: [Feature] The cbrt function support like hive.

2022-09-07 Thread GitBox
TaoZex opened a new issue, #12429: URL: https://github.com/apache/doris/issues/12429 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description Need poseex

[GitHub] [doris] morrySnow commented on a diff in pull request #12416: [feature](Nereids) Support OneRowRelation and EmptyRelation

2022-09-07 Thread GitBox
morrySnow commented on code in PR #12416: URL: https://github.com/apache/doris/pull/12416#discussion_r964532188 ## fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/UnboundOneRowRelation.java: ## @@ -0,0 +1,121 @@ +// Licensed to the Apache Software Foundation (ASF) und

[GitHub] [doris] 924060929 commented on a diff in pull request #12416: [feature](Nereids) Support OneRowRelation and EmptyRelation

2022-09-07 Thread GitBox
924060929 commented on code in PR #12416: URL: https://github.com/apache/doris/pull/12416#discussion_r964580027 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/Substring.java: ## @@ -54,7 +54,7 @@ public Substring(Expression str, Expression pos)

[GitHub] [doris] 924060929 commented on a diff in pull request #12416: [feature](Nereids) Support OneRowRelation and EmptyRelation

2022-09-07 Thread GitBox
924060929 commented on code in PR #12416: URL: https://github.com/apache/doris/pull/12416#discussion_r964583186 ## fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/UnboundOneRowRelation.java: ## @@ -0,0 +1,121 @@ +// Licensed to the Apache Software Foundation (ASF) und

[GitHub] [doris] 924060929 commented on a diff in pull request #12416: [feature](Nereids) Support OneRowRelation and EmptyRelation

2022-09-07 Thread GitBox
924060929 commented on code in PR #12416: URL: https://github.com/apache/doris/pull/12416#discussion_r964585467 ## fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/UnboundOneRowRelation.java: ## @@ -0,0 +1,121 @@ +// Licensed to the Apache Software Foundation (ASF) und

[GitHub] [doris] 924060929 commented on a diff in pull request #12416: [feature](Nereids) Support OneRowRelation and EmptyRelation

2022-09-07 Thread GitBox
924060929 commented on code in PR #12416: URL: https://github.com/apache/doris/pull/12416#discussion_r964585672 ## fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java: ## @@ -227,6 +232,56 @@ public PlanFragment visitPhysicalAggregate(

[GitHub] [doris] 924060929 commented on a diff in pull request #12416: [feature](Nereids) Support OneRowRelation and EmptyRelation

2022-09-07 Thread GitBox
924060929 commented on code in PR #12416: URL: https://github.com/apache/doris/pull/12416#discussion_r964580027 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/Substring.java: ## @@ -54,7 +54,7 @@ public Substring(Expression str, Expression pos)

[GitHub] [doris] 924060929 commented on a diff in pull request #12416: [feature](Nereids) Support OneRowRelation and EmptyRelation

2022-09-07 Thread GitBox
924060929 commented on code in PR #12416: URL: https://github.com/apache/doris/pull/12416#discussion_r964585467 ## fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/UnboundOneRowRelation.java: ## @@ -0,0 +1,121 @@ +// Licensed to the Apache Software Foundation (ASF) und

[GitHub] [doris] 924060929 commented on a diff in pull request #12416: [feature](Nereids) Support OneRowRelation and EmptyRelation

2022-09-07 Thread GitBox
924060929 commented on code in PR #12416: URL: https://github.com/apache/doris/pull/12416#discussion_r964605390 ## fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/UnboundOneRowRelation.java: ## @@ -0,0 +1,121 @@ +// Licensed to the Apache Software Foundation (ASF) und

[GitHub] [doris] 924060929 commented on a diff in pull request #12416: [feature](Nereids) Support OneRowRelation and EmptyRelation

2022-09-07 Thread GitBox
924060929 commented on code in PR #12416: URL: https://github.com/apache/doris/pull/12416#discussion_r964583186 ## fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/UnboundOneRowRelation.java: ## @@ -0,0 +1,121 @@ +// Licensed to the Apache Software Foundation (ASF) und

[GitHub] [doris] zxealous opened a new issue, #12431: [Bug] The judgment logic of the cache cleaner is wrong

2022-09-07 Thread GitBox
zxealous opened a new issue, #12431: URL: https://github.com/apache/doris/issues/12431 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version master

[GitHub] [doris] starocean999 commented on a diff in pull request #12313: [fix](grouping sets) columns in grouping sets should not be in selectstmt‘s AggFunc

2022-09-07 Thread GitBox
starocean999 commented on code in PR #12313: URL: https://github.com/apache/doris/pull/12313#discussion_r964608877 ## fe/fe-core/src/main/java/org/apache/doris/analysis/SelectStmt.java: ## @@ -444,13 +444,18 @@ public void analyze(Analyzer analyzer) throws UserException {

[GitHub] [doris] starocean999 commented on a diff in pull request #12313: [fix](grouping sets) columns in grouping sets should not be in selectstmt‘s AggFunc

2022-09-07 Thread GitBox
starocean999 commented on code in PR #12313: URL: https://github.com/apache/doris/pull/12313#discussion_r964609863 ## fe/fe-core/src/main/java/org/apache/doris/analysis/SelectStmt.java: ## @@ -1966,6 +1971,16 @@ private boolean checkGroupingFn(Expr expr) { return false;

[GitHub] [doris] zxealous opened a new pull request, #12432: [Bug](remote) Fix the judgment logic of cache cleaner

2022-09-07 Thread GitBox
zxealous opened a new pull request, #12432: URL: https://github.com/apache/doris/pull/12432 # Proposed changes Issue Number: close #12431 ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ]

[GitHub] [doris] morrySnow opened a new pull request, #12433: [fix](Nereids) local aggregate output type is mismatch with BE

2022-09-07 Thread GitBox
morrySnow opened a new pull request, #12433: URL: https://github.com/apache/doris/pull/12433 ## Problem summary After aggregate disassemble, we break aggregate into two stage: LOCAL and GLOBAL. All `AggregateFunction` in both of them use `getDataType` to get the output data type o

[GitHub] [doris] morrySnow commented on a diff in pull request #12416: [feature](Nereids) Support OneRowRelation and EmptyRelation

2022-09-07 Thread GitBox
morrySnow commented on code in PR #12416: URL: https://github.com/apache/doris/pull/12416#discussion_r964617443 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/Substring.java: ## @@ -54,7 +54,7 @@ public Substring(Expression str, Expression pos)

[GitHub] [doris] morrySnow commented on a diff in pull request #12416: [feature](Nereids) Support OneRowRelation and EmptyRelation

2022-09-07 Thread GitBox
morrySnow commented on code in PR #12416: URL: https://github.com/apache/doris/pull/12416#discussion_r964618007 ## fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/UnboundOneRowRelation.java: ## @@ -0,0 +1,121 @@ +// Licensed to the Apache Software Foundation (ASF) und

[GitHub] [doris] morrySnow commented on a diff in pull request #12416: [feature](Nereids) Support OneRowRelation and EmptyRelation

2022-09-07 Thread GitBox
morrySnow commented on code in PR #12416: URL: https://github.com/apache/doris/pull/12416#discussion_r964619191 ## fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/UnboundOneRowRelation.java: ## @@ -0,0 +1,121 @@ +// Licensed to the Apache Software Foundation (ASF) und

[GitHub] [doris] yixiutt opened a new pull request, #12434: [enhancement](generic_iterator) fix num check and add some notes

2022-09-07 Thread GitBox
yixiutt opened a new pull request, #12434: URL: https://github.com/apache/doris/pull/12434 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes

[GitHub] [doris] xinyiZzz commented on pull request #12427: [enhancement](tcmalloc) disable tcmalloc.aggressive_memory_decommit

2022-09-07 Thread GitBox
xinyiZzz commented on PR #12427: URL: https://github.com/apache/doris/pull/12427#issuecomment-1239164357 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [doris] 924060929 commented on a diff in pull request #12416: [feature](Nereids) Support OneRowRelation and EmptyRelation

2022-09-07 Thread GitBox
924060929 commented on code in PR #12416: URL: https://github.com/apache/doris/pull/12416#discussion_r964629636 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/Substring.java: ## @@ -54,7 +54,7 @@ public Substring(Expression str, Expression pos)

[GitHub] [doris] pengxiangyu opened a new pull request, #12435: [fix](cache)fix bug for cache cleaner

2022-09-07 Thread GitBox
pengxiangyu opened a new pull request, #12435: URL: https://github.com/apache/doris/pull/12435 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ]

[GitHub] [doris] xy720 merged pull request #12353: [fix](array-type) ARRAY is not supported in bloomfilter index

2022-09-07 Thread GitBox
xy720 merged PR #12353: URL: https://github.com/apache/doris/pull/12353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache

[GitHub] [doris] yiguolei merged pull request #12409: Pick read by rowids

2022-09-07 Thread GitBox
yiguolei merged PR #12409: URL: https://github.com/apache/doris/pull/12409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] branch master updated (941bda5a20 -> 184be8d13c)

2022-09-07 Thread xuyang
This is an automated email from the ASF dual-hosted git repository. xuyang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 941bda5a20 [enhancement](spark-load)support dynamic set env (#12276) add 184be8d13c [fix](array-type) ARRAY is no

[doris] branch dev-1.1.2 updated (59f34e5118 -> 42fcd7c7ee)

2022-09-07 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch dev-1.1.2 in repository https://gitbox.apache.org/repos/asf/doris.git from 59f34e5118 [fix](memtracker) Fix the exceeded limit of the first query execution (#12338) add 42fcd7c7ee Pic

[GitHub] [doris] yixiutt opened a new pull request, #12436: [enhancement](tcmalloc) add aggressive_memory_decommit conf and make …

2022-09-07 Thread GitBox
yixiutt opened a new pull request, #12436: URL: https://github.com/apache/doris/pull/12436 …it disable # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior

[GitHub] [doris] mrhhsg opened a new pull request, #12437: [fix](agg) crash caused by failure of prepare

2022-09-07 Thread GitBox
mrhhsg opened a new pull request, #12437: URL: https://github.com/apache/doris/pull/12437 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes

[GitHub] [doris] xinyiZzz commented on pull request #12436: [enhancement](tcmalloc) add aggressive_memory_decommit conf and make …

2022-09-07 Thread GitBox
xinyiZzz commented on PR #12436: URL: https://github.com/apache/doris/pull/12436#issuecomment-1239206573 a little experience: This modification will double the performance of some cases, but will cause the BE process to use more memory. Expect better manual gc strategies in the future

[GitHub] [doris] zy-kkk opened a new pull request, #12438: [improvement](error info)improve the s3 path err msg

2022-09-07 Thread GitBox
zy-kkk opened a new pull request, #12438: URL: https://github.com/apache/doris/pull/12438 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes

[GitHub] [doris] Gabriel39 commented on a diff in pull request #12407: [Opt](vectorized) Speed up bucket shuffle join hash compute

2022-09-07 Thread GitBox
Gabriel39 commented on code in PR #12407: URL: https://github.com/apache/doris/pull/12407#discussion_r964670903 ## be/src/vec/columns/column_nullable.cpp: ## @@ -67,6 +67,25 @@ void ColumnNullable::update_hashes_with_value(std::vector& hashes, } } +void ColumnNullable::

[GitHub] [doris] Gabriel39 commented on a diff in pull request #12437: [fix](agg) crash caused by failure of prepare

2022-09-07 Thread GitBox
Gabriel39 commented on code in PR #12437: URL: https://github.com/apache/doris/pull/12437#discussion_r964684961 ## be/src/vec/exec/vaggregation_node.cpp: ## @@ -499,11 +508,14 @@ Status AggregationNode::close(RuntimeState* state) { VExpr::close(_probe_expr_ctxs, state);

[GitHub] [doris] jackwener opened a new pull request, #12439: [feature](Nereids): Left deep tree join order.

2022-09-07 Thread GitBox
jackwener opened a new pull request, #12439: URL: https://github.com/apache/doris/pull/12439 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [x] Y

[GitHub] [doris] cambyzju commented on a diff in pull request #12438: [improvement](error info)improve the s3 path err msg

2022-09-07 Thread GitBox
cambyzju commented on code in PR #12438: URL: https://github.com/apache/doris/pull/12438#discussion_r964699114 ## fe/fe-core/src/main/java/org/apache/doris/analysis/ExportStmt.java: ## @@ -244,7 +244,7 @@ public static String checkPath(String path, StorageBackend.StorageType ty

[GitHub] [doris] cambyzju commented on pull request #12435: [fix](cache)fix bug for cache cleaner

2022-09-07 Thread GitBox
cambyzju commented on PR #12435: URL: https://github.com/apache/doris/pull/12435#issuecomment-1239240797 same as https://github.com/apache/doris/pull/12432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [doris] zy-kkk commented on a diff in pull request #12438: [improvement](error info)improve the s3 path err msg

2022-09-07 Thread GitBox
zy-kkk commented on code in PR #12438: URL: https://github.com/apache/doris/pull/12438#discussion_r964709125 ## fe/fe-core/src/main/java/org/apache/doris/analysis/ExportStmt.java: ## @@ -244,7 +244,7 @@ public static String checkPath(String path, StorageBackend.StorageType type

[GitHub] [doris] github-actions[bot] commented on pull request #12423: [fix](nereids) `months_add` Function cannot be found with such expr:`'1996-01-01' + INTERVAL '3' month`

2022-09-07 Thread GitBox
github-actions[bot] commented on PR #12423: URL: https://github.com/apache/doris/pull/12423#issuecomment-1239245064 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #12423: [fix](nereids) `months_add` Function cannot be found with such expr:`'1996-01-01' + INTERVAL '3' month`

2022-09-07 Thread GitBox
github-actions[bot] commented on PR #12423: URL: https://github.com/apache/doris/pull/12423#issuecomment-1239245124 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] cambyzju commented on a diff in pull request #12424: [fix](array-type) fix the invalid format load for stream load

2022-09-07 Thread GitBox
cambyzju commented on code in PR #12424: URL: https://github.com/apache/doris/pull/12424#discussion_r964713303 ## be/src/exec/base_scanner.cpp: ## @@ -481,4 +481,35 @@ void BaseScanner::_fill_columns_from_path() { } } +bool BaseScanner::is_null(const Slice& slice) { +

[GitHub] [doris] carlvinhust2012 commented on a diff in pull request #12424: [fix](array-type) fix the invalid format load for stream load

2022-09-07 Thread GitBox
carlvinhust2012 commented on code in PR #12424: URL: https://github.com/apache/doris/pull/12424#discussion_r964717805 ## be/src/exec/base_scanner.cpp: ## @@ -481,4 +481,35 @@ void BaseScanner::_fill_columns_from_path() { } } +bool BaseScanner::is_null(const Slice& slice)

[GitHub] [doris] carlvinhust2012 commented on a diff in pull request #12424: [fix](array-type) fix the invalid format load for stream load

2022-09-07 Thread GitBox
carlvinhust2012 commented on code in PR #12424: URL: https://github.com/apache/doris/pull/12424#discussion_r964717805 ## be/src/exec/base_scanner.cpp: ## @@ -481,4 +481,35 @@ void BaseScanner::_fill_columns_from_path() { } } +bool BaseScanner::is_null(const Slice& slice)

[GitHub] [doris] pengxiangyu closed pull request #12435: [fix](cache)fix bug for cache cleaner

2022-09-07 Thread GitBox
pengxiangyu closed pull request #12435: [fix](cache)fix bug for cache cleaner URL: https://github.com/apache/doris/pull/12435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] mrhhsg commented on a diff in pull request #12437: [fix](agg) crash caused by failure of prepare

2022-09-07 Thread GitBox
mrhhsg commented on code in PR #12437: URL: https://github.com/apache/doris/pull/12437#discussion_r964722684 ## be/src/vec/exec/vaggregation_node.cpp: ## @@ -499,11 +508,14 @@ Status AggregationNode::close(RuntimeState* state) { VExpr::close(_probe_expr_ctxs, state); i

[GitHub] [doris] carlvinhust2012 commented on a diff in pull request #12424: [fix](array-type) fix the invalid format load for stream load

2022-09-07 Thread GitBox
carlvinhust2012 commented on code in PR #12424: URL: https://github.com/apache/doris/pull/12424#discussion_r964723318 ## be/src/exec/base_scanner.cpp: ## @@ -481,4 +481,35 @@ void BaseScanner::_fill_columns_from_path() { } } +bool BaseScanner::is_null(const Slice& slice)

[GitHub] [doris] Gabriel39 commented on a diff in pull request #12437: [fix](agg) crash caused by failure of prepare

2022-09-07 Thread GitBox
Gabriel39 commented on code in PR #12437: URL: https://github.com/apache/doris/pull/12437#discussion_r964724969 ## be/src/vec/exec/vaggregation_node.cpp: ## @@ -499,11 +508,14 @@ Status AggregationNode::close(RuntimeState* state) { VExpr::close(_probe_expr_ctxs, state);

[GitHub] [doris] hf200012 commented on pull request #12402: [feature](quick-compaciton) enable quick compaction by default

2022-09-07 Thread GitBox
hf200012 commented on PR #12402: URL: https://github.com/apache/doris/pull/12402#issuecomment-1239267560 @chenlinzhong rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [doris] hf200012 commented on a diff in pull request #12406: [Doc](balance)add replica balance speed param

2022-09-07 Thread GitBox
hf200012 commented on code in PR #12406: URL: https://github.com/apache/doris/pull/12406#discussion_r964727024 ## docs/zh-CN/docs/admin-manual/maint-monitor/tablet-repair-and-balance.md: ## @@ -637,6 +637,14 @@ TabletScheduler 在每轮调度时,都会通过 LoadBalancer 来选择一定 * 默认值:false

[GitHub] [doris] Kikyou1997 commented on a diff in pull request #12433: [fix](Nereids) local aggregate output type is mismatch with BE

2022-09-07 Thread GitBox
Kikyou1997 commented on code in PR #12433: URL: https://github.com/apache/doris/pull/12433#discussion_r964734359 ## fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java: ## @@ -1431,7 +1431,7 @@ public void finalizeImplForNereids() throws AnalysisException {

[GitHub] [doris] xinyiZzz merged pull request #12427: [enhancement](tcmalloc) disable tcmalloc.aggressive_memory_decommit

2022-09-07 Thread GitBox
xinyiZzz merged PR #12427: URL: https://github.com/apache/doris/pull/12427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] branch dev-1.1.2 updated: [enhancement](tcmalloc) disable tcmalloc.aggressive_memory_decommit (#12427)

2022-09-07 Thread zouxinyi
This is an automated email from the ASF dual-hosted git repository. zouxinyi pushed a commit to branch dev-1.1.2 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/dev-1.1.2 by this push: new 0832267197 [enhancement](tcmalloc) disabl

[GitHub] [doris] hf200012 merged pull request #12406: [Doc](balance)add replica balance speed param

2022-09-07 Thread GitBox
hf200012 merged PR #12406: URL: https://github.com/apache/doris/pull/12406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] branch master updated: [Doc](balance)add replica balance speed param (#12406)

2022-09-07 Thread jiafengzheng
This is an automated email from the ASF dual-hosted git repository. jiafengzheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new c2808de867 [Doc](balance)add replica balanc

[GitHub] [doris] FreeOnePlus opened a new pull request, #12440: [Feature-wip](docker)Initialize and submit code for rapid development of Docker

2022-09-07 Thread GitBox
FreeOnePlus opened a new pull request, #12440: URL: https://github.com/apache/doris/pull/12440 # Proposed changes Submitted shell script code for Dockerfile, Docker-Compose and related registers. Issue Number: close #xxx ## Problem summary Describe your changes. ##

[GitHub] [doris] Kikyou1997 commented on a diff in pull request #12433: [fix](Nereids) local aggregate output type is mismatch with BE

2022-09-07 Thread GitBox
Kikyou1997 commented on code in PR #12433: URL: https://github.com/apache/doris/pull/12433#discussion_r964748000 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/AggregateFunction.java: ## @@ -17,31 +17,59 @@ package org.apache.doris.nereids.tr

[GitHub] [doris] Kikyou1997 commented on a diff in pull request #12433: [fix](Nereids) local aggregate output type is mismatch with BE

2022-09-07 Thread GitBox
Kikyou1997 commented on code in PR #12433: URL: https://github.com/apache/doris/pull/12433#discussion_r964749153 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/AggregateFunction.java: ## @@ -17,31 +17,59 @@ package org.apache.doris.nereids.tr

[GitHub] [doris] xinyiZzz commented on pull request #12348: [enhancement](load) make default load mem limit configurable

2022-09-07 Thread GitBox
xinyiZzz commented on PR #12348: URL: https://github.com/apache/doris/pull/12348#issuecomment-1239297059 `runtime_state.cpp` the code below should be removed and replaced with `_query_options.load_mem_limit`. ``` int64_t RuntimeState::get_load_mem_limit() { if (_query_options.__

[GitHub] [doris] zenoyang commented on a diff in pull request #12313: [fix](grouping sets) columns in grouping sets should not be in selectstmt‘s AggFunc

2022-09-07 Thread GitBox
zenoyang commented on code in PR #12313: URL: https://github.com/apache/doris/pull/12313#discussion_r964765694 ## fe/fe-core/src/main/java/org/apache/doris/analysis/SelectStmt.java: ## @@ -444,13 +444,18 @@ public void analyze(Analyzer analyzer) throws UserException {

[GitHub] [doris] zenoyang commented on a diff in pull request #12313: [fix](grouping sets) columns in grouping sets should not be in selectstmt‘s AggFunc

2022-09-07 Thread GitBox
zenoyang commented on code in PR #12313: URL: https://github.com/apache/doris/pull/12313#discussion_r964774086 ## fe/fe-core/src/main/java/org/apache/doris/analysis/SelectStmt.java: ## @@ -1966,6 +1971,16 @@ private boolean checkGroupingFn(Expr expr) { return false;

[GitHub] [doris] morrySnow merged pull request #12423: [fix](nereids) cast left child of TimestampArithmetic to wrong type in BindFunction

2022-09-07 Thread GitBox
morrySnow merged PR #12423: URL: https://github.com/apache/doris/pull/12423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[doris] branch master updated: [fix](nereids) cast left child of TimestampArithmetic to wrong type in BindFunction (#12423)

2022-09-07 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new bdbce77227 [fix](nereids) cast left child of T

[GitHub] [doris] starocean999 opened a new pull request, #12441: [fix](agg)the intermediate slots should be materialized as output slots

2022-09-07 Thread GitBox
starocean999 opened a new pull request, #12441: URL: https://github.com/apache/doris/pull/12441 # Proposed changes Issue Number: close #xxx ## Problem summary in some case, the output slots of agg info may be materialized by call SlotDescriptor's materializeSrcExpr metho

[GitHub] [doris] morrySnow commented on a diff in pull request #12433: [fix](Nereids) local aggregate output type is mismatch with BE

2022-09-07 Thread GitBox
morrySnow commented on code in PR #12433: URL: https://github.com/apache/doris/pull/12433#discussion_r964796270 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/AggregateFunction.java: ## @@ -17,31 +17,59 @@ package org.apache.doris.nereids.tre

[doris] branch master updated: [bug](NodeChannel) fix OOM caused by pending queue in sink send (#12359) (#12362)

2022-09-07 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 569ab30556 [bug](NodeChannel) fix OOM caused

[GitHub] [doris] dataroaring merged pull request #12362: [Bug](NodeChannel) Fix OOM caused by pending queue in sink send (#12359)

2022-09-07 Thread GitBox
dataroaring merged PR #12362: URL: https://github.com/apache/doris/pull/12362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

[GitHub] [doris] dataroaring closed issue #12359: [Bug] [Load] NodeChannel pending batches causing OOM with large exec_mem_limit and/or high load concurrency

2022-09-07 Thread GitBox
dataroaring closed issue #12359: [Bug] [Load] NodeChannel pending batches causing OOM with large exec_mem_limit and/or high load concurrency URL: https://github.com/apache/doris/issues/12359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [doris] Gabriel39 opened a new pull request, #12442: [refactor](shuffle) remove unused code

2022-09-07 Thread GitBox
Gabriel39 opened a new pull request, #12442: URL: https://github.com/apache/doris/pull/12442 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Y

[GitHub] [doris] xy720 commented on a diff in pull request #12378: [enhancement](array-type) avoid abuse of Offset and Offset64

2022-09-07 Thread GitBox
xy720 commented on code in PR #12378: URL: https://github.com/apache/doris/pull/12378#discussion_r964818244 ## be/src/vec/columns/column_array.h: ## @@ -45,6 +45,18 @@ class ColumnArray final : public COWHelper { ColumnArray(const ColumnArray&) = default; +public: +

[GitHub] [doris] morningman merged pull request #12392: [dev-1.1.2][fix] avoid thread blocks on wait_for_start()

2022-09-07 Thread GitBox
morningman merged PR #12392: URL: https://github.com/apache/doris/pull/12392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[doris] branch dev-1.1.2 updated: [dev-1.1.2][fix] avoid thread blocks on wait_for_start() (#12392)

2022-09-07 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.1.2 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/dev-1.1.2 by this push: new 0d873883ba [dev-1.1.2][fix] avoid threa

[GitHub] [doris] cambyzju opened a new pull request, #12443: [enhancement](array-type) shrink column suffix zero for type ARRAY

2022-09-07 Thread GitBox
cambyzju opened a new pull request, #12443: URL: https://github.com/apache/doris/pull/12443 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. In compute level, CHAR type will shrink suffix zeros. To keep the logic the same as

[GitHub] [doris] xinyiZzz commented on a diff in pull request #12281: [feature-wip](new-scan) Add memtracker and span for new olap scan node

2022-09-07 Thread GitBox
xinyiZzz commented on code in PR #12281: URL: https://github.com/apache/doris/pull/12281#discussion_r964853955 ## be/src/vec/exec/scan/new_olap_scan_node.cpp: ## @@ -36,6 +36,7 @@ NewOlapScanNode::NewOlapScanNode(ObjectPool* pool, const TPlanNode& tnode, } Status NewOlapSca

[GitHub] [doris] xinyiZzz commented on pull request #12257: [fix](memory): avoid coredump when list pointer is null

2022-09-07 Thread GitBox
xinyiZzz commented on PR #12257: URL: https://github.com/apache/doris/pull/12257#issuecomment-1239426859 `FreePool` will be removed in the future. simple fixes to try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [doris] xinyiZzz commented on pull request #12257: [fix](memory): avoid coredump when list pointer is null

2022-09-07 Thread GitBox
xinyiZzz commented on PR #12257: URL: https://github.com/apache/doris/pull/12257#issuecomment-1239427694 @levy5307 p0 case failed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [doris] cambyzju commented on a diff in pull request #12378: [enhancement](array-type) avoid abuse of Offset and Offset64

2022-09-07 Thread GitBox
cambyzju commented on code in PR #12378: URL: https://github.com/apache/doris/pull/12378#discussion_r964883352 ## be/src/vec/columns/column_array.h: ## @@ -45,6 +45,18 @@ class ColumnArray final : public COWHelper { ColumnArray(const ColumnArray&) = default; +public: +

  1   2   3   >