zenoyang commented on code in PR #12313:
URL: https://github.com/apache/doris/pull/12313#discussion_r964774086
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/SelectStmt.java:
##########
@@ -1966,6 +1971,16 @@ private boolean checkGroupingFn(Expr expr) {
return false;
}
+ private void getAggregateFnExpr(Expr expr, ArrayList<Expr> aggFnExprList) {
+ if (expr instanceof FunctionCallExpr && expr.fn instanceof
AggregateFunction) {
+ aggFnExprList.add(expr);
+ } else if (expr.getChildren() != null && expr.getChildren().size() >
0) {
Review Comment:
Thanks for the reminder, I have modified it, but I have kept `else if
(expr.getChildren() != null)`, otherwise it may cause NullPointerException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
