[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8821: [Refactor][doc]Add update-delete documentation

2022-04-08 Thread GitBox
github-actions[bot] commented on PR #8821: URL: https://github.com/apache/incubator-doris/pull/8821#issuecomment-1092509255 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8821: [Refactor][doc]Add update-delete documentation

2022-04-08 Thread GitBox
github-actions[bot] commented on PR #8821: URL: https://github.com/apache/incubator-doris/pull/8821#issuecomment-1092509276 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] BiteTheDDDDt commented on issue #8898: [Bug] 针对datetime类型的字段,进行where查询时,where create_time>"0000-00-00 00:00:00"返回结果为空

2022-04-08 Thread GitBox
BiteThet commented on issue #8898: URL: https://github.com/apache/incubator-doris/issues/8898#issuecomment-1092509292 This case is already fixed by master version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8913: [fix][doc] remove non-exist outfile.md

2022-04-08 Thread GitBox
github-actions[bot] commented on PR #8913: URL: https://github.com/apache/incubator-doris/pull/8913#issuecomment-1092509605 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8913: [fix][doc] remove non-exist outfile.md

2022-04-08 Thread GitBox
github-actions[bot] commented on PR #8913: URL: https://github.com/apache/incubator-doris/pull/8913#issuecomment-1092509629 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris-manager] hf200012 merged pull request #37: [improvement] node agent async start and stop

2022-04-08 Thread GitBox
hf200012 merged PR #37: URL: https://github.com/apache/incubator-doris-manager/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[incubator-doris-manager] branch master updated: node agent async start and stop (#37)

2022-04-08 Thread jiafengzheng
This is an automated email from the ASF dual-hosted git repository. jiafengzheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-manager.git The following commit(s) were added to refs/heads/master by this push: new f217049 node agent async

[GitHub] [incubator-doris] Wahno opened a new pull request, #8915: [docs] update alter table doc

2022-04-08 Thread GitBox
Wahno opened a new pull request, #8915: URL: https://github.com/apache/incubator-doris/pull/8915 # Proposed changes Issue Number: close #xxx ## Problem Summary: add alter table xxx replace with table xxx doc ## Checklist(Required) 1. Does it affect the origi

[GitHub] [incubator-doris] caiconghui commented on a diff in pull request #8786: [improvement] Refactor type info for further optimizations.

2022-04-08 Thread GitBox
caiconghui commented on code in PR #8786: URL: https://github.com/apache/incubator-doris/pull/8786#discussion_r845802562 ## be/src/olap/field.h: ## @@ -278,7 +278,7 @@ class Field { FieldType type() const { return _type_info->type(); } FieldAggregationMethod aggregat

[GitHub] [incubator-doris] JNSimba opened a new pull request, #8916: [Refactor][doc] add data model and index doc

2022-04-08 Thread GitBox
JNSimba opened a new pull request, #8916: URL: https://github.com/apache/incubator-doris/pull/8916 ## Problem Summary: 1. data model:Aggregate/Unique/Duplicate 2. index: bitmap/prefix/bloomfilter ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don

[GitHub] [incubator-doris] Lchangliang commented on pull request #8904: [Bug] fix the problem that using tsan to compile,BE will stack overflow when start.

2022-04-08 Thread GitBox
Lchangliang commented on PR #8904: URL: https://github.com/apache/incubator-doris/pull/8904#issuecomment-1092522711 > hi @Lchangliang , #8665 has been merged I rebase and test it. It is ok to compile and startup. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-doris] zhengshengjun commented on pull request #8908: [fix](load) start transaction before we need it (#8819)

2022-04-08 Thread GitBox
zhengshengjun commented on PR #8908: URL: https://github.com/apache/incubator-doris/pull/8908#issuecomment-1092530164 > How about calling beginTnx() in `SparkLoadJob.unprotectedExecuteJob`, it seems more reasonable. Also closer to the original version. `SparkLoadJob` is responsible for tran

[GitHub] [incubator-doris] adonis0147 commented on a diff in pull request #8786: [improvement] Refactor type info for further optimizations.

2022-04-08 Thread GitBox
adonis0147 commented on code in PR #8786: URL: https://github.com/apache/incubator-doris/pull/8786#discussion_r845819989 ## be/src/olap/field.h: ## @@ -278,7 +278,7 @@ class Field { FieldType type() const { return _type_info->type(); } FieldAggregationMethod aggregat

[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #8906: [feat](sql) support star exclude modifier

2022-04-08 Thread GitBox
EmmyMiao87 commented on PR #8906: URL: https://github.com/apache/incubator-doris/pull/8906#issuecomment-1092541138 It is best to be consistent with the sql of the data warehouse that supports this kind of syntax. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-doris] adonis0147 commented on a diff in pull request #8786: [improvement] Refactor type info for further optimizations.

2022-04-08 Thread GitBox
adonis0147 commented on code in PR #8786: URL: https://github.com/apache/incubator-doris/pull/8786#discussion_r845819989 ## be/src/olap/field.h: ## @@ -278,7 +278,7 @@ class Field { FieldType type() const { return _type_info->type(); } FieldAggregationMethod aggregat

[GitHub] [incubator-doris] adonis0147 commented on a diff in pull request #8786: [improvement] Refactor type info for further optimizations.

2022-04-08 Thread GitBox
adonis0147 commented on code in PR #8786: URL: https://github.com/apache/incubator-doris/pull/8786#discussion_r845819989 ## be/src/olap/field.h: ## @@ -278,7 +278,7 @@ class Field { FieldType type() const { return _type_info->type(); } FieldAggregationMethod aggregat

[GitHub] [incubator-doris] spaces-X opened a new issue, #8917: [Bug] unstable results of intersect_count with order by

2022-04-08 Thread GitBox
spaces-X opened a new issue, #8917: URL: https://github.com/apache/incubator-doris/issues/8917 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version versi

[GitHub] [incubator-doris-manager] wangyf0555 opened a new pull request, #38: [fix]Disable the button to reset the current user password in the User admin list

2022-04-08 Thread GitBox
wangyf0555 opened a new pull request, #38: URL: https://github.com/apache/incubator-doris-manager/pull/38 # According to the design of the product that user can only reset his password on the account management page. Issue Number: close #xxx ## Problem Summary: Describe

[GitHub] [incubator-doris-manager] hf200012 merged pull request #38: [fix]Disable the button to reset the current user password in the User admin list

2022-04-08 Thread GitBox
hf200012 merged PR #38: URL: https://github.com/apache/incubator-doris-manager/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[incubator-doris-manager] branch master updated: [fix]Disable the button to reset the current user password in the User admin list (#38)

2022-04-08 Thread jiafengzheng
This is an automated email from the ASF dual-hosted git repository. jiafengzheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-manager.git The following commit(s) were added to refs/heads/master by this push: new 5cbd4fd [fix]Disable the

[GitHub] [incubator-doris] Henry2SS opened a new issue, #8918: [Feature] sql digest is badly needed in many scenarios

2022-04-08 Thread GitBox
Henry2SS opened a new issue, #8918: URL: https://github.com/apache/incubator-doris/issues/8918 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description s

[GitHub] [incubator-doris] Henry2SS opened a new pull request, #8919: [Feature] (sql digest) support sql digest

2022-04-08 Thread GitBox
Henry2SS opened a new pull request, #8919: URL: https://github.com/apache/incubator-doris/pull/8919 # Proposed changes Issue Number: close #8918 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original beha

[GitHub] [incubator-doris] xinyiZzz opened a new issue, #8920: [Bug] `ThreadMemTrackerMgr::update_tracker` null pointer in vectorized

2022-04-08 Thread GitBox
xinyiZzz opened a new issue, #8920: URL: https://github.com/apache/incubator-doris/issues/8920 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version trunk

[GitHub] [incubator-doris] JNSimba commented on pull request #8865: [Refactor][Doc] Add data backup,data restore and data delete recovery

2022-04-08 Thread GitBox
JNSimba commented on PR #8865: URL: https://github.com/apache/incubator-doris/pull/8865#issuecomment-1092601971 add backup and restore example -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-doris] morrySnow commented on a diff in pull request #8899: [fix]predicate propagate was removed incautiously

2022-04-08 Thread GitBox
morrySnow commented on code in PR #8899: URL: https://github.com/apache/incubator-doris/pull/8899#discussion_r845877637 ## fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java: ## @@ -1713,6 +1713,7 @@ private PlanNode createScanNode(Analyzer analyzer, Table

[GitHub] [incubator-doris] ChPi opened a new pull request, #8921: [Bug] fix backup timeout on a table without partition

2022-04-08 Thread GitBox
ChPi opened a new pull request, #8921: URL: https://github.com/apache/incubator-doris/pull/8921 # Proposed changes Issue Number: close #8886 ## Problem Summary: backup job skips the table which has no partition ## Checklist(Required) 1. Does it affect the o

[GitHub] [incubator-doris] SWJTU-ZhangLei opened a new issue, #8922: [Bug] regression-test fail for aggreagate

2022-04-08 Thread GitBox
SWJTU-ZhangLei opened a new issue, #8922: URL: https://github.com/apache/incubator-doris/issues/8922 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version

[GitHub] [incubator-doris] SWJTU-ZhangLei commented on issue #8922: [Bug] regression-test fail for aggregate

2022-04-08 Thread GitBox
SWJTU-ZhangLei commented on issue #8922: URL: https://github.com/apache/incubator-doris/issues/8922#issuecomment-1092618545 https://github.com/trinodb/trino/blob/master/testing/trino-product-tests/src/main/resources/sql-tests/testcases/aggregate/stddev_popDistinct.result trion re

[GitHub] [incubator-doris] Lchangliang opened a new pull request, #8923: Support compression prop

2022-04-08 Thread GitBox
Lchangliang opened a new pull request, #8923: URL: https://github.com/apache/incubator-doris/pull/8923 # Proposed changes Issue Number: close #8427 ## Problem Summary: The PR just support to specify compression algorithms when creating tables like HBase. But Doris just s

[GitHub] [incubator-doris] hf200012 opened a new pull request, #8924: [Refactor][Doc]add cluster admin help

2022-04-08 Thread GitBox
hf200012 opened a new pull request, #8924: URL: https://github.com/apache/incubator-doris/pull/8924 add cluster admin help # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8865: [Refactor][Doc] Add data backup,data restore and data delete recovery

2022-04-08 Thread GitBox
github-actions[bot] commented on PR #8865: URL: https://github.com/apache/incubator-doris/pull/8865#issuecomment-1092680330 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8865: [Refactor][Doc] Add data backup,data restore and data delete recovery

2022-04-08 Thread GitBox
github-actions[bot] commented on PR #8865: URL: https://github.com/apache/incubator-doris/pull/8865#issuecomment-1092680358 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] hf200012 commented on a diff in pull request #8916: [Refactor][doc] add data model and index doc

2022-04-08 Thread GitBox
hf200012 commented on code in PR #8916: URL: https://github.com/apache/incubator-doris/pull/8916#discussion_r845942791 ## new-docs/zh-CN/data-table/data-model.md: ## @@ -24,4 +24,430 @@ specific language governing permissions and limitations under the License. --> -# 数据模型、RO

[GitHub] [incubator-doris] morrySnow commented on pull request #8695: [enhancement] update broadcast join cost algorithm

2022-04-08 Thread GitBox
morrySnow commented on PR #8695: URL: https://github.com/apache/incubator-doris/pull/8695#issuecomment-1092682219 > Ut failed ~ failed ut is be ut. and the failed info is look like asan check failed. since this patch don't change any code in be, i don't know how to fix it -- T

[GitHub] [incubator-doris-manager] wangyf0555 opened a new pull request, #39: [fix] fix bug with the create space page routing navigation is incorrect

2022-04-08 Thread GitBox
wangyf0555 opened a new pull request, #39: URL: https://github.com/apache/incubator-doris-manager/pull/39 ## Problem Summary: After recover an unfinished create space task, click the previous button to return to the previous step, but the route navigation error occurs. ## Checklist

[GitHub] [incubator-doris-manager] hf200012 merged pull request #39: [fix] fix bug with the create space page routing navigation is incorrect

2022-04-08 Thread GitBox
hf200012 merged PR #39: URL: https://github.com/apache/incubator-doris-manager/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[incubator-doris-manager] branch master updated: [fix] fix bug with the create space page routing navigation is incorrect (#39)

2022-04-08 Thread jiafengzheng
This is an automated email from the ASF dual-hosted git repository. jiafengzheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-manager.git The following commit(s) were added to refs/heads/master by this push: new 2e10f8f [fix] fix bug wi

[GitHub] [incubator-doris] xinyiZzz opened a new pull request, #8925: [fix][mem tracker] Fix MemTracker null pointer in vectorized

2022-04-08 Thread GitBox
xinyiZzz opened a new pull request, #8925: URL: https://github.com/apache/incubator-doris/pull/8925 # Proposed changes Issue Number: close #8920 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behav

[GitHub] [incubator-doris-spark-connector] hf200012 commented on a diff in pull request #15: [improvement] stream load data is converted to json format

2022-04-08 Thread GitBox
hf200012 commented on code in PR #15: URL: https://github.com/apache/incubator-doris-spark-connector/pull/15#discussion_r834992928 ## spark-doris-connector/src/main/scala/org/apache/doris/spark/sql/DorisSourceProvider.scala: ## @@ -93,7 +93,7 @@ private[sql] class DorisSourcePr

[GitHub] [incubator-doris] JNSimba commented on a diff in pull request #8916: [Refactor][doc] add data model and index doc

2022-04-08 Thread GitBox
JNSimba commented on code in PR #8916: URL: https://github.com/apache/incubator-doris/pull/8916#discussion_r845961150 ## new-docs/zh-CN/data-table/data-model.md: ## @@ -24,4 +24,430 @@ specific language governing permissions and limitations under the License. --> -# 数据模型、ROL

[GitHub] [incubator-doris] caoliang-web opened a new pull request, #8926: [Refactor][doc]Edit the ecological extension part of the document

2022-04-08 Thread GitBox
caoliang-web opened a new pull request, #8926: URL: https://github.com/apache/incubator-doris/pull/8926 ## Problem Summary: 1.Edit the ecological extension part of the document ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has

[GitHub] [incubator-doris] smallhibiscus opened a new pull request, #8927: [Refactor][doc] add data model and index doc

2022-04-08 Thread GitBox
smallhibiscus opened a new pull request, #8927: URL: https://github.com/apache/incubator-doris/pull/8927 # Proposed changes Issue Number: close #xxx ## Problem Summary: add data-table/advance-usage\basic-usage\hit-the-rollup\data-partition en and zh-CN docs. ##

[GitHub] [incubator-doris] littleeleventhwolf commented on pull request #8906: [feat](sql) support star exclude modifier

2022-04-08 Thread GitBox
littleeleventhwolf commented on PR #8906: URL: https://github.com/apache/incubator-doris/pull/8906#issuecomment-1092737543 > It is best to be consistent with the sql of the data warehouse that supports this kind of syntax. I try to make it similar to BigQuery, using `except` dialect.

[GitHub] [incubator-doris] xinyiZzz opened a new issue, #8928: [Bug] No matching function with signature: hex(hll)

2022-04-08 Thread GitBox
xinyiZzz opened a new issue, #8928: URL: https://github.com/apache/incubator-doris/issues/8928 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version trunk

[GitHub] [incubator-doris] EmmyMiao87 commented on a diff in pull request #8927: [Refactor][doc] add data-table doc

2022-04-08 Thread GitBox
EmmyMiao87 commented on code in PR #8927: URL: https://github.com/apache/incubator-doris/pull/8927#discussion_r846019588 ## new-docs/en/data-table/data-partition.md: ## @@ -209,9 +212,46 @@ It is also possible to use only one layer of partitioning. When using a layer pa

[GitHub] [incubator-doris] EmmyMiao87 commented on a diff in pull request #8927: [Refactor][doc] add data-table doc

2022-04-08 Thread GitBox
EmmyMiao87 commented on code in PR #8927: URL: https://github.com/apache/incubator-doris/pull/8927#discussion_r846032038 ## new-docs/en/data-table/hit-the-rollup.md: ## @@ -26,20 +26,164 @@ under the License. # Rollup and query +ROLLUP in multidimensional analysis means "sc

[GitHub] [incubator-doris] Gabriel39 opened a new pull request, #8929: [BUGFIX] fix NPE for count(*) expr

2022-04-08 Thread GitBox
Gabriel39 opened a new pull request, #8929: URL: https://github.com/apache/incubator-doris/pull/8929 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behav

[GitHub] [incubator-doris] Gabriel39 closed pull request #8929: [BUGFIX] fix NPE for count(*) expr

2022-04-08 Thread GitBox
Gabriel39 closed pull request #8929: [BUGFIX] fix NPE for count(*) expr URL: https://github.com/apache/incubator-doris/pull/8929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [incubator-doris] BiteTheDDDDt opened a new pull request, #8930: [Enhancement][Regression-Test] enhancement for regression-test framework

2022-04-08 Thread GitBox
BiteThet opened a new pull request, #8930: URL: https://github.com/apache/incubator-doris/pull/8930 # Proposed changes Issue Number: close #8729 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original b

[GitHub] [incubator-doris] BiteTheDDDDt closed pull request #8730: [Enhancement] enhancement for regression-test framework

2022-04-08 Thread GitBox
BiteThet closed pull request #8730: [Enhancement] enhancement for regression-test framework URL: https://github.com/apache/incubator-doris/pull/8730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-doris] aibihang opened a new issue, #8931: [Enhancement] add multi columns ddl sql bug

2022-04-08 Thread GitBox
aibihang opened a new issue, #8931: URL: https://github.com/apache/incubator-doris/issues/8931 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description w

[GitHub] [incubator-doris] kkfnui opened a new issue, #8932: [Bug] There is no ccache in apache/incubator-doris:build-env-latest by default

2022-04-08 Thread GitBox
kkfnui opened a new issue, #8932: URL: https://github.com/apache/incubator-doris/issues/8932 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version docker

[GitHub] [incubator-doris] kkfnui commented on issue #8932: [Bug] There is no ccache in apache/incubator-doris:build-env-latest by default

2022-04-08 Thread GitBox
kkfnui commented on issue #8932: URL: https://github.com/apache/incubator-doris/issues/8932#issuecomment-1092868958 It has been fixed in the newest version. But there isn't new build env update for developer. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-doris] yiguolei commented on issue #8932: [Bug] There is no ccache in apache/incubator-doris:build-env-latest by default

2022-04-08 Thread GitBox
yiguolei commented on issue #8932: URL: https://github.com/apache/incubator-doris/issues/8932#issuecomment-1092869131 Great. I also find this problem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-doris] jackwener commented on issue #8932: [Bug] There is no ccache in apache/incubator-doris:build-env-latest by default

2022-04-08 Thread GitBox
jackwener commented on issue #8932: URL: https://github.com/apache/incubator-doris/issues/8932#issuecomment-1092869317 Great catch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [incubator-doris] jackwener commented on issue #8928: [Bug] No matching function with signature: hex(hll)

2022-04-08 Thread GitBox
jackwener commented on issue #8928: URL: https://github.com/apache/incubator-doris/issues/8928#issuecomment-1092872088 I think that it's a enhancement instead of bug. BTW, I think is a good-first-issue for the newer of Doris, how do you think about this? -- This is an automated m

[GitHub] [incubator-doris] kkfnui commented on issue #8932: [Bug] There is no ccache in apache/incubator-doris:build-env-latest by default

2022-04-08 Thread GitBox
kkfnui commented on issue #8932: URL: https://github.com/apache/incubator-doris/issues/8932#issuecomment-1092876459 There should be another problem. ``` build.sh: line 185: /var/local/thirdparty/build-thirdparty.sh: No such file or directory ``` It's because of env setting i

[GitHub] [incubator-doris] zbtzbtzbt opened a new pull request, #8933: [refactor] remove useless inline

2022-04-08 Thread GitBox
zbtzbtzbt opened a new pull request, #8933: URL: https://github.com/apache/incubator-doris/pull/8933 # Proposed changes I found too much inline in doris, some are useless so, this pr is for remove useless keyword `inline` 1. Member functions defined in a class are `inline` by def

[GitHub] [incubator-doris] cambyzju commented on a diff in pull request #8765: [Feature] CSV import and export support header

2022-04-08 Thread GitBox
cambyzju commented on code in PR #8765: URL: https://github.com/apache/incubator-doris/pull/8765#discussion_r846157750 ## be/src/runtime/file_result_writer.cpp: ## @@ -216,12 +218,82 @@ std::string FileResultWriter::_file_format_to_name() { return "unknown"; } } +

[GitHub] [incubator-doris] cambyzju commented on issue #8928: [Bug] No matching function with signature: hex(hll)

2022-04-08 Thread GitBox
cambyzju commented on issue #8928: URL: https://github.com/apache/incubator-doris/issues/8928#issuecomment-1092931289 hi xinyiZzz, The reason is: 1. **hll_hash** function return HLL data type; 2. but **hex** function do not support HLL data type as input; Could I know which s

[GitHub] [incubator-doris] kkfnui opened a new issue, #8934: [Bug] The gcc version in `apache/incubator-doris:build-env-latest` is not meet the required by CMakeLists.txt:92

2022-04-08 Thread GitBox
kkfnui opened a new issue, #8934: URL: https://github.com/apache/incubator-doris/issues/8934 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version docker

[GitHub] [incubator-doris] morningman commented on a diff in pull request #8808: [feature](cold-hot) support s3 resource

2022-04-08 Thread GitBox
morningman commented on code in PR #8808: URL: https://github.com/apache/incubator-doris/pull/8808#discussion_r845798039 ## fe/fe-core/src/main/java/org/apache/doris/catalog/DataProperty.java: ## @@ -46,40 +57,72 @@ public DataProperty(TStorageMedium medium) { this.stor

[GitHub] [incubator-doris] morningman merged pull request #8913: [fix][doc] remove non-exist outfile.md

2022-04-08 Thread GitBox
morningman merged PR #8913: URL: https://github.com/apache/incubator-doris/pull/8913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[incubator-doris] branch master updated: [fix][doc] remove non-exist outfile.md (#8913)

2022-04-08 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 2059e88d43 [fix][doc] remove non-ex

[GitHub] [incubator-doris] morningman commented on a diff in pull request #8925: [fix][mem tracker] Fix MemTracker null pointer in vectorized

2022-04-08 Thread GitBox
morningman commented on code in PR #8925: URL: https://github.com/apache/incubator-doris/pull/8925#discussion_r846249038 ## be/src/vec/sink/vtablet_sink.cpp: ## @@ -43,10 +43,11 @@ Status VOlapTableSink::init(const TDataSink& sink) { } Status VOlapTableSink::prepare(RuntimeS

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8911: [fix](account) use LOG.info instead of LOG.debug

2022-04-08 Thread GitBox
github-actions[bot] commented on PR #8911: URL: https://github.com/apache/incubator-doris/pull/8911#issuecomment-1093009362 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8911: [fix](account) use LOG.info instead of LOG.debug

2022-04-08 Thread GitBox
github-actions[bot] commented on PR #8911: URL: https://github.com/apache/incubator-doris/pull/8911#issuecomment-1093009399 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] morningman commented on a diff in pull request #8899: [fix]predicate propagate was removed incautiously

2022-04-08 Thread GitBox
morningman commented on code in PR #8899: URL: https://github.com/apache/incubator-doris/pull/8899#discussion_r846252706 ## fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java: ## @@ -1713,6 +1713,7 @@ private PlanNode createScanNode(Analyzer analyzer, Tabl

[GitHub] [incubator-doris] morningman commented on a diff in pull request #8919: [Feature] (sql digest) support sql digest

2022-04-08 Thread GitBox
morningman commented on code in PR #8919: URL: https://github.com/apache/incubator-doris/pull/8919#discussion_r846254884 ## fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java: ## @@ -871,12 +871,20 @@ public String toSql() { return (printSqlInParens) ? "(" + t

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8824: [fix] (routine load)Routine load task doesn't reallocate when previous BE is down.

2022-04-08 Thread GitBox
github-actions[bot] commented on PR #8824: URL: https://github.com/apache/incubator-doris/pull/8824#issuecomment-1093016410 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8904: [Bug] fix the problem that using tsan to compile,BE will stack overflow when start.

2022-04-08 Thread GitBox
github-actions[bot] commented on PR #8904: URL: https://github.com/apache/incubator-doris/pull/8904#issuecomment-1093020455 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] morningman commented on issue #8932: [Bug] There is no ccache in apache/incubator-doris:build-env-latest by default

2022-04-08 Thread GitBox
morningman commented on issue #8932: URL: https://github.com/apache/incubator-doris/issues/8932#issuecomment-1093026227 I think you should use: `apache/incubator-doris:build-env-ldb-toolchain-latest` not `apache/incubator-doris:build-env-latest` -- This is an automated me

[GitHub] [incubator-doris] morningman commented on issue #8934: [Bug] The gcc version in `apache/incubator-doris:build-env-latest` is not meet the required by CMakeLists.txt:92

2022-04-08 Thread GitBox
morningman commented on issue #8934: URL: https://github.com/apache/incubator-doris/issues/8934#issuecomment-1093026721 try this image: `apache/incubator-doris:build-env-ldb-toolchain-latest` -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] kkfnui closed issue #8932: [Bug] There is no ccache in apache/incubator-doris:build-env-latest by default

2022-04-08 Thread GitBox
kkfnui closed issue #8932: [Bug] There is no ccache in apache/incubator-doris:build-env-latest by default URL: https://github.com/apache/incubator-doris/issues/8932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] kkfnui commented on issue #8932: [Bug] There is no ccache in apache/incubator-doris:build-env-latest by default

2022-04-08 Thread GitBox
kkfnui commented on issue #8932: URL: https://github.com/apache/incubator-doris/issues/8932#issuecomment-1093043876 > I think you should use: `apache/incubator-doris:build-env-ldb-toolchain-latest` not `apache/incubator-doris:build-env-latest` It build successed! -- This is an au

[GitHub] [incubator-doris] kkfnui commented on issue #8934: [Bug] The gcc version in `apache/incubator-doris:build-env-latest` is not meet the required by CMakeLists.txt:92

2022-04-08 Thread GitBox
kkfnui commented on issue #8934: URL: https://github.com/apache/incubator-doris/issues/8934#issuecomment-1093044557 > try this image: `apache/incubator-doris:build-env-ldb-toolchain-latest` Got it. And it success now! -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] kkfnui closed issue #8934: [Bug] The gcc version in `apache/incubator-doris:build-env-latest` is not meet the required by CMakeLists.txt:92

2022-04-08 Thread GitBox
kkfnui closed issue #8934: [Bug] The gcc version in `apache/incubator-doris:build-env-latest` is not meet the required by CMakeLists.txt:92 URL: https://github.com/apache/incubator-doris/issues/8934 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-doris] jackwener closed pull request #8935: [feature](ci): add scope labeler

2022-04-08 Thread GitBox
jackwener closed pull request #8935: [feature](ci): add scope labeler URL: https://github.com/apache/incubator-doris/pull/8935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [incubator-doris] jackwener opened a new pull request, #8935: [feature](ci): add scope labeler

2022-04-08 Thread GitBox
jackwener opened a new pull request, #8935: URL: https://github.com/apache/incubator-doris/pull/8935 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behav

[GitHub] [incubator-doris] jackwener opened a new pull request, #8936: test

2022-04-08 Thread GitBox
jackwener opened a new pull request, #8936: URL: https://github.com/apache/incubator-doris/pull/8936 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behav

[GitHub] [incubator-doris] jackwener closed pull request #8936: test

2022-04-08 Thread GitBox
jackwener closed pull request #8936: test URL: https://github.com/apache/incubator-doris/pull/8936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [incubator-doris] jackwener commented on pull request #8935: [feature](ci): add scope labeler

2022-04-08 Thread GitBox
jackwener commented on PR #8935: URL: https://github.com/apache/incubator-doris/pull/8935#issuecomment-1093139351 Maybe, the CI can add more `file location` -> label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-doris] jackwener commented on pull request #8513: [Bug] fix don't rewrite nested union statement bug

2022-04-08 Thread GitBox
jackwener commented on PR #8513: URL: https://github.com/apache/incubator-doris/pull/8513#issuecomment-1093154589 It's been a while. let's fix the conflicts and then merge. BTW, thanks for your contribution❤ -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-doris] jackwener commented on pull request #7121: [Feature] Add an OrToIn expr rewrite rule.

2022-04-08 Thread GitBox
jackwener commented on PR #7121: URL: https://github.com/apache/incubator-doris/pull/7121#issuecomment-1093157940 It's been a while. I will review this PR this weekend. Thanks for contribution❤. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [incubator-doris] qidaye commented on a diff in pull request #8808: [feature](cold-hot) support s3 resource

2022-04-08 Thread GitBox
qidaye commented on code in PR #8808: URL: https://github.com/apache/incubator-doris/pull/8808#discussion_r846551943 ## fe/fe-core/src/main/java/org/apache/doris/catalog/OdbcCatalogResource.java: ## @@ -93,6 +93,29 @@ private void checkProperties(String propertiesKey) throws Dd

[GitHub] [incubator-doris] qidaye commented on a diff in pull request #8808: [feature](cold-hot) support s3 resource

2022-04-08 Thread GitBox
qidaye commented on code in PR #8808: URL: https://github.com/apache/incubator-doris/pull/8808#discussion_r846552718 ## fe/fe-core/src/main/java/org/apache/doris/alter/Alter.java: ## @@ -79,9 +82,15 @@ import java.util.Arrays; import java.util.Comparator; +import java.util.H

[GitHub] [incubator-doris] BiteTheDDDDt closed issue #8526: [Feature][Vectorized] vectorized table functions support

2022-04-08 Thread GitBox
BiteThet closed issue #8526: [Feature][Vectorized] vectorized table functions support URL: https://github.com/apache/incubator-doris/issues/8526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [incubator-doris] kkfnui opened a new pull request, #8937: [doc] Add 1.0.x version for build image

2022-04-08 Thread GitBox
kkfnui opened a new pull request, #8937: URL: https://github.com/apache/incubator-doris/pull/8937 apache/incubator-doris:build-env-ldb-toolchain-latest is the right env for 1.0.x. # Proposed changes The doc isn't friend for new develop. I think it's more readable for new de

[GitHub] [incubator-doris] mrhhsg opened a new pull request, #8938: [Thirdparty]Add llvm for codegen

2022-04-08 Thread GitBox
mrhhsg opened a new pull request, #8938: URL: https://github.com/apache/incubator-doris/pull/8938 # Proposed changes Issue Number: close #xxx ## Problem Summary: Add LLVM to third-party for codegen. ## Checklist(Required) 1. Does it affect the original behav

[GitHub] [incubator-doris] mrhhsg commented on pull request #8895: [Feature]Add codegen with llvm

2022-04-08 Thread GitBox
mrhhsg commented on PR #8895: URL: https://github.com/apache/incubator-doris/pull/8895#issuecomment-1093606742 According to @morningman 's suggestions, I have created one DSIP: https://cwiki.apache.org/confluence/display/DORIS/DSIP-007%3A+Codegen+support+for+Doris And created one new PR f

[GitHub] [incubator-doris] chenlinzhong commented on a diff in pull request #8765: [Feature] CSV import and export support header

2022-04-08 Thread GitBox
chenlinzhong commented on code in PR #8765: URL: https://github.com/apache/incubator-doris/pull/8765#discussion_r846564274 ## be/src/runtime/file_result_writer.cpp: ## @@ -216,12 +218,82 @@ std::string FileResultWriter::_file_format_to_name() { return "unknown"; }

[GitHub] [incubator-doris] hf200012 opened a new pull request, #8939: [Refactor][doc] Added DML SQL help documentation LOAD section

2022-04-08 Thread GitBox
hf200012 opened a new pull request, #8939: URL: https://github.com/apache/incubator-doris/pull/8939 Added DML SQL help documentation LOAD section # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(

[GitHub] [incubator-doris] smallhibiscus commented on pull request #8927: [Refactor][doc] add data-table doc

2022-04-08 Thread GitBox
smallhibiscus commented on PR #8927: URL: https://github.com/apache/incubator-doris/pull/8927#issuecomment-1093618794 Thank you,I have modified these. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-doris] qzsee commented on pull request #8513: [Bug] fix don't rewrite nested union statement bug

2022-04-08 Thread GitBox
qzsee commented on PR #8513: URL: https://github.com/apache/incubator-doris/pull/8513#issuecomment-1093686696 > It's been a while. > let's fix the conflicts and then merge. > BTW, thanks for your contribution❤ done -- This is an automated message from the Apache Git Service. T

[GitHub] [incubator-doris] morningman commented on pull request #8935: [feature](ci): add scope labeler

2022-04-08 Thread GitBox
morningman commented on PR #8935: URL: https://github.com/apache/incubator-doris/pull/8935#issuecomment-1093734264 Maybe we need to use submodules `[.github](https://github.com/apache/incubator-doris/tree/master/.github)/actions/` Or we have to ask Apache Infra to add permission for this

[GitHub] [incubator-doris] wang1xinai commented on issue #8898: [Bug] 针对datetime类型的字段,进行where查询时,where create_time>"0000-00-00 00:00:00"返回结果为空

2022-04-08 Thread GitBox
wang1xinai commented on issue #8898: URL: https://github.com/apache/incubator-doris/issues/8898#issuecomment-1093741913 > > What does version `5.1.0` mean in Doris? Is it a bug for Vectorization Version? > > This version is used to adapt to mysql. 666 -- This is an automate