github-actions[bot] closed pull request #35386: [feature](scan) support split
scanners by size of segment
URL: https://github.com/apache/doris/pull/35386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
github-actions[bot] commented on PR #35386:
URL: https://github.com/apache/doris/pull/35386#issuecomment-2495130169
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of
keeping the PR queue manageable
yiguolei commented on code in PR #35386:
URL: https://github.com/apache/doris/pull/35386#discussion_r1615185956
##
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##
@@ -951,6 +955,14 @@ public class SessionVariable implements Serializable,
Writable {
yiguolei commented on code in PR #35386:
URL: https://github.com/apache/doris/pull/35386#discussion_r1615185821
##
be/src/olap/parallel_scanner_builder.cpp:
##
@@ -32,13 +32,138 @@ template
Status
ParallelScannerBuilder::build_scanners(std::list&
scanners) {
RETURN_IF_E
github-actions[bot] commented on code in PR #35386:
URL: https://github.com/apache/doris/pull/35386#discussion_r1614369638
##
be/src/olap/parallel_scanner_builder.cpp:
##
@@ -32,13 +32,138 @@ template
Status
ParallelScannerBuilder::build_scanners(std::list&
scanners) {
mrhhsg commented on PR #35386:
URL: https://github.com/apache/doris/pull/35386#issuecomment-2130661399
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
github-actions[bot] commented on PR #35386:
URL: https://github.com/apache/doris/pull/35386#issuecomment-2130641175
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mrhhsg commented on PR #35386:
URL: https://github.com/apache/doris/pull/35386#issuecomment-2130637415
run builldall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
doris-robot commented on PR #35386:
URL: https://github.com/apache/doris/pull/35386#issuecomment-2130637393
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
mrhhsg commented on PR #35383:
URL: https://github.com/apache/doris/pull/35383#issuecomment-2130636568
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
mrhhsg commented on PR #35383:
URL: https://github.com/apache/doris/pull/35383#issuecomment-2130635874
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
mrhhsg closed pull request #35383: [feature](scan) support split scanners by
size of segment
URL: https://github.com/apache/doris/pull/35383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
yiguolei commented on code in PR #35383:
URL: https://github.com/apache/doris/pull/35383#discussion_r1614204920
##
be/src/olap/parallel_scanner_builder.h:
##
@@ -77,11 +82,19 @@ class ParallelScannerBuilder {
size_t _rows_per_scanner {_min_rows_per_scanner};
+/// us
yiguolei commented on code in PR #35383:
URL: https://github.com/apache/doris/pull/35383#discussion_r1614204261
##
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##
@@ -951,6 +955,14 @@ public class SessionVariable implements Serializable,
Writable {
doris-robot commented on PR #35383:
URL: https://github.com/apache/doris/pull/35383#issuecomment-2130098531
TeamCity be ut coverage result:
Function Coverage: 35.63% (9014/25299)
Line Coverage: 27.29% (74540/273096)
Region Coverage: 26.51% (38563/145465)
Branch Coverage: 23.3
github-actions[bot] commented on code in PR #35383:
URL: https://github.com/apache/doris/pull/35383#discussion_r1613742925
##
be/src/olap/parallel_scanner_builder.cpp:
##
@@ -32,13 +32,138 @@ template
Status
ParallelScannerBuilder::build_scanners(std::list&
scanners) {
mrhhsg commented on PR #35383:
URL: https://github.com/apache/doris/pull/35383#issuecomment-2129942248
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
yiguolei commented on code in PR #35383:
URL: https://github.com/apache/doris/pull/35383#discussion_r1613692288
##
be/src/olap/parallel_scanner_builder.cpp:
##
@@ -32,13 +32,120 @@ template
Status
ParallelScannerBuilder::build_scanners(std::list&
scanners) {
RETURN_IF_E
yiguolei commented on code in PR #35383:
URL: https://github.com/apache/doris/pull/35383#discussion_r1613679530
##
be/src/olap/parallel_scanner_builder.cpp:
##
@@ -32,13 +32,120 @@ template
Status
ParallelScannerBuilder::build_scanners(std::list&
scanners) {
RETURN_IF_E
yiguolei commented on code in PR #35383:
URL: https://github.com/apache/doris/pull/35383#discussion_r1613678090
##
be/src/olap/parallel_scanner_builder.cpp:
##
@@ -185,17 +293,45 @@ Status ParallelScannerBuilder::_load() {
for (auto& rowset : rowsets) {
R
doris-robot commented on PR #35383:
URL: https://github.com/apache/doris/pull/35383#issuecomment-2129697620
TeamCity be ut coverage result:
Function Coverage: 35.64% (9018/25303)
Line Coverage: 27.30% (74587/273233)
Region Coverage: 26.53% (38607/145518)
Branch Coverage: 23.3
github-actions[bot] commented on code in PR #35383:
URL: https://github.com/apache/doris/pull/35383#discussion_r1613464946
##
be/src/olap/parallel_scanner_builder.cpp:
##
@@ -32,13 +32,120 @@ template
Status
ParallelScannerBuilder::build_scanners(std::list&
scanners) {
mrhhsg commented on PR #35383:
URL: https://github.com/apache/doris/pull/35383#issuecomment-2129495311
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
doris-robot commented on PR #35383:
URL: https://github.com/apache/doris/pull/35383#issuecomment-2129495244
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
24 matches
Mail list logo
