github-actions[bot] commented on code in PR #35386:
URL: https://github.com/apache/doris/pull/35386#discussion_r1614369638
##########
be/src/olap/parallel_scanner_builder.cpp:
##########
@@ -32,13 +32,138 @@ template <typename ParentType>
Status
ParallelScannerBuilder<ParentType>::build_scanners(std::list<VScannerSPtr>&
scanners) {
RETURN_IF_ERROR(_load());
if (_is_dup_mow_key) {
+ if (_split_by_segment_size) {
+ return _build_scanners_by_segment_size(scanners);
+ }
return _build_scanners_by_rowid(scanners);
} else {
// TODO: support to split by key range
return Status::NotSupported("split by key range not supported yet.");
}
}
+template <typename ParentType>
+Status ParallelScannerBuilder<ParentType>::_build_scanners_by_segment_size(
Review Comment:
warning: function '_build_scanners_by_segment_size' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
Status ParallelScannerBuilder<ParentType>::_build_scanners_by_segment_size(
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/parallel_scanner_builder.cpp:45:** 118 lines including
whitespace and comments (threshold 80)
```cpp
Status ParallelScannerBuilder<ParentType>::_build_scanners_by_segment_size(
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
