Re: [PR] Buf fix in be broker module. [doris]

2024-05-13 Thread via GitHub
XuPengfei-1020 closed pull request #34773: Buf fix in be broker module. URL: https://github.com/apache/doris/pull/34773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Buf fix in be broker module. [doris]

2024-05-13 Thread via GitHub
XuPengfei-1020 commented on PR #34773: URL: https://github.com/apache/doris/pull/34773#issuecomment-2109176528 Tow of the bugs abrove has just been fixed by others, so I close this PR now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Buf fix in be broker module. [doris]

2024-05-13 Thread via GitHub
XuPengfei-1020 commented on code in PR #34773: URL: https://github.com/apache/doris/pull/34773#discussion_r1599305060 ## be/src/io/fs/broker_file_system.cpp: ## @@ -415,6 +415,7 @@ Status BrokerFileSystem::download_impl(const Path& remote_file, const Path& loca RETUR

Re: [PR] Buf fix in be broker module. [doris]

2024-05-13 Thread via GitHub
gavinchou commented on code in PR #34773: URL: https://github.com/apache/doris/pull/34773#discussion_r1598220530 ## be/src/io/fs/broker_file_system.cpp: ## @@ -415,6 +415,7 @@ Status BrokerFileSystem::download_impl(const Path& remote_file, const Path& loca RETURN_IF_

Re: [PR] Buf fix in be broker module. [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34773: URL: https://github.com/apache/doris/pull/34773#issuecomment-2107053213 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Buf fix in be broker module. [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34773: URL: https://github.com/apache/doris/pull/34773#issuecomment-2107045847 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] Buf fix in be broker module. [doris]

2024-05-13 Thread via GitHub
XuPengfei-1020 opened a new pull request, #34773: URL: https://github.com/apache/doris/pull/34773 ## Proposed changes Issue Number: close #xxx This pr contains tow small bug fix about snapshop_loader and broker module. 1. Uncheckd erase action of vector may cause be r