gavinchou commented on code in PR #34773:
URL: https://github.com/apache/doris/pull/34773#discussion_r1598220530
##########
be/src/io/fs/broker_file_system.cpp:
##########
@@ -415,6 +415,7 @@ Status BrokerFileSystem::download_impl(const Path&
remote_file, const Path& loca
RETURN_IF_ERROR(local_writer->append({read_buf.get(), read_len}));
} // file_handler should be closed before calculating checksum
+ RETURN_IF_ERROR(local_writer->close());
Review Comment:
we may just `return local_writer->close()`
line 420 can be ommited
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
