Re: [PR] [fix](rpc) do not sanitizer exception of thrift rpc [doris]

2024-04-06 Thread via GitHub
dataroaring closed pull request #33267: [fix](rpc) do not sanitizer exception of thrift rpc URL: https://github.com/apache/doris/pull/33267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] [fix](rpc) do not sanitizer exception of thrift rpc [doris]

2024-04-05 Thread via GitHub
github-actions[bot] commented on PR #33267: URL: https://github.com/apache/doris/pull/33267#issuecomment-2040108662 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](rpc) do not sanitizer exception of thrift rpc [doris]

2024-04-05 Thread via GitHub
doris-robot commented on PR #33267: URL: https://github.com/apache/doris/pull/33267#issuecomment-2039733919 TPC-H: Total hot run time: 38574 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](rpc) do not sanitizer exception of thrift rpc [doris]

2024-04-05 Thread via GitHub
doris-robot commented on PR #33267: URL: https://github.com/apache/doris/pull/33267#issuecomment-2039718047 TeamCity be ut coverage result: Function Coverage: 35.64% (8887/24932) Line Coverage: 27.38% (72950/266459) Region Coverage: 26.55% (37718/142040) Branch Coverage: 23.3

Re: [PR] [fix](rpc) do not sanitizer exception of thrift rpc [doris]

2024-04-05 Thread via GitHub
dataroaring commented on PR #33267: URL: https://github.com/apache/doris/pull/33267#issuecomment-2039651693 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](rpc) do not sanitizer exception of thrift rpc [doris]

2024-04-05 Thread via GitHub
doris-robot commented on PR #33267: URL: https://github.com/apache/doris/pull/33267#issuecomment-2039423523 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 1e60442d4e251f63aabee7e4c94f244f049345b7 with default session variables Stream

Re: [PR] [fix](rpc) do not sanitizer exception of thrift rpc [doris]

2024-04-05 Thread via GitHub
doris-robot commented on PR #33267: URL: https://github.com/apache/doris/pull/33267#issuecomment-2039418062 ClickBench: Total hot run time: 29.7 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools C

Re: [PR] [fix](rpc) do not sanitizer exception of thrift rpc [doris]

2024-04-05 Thread via GitHub
doris-robot commented on PR #33267: URL: https://github.com/apache/doris/pull/33267#issuecomment-2039407096 TPC-DS: Total hot run time: 181218 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](rpc) do not sanitizer exception of thrift rpc [doris]

2024-04-05 Thread via GitHub
doris-robot commented on PR #33267: URL: https://github.com/apache/doris/pull/33267#issuecomment-2039382420 TeamCity be ut coverage result: Function Coverage: 35.64% (8887/24932) Line Coverage: 27.37% (72956/266531) Region Coverage: 26.55% (37722/142090) Branch Coverage: 23.3

Re: [PR] [fix](rpc) do not sanitizer exception of thrift rpc [doris]

2024-04-05 Thread via GitHub
doris-robot commented on PR #33267: URL: https://github.com/apache/doris/pull/33267#issuecomment-2039378627 TPC-H: Total hot run time: 38954 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](rpc) do not sanitizer exception of thrift rpc [doris]

2024-04-05 Thread via GitHub
github-actions[bot] commented on code in PR #33267: URL: https://github.com/apache/doris/pull/33267#discussion_r1553270493 ## be/src/util/thrift_client.cpp: ## @@ -28,7 +28,7 @@ namespace doris { -Status ThriftClientImpl::open() { +__attribute__((no_sanitize_address)) Statu

Re: [PR] [fix](rpc) do not sanitizer exception of thrift rpc [doris]

2024-04-05 Thread via GitHub
github-actions[bot] commented on PR #33267: URL: https://github.com/apache/doris/pull/33267#issuecomment-2039331544 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](rpc) do not sanitizer exception of thrift rpc [doris]

2024-04-05 Thread via GitHub
dataroaring commented on PR #33267: URL: https://github.com/apache/doris/pull/33267#issuecomment-2039331029 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](rpc) do not sanitizer exception of thrift rpc [doris]

2024-04-05 Thread via GitHub
dataroaring commented on PR #33267: URL: https://github.com/apache/doris/pull/33267#issuecomment-2039323163 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](rpc) do not sanitizer exception of thrift rpc [doris]

2024-04-04 Thread via GitHub
github-actions[bot] commented on PR #33267: URL: https://github.com/apache/doris/pull/33267#issuecomment-2038987484 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](rpc) do not sanitizer exception of thrift rpc [doris]

2024-04-04 Thread via GitHub
github-actions[bot] commented on PR #33267: URL: https://github.com/apache/doris/pull/33267#issuecomment-2038918188 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](rpc) do not sanitizer exception of thrift rpc [doris]

2024-04-04 Thread via GitHub
github-actions[bot] commented on PR #33267: URL: https://github.com/apache/doris/pull/33267#issuecomment-2038914221 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](rpc) do not sanitizer exception of thrift rpc [doris]

2024-04-04 Thread via GitHub
dataroaring commented on PR #33267: URL: https://github.com/apache/doris/pull/33267#issuecomment-2038912941 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](rpc) do not sanitizer exception of thrift rpc [doris]

2024-04-04 Thread via GitHub
doris-robot commented on PR #33267: URL: https://github.com/apache/doris/pull/33267#issuecomment-2038912913 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](rpc) do not sanitizer exception of thrift rpc [doris]

2024-04-04 Thread via GitHub
dataroaring opened a new pull request, #33267: URL: https://github.com/apache/doris/pull/33267 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mai