github-actions[bot] commented on code in PR #33267:
URL: https://github.com/apache/doris/pull/33267#discussion_r1553270493
##########
be/src/util/thrift_client.cpp:
##########
@@ -28,7 +28,7 @@
namespace doris {
-Status ThriftClientImpl::open() {
+__attribute__((no_sanitize_address)) Status ThriftClientImpl::open() {
Review Comment:
warning: method 'open' can be made static
[readability-convert-member-functions-to-static]
be/src/util/thrift_client.h:49:
```diff
- Status open();
+ static Status open();
```
##########
be/src/util/thrift_client.cpp:
##########
@@ -78,7 +78,7 @@
return status;
}
-void ThriftClientImpl::close() {
+__attribute__((no_sanitize_address)) void ThriftClientImpl::close() {
Review Comment:
warning: method 'close' can be made static
[readability-convert-member-functions-to-static]
be/src/util/thrift_client.h:56:
```diff
- void close();
+ static void close();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
