Re: [PR] [fix](group commit) abort txn should use label if replay wal failed [doris]

2024-01-22 Thread via GitHub
yiguolei merged PR #30219: URL: https://github.com/apache/doris/pull/30219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [fix](group commit) abort txn should use label if replay wal failed [doris]

2024-01-22 Thread via GitHub
github-actions[bot] commented on PR #30219: URL: https://github.com/apache/doris/pull/30219#issuecomment-1903598581 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](group commit) abort txn should use label if replay wal failed [doris]

2024-01-22 Thread via GitHub
doris-robot commented on PR #30219: URL: https://github.com/apache/doris/pull/30219#issuecomment-1903592260 TeamCity be ut coverage result: Function Coverage: 36.72% (8660/23586) Line Coverage: 28.77% (70728/245845) Region Coverage: 27.64% (36462/131919) Branch Coverage: 24.3

Re: [PR] [fix](group commit) abort txn should use label if replay wal failed [doris]

2024-01-22 Thread via GitHub
doris-robot commented on PR #30219: URL: https://github.com/apache/doris/pull/30219#issuecomment-1903551109 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit d112743894b95d781a6a398658dcdbffab9b2738 with default session variables Stream

Re: [PR] [fix](group commit) abort txn should use label if replay wal failed [doris]

2024-01-22 Thread via GitHub
github-actions[bot] commented on PR #30219: URL: https://github.com/apache/doris/pull/30219#issuecomment-1903549245 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](group commit) abort txn should use label if replay wal failed [doris]

2024-01-22 Thread via GitHub
doris-robot commented on PR #30219: URL: https://github.com/apache/doris/pull/30219#issuecomment-1903545999 ClickBench: Total hot run time: 31.3 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools C

Re: [PR] [fix](group commit) abort txn should use label if replay wal failed [doris]

2024-01-22 Thread via GitHub
doris-robot commented on PR #30219: URL: https://github.com/apache/doris/pull/30219#issuecomment-1903536928 TPC-DS: Total hot run time: 176329 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](group commit) abort txn should use label if replay wal failed [doris]

2024-01-22 Thread via GitHub
doris-robot commented on PR #30219: URL: https://github.com/apache/doris/pull/30219#issuecomment-1903516749 TPC-H: Total hot run time: 38836 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](group commit) abort txn should use label if replay wal failed [doris]

2024-01-22 Thread via GitHub
mymeiyi commented on PR #30219: URL: https://github.com/apache/doris/pull/30219#issuecomment-1903450150 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](group commit) abort txn should use label if replay wal failed [doris]

2024-01-22 Thread via GitHub
github-actions[bot] commented on code in PR #30219: URL: https://github.com/apache/doris/pull/30219#discussion_r1461469968 ## be/src/olap/wal/wal_table.cpp: ## @@ -168,13 +167,13 @@ bool WalTable::_need_replay(std::shared_ptr wal_info) { #endif } -Status WalTable::_try_abor

[PR] [fix](group commit) abort txn should use label if replay wal failed [doris]

2024-01-21 Thread via GitHub
mymeiyi opened a new pull request, #30219: URL: https://github.com/apache/doris/pull/30219 ## Proposed changes 1. If replay wal failed, should abort txn use label, because the txn id is the group commit txn id. 2. refactor some code ## Further comments If this is a re