github-actions[bot] commented on code in PR #30219:
URL: https://github.com/apache/doris/pull/30219#discussion_r1461469968


##########
be/src/olap/wal/wal_table.cpp:
##########
@@ -168,13 +167,13 @@ bool WalTable::_need_replay(std::shared_ptr<WalInfo> 
wal_info) {
 #endif
 }
 
-Status WalTable::_try_abort_txn(int64_t db_id, int64_t wal_id) {
+Status WalTable::_try_abort_txn(int64_t db_id, std::string& label) {

Review Comment:
   warning: method '_try_abort_txn' can be made static 
[readability-convert-member-functions-to-static]
   
   ```suggestion
   static Status WalTable::_try_abort_txn(int64_t db_id, std::string& label) {
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to