Re: [PR] [Refactor](opt) Opt rf and remove unless code [doris]

2024-02-16 Thread via GitHub
BiteThet merged PR #30900: URL: https://github.com/apache/doris/pull/30900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris

Re: [PR] [Refactor](opt) Opt rf and remove unless code [doris]

2024-02-15 Thread via GitHub
github-actions[bot] commented on PR #30900: URL: https://github.com/apache/doris/pull/30900#issuecomment-1947749499 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Refactor](opt) Opt rf and remove unless code [doris]

2024-02-15 Thread via GitHub
github-actions[bot] commented on PR #30900: URL: https://github.com/apache/doris/pull/30900#issuecomment-1947749520 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Refactor](opt) Opt rf and remove unless code [doris]

2024-02-15 Thread via GitHub
HappenLee commented on code in PR #30900: URL: https://github.com/apache/doris/pull/30900#discussion_r1491924539 ## be/src/exprs/runtime_filter.h: ## @@ -276,20 +273,21 @@ class IRuntimeFilter { Status merge_from(const RuntimePredicateWrapper* wrapper); -// for ut

Re: [PR] [Refactor](opt) Opt rf and remove unless code [doris]

2024-02-15 Thread via GitHub
HappenLee commented on code in PR #30900: URL: https://github.com/apache/doris/pull/30900#discussion_r1491922989 ## be/src/exprs/runtime_filter.cpp: ## @@ -735,7 +735,9 @@ class RuntimePredicateWrapper { _is_bloomfilter = true; // we won't use this class to ins

Re: [PR] [Refactor](opt) Opt rf and remove unless code [doris]

2024-02-14 Thread via GitHub
yiguolei commented on code in PR #30900: URL: https://github.com/apache/doris/pull/30900#discussion_r1490252337 ## be/src/exprs/runtime_filter.h: ## @@ -276,20 +273,21 @@ class IRuntimeFilter { Status merge_from(const RuntimePredicateWrapper* wrapper); -// for ut

Re: [PR] [Refactor](opt) Opt rf and remove unless code [doris]

2024-02-14 Thread via GitHub
yiguolei commented on code in PR #30900: URL: https://github.com/apache/doris/pull/30900#discussion_r1490250293 ## be/src/exprs/runtime_filter.cpp: ## @@ -735,7 +735,9 @@ class RuntimePredicateWrapper { _is_bloomfilter = true; // we won't use this class to inse