yiguolei commented on code in PR #30900:
URL: https://github.com/apache/doris/pull/30900#discussion_r1490252337
##########
be/src/exprs/runtime_filter.h:
##########
@@ -276,20 +273,21 @@ class IRuntimeFilter {
Status merge_from(const RuntimePredicateWrapper* wrapper);
- // for ut
static Status create_wrapper(RuntimeFilterParamsContext* state,
const MergeRuntimeFilterParams* param,
ObjectPool* pool,
std::unique_ptr<RuntimePredicateWrapper>*
wrapper);
static Status create_wrapper(RuntimeFilterParamsContext* state,
const UpdateRuntimeFilterParams* param,
ObjectPool* pool,
std::unique_ptr<RuntimePredicateWrapper>*
wrapper);
+
static Status create_wrapper(RuntimeFilterParamsContext* state,
- const UpdateRuntimeFilterParamsV2* param,
ObjectPool* pool,
- std::unique_ptr<RuntimePredicateWrapper>*
wrapper);
+ const UpdateRuntimeFilterParamsV2* param,
Review Comment:
The lifecycle of wrapper is not consistency. Sometimes it is in pool, but
sometimes we use unique ptr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
