Re: [PR] [Improvement](agg) Improve count distinct distribute keys [doris]

2024-04-26 Thread via GitHub
Gabriel39 merged PR #33167: URL: https://github.com/apache/doris/pull/33167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [Improvement](agg) Improve count distinct distribute keys [doris]

2024-04-26 Thread via GitHub
doris-robot commented on PR #33167: URL: https://github.com/apache/doris/pull/33167#issuecomment-2078803727 TPC-DS: Total hot run time: 186747 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Improvement](agg) Improve count distinct distribute keys [doris]

2024-04-26 Thread via GitHub
doris-robot commented on PR #33167: URL: https://github.com/apache/doris/pull/33167#issuecomment-2078784006 TPC-H: Total hot run time: 40813 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Improvement](agg) Improve count distinct distribute keys [doris]

2024-04-26 Thread via GitHub
github-actions[bot] commented on PR #33167: URL: https://github.com/apache/doris/pull/33167#issuecomment-2078757665 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Improvement](agg) Improve count distinct distribute keys [doris]

2024-04-26 Thread via GitHub
github-actions[bot] commented on code in PR #33167: URL: https://github.com/apache/doris/pull/33167#discussion_r1580564181 ## be/src/vec/aggregate_functions/aggregate_function_uniq_distribute_key.h: ## @@ -0,0 +1,253 @@ +// Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [Improvement](agg) Improve count distinct distribute keys [doris]

2024-04-25 Thread via GitHub
Gabriel39 commented on PR #33167: URL: https://github.com/apache/doris/pull/33167#issuecomment-2078745866 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Improvement](agg) Improve count distinct distribute keys [doris]

2024-04-23 Thread via GitHub
zhangstar333 commented on code in PR #33167: URL: https://github.com/apache/doris/pull/33167#discussion_r1576084808 ## be/src/vec/aggregate_functions/aggregate_function_uniq_without_key.h: ## @@ -0,0 +1,256 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

Re: [PR] [Improvement](agg) Improve count distinct distribute keys [doris]

2024-04-23 Thread via GitHub
github-actions[bot] commented on PR #33167: URL: https://github.com/apache/doris/pull/33167#issuecomment-2072033142 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Improvement](agg) Improve count distinct distribute keys [doris]

2024-04-23 Thread via GitHub
github-actions[bot] commented on PR #33167: URL: https://github.com/apache/doris/pull/33167#issuecomment-2072033090 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Improvement](agg) Improve count distinct distribute keys [doris]

2024-04-23 Thread via GitHub
BiteThet commented on code in PR #33167: URL: https://github.com/apache/doris/pull/33167#discussion_r1576046803 ## be/src/vec/aggregate_functions/aggregate_function_uniq_without_key.h: ## @@ -0,0 +1,256 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

Re: [PR] [Improvement](agg) Improve count distinct distribute keys [doris]

2024-04-23 Thread via GitHub
BiteThet commented on code in PR #33167: URL: https://github.com/apache/doris/pull/33167#discussion_r1576040074 ## be/src/vec/aggregate_functions/aggregate_function_uniq_without_key.h: ## @@ -0,0 +1,256 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

Re: [PR] [Improvement](agg) Improve count distinct distribute keys [doris]

2024-04-23 Thread via GitHub
doris-robot commented on PR #33167: URL: https://github.com/apache/doris/pull/33167#issuecomment-2071745058 ClickBench: Total hot run time: 31.27 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Improvement](agg) Improve count distinct distribute keys [doris]

2024-04-23 Thread via GitHub
Gabriel39 commented on PR #33167: URL: https://github.com/apache/doris/pull/33167#issuecomment-2071667727 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Improvement](agg) Improve count distinct distribute keys [doris]

2024-04-23 Thread via GitHub
Gabriel39 commented on PR #33167: URL: https://github.com/apache/doris/pull/33167#issuecomment-2071661166 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Improvement](agg) Improve count distinct distribute keys [doris]

2024-04-02 Thread via GitHub
Gabriel39 closed pull request #33167: [Improvement](agg) Improve count distinct distribute keys URL: https://github.com/apache/doris/pull/33167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [Improvement](agg) Improve count distinct distribute keys [doris]

2024-04-02 Thread via GitHub
github-actions[bot] commented on code in PR #33167: URL: https://github.com/apache/doris/pull/33167#discussion_r1547507219 ## be/src/vec/aggregate_functions/aggregate_function_uniq_without_key.h: ## @@ -0,0 +1,256 @@ +// Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [Improvement](agg) Improve count distinct distribute keys [doris]

2024-04-02 Thread via GitHub
doris-robot commented on PR #33167: URL: https://github.com/apache/doris/pull/33167#issuecomment-2031523136 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [Improvement](agg) Improve count distinct distribute keys [doris]

2024-04-02 Thread via GitHub
Gabriel39 opened a new pull request, #33167: URL: https://github.com/apache/doris/pull/33167 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailt