github-actions[bot] commented on code in PR #33167: URL: https://github.com/apache/doris/pull/33167#discussion_r1547507219
########## be/src/vec/aggregate_functions/aggregate_function_uniq_without_key.h: ########## @@ -0,0 +1,256 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +// This file is copied from +// https://github.com/ClickHouse/ClickHouse/blob/master/src/AggregateFunctions/AggregateFunctionUniqDistributeKey.h +// and modified by Doris + +#pragma once + +#include <stddef.h> Review Comment: warning: inclusion of deprecated C++ header 'stddef.h'; consider using 'cstddef' instead [modernize-deprecated-headers] ```suggestion #include <cstddef> ``` ########## be/src/vec/aggregate_functions/aggregate_function_uniq_without_key.h: ########## @@ -0,0 +1,256 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +// This file is copied from +// https://github.com/ClickHouse/ClickHouse/blob/master/src/AggregateFunctions/AggregateFunctionUniqDistributeKey.h +// and modified by Doris + +#pragma once + +#include <stddef.h> + +#include <algorithm> +#include <boost/iterator/iterator_facade.hpp> +#include <memory> +#include <vector> + +#include "vec/aggregate_functions/aggregate_function.h" +#include "vec/aggregate_functions/aggregate_function_uniq.h" +#include "vec/columns/column.h" +#include "vec/columns/column_fixed_length_object.h" +#include "vec/columns/column_nullable.h" +#include "vec/columns/column_vector.h" +#include "vec/columns/columns_number.h" +#include "vec/common/assert_cast.h" +#include "vec/core/types.h" +#include "vec/data_types/data_type.h" +#include "vec/data_types/data_type_fixed_length_object.h" +#include "vec/data_types/data_type_number.h" +#include "vec/io/var_int.h" + +namespace doris { +namespace vectorized { Review Comment: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] ```suggestion namespace doris::vectorized { ``` be/src/vec/aggregate_functions/aggregate_function_uniq_without_key.h:48: ```diff - } // namespace vectorized - } // namespace doris + } // namespace doris ``` ########## be/src/vec/aggregate_functions/aggregate_function_uniq_without_key.h: ########## @@ -0,0 +1,256 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +// This file is copied from +// https://github.com/ClickHouse/ClickHouse/blob/master/src/AggregateFunctions/AggregateFunctionUniqDistributeKey.h +// and modified by Doris + +#pragma once + +#include <stddef.h> + +#include <algorithm> +#include <boost/iterator/iterator_facade.hpp> +#include <memory> +#include <vector> + +#include "vec/aggregate_functions/aggregate_function.h" +#include "vec/aggregate_functions/aggregate_function_uniq.h" +#include "vec/columns/column.h" +#include "vec/columns/column_fixed_length_object.h" +#include "vec/columns/column_nullable.h" +#include "vec/columns/column_vector.h" +#include "vec/columns/columns_number.h" +#include "vec/common/assert_cast.h" +#include "vec/core/types.h" +#include "vec/data_types/data_type.h" +#include "vec/data_types/data_type_fixed_length_object.h" +#include "vec/data_types/data_type_number.h" +#include "vec/io/var_int.h" + +namespace doris { +namespace vectorized { +class Arena; +class BufferReadable; +class BufferWritable; +} // namespace vectorized +} // namespace doris +template <typename T> +struct HashCRC32; +namespace doris::vectorized { + +template <typename T> +struct AggregateFunctionUniqDistributeKeyData { + static constexpr bool is_string_key = std::is_same_v<T, String>; + using Key = std::conditional_t<is_string_key, UInt128, T>; + using Hash = std::conditional_t<is_string_key, UInt128TrivialHash, HashCRC32<Key>>; + + using Set = flat_hash_set<Key, Hash>; + + // TODO: replace SipHash with xxhash to speed up + static UInt128 ALWAYS_INLINE get_key(const StringRef& value) { + UInt128 key; + SipHash hash; + hash.update(value.data, value.size); + hash.get128(key.low, key.high); + return key; + } + + Set set; + UInt64 count = 0; +}; + +template <typename T, typename Data> +class AggregateFunctionUniqDistributeKey final + : public IAggregateFunctionDataHelper<Data, AggregateFunctionUniqDistributeKey<T, Data>> { +public: + using KeyType = std::conditional_t<std::is_same_v<T, String>, UInt128, T>; + AggregateFunctionUniqDistributeKey(const DataTypes& argument_types_) + : IAggregateFunctionDataHelper<Data, AggregateFunctionUniqDistributeKey<T, Data>>( + argument_types_) {} + + String get_name() const override { return "uniqExactDistributeKey"; } + + DataTypePtr get_return_type() const override { return std::make_shared<DataTypeInt64>(); } + + void add(AggregateDataPtr __restrict place, const IColumn** columns, ssize_t row_num, + Arena*) const override { + detail::OneAdder<T, Data>::add(this->data(place), *columns[0], row_num); + } + + static ALWAYS_INLINE const KeyType* get_keys(std::vector<KeyType>& keys_container, + const IColumn& column, size_t batch_size) { + if constexpr (std::is_same_v<T, String>) { + keys_container.resize(batch_size); + for (size_t i = 0; i != batch_size; ++i) { + StringRef value = column.get_data_at(i); + keys_container[i] = Data::get_key(value); + } + return keys_container.data(); + } else { + using ColumnType = + std::conditional_t<IsDecimalNumber<T>, ColumnDecimal<T>, ColumnVector<T>>; + return assert_cast<const ColumnType&>(column).get_data().data(); + } + } + + void add_batch(size_t batch_size, AggregateDataPtr* places, size_t place_offset, + const IColumn** columns, Arena* arena, bool /*agg_many*/) const override { + std::vector<KeyType> keys_container; + const KeyType* keys = get_keys(keys_container, *columns[0], batch_size); + + std::vector<typename Data::Set*> array_of_data_set(batch_size); + + for (size_t i = 0; i != batch_size; ++i) { + array_of_data_set[i] = &(this->data(places[i] + place_offset).set); + } + + for (size_t i = 0; i != batch_size; ++i) { + if (i + HASH_MAP_PREFETCH_DIST < batch_size) { + array_of_data_set[i + HASH_MAP_PREFETCH_DIST]->prefetch( + keys[i + HASH_MAP_PREFETCH_DIST]); + } + + array_of_data_set[i]->insert(keys[i]); + } + } + + void add_batch_single_place(size_t batch_size, AggregateDataPtr place, const IColumn** columns, + Arena* arena) const override { + std::vector<KeyType> keys_container; + const KeyType* keys = get_keys(keys_container, *columns[0], batch_size); + auto& set = this->data(place).set; + + for (size_t i = 0; i != batch_size; ++i) { + if (i + HASH_MAP_PREFETCH_DIST < batch_size) { + set.prefetch(keys[i + HASH_MAP_PREFETCH_DIST]); + } + set.insert(keys[i]); + } + } + + void merge(AggregateDataPtr __restrict place, ConstAggregateDataPtr rhs, + Arena*) const override { + this->data(place).count += this->data(rhs).count; + } + + void serialize(ConstAggregateDataPtr __restrict place, BufferWritable& buf) const override { + write_var_uint(this->data(place).set.size(), buf); + } + + void deserialize(AggregateDataPtr __restrict place, BufferReadable& buf, + Arena*) const override { + read_var_uint(this->data(place).count, buf); + } + + void insert_result_into(ConstAggregateDataPtr __restrict place, IColumn& to) const override { + assert_cast<ColumnInt64&>(to).get_data().push_back(this->data(place).count); + } + + void deserialize_from_column(AggregateDataPtr places, const IColumn& column, Arena* arena, + size_t num_rows) const override { + auto data = reinterpret_cast<const UInt64*>( + assert_cast<const ColumnFixedLengthObject&>(column).get_data().data()); + for (size_t i = 0; i != num_rows; ++i) { + auto rhs_place = places + sizeof(Data) * i; Review Comment: warning: 'auto rhs_place' can be declared as 'auto *rhs_place' [readability-qualified-auto] ```suggestion auto *rhs_place = places + sizeof(Data) * i; ``` ########## be/src/vec/aggregate_functions/aggregate_function_uniq_without_key.h: ########## @@ -0,0 +1,256 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +// This file is copied from +// https://github.com/ClickHouse/ClickHouse/blob/master/src/AggregateFunctions/AggregateFunctionUniqDistributeKey.h +// and modified by Doris + +#pragma once + +#include <stddef.h> + +#include <algorithm> +#include <boost/iterator/iterator_facade.hpp> Review Comment: warning: 'boost/iterator/iterator_facade.hpp' file not found [clang-diagnostic-error] ```cpp #include <boost/iterator/iterator_facade.hpp> ^ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
