[GitHub] [doris] bobhan1 commented on pull request #23316: [enhancement](merge-on-write) Add delete bitmap correctness check in commit phase

2023-08-28 Thread via GitHub
bobhan1 commented on PR #23316: URL: https://github.com/apache/doris/pull/23316#issuecomment-1696875637 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] github-actions[bot] commented on pull request #23578: [fix](daemon) Fix incorrect initialization order of daemon services

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23578: URL: https://github.com/apache/doris/pull/23578#issuecomment-1696874780 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #23609: [typo](docs)Changes to expressions

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23609: URL: https://github.com/apache/doris/pull/23609#issuecomment-1696874782 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[doris] branch master updated (4c00b1760b -> 993659cd0b)

2023-08-28 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 4c00b1760b [feature](partial update) Support partial update for broker load (#22970) add 993659cd0b [FIX](serde

[GitHub] [doris] yiguolei merged pull request #23565: [FIX](serde) fix handle serde error

2023-08-28 Thread via GitHub
yiguolei merged PR #23565: URL: https://github.com/apache/doris/pull/23565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] github-actions[bot] commented on pull request #23474: [feature](agg) add the aggregation function 'array_agg'

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23474: URL: https://github.com/apache/doris/pull/23474#issuecomment-1696873778 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #23564: [fix](filter) fix error id in bloomfilter

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23564: URL: https://github.com/apache/doris/pull/23564#issuecomment-1696869607 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] xingyingone commented on pull request #23474: [feature](agg) add the aggregation function 'array_agg'

2023-08-28 Thread via GitHub
xingyingone commented on PR #23474: URL: https://github.com/apache/doris/pull/23474#issuecomment-1696867357 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] hello-stephen commented on pull request #23603: [bug](function) fix explode_number function return wrong rows

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23603: URL: https://github.com/apache/doris/pull/23603#issuecomment-169683 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.4 seconds stream load tsv: 537 seconds loaded 74807831229 Bytes,

[GitHub] [doris] github-actions[bot] commented on pull request #23604: [fix](regression) add sync for loading data to avoid case failure in multi-fe test env

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23604: URL: https://github.com/apache/doris/pull/23604#issuecomment-1696864510 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #23604: [fix](regression) add sync for loading data to avoid case failure in multi-fe test env

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23604: URL: https://github.com/apache/doris/pull/23604#issuecomment-1696864562 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[doris] 02/02: [Fix](multi-catalog) Fix broker load reader and hdfs reader issue. (#23529)

2023-08-28 Thread kxiao
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch branch-2.0 in repository https://gitbox.apache.org/repos/asf/doris.git commit 12162d6ee53a86bad6231978e7ba1c238449af24 Author: Qi Chen AuthorDate: Tue Aug 29 13:45:48 2023 +0800 [Fix](multi-c

[doris] 01/02: [fix](planner) only forbid substitute literal expr in function call expr (#23532)

2023-08-28 Thread kxiao
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch branch-2.0 in repository https://gitbox.apache.org/repos/asf/doris.git commit f5aae5baaa28b4193ae7c32f9b90606d68f8f926 Author: starocean999 <40539150+starocean...@users.noreply.github.com> AuthorDa

[doris] branch branch-2.0 updated (3ed1f40080 -> 12162d6ee5)

2023-08-28 Thread kxiao
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a change to branch branch-2.0 in repository https://gitbox.apache.org/repos/asf/doris.git discard 3ed1f40080 [Improvement](meta) add default_value column & is changed column for result of show variables stmt (#235

[GitHub] [doris] github-actions[bot] commented on pull request #23578: [fix](daemon) Fix incorrect initialization order of daemon services

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23578: URL: https://github.com/apache/doris/pull/23578#issuecomment-1696863183 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] Mryange commented on pull request #23564: [fix](filter) fix error id in bloomfilter

2023-08-28 Thread via GitHub
Mryange commented on PR #23564: URL: https://github.com/apache/doris/pull/23564#issuecomment-1696861680 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[doris] branch master updated: [feature](partial update) Support partial update for broker load (#22970)

2023-08-28 Thread zhangchen
This is an automated email from the ASF dual-hosted git repository. zhangchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 4c00b1760b [feature](partial update) Support p

[GitHub] [doris] zhannngchen merged pull request #22970: [feature](partial update) Support partial update for broker load

2023-08-28 Thread via GitHub
zhannngchen merged PR #22970: URL: https://github.com/apache/doris/pull/22970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

[GitHub] [doris] github-actions[bot] commented on pull request #23600: [minor](optimizer): SUPPORT COLLATE GRAMMAR

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23600: URL: https://github.com/apache/doris/pull/23600#issuecomment-1696849145 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #23600: [minor](optimizer): SUPPORT COLLATE GRAMMAR

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23600: URL: https://github.com/apache/doris/pull/23600#issuecomment-1696849102 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] i78086 opened a new pull request, #23610: [typo] (docs) when config automatic-service-start, we need config JAVA_HOME in the fe.conf and be.conf firstly

2023-08-28 Thread via GitHub
i78086 opened a new pull request, #23610: URL: https://github.com/apache/doris/pull/23610 ## Proposed changes Issue Number: close #xxx ## Further comments when config automatic-service-start, we need config JAVA_HOME in the fe.conf and be.conf firstly, this is ne

[GitHub] [doris] ixzc commented on issue #23608: [Bug] https://doris.apache.org/docs/dev/sql-manual/sql-reference/Data-Manipulation-Statements/Manipulation/UPDATE/

2023-08-28 Thread via GitHub
ixzc commented on issue #23608: URL: https://github.com/apache/doris/issues/23608#issuecomment-1696845199 What's wrong with this SQL? Please clarify the problem, I can help you to submit pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [doris] github-actions[bot] commented on pull request #23590: [regression](fix) enable fixed unstable cases

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23590: URL: https://github.com/apache/doris/pull/23590#issuecomment-1696842215 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] zhannngchen commented on a diff in pull request #23448: [improvement](compaction) add an option on delete stale rowset by judging _stale_rs_metas size when doing compaction

2023-08-28 Thread via GitHub
zhannngchen commented on code in PR #23448: URL: https://github.com/apache/doris/pull/23448#discussion_r1308265490 ## be/src/olap/compaction.cpp: ## @@ -693,6 +693,11 @@ Status Compaction::modify_rowsets(const Merger::Statistics* stats) { _tablet->merge_delete_bi

[GitHub] [doris] zhannngchen commented on a diff in pull request #23448: [improvement](compaction) add an option on delete stale rowset by judging _stale_rs_metas size when doing compaction

2023-08-28 Thread via GitHub
zhannngchen commented on code in PR #23448: URL: https://github.com/apache/doris/pull/23448#discussion_r1308265490 ## be/src/olap/compaction.cpp: ## @@ -693,6 +693,11 @@ Status Compaction::modify_rowsets(const Merger::Statistics* stats) { _tablet->merge_delete_bi

[GitHub] [doris] github-actions[bot] commented on pull request #23599: [fix](regression) Fix test no_await

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23599: URL: https://github.com/apache/doris/pull/23599#issuecomment-1696837036 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] shuke987 commented on pull request #23590: [regression](fix) enable fixed unstable cases

2023-08-28 Thread via GitHub
shuke987 commented on PR #23590: URL: https://github.com/apache/doris/pull/23590#issuecomment-1696836248 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] echo-hhj opened a new pull request, #23609: [typo](docs)Changes to expressions

2023-08-28 Thread via GitHub
echo-hhj opened a new pull request, #23609: URL: https://github.com/apache/doris/pull/23609 Changed the evaluation expression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [doris] chd0919 opened a new issue, #23608: [Bug] https://doris.apache.org/docs/dev/sql-manual/sql-reference/Data-Manipulation-Statements/Manipulation/UPDATE/

2023-08-28 Thread via GitHub
chd0919 opened a new issue, #23608: URL: https://github.com/apache/doris/issues/23608 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version doc ### What's W

[GitHub] [doris] github-actions[bot] commented on pull request #23603: [bug](function) fix explode_number function return wrong rows

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23603: URL: https://github.com/apache/doris/pull/23603#issuecomment-1696835425 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] Yukang-Lian commented on pull request #23487: [Fix](Full compaction) Fix full compaction regressison test

2023-08-28 Thread via GitHub
Yukang-Lian commented on PR #23487: URL: https://github.com/apache/doris/pull/23487#issuecomment-1696830755 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] hello-stephen commented on pull request #20622: [fix](fe) Support set hive version when create hive external table

2023-08-28 Thread via GitHub
hello-stephen commented on PR #20622: URL: https://github.com/apache/doris/pull/20622#issuecomment-1696829099 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47.83 seconds stream load tsv: 537 seconds loaded 74807831229 Bytes

[GitHub] [doris] zhangstar333 commented on pull request #23603: [bug](function) fix explode_number function return wrong rows

2023-08-28 Thread via GitHub
zhangstar333 commented on PR #23603: URL: https://github.com/apache/doris/pull/23603#issuecomment-1696829091 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris-website] httpshirley opened a new pull request, #299: add blogs

2023-08-28 Thread via GitHub
httpshirley opened a new pull request, #299: URL: https://github.com/apache/doris-website/pull/299 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [doris] zhangstar333 closed pull request #22473: [Test] test ssb sf100 problem

2023-08-28 Thread via GitHub
zhangstar333 closed pull request #22473: [Test] test ssb sf100 problem URL: https://github.com/apache/doris/pull/22473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [doris] hello-stephen commented on pull request #23597: [feature](Nereids) support struct type

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23597: URL: https://github.com/apache/doris/pull/23597#issuecomment-1696820286 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47.52 seconds stream load tsv: 538 seconds loaded 74807831229 Bytes

[GitHub] [doris-flink-connector] JNSimba commented on a diff in pull request #187: [Improve]Added direct access to BE through the intranet

2023-08-28 Thread via GitHub
JNSimba commented on code in PR #187: URL: https://github.com/apache/doris-flink-connector/pull/187#discussion_r1308249874 ## flink-doris-connector/src/main/java/org/apache/doris/flink/sink/BackendUtil.java: ## @@ -19,30 +19,55 @@ import org.apache.doris.flink.exception.Dori

[GitHub] [doris-flink-connector] JNSimba commented on a diff in pull request #187: [Improve]Added direct access to BE through the intranet

2023-08-28 Thread via GitHub
JNSimba commented on code in PR #187: URL: https://github.com/apache/doris-flink-connector/pull/187#discussion_r1308248781 ## flink-doris-connector/src/main/java/org/apache/doris/flink/sink/BackendUtil.java: ## @@ -19,30 +19,55 @@ import org.apache.doris.flink.exception.Dori

[GitHub] [doris-flink-connector] JNSimba commented on a diff in pull request #187: [Improve]Added direct access to BE through the intranet

2023-08-28 Thread via GitHub
JNSimba commented on code in PR #187: URL: https://github.com/apache/doris-flink-connector/pull/187#discussion_r1308248781 ## flink-doris-connector/src/main/java/org/apache/doris/flink/sink/BackendUtil.java: ## @@ -19,30 +19,55 @@ import org.apache.doris.flink.exception.Dori

[GitHub] [doris] hello-stephen commented on pull request #23601: [fix](view) The parameter positions of timestamp diff function to sql are reversed

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23601: URL: https://github.com/apache/doris/pull/23601#issuecomment-1696811902 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.92 seconds stream load tsv: 537 seconds loaded 74807831229 Bytes

[GitHub] [doris] github-actions[bot] commented on pull request #23362: [Enhancement](Load) stream Load using SQL

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23362: URL: https://github.com/apache/doris/pull/23362#issuecomment-1696807820 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[doris] branch master updated: [Fix](multi-catalog) Fix broker load reader and hdfs reader issue. (#23529)

2023-08-28 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 97eb2b9172 [Fix](multi-catalog) Fix broker lo

[GitHub] [doris] morningman merged pull request #23529: [Fix](multi-catalog) Fix broker load reader and hdfs reader issue.

2023-08-28 Thread via GitHub
morningman merged PR #23529: URL: https://github.com/apache/doris/pull/23529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[GitHub] [doris] morningman commented on pull request #20622: [fix](fe) Support set hive version when create hive external table

2023-08-28 Thread via GitHub
morningman commented on PR #20622: URL: https://github.com/apache/doris/pull/20622#issuecomment-1696802275 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] github-actions[bot] commented on pull request #23362: [Enhancement](Load) stream Load using SQL

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23362: URL: https://github.com/apache/doris/pull/23362#issuecomment-1696798832 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] hello-stephen commented on pull request #23607: [Bug](materialized-view) fix change base schema when create mv

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23607: URL: https://github.com/apache/doris/pull/23607#issuecomment-1696798706 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.02 seconds stream load tsv: 535 seconds loaded 74807831229 Bytes

[GitHub] [doris] github-actions[bot] commented on pull request #23362: [Enhancement](Load) stream Load using SQL

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23362: URL: https://github.com/apache/doris/pull/23362#issuecomment-1696794191 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #23578: [fix](daemon) Fix incorrect initialization order of daemon services

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23578: URL: https://github.com/apache/doris/pull/23578#issuecomment-1696790824 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[doris] branch master updated: [bug](decimal) Use max value as result if overflow (#23602)

2023-08-28 Thread panxiaolei
This is an automated email from the ASF dual-hosted git repository. panxiaolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 7dcde4d529 [bug](decimal) Use max value as re

[GitHub] [doris] BiteTheDDDDt merged pull request #23602: [bug](decimal) Use max value as result if overflow

2023-08-28 Thread via GitHub
BiteThet merged PR #23602: URL: https://github.com/apache/doris/pull/23602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris

[GitHub] [doris] github-actions[bot] commented on pull request #23602: [bug](decimal) Use max value as result if overflow

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23602: URL: https://github.com/apache/doris/pull/23602#issuecomment-1696788827 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #23362: [Enhancement](Load) stream Load using SQL

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23362: URL: https://github.com/apache/doris/pull/23362#issuecomment-1696788685 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] BiteTheDDDDt commented on pull request #23603: [bug](function) fix explode_number function return wrong rows

2023-08-28 Thread via GitHub
BiteThet commented on PR #23603: URL: https://github.com/apache/doris/pull/23603#issuecomment-1696783391 need fix ut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] morrySnow commented on pull request #23597: [feature](Nereids) support struct type

2023-08-28 Thread via GitHub
morrySnow commented on PR #23597: URL: https://github.com/apache/doris/pull/23597#issuecomment-1696778595 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] morrySnow commented on pull request #23601: [fix](view) The parameter positions of timestamp diff function to sql are reversed

2023-08-28 Thread via GitHub
morrySnow commented on PR #23601: URL: https://github.com/apache/doris/pull/23601#issuecomment-1696773784 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] BiteTheDDDDt commented on pull request #23607: [Bug](materialized-view) fix change base schema when create mv

2023-08-28 Thread via GitHub
BiteThet commented on PR #23607: URL: https://github.com/apache/doris/pull/23607#issuecomment-1696772219 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] BiteTheDDDDt opened a new pull request, #23607: [Bug](materialized-view) fix change base schema when create mv

2023-08-28 Thread via GitHub
BiteThet opened a new pull request, #23607: URL: https://github.com/apache/doris/pull/23607 ## Proposed changes fix change base schema when create mv ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](m

[GitHub] [doris] hello-stephen commented on pull request #23605: [fix](move-memtable) wait StreamClose from remote

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23605: URL: https://github.com/apache/doris/pull/23605#issuecomment-1696771458 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.03 seconds stream load tsv: 543 seconds loaded 74807831229 Bytes

[GitHub] [doris] github-actions[bot] commented on pull request #23362: [Enhancement](Load) stream Load using SQL

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23362: URL: https://github.com/apache/doris/pull/23362#issuecomment-1696771386 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] hello-stephen commented on pull request #23443: [Enhancement](merge on write) Add primary keys consistency check for partial update

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23443: URL: https://github.com/apache/doris/pull/23443#issuecomment-1696766085 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.47 seconds stream load tsv: 548 seconds loaded 74807831229 Bytes

[GitHub] [doris] shawn0762 opened a new issue, #23606: [Bug]

2023-08-28 Thread via GitHub
shawn0762 opened a new issue, #23606: URL: https://github.com/apache/doris/issues/23606 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version doris-1.2.6-rc03-Unkno

[GitHub] [doris] tarepanda1024 commented on pull request #20622: [fix](fe) Support set hive version when create hive external table

2023-08-28 Thread via GitHub
tarepanda1024 commented on PR #20622: URL: https://github.com/apache/doris/pull/20622#issuecomment-1696760723 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [doris] hello-stephen commented on pull request #23602: [bug](decimal) Use max value as result if overflow

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23602: URL: https://github.com/apache/doris/pull/23602#issuecomment-1696758558 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.15 seconds stream load tsv: 536 seconds loaded 74807831229 Bytes

[GitHub] [doris] github-actions[bot] commented on pull request #23605: [fix](move-memtable) wait StreamClose from remote

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23605: URL: https://github.com/apache/doris/pull/23605#issuecomment-1696756209 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] kaijchen commented on pull request #23605: [fix](move-memtable) wait StreamClose from remote

2023-08-28 Thread via GitHub
kaijchen commented on PR #23605: URL: https://github.com/apache/doris/pull/23605#issuecomment-1696751639 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] kaijchen opened a new pull request, #23605: [fix](move-memtable) wait StreamClose from remote

2023-08-28 Thread via GitHub
kaijchen opened a new pull request, #23605: URL: https://github.com/apache/doris/pull/23605 ## Proposed changes Previously, SinkV2 will count reports from remote as a signal for close_wait. It is error-prone because it's hard to predict how many reports will be generated. Th

[GitHub] [doris] hello-stephen commented on pull request #23603: [bug](function) fix explode_number function return wrong rows

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23603: URL: https://github.com/apache/doris/pull/23603#issuecomment-1696748906 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.02 seconds stream load tsv: 536 seconds loaded 74807831229 Bytes

[GitHub] [doris] kaijchen commented on pull request #23135: [feature](move-memtable)[0/7] support memtable on sink node

2023-08-28 Thread via GitHub
kaijchen commented on PR #23135: URL: https://github.com/apache/doris/pull/23135#issuecomment-1696748171 closed as all subtasks done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [doris] kaijchen closed pull request #23135: [feature](move-memtable)[0/7] support memtable on sink node

2023-08-28 Thread via GitHub
kaijchen closed pull request #23135: [feature](move-memtable)[0/7] support memtable on sink node URL: https://github.com/apache/doris/pull/23135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [doris] zgxme commented on a diff in pull request #22883: [Enhancement] submit Baidu test cases

2023-08-28 Thread via GitHub
zgxme commented on code in PR #22883: URL: https://github.com/apache/doris/pull/22883#discussion_r1308178776 ## pytest/run_case.sh: ## @@ -0,0 +1,325 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[GitHub] [doris] zgxme commented on a diff in pull request #22883: [Enhancement] submit Baidu test cases

2023-08-28 Thread via GitHub
zgxme commented on code in PR #22883: URL: https://github.com/apache/doris/pull/22883#discussion_r1308176481 ## pytest/run_case.sh: ## @@ -0,0 +1,325 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[GitHub] [doris] hello-stephen commented on pull request #23448: [improvement](compaction) add an option on delete stale rowset by judging _stale_rs_metas size when doing compaction

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23448: URL: https://github.com/apache/doris/pull/23448#issuecomment-1696742882 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.44 seconds stream load tsv: 534 seconds loaded 74807831229 Bytes

[GitHub] [doris] zgxme commented on a diff in pull request #22883: [Enhancement] submit Baidu test cases

2023-08-28 Thread via GitHub
zgxme commented on code in PR #22883: URL: https://github.com/apache/doris/pull/22883#discussion_r1308176481 ## pytest/run_case.sh: ## @@ -0,0 +1,325 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[GitHub] [doris] zgxme commented on pull request #22883: [Enhancement] submit Baidu test cases

2023-08-28 Thread via GitHub
zgxme commented on PR #22883: URL: https://github.com/apache/doris/pull/22883#issuecomment-1696739854 Hi @zhangy5 , thanks for your contribution ! With the Baidu test cases, we found a few more serious issues: 1. be out of core. 2. test result calibration issues, we are on goin

[GitHub] [doris] hello-stephen commented on pull request #23565: [FIX](serde) fix handle serde error

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23565: URL: https://github.com/apache/doris/pull/23565#issuecomment-1696739755 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.38 seconds stream load tsv: 543 seconds loaded 74807831229 Bytes

[GitHub] [doris] hello-stephen commented on pull request #23364: [fix](odbc) fix odbc insert string data to sqlserve

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23364: URL: https://github.com/apache/doris/pull/23364#issuecomment-1696735940 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.6 seconds stream load tsv: 538 seconds loaded 74807831229 Bytes,

[GitHub] [doris] hello-stephen commented on pull request #23600: [minor](optimizer): SUPPORT COLLATE GRAMMAR

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23600: URL: https://github.com/apache/doris/pull/23600#issuecomment-1696734905 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47.67 seconds stream load tsv: 537 seconds loaded 74807831229 Bytes

[GitHub] [doris] hello-stephen commented on pull request #21837: [Improvement][sparkLoad] use system env configs when user does not set env configs.

2023-08-28 Thread via GitHub
hello-stephen commented on PR #21837: URL: https://github.com/apache/doris/pull/21837#issuecomment-1696731854 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47.53 seconds stream load tsv: 535 seconds loaded 74807831229 Bytes

[GitHub] [doris] hello-stephen commented on pull request #23555: [Fix](cache) fix query cache returns wrong result after deleting partitions.

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23555: URL: https://github.com/apache/doris/pull/23555#issuecomment-1696731279 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.24 seconds stream load tsv: 533 seconds loaded 74807831229 Bytes

[GitHub] [doris] hello-stephen commented on pull request #23489: [FIX](array)update array olapconvertor and support array nested other complex type

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23489: URL: https://github.com/apache/doris/pull/23489#issuecomment-1696730494 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 48.82 seconds stream load tsv: 548 seconds loaded 74807831229 Bytes

[GitHub] [doris] hello-stephen commented on pull request #23489: [FIX](array)update array olapconvertor and support array nested other complex type

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23489: URL: https://github.com/apache/doris/pull/23489#issuecomment-1696729850 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.97 seconds stream load tsv: 549 seconds loaded 74807831229 Bytes

[GitHub] [doris] yiguolei commented on a diff in pull request #23582: [Improvement](pipeline) Cancel outdated query if original fe restarts

2023-08-28 Thread via GitHub
yiguolei commented on code in PR #23582: URL: https://github.com/apache/doris/pull/23582#discussion_r1308166974 ## be/src/agent/heartbeat_server.cpp: ## @@ -219,6 +222,69 @@ Status HeartbeatServer::_heartbeat(const TMasterInfo& master_info) { _master_info->__set_backen

[GitHub] [doris] hello-stephen commented on pull request #23581: [Fix](column predicate) seperate CHAR primitive type for column predicate

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23581: URL: https://github.com/apache/doris/pull/23581#issuecomment-1696729568 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.77 seconds stream load tsv: 538 seconds loaded 74807831229 Bytes

[GitHub] [doris] github-actions[bot] commented on pull request #20622: [fix](fe) Support set hive version when create hive external table

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #20622: URL: https://github.com/apache/doris/pull/20622#issuecomment-1696729482 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #20622: [fix](fe) Support set hive version when create hive external table

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #20622: URL: https://github.com/apache/doris/pull/20622#issuecomment-1696729461 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris-flink-connector] JNSimba commented on a diff in pull request #187: [Improve]Added direct access to BE through the intranet

2023-08-28 Thread via GitHub
JNSimba commented on code in PR #187: URL: https://github.com/apache/doris-flink-connector/pull/187#discussion_r1308166380 ## flink-doris-connector/src/main/java/org/apache/doris/flink/cfg/DorisOptions.java: ## @@ -107,11 +130,13 @@ public Builder setJdbcUrl(String jdbcUrl) {

[GitHub] [doris-flink-connector] JNSimba commented on pull request #187: [Improve]Added direct access to BE through the intranet

2023-08-28 Thread via GitHub
JNSimba commented on PR #187: URL: https://github.com/apache/doris-flink-connector/pull/187#issuecomment-1696728166 By the way, add the options of flink table, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [doris] hello-stephen commented on pull request #20622: [fix](fe) Support set hive version when create hive external table

2023-08-28 Thread via GitHub
hello-stephen commented on PR #20622: URL: https://github.com/apache/doris/pull/20622#issuecomment-1696728014 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.96 seconds stream load tsv: 538 seconds loaded 74807831229 Bytes

[GitHub] [doris] yiguolei commented on a diff in pull request #23582: [Improvement](pipeline) Cancel outdated query if original fe restarts

2023-08-28 Thread via GitHub
yiguolei commented on code in PR #23582: URL: https://github.com/apache/doris/pull/23582#discussion_r1308165301 ## .gitignore: ## @@ -37,6 +37,7 @@ package-lock.json !.idea/icon.svg **/.vscode/ **/.fleet/ +compile_commands.json Review Comment: why add this? -- This is

[GitHub] [doris-flink-connector] JNSimba commented on a diff in pull request #187: [Improve]Added direct access to BE through the intranet

2023-08-28 Thread via GitHub
JNSimba commented on code in PR #187: URL: https://github.com/apache/doris-flink-connector/pull/187#discussion_r1308165258 ## flink-doris-connector/src/main/java/org/apache/doris/flink/cfg/DorisConnectionOptions.java: ## @@ -27,19 +27,30 @@ public class DorisConnectionOptions i

[GitHub] [doris] github-actions[bot] commented on pull request #23603: [bug](function) fix explode_number function return wrong rows

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23603: URL: https://github.com/apache/doris/pull/23603#issuecomment-1696726490 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #23603: [bug](function) fix explode_number function return wrong rows

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23603: URL: https://github.com/apache/doris/pull/23603#issuecomment-1696726377 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] hello-stephen commented on pull request #23564: [fix](filter) fix error id in bloomfilter

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23564: URL: https://github.com/apache/doris/pull/23564#issuecomment-1696725572 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.48 seconds stream load tsv: 537 seconds loaded 74807831229 Bytes

[GitHub] [doris] github-actions[bot] commented on pull request #23590: [regression](fix) enable fixed unstable cases

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23590: URL: https://github.com/apache/doris/pull/23590#issuecomment-1696725306 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #23443: [Enhancement](merge on write) Add primary keys consistency check for partial update

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23443: URL: https://github.com/apache/doris/pull/23443#issuecomment-1696724772 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #23602: [bug](decimal) Use max value as result if overflow

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23602: URL: https://github.com/apache/doris/pull/23602#issuecomment-1696724589 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] CodeCooker17 commented on pull request #20622: [fix](fe) Support set hive version when create hive external table

2023-08-28 Thread via GitHub
CodeCooker17 commented on PR #20622: URL: https://github.com/apache/doris/pull/20622#issuecomment-1696724291 create EXTERNAL TABLE `auto_user_gender_tag_v2_external`( `case_id` bigint, `tag_id` string, `tag_value` string ) ENGINE=hive properties ( "database" = "d

[GitHub] [doris] github-actions[bot] commented on pull request #23364: [fix](odbc) fix odbc insert string data to sqlserve

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23364: URL: https://github.com/apache/doris/pull/23364#issuecomment-1696723822 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #23590: [regression](fix) enable fixed unstable cases

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23590: URL: https://github.com/apache/doris/pull/23590#issuecomment-1696723339 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] hello-stephen commented on pull request #23564: [fix](filter) fix error id in bloomfilter

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23564: URL: https://github.com/apache/doris/pull/23564#issuecomment-1696723085 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 50.55 seconds stream load tsv: 541 seconds loaded 74807831229 Bytes

  1   2   3   4   5   6   >