[GitHub] [doris] github-actions[bot] commented on pull request #16588: [feature](cooldown) Auto delete unused remote files

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16588: URL: https://github.com/apache/doris/pull/16588#issuecomment-1426653464 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[doris] branch master updated: [Opt](exec) remove unless null key when no split in convert key range (#16624)

2023-02-10 Thread lihaopeng
This is an automated email from the ASF dual-hosted git repository. lihaopeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 09b7c22f6b [Opt](exec) remove unless null key

[GitHub] [doris] HappenLee merged pull request #16624: [Opt](exec) remove unless null key when no split in convert key range

2023-02-10 Thread via GitHub
HappenLee merged PR #16624: URL: https://github.com/apache/doris/pull/16624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[GitHub] [doris] hello-stephen commented on pull request #16633: [Improvement](ES)Supprt datav2 and datetimev2 for es query

2023-02-10 Thread via GitHub
hello-stephen commented on PR #16633: URL: https://github.com/apache/doris/pull/16633#issuecomment-1426644521 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.44 seconds stream load tsv: 475 seconds loaded 74807831229 Bytes, about 150 MB/s

[GitHub] [doris] github-actions[bot] commented on pull request #16073: [feature](Load)Remove user/password in properties for mysql load to avoid double auth.

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16073: URL: https://github.com/apache/doris/pull/16073#issuecomment-1426641097 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16633: [Improvement](ES)Supprt datav2 and datetimev2 for es query

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16633: URL: https://github.com/apache/doris/pull/16633#issuecomment-1426639228 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16633: [Improvement](ES)Supprt datav2 and datetimev2 for es query

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16633: URL: https://github.com/apache/doris/pull/16633#issuecomment-1426638241 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] SaintBacchus opened a new pull request, #16633: [Improvement](ES)Supprt datav2 and datetimev2 for es query

2023-02-10 Thread via GitHub
SaintBacchus opened a new pull request, #16633: URL: https://github.com/apache/doris/pull/16633 # Proposed changes Issue Number: close #xxx ## Problem summary Now doris support query only date and datetime type for es query. Make it support the new datev2 and datetimev

[GitHub] [doris] github-actions[bot] commented on pull request #16632: [improve](dynamic-table) change `addColumns` RPC interface fields fro…

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16632: URL: https://github.com/apache/doris/pull/16632#issuecomment-1426637341 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16632: [improve](dynamic-table) change `addColumns` RPC interface fields fro…

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16632: URL: https://github.com/apache/doris/pull/16632#issuecomment-1426634382 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] eldenmoon opened a new pull request, #16632: [improve](dynamic-table) change `addColumns` RPC interface fields fro…

2023-02-10 Thread via GitHub
eldenmoon opened a new pull request, #16632: URL: https://github.com/apache/doris/pull/16632 …m `required` to `optional` and and config doc # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1.

svn commit: r60062 - /dev/doris/1.2.2-rc01/

2023-02-10 Thread morningman
Author: morningman Date: Sat Feb 11 05:56:51 2023 New Revision: 60062 Log: update doris 1.2.2 release, add arm fe be Added: dev/doris/1.2.2-rc01/apache-doris-be-1.2.2-bin-arm.tar.xz (with props) dev/doris/1.2.2-rc01/apache-doris-be-1.2.2-bin-arm.tar.xz.asc (with props) dev/doris/1

[doris] branch master updated: [Improvement](inverted index) inverted index query match bitmap cache (#16578)

2023-02-10 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new aba843bb2b [Improvement](inverted index) inve

[GitHub] [doris] morningman merged pull request #16578: [Improvement](inverted index) inverted index query match bitmap cache

2023-02-10 Thread via GitHub
morningman merged PR #16578: URL: https://github.com/apache/doris/pull/16578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[GitHub] [doris] morningman merged pull request #16335: [WIP](dynamic-table) support dynamic schema table

2023-02-10 Thread via GitHub
morningman merged PR #16335: URL: https://github.com/apache/doris/pull/16335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[GitHub] [doris] morningman closed issue #16351: [Feature] support dynami schema table

2023-02-10 Thread via GitHub
morningman closed issue #16351: [Feature] support dynami schema table URL: https://github.com/apache/doris/issues/16351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] morningman commented on a diff in pull request #16335: [WIP](dynamic-table) support dynamic schema table

2023-02-10 Thread via GitHub
morningman commented on code in PR #16335: URL: https://github.com/apache/doris/pull/16335#discussion_r1103531027 ## gensrc/thrift/FrontendService.thrift: ## @@ -716,6 +717,23 @@ struct TFetchSchemaTableDataResult { 2: optional list data_batch; } +// Only support base tabl

svn commit: r60061 - /dev/doris/1.2.2-rc01/

2023-02-10 Thread morningman
Author: morningman Date: Sat Feb 11 05:10:57 2023 New Revision: 60061 Log: add 1.2.2-rc01 release Added: dev/doris/1.2.2-rc01/ dev/doris/1.2.2-rc01/apache-doris-1.2.2-src.tar.gz (with props) dev/doris/1.2.2-rc01/apache-doris-1.2.2-src.tar.gz.asc (with props) dev/doris/1.2.2-rc

[GitHub] [doris] github-actions[bot] commented on pull request #16630: [feature](docker) Add Docker BE computer node Interface

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16630: URL: https://github.com/apache/doris/pull/16630#issuecomment-1426618411 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #16630: [feature](docker) Add Docker BE computer node Interface

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16630: URL: https://github.com/apache/doris/pull/16630#issuecomment-1426618394 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #16629: [fix](docker)Fix Docker init_be script

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16629: URL: https://github.com/apache/doris/pull/16629#issuecomment-1426618309 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #16629: [fix](docker)Fix Docker init_be script

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16629: URL: https://github.com/apache/doris/pull/16629#issuecomment-1426618305 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] FreeOnePlus opened a new issue, #16631: [Feature] docker-compose demo list

2023-02-10 Thread via GitHub
FreeOnePlus opened a new issue, #16631: URL: https://github.com/apache/doris/issues/16631 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description It is a great th

[GitHub] [doris] FreeOnePlus opened a new pull request, #16630: [feature](docker) Add Docker BE computer node Interface

2023-02-10 Thread via GitHub
FreeOnePlus opened a new pull request, #16630: URL: https://github.com/apache/doris/pull/16630 # Proposed changes The valid value of the NODE_ROLE interface is only 'computation'. When the input value is 'computation', the BE node is initialized as a Computer Node node. If the input

[GitHub] [doris] github-actions[bot] commented on pull request #16378: [Feature](Materialized-View) support multiple slot on one column in materialized view

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16378: URL: https://github.com/apache/doris/pull/16378#issuecomment-1426610506 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] FreeOnePlus opened a new pull request, #16629: [fix](docker)Fix Docker init_be script

2023-02-10 Thread via GitHub
FreeOnePlus opened a new pull request, #16629: URL: https://github.com/apache/doris/pull/16629 # Proposed changes docker_process_sql function have error output. ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original b

[GitHub] [doris] github-actions[bot] commented on pull request #16513: [UT-Fix](MTMV) Fix MTMV FE UT bugs

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16513: URL: https://github.com/apache/doris/pull/16513#issuecomment-1426586361 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[doris] branch master updated (b155fc07f6 -> e99202754e)

2023-02-10 Thread adonisling
This is an automated email from the ASF dual-hosted git repository. adonisling pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from b155fc07f6 [fix](fragment thread) fix thread in fragment thread pool hang (#16608) add e99202754e [UT-Fix](MT

[GitHub] [doris] adonis0147 merged pull request #16513: [UT-Fix](MTMV) Fix MTMV FE UT bugs

2023-02-10 Thread via GitHub
adonis0147 merged PR #16513: URL: https://github.com/apache/doris/pull/16513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[GitHub] [doris] yiguolei merged pull request #16608: [fix](fragment thread) fix thread in fragment thread pool hang

2023-02-10 Thread via GitHub
yiguolei merged PR #16608: URL: https://github.com/apache/doris/pull/16608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] branch master updated: [fix](fragment thread) fix thread in fragment thread pool hang (#16608)

2023-02-10 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new b155fc07f6 [fix](fragment thread) fix thread in

[doris] branch master updated: [improvement](batch size) pass batch size of exec engine to storage engine (#16614)

2023-02-10 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 171ae2892f [improvement](batch size) pass batch

[GitHub] [doris] yiguolei merged pull request #16614: [improvement](batch size) pass batch size of exec engine to storage engine

2023-02-10 Thread via GitHub
yiguolei merged PR #16614: URL: https://github.com/apache/doris/pull/16614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] hello-stephen commented on pull request #16583: [Feature](ES): Es support sort node pushdown limit and date type

2023-02-10 Thread via GitHub
hello-stephen commented on PR #16583: URL: https://github.com/apache/doris/pull/16583#issuecomment-1426347346 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.88 seconds stream load tsv: 478 seconds loaded 74807831229 Bytes, about 149 MB/s

[GitHub] [doris] hello-stephen commented on pull request #16621: [Enhancement](func)Introduce non_nullable extraction function.

2023-02-10 Thread via GitHub
hello-stephen commented on PR #16621: URL: https://github.com/apache/doris/pull/16621#issuecomment-1426246709 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.62 seconds stream load tsv: 470 seconds loaded 74807831229 Bytes, about 151 MB/s

[GitHub] [doris] hello-stephen commented on pull request #16615: [Feature-WIP](inverted index) step 1 for supporting range predicate pushing down to inverted index

2023-02-10 Thread via GitHub
hello-stephen commented on PR #16615: URL: https://github.com/apache/doris/pull/16615#issuecomment-1426203286 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.41 seconds stream load tsv: 472 seconds loaded 74807831229 Bytes, about 151 MB/s

[GitHub] [doris] hello-stephen commented on pull request #16613: [Feature](struct-type) Add implicitly cast for struct-type

2023-02-10 Thread via GitHub
hello-stephen commented on PR #16613: URL: https://github.com/apache/doris/pull/16613#issuecomment-1426133498 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.5 seconds stream load tsv: 487 seconds loaded 74807831229 Bytes, about 146 MB/s

[GitHub] [doris] hello-stephen commented on pull request #16607: [fix](engine_clone_task) disable compact when tablet version discontinuous to avoid engine clone task failure

2023-02-10 Thread via GitHub
hello-stephen commented on PR #16607: URL: https://github.com/apache/doris/pull/16607#issuecomment-1426066124 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.22 seconds stream load tsv: 478 seconds loaded 74807831229 Bytes, about 149 MB/s

[GitHub] [doris] xiaokang opened a new pull request, #16628: [doc](inverted index) inverted index introduction and usage doc

2023-02-10 Thread via GitHub
xiaokang opened a new pull request, #16628: URL: https://github.com/apache/doris/pull/16628 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Ye

[GitHub] [doris] morningman commented on pull request #16619: Revert "[Performance] Optimize performance of like expr using strstr()"

2023-02-10 Thread via GitHub
morningman commented on PR #16619: URL: https://github.com/apache/doris/pull/16619#issuecomment-1426026762 Do we have same issue on master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[doris] branch master updated: [Bug](point query) make get_rowset thread safe (#16609)

2023-02-10 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 8749aedbae [Bug](point query) make get_rowset t

[GitHub] [doris] yiguolei merged pull request #16609: [Bug](rowset) make `Tablet::get_rowset` thread safe

2023-02-10 Thread via GitHub
yiguolei merged PR #16609: URL: https://github.com/apache/doris/pull/16609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] annotated tag 1.2.2-rc01 updated (a3521b3667 -> 3adf6800c6)

2023-02-10 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to annotated tag 1.2.2-rc01 in repository https://gitbox.apache.org/repos/asf/doris.git *** WARNING: tag 1.2.2-rc01 was modified! *** from a3521b3667 (commit) to 3adf6800c6 (tag) tagging a3

[doris] branch branch-1.2-lts updated: [branch-1.2] pick build-for-release.sh from master

2023-02-10 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-1.2-lts by this push: new 2a8a38e101 [branch-1.2] pick

[GitHub] [doris] hello-stephen commented on pull request #16533: [Enhance](ComputeNode) ES Scan node support to be scheduled to compute node.

2023-02-10 Thread via GitHub
hello-stephen commented on PR #16533: URL: https://github.com/apache/doris/pull/16533#issuecomment-1425993574 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.92 seconds stream load tsv: 480 seconds loaded 74807831229 Bytes, about 148 MB/s

[GitHub] [doris] Tanya-W commented on a diff in pull request #16615: [Feature-WIP](inverted index) step 1 for supporting range predicate pushing down to inverted index

2023-02-10 Thread via GitHub
Tanya-W commented on code in PR #16615: URL: https://github.com/apache/doris/pull/16615#discussion_r1102904598 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -642,52 +641,133 @@ bool SegmentIterator::_is_handle_predicate_by_fulltext(ColumnPredicate* predicat

[GitHub] [doris] github-actions[bot] commented on pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1425984657 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[doris] branch branch-1.2-lts updated: [fix](merge-on-write) fix that the query result has duplicate keys when load with sequence column (#16587)

2023-02-10 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-1.2-lts by this push: new 2191fdcf84 [fix](merge-on-wri

[GitHub] [doris] hello-stephen commented on pull request #16605: [bugfix](column_reader) index_page should not be pre-decoded

2023-02-10 Thread via GitHub
hello-stephen commented on PR #16605: URL: https://github.com/apache/doris/pull/16605#issuecomment-1425900015 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.17 seconds stream load tsv: 465 seconds loaded 74807831229 Bytes, about 153 MB/s

[doris] branch master updated: [fix](merge-on-write) fix that the query result has duplicate keys when load with sequence column (#16587)

2023-02-10 Thread zhangchen
This is an automated email from the ASF dual-hosted git repository. zhangchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new c3110f8153 [fix](merge-on-write) fix that the

[GitHub] [doris] zhannngchen merged pull request #16587: [fix](merge-on-write) fix that the query result has duplicate keys when load with sequence column

2023-02-10 Thread via GitHub
zhannngchen merged PR #16587: URL: https://github.com/apache/doris/pull/16587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

[GitHub] [doris] Yukang-Lian commented on a diff in pull request #16617: ZhangShunjieNet interface

2023-02-10 Thread via GitHub
Yukang-Lian commented on code in PR #16617: URL: https://github.com/apache/doris/pull/16617#discussion_r1102817961 ## be/src/service/backend_options.cpp: ## @@ -101,6 +100,61 @@ bool BackendOptions::analyze_priority_cidrs() { return true; } + +//从network_interface中获取IP

[GitHub] [doris] ZashJie commented on issue #16627: [Enhancement] add a test case in all data model which get all types that doris supports

2023-02-10 Thread via GitHub
ZashJie commented on issue #16627: URL: https://github.com/apache/doris/issues/16627#issuecomment-1425872823 I want to participate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [doris] Yukang-Lian commented on a diff in pull request #16617: ZhangShunjieNet interface

2023-02-10 Thread via GitHub
Yukang-Lian commented on code in PR #16617: URL: https://github.com/apache/doris/pull/16617#discussion_r1102817723 ## be/src/service/backend_options.cpp: ## @@ -81,15 +84,11 @@ std::string BackendOptions::get_localhost() { return _s_localhost; } -bool BackendOptions::ana

[GitHub] [doris] github-actions[bot] commented on pull request #16609: [Bug](point query) make `Tablet::get_rowset` thread safe

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16609: URL: https://github.com/apache/doris/pull/16609#issuecomment-1425872549 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #16609: [Bug](point query) make `Tablet::get_rowset` thread safe

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16609: URL: https://github.com/apache/doris/pull/16609#issuecomment-1425872492 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] dataroaring opened a new issue, #16627: [Enhancement] add a test case in all data model which get all types that doris supports

2023-02-10 Thread via GitHub
dataroaring opened a new issue, #16627: URL: https://github.com/apache/doris/issues/16627 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description If a new data ty

[GitHub] [doris] github-actions[bot] commented on pull request #16564: [feature](merge-on-write) add DCHECK in compaction to detect duplicate key

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16564: URL: https://github.com/apache/doris/pull/16564#issuecomment-1425847296 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16564: [feature](merge-on-write) add CHECK in compaction to detect duplicate key

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16564: URL: https://github.com/apache/doris/pull/16564#issuecomment-1425844878 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] xy720 opened a new pull request, #16626: [fix](struct-type) forbid struct-type to be distributed key/aggregation key and add more tests

2023-02-10 Thread via GitHub
xy720 opened a new pull request, #16626: URL: https://github.com/apache/doris/pull/16626 # Proposed changes Issue Number: close #16547 ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [x] Ye

[GitHub] [doris] github-actions[bot] commented on pull request #16621: [Enhancement](func)Introduce non_nullable extraction function.

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16621: URL: https://github.com/apache/doris/pull/16621#issuecomment-1425820894 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16625: fix oss access issue with aws s3 sdk

2023-02-10 Thread via GitHub
github-actions[bot] commented on code in PR #16625: URL: https://github.com/apache/doris/pull/16625#discussion_r1102770191 ## be/src/io/s3_reader.cpp: ## @@ -45,6 +46,7 @@ S3Reader::S3Reader(const std::map& properties, const s _closed(false), _client(Clien

[GitHub] [doris] zclllyybb commented on a diff in pull request #16621: [Enhancement](func)Introduce non_nullable extraction function.

2023-02-10 Thread via GitHub
zclllyybb commented on code in PR #16621: URL: https://github.com/apache/doris/pull/16621#discussion_r1102770333 ## be/src/vec/functions/function_nonnullable.cpp: ## @@ -0,0 +1,76 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

[GitHub] [doris] github-actions[bot] commented on pull request #16625: fix oss access issue with aws s3 sdk

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16625: URL: https://github.com/apache/doris/pull/16625#issuecomment-1425813692 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4144330874";) output. shellcheck err

[GitHub] [doris] GoGoWen opened a new pull request, #16625: fix oss access issue with aws s3 sdk

2023-02-10 Thread via GitHub
GoGoWen opened a new pull request, #16625: URL: https://github.com/apache/doris/pull/16625 # Proposed changes when access oss with key contains char ($&,:@=`), the aws-sdk-cpp(version:1.9.211) will get "$&,:@=`" unescaped, so cause get none when the key contains special char like

[GitHub] [doris] HappenLee commented on a diff in pull request #16621: [Enhancement](func)Introduce non_nullable extraction function.

2023-02-10 Thread via GitHub
HappenLee commented on code in PR #16621: URL: https://github.com/apache/doris/pull/16621#discussion_r1102758942 ## gensrc/script/doris_builtins_functions.py: ## @@ -1526,6 +1525,24 @@ [['multi_match_any'], 'TINYINT', ['STRING', 'ARRAY_STRING'], 'ALWAYS_NOT_NULLABLE'],

[GitHub] [doris] github-actions[bot] commented on pull request #16624: [Opt](exec) remove unless null key when no split in convert key range

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16624: URL: https://github.com/apache/doris/pull/16624#issuecomment-1425806125 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] morrySnow commented on a diff in pull request #14397: [feature](nereids)support window function

2023-02-10 Thread via GitHub
morrySnow commented on code in PR #14397: URL: https://github.com/apache/doris/pull/14397#discussion_r1100123071 ## fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4: ## @@ -332,6 +337,33 @@ functionIdentifier | LEFT | RIGHT ; +windowSpec +// tod

[GitHub] [doris] github-actions[bot] commented on pull request #16569: [Optimization](index) Optimization for no need to read raw data for index column that only in where clause

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16569: URL: https://github.com/apache/doris/pull/16569#issuecomment-1425803102 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] HappenLee opened a new pull request, #16624: [Opt](exec) remove unless null key when no split in convert key range

2023-02-10 Thread via GitHub
HappenLee opened a new pull request, #16624: URL: https://github.com/apache/doris/pull/16624 # Proposed changes if key range no split,do not need add null value as a scan key in key range convert ## Problem summary Describe your changes. ## Checklist(Required)

[GitHub] [doris] github-actions[bot] commented on pull request #16578: [Improvement](inverted index) inverted index query match bitmap cache

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16578: URL: https://github.com/apache/doris/pull/16578#issuecomment-1425800543 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] Tanya-W commented on pull request #16578: [Improvement](inverted index) inverted index query match bitmap cache

2023-02-10 Thread via GitHub
Tanya-W commented on PR #16578: URL: https://github.com/apache/doris/pull/16578#issuecomment-1425797407 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [doris] zclllyybb commented on pull request #16621: [Enhancement](func)Introduce non_nullable extraction function.

2023-02-10 Thread via GitHub
zclllyybb commented on PR #16621: URL: https://github.com/apache/doris/pull/16621#issuecomment-1425788927 > please add some test case will do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [doris] github-actions[bot] commented on pull request #16569: [Optimization](index) Optimization for no need to read raw data for index column that only in where clause

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16569: URL: https://github.com/apache/doris/pull/16569#issuecomment-1425784649 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16569: [Optimization](index) Optimization for no need to read raw data for index column that only in where clause

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16569: URL: https://github.com/apache/doris/pull/16569#issuecomment-1425782664 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] Tanya-W commented on a diff in pull request #16569: [Optimization](index) Optimization for no need to read raw data for index column that only in where clause

2023-02-10 Thread via GitHub
Tanya-W commented on code in PR #16569: URL: https://github.com/apache/doris/pull/16569#discussion_r1102736060 ## be/src/olap/reader.h: ## @@ -102,6 +102,7 @@ class TabletReader { std::vector rs_readers; std::vector return_columns; +std::set output_co

[GitHub] [doris] Tanya-W commented on a diff in pull request #16569: [Optimization](index) Optimization for no need to read raw data for index column that only in where clause

2023-02-10 Thread via GitHub
Tanya-W commented on code in PR #16569: URL: https://github.com/apache/doris/pull/16569#discussion_r1102729986 ## fe/fe-core/src/main/java/org/apache/doris/planner/OriginalPlanner.java: ## @@ -436,6 +441,60 @@ private void pushSortToOlapScan() { } } +/** +

[GitHub] [doris] zhannngchen commented on pull request #16605: [bugfix](column_reader) index_page should not be pre-decoded

2023-02-10 Thread via GitHub
zhannngchen commented on PR #16605: URL: https://github.com/apache/doris/pull/16605#issuecomment-1425763979 Add a DCHECK for the type variable to make sure we used the right decoder? ``` if constexpr (USED_IN_DICT_ENCODING) { auto type = decode_fixed32_le((const uint8_t*

[GitHub] [doris] zhannngchen commented on pull request #16605: [bugfix](column_reader) index_page should not be pre-decoded

2023-02-10 Thread via GitHub
zhannngchen commented on PR #16605: URL: https://github.com/apache/doris/pull/16605#issuecomment-1425762899 Add a DCHECK for the type variable to make sure we used the right decoder? ``` if constexpr (USED_IN_DICT_ENCODING) { auto type = decode_fixed32_le((const uint8_t*

[GitHub] [doris] yiguolei commented on pull request #16594: [fix](bthread) fix bthread hang

2023-02-10 Thread via GitHub
yiguolei commented on PR #16594: URL: https://github.com/apache/doris/pull/16594#issuecomment-1425761974 Please not merge this PR to master branch. Could merge it to 1.1.6 and 1.2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [doris] yiguolei commented on a diff in pull request #16594: [fix](bthread) fix bthread hang

2023-02-10 Thread via GitHub
yiguolei commented on code in PR #16594: URL: https://github.com/apache/doris/pull/16594#discussion_r1102727049 ## be/src/vec/sink/vtablet_sink.cpp: ## @@ -688,8 +688,9 @@ Status VNodeChannel::close_wait(RuntimeState* state) { } // waiting for finished, it may take a

[doris] branch master updated (75847f7f6a -> e6abfed6d1)

2023-02-10 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 75847f7f6a [bugfix](exchange node) should not depend on eos to judge the ending of stream receiver (#16600) a

[GitHub] [doris] morningman merged pull request #16573: [fix](dlf) Support DLF by catalog properties and update the doc

2023-02-10 Thread via GitHub
morningman merged PR #16573: URL: https://github.com/apache/doris/pull/16573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[GitHub] [doris] isHuangXin commented on issue #16623: [Bug] Cancel Schema change job is useless in BE

2023-02-10 Thread via GitHub
isHuangXin commented on issue #16623: URL: https://github.com/apache/doris/issues/16623#issuecomment-1425759089 plz assign it to me~ I will have a try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [doris] github-actions[bot] commented on pull request #16621: [Enhancement](func)Introduce non_nullable extraction function.

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16621: URL: https://github.com/apache/doris/pull/16621#issuecomment-1425758627 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] zclllyybb commented on a diff in pull request #16621: [Enhancement](func)Introduce non_nullable extraction function.

2023-02-10 Thread via GitHub
zclllyybb commented on code in PR #16621: URL: https://github.com/apache/doris/pull/16621#discussion_r1102722255 ## be/src/vec/functions/function_nonnullable.cpp: ## @@ -0,0 +1,75 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

[GitHub] [doris] Lchangliang commented on issue #16623: [Bug] Cancel Schema change job is useless in BE

2023-02-10 Thread via GitHub
Lchangliang commented on issue #16623: URL: https://github.com/apache/doris/issues/16623#issuecomment-1425755540 CANCEL ALTER TABLE COLUMN FROM tbl_name; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [doris] Lchangliang commented on issue #16623: [Bug] Cancel Schema change job is useless in BE

2023-02-10 Thread via GitHub
Lchangliang commented on issue #16623: URL: https://github.com/apache/doris/issues/16623#issuecomment-1425755136 https://doris.apache.org/zh-CN/docs/dev/sql-manual/sql-reference/Data-Definition-Statements/Alter/ALTER-TABLE-BITMAP -- This is an automated message from the Apache Git Service

[GitHub] [doris] github-actions[bot] commented on pull request #16614: [improvement](batch size) pass batch size of exec engine to storage engine

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16614: URL: https://github.com/apache/doris/pull/16614#issuecomment-1425754450 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #16614: [improvement](batch size) pass batch size of exec engine to storage engine

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16614: URL: https://github.com/apache/doris/pull/16614#issuecomment-1425754403 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] Lchangliang commented on issue #16623: [Bug] Cancel Schema change job is useless in BE

2023-02-10 Thread via GitHub
Lchangliang commented on issue #16623: URL: https://github.com/apache/doris/issues/16623#issuecomment-1425752183 I think we can use the ssb case generated by tools dir (tools/ssb-tools). Generate 100 gigabytes of data for the table lineorder and choose two columns to simulate the problem.

[GitHub] [doris] yiguolei merged pull request #16600: [bugfix](exchange node) should not depend on eos to judge the ending of stream receiver

2023-02-10 Thread via GitHub
yiguolei merged PR #16600: URL: https://github.com/apache/doris/pull/16600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] yiguolei merged pull request #16595: [fix](auth)(meta) fix auto info missing when upgrading from 1.1 to 1.2

2023-02-10 Thread via GitHub
yiguolei merged PR #16595: URL: https://github.com/apache/doris/pull/16595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] BiteTheDDDDt commented on pull request #16621: [Enhancement](func)Introduce non_nullable extraction function.

2023-02-10 Thread via GitHub
BiteThet commented on PR #16621: URL: https://github.com/apache/doris/pull/16621#issuecomment-1425750929 please add some test case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #16621: [Enhancement](func)Introduce non_nullable extraction function.

2023-02-10 Thread via GitHub
BiteThet commented on code in PR #16621: URL: https://github.com/apache/doris/pull/16621#discussion_r1102715006 ## be/src/vec/functions/function_nonnullable.cpp: ## @@ -0,0 +1,75 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licens

[GitHub] [doris] github-actions[bot] commented on pull request #16378: [Feature](Materialized-View) support multiple slot on one column in materialized view

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16378: URL: https://github.com/apache/doris/pull/16378#issuecomment-1425749557 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] isHuangXin commented on issue #16623: [Bug] Cancel Schema change job is useless in BE

2023-02-10 Thread via GitHub
isHuangXin commented on issue #16623: URL: https://github.com/apache/doris/issues/16623#issuecomment-1425747154 Can you give a more detailed test case? For example, create a table, create a bitmap index for column A, and the SQL script to cancel the bitmap index. -- This is an automat

[GitHub] [doris] morningman merged pull request #16527: [Fix](Jdbc Catalog) jdbc catalog support to connect to doris database

2023-02-10 Thread via GitHub
morningman merged PR #16527: URL: https://github.com/apache/doris/pull/16527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[GitHub] [doris] Lchangliang opened a new issue, #16623: [Bug] Cancel Schema change job is useless in BE

2023-02-10 Thread via GitHub
Lchangliang opened a new issue, #16623: URL: https://github.com/apache/doris/issues/16623 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version 1.2 or master also

[GitHub] [doris] github-actions[bot] commented on pull request #16621: [Enhancement](func)Introduce non_nullable extraction function.

2023-02-10 Thread via GitHub
github-actions[bot] commented on PR #16621: URL: https://github.com/apache/doris/pull/16621#issuecomment-1425736943 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

  1   2   3   >