morningman closed pull request #9760: [refactor] remove unused code in
DeltaWriter
URL: https://github.com/apache/incubator-doris/pull/9760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
zy-kkk opened a new issue, #9766:
URL: https://github.com/apache/incubator-doris/issues/9766
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and
found no similar issues.
### Version
commit
smallhibiscus opened a new pull request, #9765:
URL: https://github.com/apache/incubator-doris/pull/9765
…ccurs in fe.
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Add jvm parameters and the process will automatically stop when oom occurs
in fe.
morrySnow commented on PR #9764:
URL: https://github.com/apache/incubator-doris/pull/9764#issuecomment-1136772363
just like step 1 #9460 , all fe check style error is not related to the
rules this patch care about
--
This is an automated message from the Apache Git Service.
To respond to
morrySnow opened a new pull request, #9764:
URL: https://github.com/apache/incubator-doris/pull/9764
change below rules' severity to error and fix original code error:
- EmptyBlock
- EmptyCatchBlock
- LeftCurly
- RightCurly
- IllegalTokenText
- MultipleVariableDeclaratio
gtchaos commented on code in PR #9579:
URL: https://github.com/apache/incubator-doris/pull/9579#discussion_r881245759
##
docs/zh-CN/sql-manual/sql-reference/Data-Manipulation-Statements/OUTFILE.md:
##
@@ -75,10 +75,20 @@ INTO OUTFILE "file_path"
broker.kerberos_principa
yangzhg opened a new pull request, #9763:
URL: https://github.com/apache/incubator-doris/pull/9763
# Proposed changes
fix security issue of fast json
https://github.com/alibaba/fastjson/wiki/security_update_20220523
## Problem Summary:
Describe the overview of changes.
morningman commented on code in PR #9579:
URL: https://github.com/apache/incubator-doris/pull/9579#discussion_r881185498
##
fe/fe-core/src/main/java/org/apache/doris/analysis/OutFileClause.java:
##
@@ -430,9 +432,13 @@ private void analyzeBrokerDesc(Set
processedPropKeys) throw
stalary commented on PR #9694:
URL: https://github.com/apache/incubator-doris/pull/9694#issuecomment-1136675730
> @morningman @stalary i have rebased master and solved the BE format check
error, please review
Please fix the checkstyle problem.
https://github.com/apache/incubator-d
nextdreamblue commented on PR #9694:
URL: https://github.com/apache/incubator-doris/pull/9694#issuecomment-113311
@morningman @stalary hava rebase master and solve the BE format check error,
please review
--
This is an automated message from the Apache Git Service.
To respond to the m
jackwener commented on issue #9759:
URL:
https://github.com/apache/incubator-doris/issues/9759#issuecomment-1136634204
> @jackwener currently, there are many Status(substitute (x)) calls in
BE, it is very ugly. we are try to remove them. #9533. Maybe we could replace
other substitute o
github-actions[bot] commented on PR #9492:
URL: https://github.com/apache/incubator-doris/pull/9492#issuecomment-1136620777
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
github-actions[bot] commented on PR #9492:
URL: https://github.com/apache/incubator-doris/pull/9492#issuecomment-1136620761
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
liaoxin01 commented on code in PR #9582:
URL: https://github.com/apache/incubator-doris/pull/9582#discussion_r881123403
##
be/src/vec/functions/function_binary_arithmetic.h:
##
@@ -449,6 +469,18 @@ struct DecimalBinaryOperation {
private:
/// there's implicit type converti
liaoxin01 commented on code in PR #9582:
URL: https://github.com/apache/incubator-doris/pull/9582#discussion_r881118810
##
be/src/vec/data_types/data_type_factory.cpp:
##
@@ -26,13 +26,75 @@ namespace doris::vectorized {
DataTypePtr DataTypeFactory::create_data_type(const dor
liaoxin01 commented on code in PR #9582:
URL: https://github.com/apache/incubator-doris/pull/9582#discussion_r881117053
##
be/src/vec/columns/column_decimal.cpp:
##
@@ -130,6 +131,38 @@ void ColumnDecimal::insert_data(const char* src, size_t
/*length*/) {
data.emplace_back
liaoxin01 commented on code in PR #9582:
URL: https://github.com/apache/incubator-doris/pull/9582#discussion_r881113467
##
be/src/vec/columns/column_decimal.cpp:
##
@@ -130,6 +131,38 @@ void ColumnDecimal::insert_data(const char* src, size_t
/*length*/) {
data.emplace_back
mrhhsg commented on code in PR #9663:
URL: https://github.com/apache/incubator-doris/pull/9663#discussion_r881109495
##
be/src/vec/common/hash_table/hash_table_key_holder.h:
##
@@ -120,7 +120,7 @@ namespace doris::vectorized {
*/
struct SerializedKeyHolder {
StringRef k
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new ca05d1ee01 [fix](memory tracker) Fi
morningman closed issue #9540: [Bug] DCHECK failed caused by tls_ctx()->type()
== ThreadContext::TaskType::UNKNOWN
URL: https://github.com/apache/incubator-doris/issues/9540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
morningman merged PR #9661:
URL: https://github.com/apache/incubator-doris/pull/9661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...
yiguolei commented on issue #9759:
URL:
https://github.com/apache/incubator-doris/issues/9759#issuecomment-1136539560
@jackwener currently, there are many Status(substitute (x)) calls in
BE, it is very ugly. we are try to remove them.
https://github.com/apache/incubator-doris/pull/
yiguolei commented on code in PR #9754:
URL: https://github.com/apache/incubator-doris/pull/9754#discussion_r881062640
##
fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java:
##
@@ -61,10 +61,19 @@ public class ColumnDef {
public static class DefaultValue {
yiguolei commented on code in PR #9754:
URL: https://github.com/apache/incubator-doris/pull/9754#discussion_r881062640
##
fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java:
##
@@ -61,10 +61,19 @@ public class ColumnDef {
public static class DefaultValue {
yiguolei commented on code in PR #9754:
URL: https://github.com/apache/incubator-doris/pull/9754#discussion_r881062007
##
fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java:
##
@@ -61,10 +61,19 @@ public class ColumnDef {
public static class DefaultValue {
yiguolei commented on code in PR #9663:
URL: https://github.com/apache/incubator-doris/pull/9663#discussion_r881047186
##
be/src/vec/common/hash_table/hash_table_key_holder.h:
##
@@ -120,7 +120,7 @@ namespace doris::vectorized {
*/
struct SerializedKeyHolder {
StringRef
withium opened a new issue, #9762:
URL: https://github.com/apache/incubator-doris/issues/9762
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and
found no similar issues.
### Version
0.15
morningman opened a new pull request, #9761:
URL: https://github.com/apache/incubator-doris/pull/9761
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
This bug is introduced from #9306, that user need to execute
"help stream-load" to show the help doc.
morningman opened a new pull request, #9760:
URL: https://github.com/apache/incubator-doris/pull/9760
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original beha
jackwener opened a new issue, #9759:
URL: https://github.com/apache/incubator-doris/issues/9759
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and
found no similar issues.
### Description
github-actions[bot] commented on PR #9459:
URL: https://github.com/apache/incubator-doris/pull/9459#issuecomment-1136060229
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
morningman commented on code in PR #9582:
URL: https://github.com/apache/incubator-doris/pull/9582#discussion_r880616200
##
be/src/vec/functions/function_binary_arithmetic.h:
##
@@ -527,6 +563,31 @@ struct DecimalBinaryOperation {
return apply(a, b, is_null);
github-actions[bot] commented on PR #9756:
URL: https://github.com/apache/incubator-doris/pull/9756#issuecomment-1135999456
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
xiaokang commented on code in PR #9747:
URL: https://github.com/apache/incubator-doris/pull/9747#discussion_r880562308
##
be/src/util/block_compression.cpp:
##
@@ -22,6 +22,8 @@
#include
#include
#include
+#include
Review Comment:
It will be better to add some doc for
Gabriel39 commented on PR #9758:
URL: https://github.com/apache/incubator-doris/pull/9758#issuecomment-1135971891
This job is still WIP. This PR support DateV2 for BE. DateTimeV2 depends on
DecimalV3 (WIP) so is not included now. Besides, this PR only refactored
execution layer and I will r
spaces-X commented on code in PR #9459:
URL: https://github.com/apache/incubator-doris/pull/9459#discussion_r880541569
##
be/src/common/config.h:
##
@@ -464,6 +464,8 @@ CONF_Int32(memory_max_alignment, "16");
// write buffer size before flush
CONF_mInt64(write_buffer_size, "20
Gabriel39 opened a new pull request, #9758:
URL: https://github.com/apache/incubator-doris/pull/9758
# Proposed changes
Issue Number: #9575
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior:
github-actions[bot] commented on PR #9661:
URL: https://github.com/apache/incubator-doris/pull/9661#issuecomment-1135940018
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
github-actions[bot] commented on PR #9661:
URL: https://github.com/apache/incubator-doris/pull/9661#issuecomment-1135940064
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
dataalive commented on code in PR #9753:
URL: https://github.com/apache/incubator-doris/pull/9753#discussion_r880515874
##
docs/zh-CN/advanced/join-optimization/doris-join-optimization.md:
##
@@ -0,0 +1,226 @@
+---
+{
+"title": "Doris Join 优化原理",
+"language": "zh-CN"
+}
dataalive commented on code in PR #9753:
URL: https://github.com/apache/incubator-doris/pull/9753#discussion_r880514364
##
docs/zh-CN/advanced/join-optimization/doris-join-optimization.md:
##
@@ -0,0 +1,226 @@
+---
+{
+"title": "Doris Join 优化原理",
+"language": "zh-CN"
+}
dataalive commented on code in PR #9753:
URL: https://github.com/apache/incubator-doris/pull/9753#discussion_r880512484
##
docs/en/advanced/join-optimization/doris-join-optimization.md:
##
@@ -0,0 +1,222 @@
+---
+{
+"title": "Doris Join optimization principle",
+"languag
dataalive commented on code in PR #9753:
URL: https://github.com/apache/incubator-doris/pull/9753#discussion_r880512484
##
docs/en/advanced/join-optimization/doris-join-optimization.md:
##
@@ -0,0 +1,222 @@
+---
+{
+"title": "Doris Join optimization principle",
+"languag
github-actions[bot] commented on PR #9756:
URL: https://github.com/apache/incubator-doris/pull/9756#issuecomment-1135929490
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
EmmyMiao87 opened a new issue, #9757:
URL: https://github.com/apache/incubator-doris/issues/9757
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and
found no similar issues.
### Description
EmmyMiao87 closed issue #9623: [Enhancement](Nereids)refactor plan node into
plan + operator
URL: https://github.com/apache/incubator-doris/issues/9623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
EmmyMiao87 merged PR #9755:
URL: https://github.com/apache/incubator-doris/pull/9755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...
This is an automated email from the ASF dual-hosted git repository.
lingmiao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new cc9321a09b [Enhancement](Nereids)refa
jackwener commented on code in PR #8861:
URL: https://github.com/apache/incubator-doris/pull/8861#discussion_r880414867
##
fe/fe-core/src/main/java/org/apache/doris/statistics/PartitionStats.java:
##
@@ -0,0 +1,129 @@
+// Licensed to the Apache Software Foundation (ASF) under on
EmmyMiao87 commented on code in PR #9739:
URL: https://github.com/apache/incubator-doris/pull/9739#discussion_r880413840
##
fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java:
##
@@ -302,6 +302,7 @@ public boolean isAnalyzed() {
return isAnalyzed;
}
+
EmmyMiao87 commented on code in PR #9739:
URL: https://github.com/apache/incubator-doris/pull/9739#discussion_r880410227
##
fe/fe-core/src/main/java/org/apache/doris/rewrite/RewriteInPredicateRule.java:
##
@@ -0,0 +1,113 @@
+// Licensed to the Apache Software Foundation (ASF) un
github-actions[bot] commented on PR #9743:
URL: https://github.com/apache/incubator-doris/pull/9743#issuecomment-1135807590
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
EmmyMiao87 commented on code in PR #9739:
URL: https://github.com/apache/incubator-doris/pull/9739#discussion_r880377435
##
fe/fe-core/src/main/java/org/apache/doris/rewrite/RewriteInPredicateRule.java:
##
@@ -0,0 +1,113 @@
+// Licensed to the Apache Software Foundation (ASF) un
yangzhg commented on code in PR #9541:
URL: https://github.com/apache/incubator-doris/pull/9541#discussion_r880373945
##
thirdparty/build-thirdparty.sh:
##
@@ -643,12 +643,13 @@ build_arrow() {
export ARROW_SNAPPY_URL=${TP_SOURCE_DIR}/${SNAPPY_NAME}
export ARROW_ZLIB_U
github-actions[bot] commented on PR #9466:
URL: https://github.com/apache/incubator-doris/pull/9466#issuecomment-1135750458
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
github-actions[bot] commented on PR #9466:
URL: https://github.com/apache/incubator-doris/pull/9466#issuecomment-1135750384
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
platoneko closed pull request #9139: [refactor-wip] Add FileSystem, ReadStream,
WriteStream
URL: https://github.com/apache/incubator-doris/pull/9139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Lchangliang commented on code in PR #8923:
URL: https://github.com/apache/incubator-doris/pull/8923#discussion_r880313916
##
be/src/olap/tablet_meta.cpp:
##
@@ -90,8 +91,34 @@ TabletMeta::TabletMeta(int64_t table_id, int64_t
partition_id, int64_t tablet_id
LOG(WARNING)
smallhibiscus opened a new pull request, #9756:
URL: https://github.com/apache/incubator-doris/pull/9756
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Fix the format error of en doc.
## Checklist(Required)
1. Does it affect the original beh
924060929 opened a new pull request, #9755:
URL: https://github.com/apache/incubator-doris/pull/9755
# Proposed changes
Issue Number: close #9623
## Problem Summary:
refactor plan node into expression + operator.
## Checklist(Required)
1. Does it affect the
dujl commented on code in PR #9559:
URL: https://github.com/apache/incubator-doris/pull/9559#discussion_r880271438
##
fe/fe-core/src/test/java/org/apache/doris/analysis/CreateTableStmtTest.java:
##
@@ -274,4 +274,21 @@ public void testCreateIcebergTable() throws UserException {
BePPPower commented on PR #9754:
URL: https://github.com/apache/incubator-doris/pull/9754#issuecomment-1135609501
There is still a problem: when we set default CURRENT_TIMESTAMP for
varchar/char column type, it also will success.
--
This is an automated message from the Apache Git
BePPPower opened a new pull request, #9754:
URL: https://github.com/apache/incubator-doris/pull/9754
…CURRENT_TIMESTAMP
# Proposed changes
Issue Number: close #9570
## Problem Summary:
An auto-initialized column is set to the current timestamp for inserted rows
t
hf200012 opened a new pull request, #9753:
URL: https://github.com/apache/incubator-doris/pull/9753
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavi
SaintBacchus commented on PR #9608:
URL: https://github.com/apache/incubator-doris/pull/9608#issuecomment-1135572749
Will this feature collect the plan frament execution metrics as the sql
profile?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
SaintBacchus commented on PR #9725:
URL: https://github.com/apache/incubator-doris/pull/9725#issuecomment-1135530818
OK, I revert the last commit and do the performence improve in the later
worker.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
stalary commented on PR #9725:
URL: https://github.com/apache/incubator-doris/pull/9725#issuecomment-1135515892
> @stalary In the lastest commit I separate the interface
`getProfile(queryId)` into two parts of `getProfileContent` and
`getProfileBuilder`. Since if we want to store the record
stalary commented on PR #9725:
URL: https://github.com/apache/incubator-doris/pull/9725#issuecomment-1135515003
I think it's ok to return enough data at the bottom level for the top level
to choose. This will be easier to extend later when we support more storage
methods.
--
This is an a
SaintBacchus commented on PR #9725:
URL: https://github.com/apache/incubator-doris/pull/9725#issuecomment-1135500847
@stalary In the lastest commit I separate the interface
`getProfile(queryId)` into two parts of `getProfileContent` and
`getProfileBuilder`.
Since if we want to store th
69 matches
Mail list logo