[GitHub] [incubator-doris] morningman closed pull request #9760: [refactor] remove unused code in DeltaWriter

2022-05-24 Thread GitBox
morningman closed pull request #9760: [refactor] remove unused code in DeltaWriter URL: https://github.com/apache/incubator-doris/pull/9760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [incubator-doris] zy-kkk opened a new issue, #9766: [Bug] vectorized compaction

2022-05-24 Thread GitBox
zy-kkk opened a new issue, #9766: URL: https://github.com/apache/incubator-doris/issues/9766 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version commit

[GitHub] [incubator-doris] smallhibiscus opened a new pull request, #9765: [improvement] Add jvm parameters and the process will automatically stop when oom o…

2022-05-24 Thread GitBox
smallhibiscus opened a new pull request, #9765: URL: https://github.com/apache/incubator-doris/pull/9765 …ccurs in fe. # Proposed changes Issue Number: close #xxx ## Problem Summary: Add jvm parameters and the process will automatically stop when oom occurs in fe.

[GitHub] [incubator-doris] morrySnow commented on pull request #9764: [style] (fe) wrap and whitespace rules

2022-05-24 Thread GitBox
morrySnow commented on PR #9764: URL: https://github.com/apache/incubator-doris/pull/9764#issuecomment-1136772363 just like step 1 #9460 , all fe check style error is not related to the rules this patch care about -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-doris] morrySnow opened a new pull request, #9764: [style] (fe) wrap and whitespace rules

2022-05-24 Thread GitBox
morrySnow opened a new pull request, #9764: URL: https://github.com/apache/incubator-doris/pull/9764 change below rules' severity to error and fix original code error: - EmptyBlock - EmptyCatchBlock - LeftCurly - RightCurly - IllegalTokenText - MultipleVariableDeclaratio

[GitHub] [incubator-doris] gtchaos commented on a diff in pull request #9579: [Feature] Support read hive external table and outfile into HDFS that authenticated by kerberos

2022-05-24 Thread GitBox
gtchaos commented on code in PR #9579: URL: https://github.com/apache/incubator-doris/pull/9579#discussion_r881245759 ## docs/zh-CN/sql-manual/sql-reference/Data-Manipulation-Statements/OUTFILE.md: ## @@ -75,10 +75,20 @@ INTO OUTFILE "file_path" broker.kerberos_principa

[GitHub] [incubator-doris] yangzhg opened a new pull request, #9763: [security] update canal version to fix fastjson security issue

2022-05-24 Thread GitBox
yangzhg opened a new pull request, #9763: URL: https://github.com/apache/incubator-doris/pull/9763 # Proposed changes fix security issue of fast json https://github.com/alibaba/fastjson/wiki/security_update_20220523 ## Problem Summary: Describe the overview of changes.

[GitHub] [incubator-doris] morningman commented on a diff in pull request #9579: [Feature] Support read hive external table and outfile into HDFS that authenticated by kerberos

2022-05-24 Thread GitBox
morningman commented on code in PR #9579: URL: https://github.com/apache/incubator-doris/pull/9579#discussion_r881185498 ## fe/fe-core/src/main/java/org/apache/doris/analysis/OutFileClause.java: ## @@ -430,9 +432,13 @@ private void analyzeBrokerDesc(Set processedPropKeys) throw

[GitHub] [incubator-doris] stalary commented on pull request #9694: [Bug] Fix create table like when having hidden columns

2022-05-24 Thread GitBox
stalary commented on PR #9694: URL: https://github.com/apache/incubator-doris/pull/9694#issuecomment-1136675730 > @morningman @stalary i have rebased master and solved the BE format check error, please review Please fix the checkstyle problem. https://github.com/apache/incubator-d

[GitHub] [incubator-doris] nextdreamblue commented on pull request #9694: [Bug] Fix create table like when having hidden columns

2022-05-24 Thread GitBox
nextdreamblue commented on PR #9694: URL: https://github.com/apache/incubator-doris/pull/9694#issuecomment-113311 @morningman @stalary hava rebase master and solve the BE format check error, please review -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-doris] jackwener commented on issue #9759: [Enhancement] Replace `Substitute` `stringstream` with `fmt/format`

2022-05-24 Thread GitBox
jackwener commented on issue #9759: URL: https://github.com/apache/incubator-doris/issues/9759#issuecomment-1136634204 > @jackwener currently, there are many Status(substitute (x)) calls in BE, it is very ugly. we are try to remove them. #9533. Maybe we could replace other substitute o

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9492: [fix](resource-tag) Consider resource tags when assigning tasks for broker & routine load

2022-05-24 Thread GitBox
github-actions[bot] commented on PR #9492: URL: https://github.com/apache/incubator-doris/pull/9492#issuecomment-1136620777 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9492: [fix](resource-tag) Consider resource tags when assigning tasks for broker & routine load

2022-05-24 Thread GitBox
github-actions[bot] commented on PR #9492: URL: https://github.com/apache/incubator-doris/pull/9492#issuecomment-1136620761 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] liaoxin01 commented on a diff in pull request #9582: [refactor](decimalv3) optimize decimal performance and precision

2022-05-24 Thread GitBox
liaoxin01 commented on code in PR #9582: URL: https://github.com/apache/incubator-doris/pull/9582#discussion_r881123403 ## be/src/vec/functions/function_binary_arithmetic.h: ## @@ -449,6 +469,18 @@ struct DecimalBinaryOperation { private: /// there's implicit type converti

[GitHub] [incubator-doris] liaoxin01 commented on a diff in pull request #9582: [refactor](decimalv3) optimize decimal performance and precision

2022-05-24 Thread GitBox
liaoxin01 commented on code in PR #9582: URL: https://github.com/apache/incubator-doris/pull/9582#discussion_r881118810 ## be/src/vec/data_types/data_type_factory.cpp: ## @@ -26,13 +26,75 @@ namespace doris::vectorized { DataTypePtr DataTypeFactory::create_data_type(const dor

[GitHub] [incubator-doris] liaoxin01 commented on a diff in pull request #9582: [refactor](decimalv3) optimize decimal performance and precision

2022-05-24 Thread GitBox
liaoxin01 commented on code in PR #9582: URL: https://github.com/apache/incubator-doris/pull/9582#discussion_r881117053 ## be/src/vec/columns/column_decimal.cpp: ## @@ -130,6 +131,38 @@ void ColumnDecimal::insert_data(const char* src, size_t /*length*/) { data.emplace_back

[GitHub] [incubator-doris] liaoxin01 commented on a diff in pull request #9582: [refactor](decimalv3) optimize decimal performance and precision

2022-05-24 Thread GitBox
liaoxin01 commented on code in PR #9582: URL: https://github.com/apache/incubator-doris/pull/9582#discussion_r881113467 ## be/src/vec/columns/column_decimal.cpp: ## @@ -130,6 +131,38 @@ void ColumnDecimal::insert_data(const char* src, size_t /*length*/) { data.emplace_back

[GitHub] [incubator-doris] mrhhsg commented on a diff in pull request #9663: [Enhancement]Add prefetch in join node

2022-05-24 Thread GitBox
mrhhsg commented on code in PR #9663: URL: https://github.com/apache/incubator-doris/pull/9663#discussion_r881109495 ## be/src/vec/common/hash_table/hash_table_key_holder.h: ## @@ -120,7 +120,7 @@ namespace doris::vectorized { */ struct SerializedKeyHolder { StringRef k

[incubator-doris] branch master updated: [fix](memory tracker) Fix lru cache, compaction tracker, add USE_MEM_TRACKER compile (#9661)

2022-05-24 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new ca05d1ee01 [fix](memory tracker) Fi

[GitHub] [incubator-doris] morningman closed issue #9540: [Bug] DCHECK failed caused by tls_ctx()->type() == ThreadContext::TaskType::UNKNOWN

2022-05-24 Thread GitBox
morningman closed issue #9540: [Bug] DCHECK failed caused by tls_ctx()->type() == ThreadContext::TaskType::UNKNOWN URL: https://github.com/apache/incubator-doris/issues/9540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-doris] morningman merged pull request #9661: [fix][memory tracker] Fix lru cache, compaction tracker, add USE_MEM_TRACKER compile

2022-05-24 Thread GitBox
morningman merged PR #9661: URL: https://github.com/apache/incubator-doris/pull/9661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [incubator-doris] yiguolei commented on issue #9759: [Enhancement] Replace `Substitute` `stringstream` with `fmt/format`

2022-05-24 Thread GitBox
yiguolei commented on issue #9759: URL: https://github.com/apache/incubator-doris/issues/9759#issuecomment-1136539560 @jackwener currently, there are many Status(substitute (x)) calls in BE, it is very ugly. we are try to remove them. https://github.com/apache/incubator-doris/pull/

[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9754: [feature] datetime column type support auto-initialized with default …

2022-05-24 Thread GitBox
yiguolei commented on code in PR #9754: URL: https://github.com/apache/incubator-doris/pull/9754#discussion_r881062640 ## fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java: ## @@ -61,10 +61,19 @@ public class ColumnDef { public static class DefaultValue {

[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9754: [feature] datetime column type support auto-initialized with default …

2022-05-24 Thread GitBox
yiguolei commented on code in PR #9754: URL: https://github.com/apache/incubator-doris/pull/9754#discussion_r881062640 ## fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java: ## @@ -61,10 +61,19 @@ public class ColumnDef { public static class DefaultValue {

[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9754: [feature] datetime column type support auto-initialized with default …

2022-05-24 Thread GitBox
yiguolei commented on code in PR #9754: URL: https://github.com/apache/incubator-doris/pull/9754#discussion_r881062007 ## fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java: ## @@ -61,10 +61,19 @@ public class ColumnDef { public static class DefaultValue {

[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9663: [Enhancement]Add prefetch in join node

2022-05-24 Thread GitBox
yiguolei commented on code in PR #9663: URL: https://github.com/apache/incubator-doris/pull/9663#discussion_r881047186 ## be/src/vec/common/hash_table/hash_table_key_holder.h: ## @@ -120,7 +120,7 @@ namespace doris::vectorized { */ struct SerializedKeyHolder { StringRef

[GitHub] [incubator-doris] withium opened a new issue, #9762: [Bug] Transaction blocked with committed state

2022-05-24 Thread GitBox
withium opened a new issue, #9762: URL: https://github.com/apache/incubator-doris/issues/9762 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version 0.15

[GitHub] [incubator-doris] morningman opened a new pull request, #9761: [fix](help) fix bug of help command

2022-05-24 Thread GitBox
morningman opened a new pull request, #9761: URL: https://github.com/apache/incubator-doris/pull/9761 # Proposed changes Issue Number: close #xxx ## Problem Summary: This bug is introduced from #9306, that user need to execute "help stream-load" to show the help doc.

[GitHub] [incubator-doris] morningman opened a new pull request, #9760: [refactor] remove unused code in DeltaWriter

2022-05-24 Thread GitBox
morningman opened a new pull request, #9760: URL: https://github.com/apache/incubator-doris/pull/9760 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original beha

[GitHub] [incubator-doris] jackwener opened a new issue, #9759: [Enhancement] Replace `Substitute` `stringstream` with `fmt/format`

2022-05-24 Thread GitBox
jackwener opened a new issue, #9759: URL: https://github.com/apache/incubator-doris/issues/9759 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9459: [stream-load-vec]: memtable flush only if necessary after aggregated

2022-05-24 Thread GitBox
github-actions[bot] commented on PR #9459: URL: https://github.com/apache/incubator-doris/pull/9459#issuecomment-1136060229 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] morningman commented on a diff in pull request #9582: [refactor](decimalv3) optimize decimal performance and precision

2022-05-24 Thread GitBox
morningman commented on code in PR #9582: URL: https://github.com/apache/incubator-doris/pull/9582#discussion_r880616200 ## be/src/vec/functions/function_binary_arithmetic.h: ## @@ -527,6 +563,31 @@ struct DecimalBinaryOperation { return apply(a, b, is_null);

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9756: [Refactor][doc]Fix formatting issues in English documents.

2022-05-24 Thread GitBox
github-actions[bot] commented on PR #9756: URL: https://github.com/apache/incubator-doris/pull/9756#issuecomment-1135999456 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] xiaokang commented on a diff in pull request #9747: add zstd compression codec

2022-05-24 Thread GitBox
xiaokang commented on code in PR #9747: URL: https://github.com/apache/incubator-doris/pull/9747#discussion_r880562308 ## be/src/util/block_compression.cpp: ## @@ -22,6 +22,8 @@ #include #include #include +#include Review Comment: It will be better to add some doc for

[GitHub] [incubator-doris] Gabriel39 commented on pull request #9758: [feature-wip] Support datev2

2022-05-24 Thread GitBox
Gabriel39 commented on PR #9758: URL: https://github.com/apache/incubator-doris/pull/9758#issuecomment-1135971891 This job is still WIP. This PR support DateV2 for BE. DateTimeV2 depends on DecimalV3 (WIP) so is not included now. Besides, this PR only refactored execution layer and I will r

[GitHub] [incubator-doris] spaces-X commented on a diff in pull request #9459: [stream-load-vec]: memtable flush only if necessary after aggregated

2022-05-24 Thread GitBox
spaces-X commented on code in PR #9459: URL: https://github.com/apache/incubator-doris/pull/9459#discussion_r880541569 ## be/src/common/config.h: ## @@ -464,6 +464,8 @@ CONF_Int32(memory_max_alignment, "16"); // write buffer size before flush CONF_mInt64(write_buffer_size, "20

[GitHub] [incubator-doris] Gabriel39 opened a new pull request, #9758: [feature-wip] Support datev2

2022-05-24 Thread GitBox
Gabriel39 opened a new pull request, #9758: URL: https://github.com/apache/incubator-doris/pull/9758 # Proposed changes Issue Number: #9575 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior:

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9661: [fix][memory tracker] Fix lru cache, compaction tracker, add USE_MEM_TRACKER compile

2022-05-24 Thread GitBox
github-actions[bot] commented on PR #9661: URL: https://github.com/apache/incubator-doris/pull/9661#issuecomment-1135940018 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9661: [fix][memory tracker] Fix lru cache, compaction tracker, add USE_MEM_TRACKER compile

2022-05-24 Thread GitBox
github-actions[bot] commented on PR #9661: URL: https://github.com/apache/incubator-doris/pull/9661#issuecomment-1135940064 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] dataalive commented on a diff in pull request #9753: [doc]Add Doris join optimization documentation

2022-05-24 Thread GitBox
dataalive commented on code in PR #9753: URL: https://github.com/apache/incubator-doris/pull/9753#discussion_r880515874 ## docs/zh-CN/advanced/join-optimization/doris-join-optimization.md: ## @@ -0,0 +1,226 @@ +--- +{ +"title": "Doris Join 优化原理", +"language": "zh-CN" +}

[GitHub] [incubator-doris] dataalive commented on a diff in pull request #9753: [doc]Add Doris join optimization documentation

2022-05-24 Thread GitBox
dataalive commented on code in PR #9753: URL: https://github.com/apache/incubator-doris/pull/9753#discussion_r880514364 ## docs/zh-CN/advanced/join-optimization/doris-join-optimization.md: ## @@ -0,0 +1,226 @@ +--- +{ +"title": "Doris Join 优化原理", +"language": "zh-CN" +}

[GitHub] [incubator-doris] dataalive commented on a diff in pull request #9753: [doc]Add Doris join optimization documentation

2022-05-24 Thread GitBox
dataalive commented on code in PR #9753: URL: https://github.com/apache/incubator-doris/pull/9753#discussion_r880512484 ## docs/en/advanced/join-optimization/doris-join-optimization.md: ## @@ -0,0 +1,222 @@ +--- +{ +"title": "Doris Join optimization principle", +"languag

[GitHub] [incubator-doris] dataalive commented on a diff in pull request #9753: [doc]Add Doris join optimization documentation

2022-05-24 Thread GitBox
dataalive commented on code in PR #9753: URL: https://github.com/apache/incubator-doris/pull/9753#discussion_r880512484 ## docs/en/advanced/join-optimization/doris-join-optimization.md: ## @@ -0,0 +1,222 @@ +--- +{ +"title": "Doris Join optimization principle", +"languag

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9756: [Refactor][doc]Fix formatting issues in English documents.

2022-05-24 Thread GitBox
github-actions[bot] commented on PR #9756: URL: https://github.com/apache/incubator-doris/pull/9756#issuecomment-1135929490 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] EmmyMiao87 opened a new issue, #9757: [Enhancement](TPC-DS) Fix failed queries in version 1.0.0

2022-05-24 Thread GitBox
EmmyMiao87 opened a new issue, #9757: URL: https://github.com/apache/incubator-doris/issues/9757 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description

[GitHub] [incubator-doris] EmmyMiao87 closed issue #9623: [Enhancement](Nereids)refactor plan node into plan + operator

2022-05-24 Thread GitBox
EmmyMiao87 closed issue #9623: [Enhancement](Nereids)refactor plan node into plan + operator URL: https://github.com/apache/incubator-doris/issues/9623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [incubator-doris] EmmyMiao87 merged pull request #9755: [Enhancement](Nereids)refactor plan node into plan + operator

2022-05-24 Thread GitBox
EmmyMiao87 merged PR #9755: URL: https://github.com/apache/incubator-doris/pull/9755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[incubator-doris] branch master updated: [Enhancement](Nereids)refactor plan node into plan + operator (#9755)

2022-05-24 Thread lingmiao
This is an automated email from the ASF dual-hosted git repository. lingmiao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new cc9321a09b [Enhancement](Nereids)refa

[GitHub] [incubator-doris] jackwener commented on a diff in pull request #8861: [feature-wip](statistics) step4: collect statistics by implementing statistics tasks

2022-05-24 Thread GitBox
jackwener commented on code in PR #8861: URL: https://github.com/apache/incubator-doris/pull/8861#discussion_r880414867 ## fe/fe-core/src/main/java/org/apache/doris/statistics/PartitionStats.java: ## @@ -0,0 +1,129 @@ +// Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [incubator-doris] EmmyMiao87 commented on a diff in pull request #9739: [Enhancement][fix] Add a rewrite rule to optimize InPredicate.

2022-05-24 Thread GitBox
EmmyMiao87 commented on code in PR #9739: URL: https://github.com/apache/incubator-doris/pull/9739#discussion_r880413840 ## fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java: ## @@ -302,6 +302,7 @@ public boolean isAnalyzed() { return isAnalyzed; } +

[GitHub] [incubator-doris] EmmyMiao87 commented on a diff in pull request #9739: [Enhancement][fix] Add a rewrite rule to optimize InPredicate.

2022-05-24 Thread GitBox
EmmyMiao87 commented on code in PR #9739: URL: https://github.com/apache/incubator-doris/pull/9739#discussion_r880410227 ## fe/fe-core/src/main/java/org/apache/doris/rewrite/RewriteInPredicateRule.java: ## @@ -0,0 +1,113 @@ +// Licensed to the Apache Software Foundation (ASF) un

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9743: [Improvement] fix typo

2022-05-24 Thread GitBox
github-actions[bot] commented on PR #9743: URL: https://github.com/apache/incubator-doris/pull/9743#issuecomment-1135807590 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] EmmyMiao87 commented on a diff in pull request #9739: [Enhancement][fix] Add a rewrite rule to optimize InPredicate.

2022-05-24 Thread GitBox
EmmyMiao87 commented on code in PR #9739: URL: https://github.com/apache/incubator-doris/pull/9739#discussion_r880377435 ## fe/fe-core/src/main/java/org/apache/doris/rewrite/RewriteInPredicateRule.java: ## @@ -0,0 +1,113 @@ +// Licensed to the Apache Software Foundation (ASF) un

[GitHub] [incubator-doris] yangzhg commented on a diff in pull request #9541: [feature-wip](parquet-orc) Support orc scanner in vectorized engine

2022-05-24 Thread GitBox
yangzhg commented on code in PR #9541: URL: https://github.com/apache/incubator-doris/pull/9541#discussion_r880373945 ## thirdparty/build-thirdparty.sh: ## @@ -643,12 +643,13 @@ build_arrow() { export ARROW_SNAPPY_URL=${TP_SOURCE_DIR}/${SNAPPY_NAME} export ARROW_ZLIB_U

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9466: [feature-wip][array-type] Support more sub types.

2022-05-24 Thread GitBox
github-actions[bot] commented on PR #9466: URL: https://github.com/apache/incubator-doris/pull/9466#issuecomment-1135750458 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9466: [feature-wip][array-type] Support more sub types.

2022-05-24 Thread GitBox
github-actions[bot] commented on PR #9466: URL: https://github.com/apache/incubator-doris/pull/9466#issuecomment-1135750384 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] platoneko closed pull request #9139: [refactor-wip] Add FileSystem, ReadStream, WriteStream

2022-05-24 Thread GitBox
platoneko closed pull request #9139: [refactor-wip] Add FileSystem, ReadStream, WriteStream URL: https://github.com/apache/incubator-doris/pull/9139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [incubator-doris] Lchangliang commented on a diff in pull request #8923: [Feature] Support compression prop

2022-05-24 Thread GitBox
Lchangliang commented on code in PR #8923: URL: https://github.com/apache/incubator-doris/pull/8923#discussion_r880313916 ## be/src/olap/tablet_meta.cpp: ## @@ -90,8 +91,34 @@ TabletMeta::TabletMeta(int64_t table_id, int64_t partition_id, int64_t tablet_id LOG(WARNING)

[GitHub] [incubator-doris] smallhibiscus opened a new pull request, #9756: [Refactor][doc]Fix formatting issues in English documents.

2022-05-24 Thread GitBox
smallhibiscus opened a new pull request, #9756: URL: https://github.com/apache/incubator-doris/pull/9756 # Proposed changes Issue Number: close #xxx ## Problem Summary: Fix the format error of en doc. ## Checklist(Required) 1. Does it affect the original beh

[GitHub] [incubator-doris] 924060929 opened a new pull request, #9755: refactor treenode

2022-05-24 Thread GitBox
924060929 opened a new pull request, #9755: URL: https://github.com/apache/incubator-doris/pull/9755 # Proposed changes Issue Number: close #9623 ## Problem Summary: refactor plan node into expression + operator. ## Checklist(Required) 1. Does it affect the

[GitHub] [incubator-doris] dujl commented on a diff in pull request #9559: [feature-wip](hudi) Step1: Support create hudi external table

2022-05-24 Thread GitBox
dujl commented on code in PR #9559: URL: https://github.com/apache/incubator-doris/pull/9559#discussion_r880271438 ## fe/fe-core/src/test/java/org/apache/doris/analysis/CreateTableStmtTest.java: ## @@ -274,4 +274,21 @@ public void testCreateIcebergTable() throws UserException {

[GitHub] [incubator-doris] BePPPower commented on pull request #9754: [feature] datetime column type support auto-initialized with default …

2022-05-24 Thread GitBox
BePPPower commented on PR #9754: URL: https://github.com/apache/incubator-doris/pull/9754#issuecomment-1135609501 There is still a problem: when we set default CURRENT_TIMESTAMP for varchar/char column type, it also will success. -- This is an automated message from the Apache Git

[GitHub] [incubator-doris] BePPPower opened a new pull request, #9754: [feature] datetime column type support auto-initialized with default …

2022-05-24 Thread GitBox
BePPPower opened a new pull request, #9754: URL: https://github.com/apache/incubator-doris/pull/9754 …CURRENT_TIMESTAMP # Proposed changes Issue Number: close #9570 ## Problem Summary: An auto-initialized column is set to the current timestamp for inserted rows t

[GitHub] [incubator-doris] hf200012 opened a new pull request, #9753: [doc]Add Doris join optimization documentation

2022-05-24 Thread GitBox
hf200012 opened a new pull request, #9753: URL: https://github.com/apache/incubator-doris/pull/9753 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavi

[GitHub] [incubator-doris] SaintBacchus commented on pull request #9608: [Feature] Introducing OpenTelemetry to improve the observability of Doris.

2022-05-24 Thread GitBox
SaintBacchus commented on PR #9608: URL: https://github.com/apache/incubator-doris/pull/9608#issuecomment-1135572749 Will this feature collect the plan frament execution metrics as the sql profile? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-doris] SaintBacchus commented on pull request #9725: [Enhancement][Step1] Add a ProfileStorage interface to support record all the querylog in persist storage.

2022-05-24 Thread GitBox
SaintBacchus commented on PR #9725: URL: https://github.com/apache/incubator-doris/pull/9725#issuecomment-1135530818 OK, I revert the last commit and do the performence improve in the later worker. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-doris] stalary commented on pull request #9725: [Enhancement][Step1] Add a ProfileStorage interface to support record all the querylog in persist storage.

2022-05-24 Thread GitBox
stalary commented on PR #9725: URL: https://github.com/apache/incubator-doris/pull/9725#issuecomment-1135515892 > @stalary In the lastest commit I separate the interface `getProfile(queryId)` into two parts of `getProfileContent` and `getProfileBuilder`. Since if we want to store the record

[GitHub] [incubator-doris] stalary commented on pull request #9725: [Enhancement][Step1] Add a ProfileStorage interface to support record all the querylog in persist storage.

2022-05-24 Thread GitBox
stalary commented on PR #9725: URL: https://github.com/apache/incubator-doris/pull/9725#issuecomment-1135515003 I think it's ok to return enough data at the bottom level for the top level to choose. This will be easier to extend later when we support more storage methods. -- This is an a

[GitHub] [incubator-doris] SaintBacchus commented on pull request #9725: [Enhancement][Step1] Add a ProfileStorage interface to support record all the querylog in persist storage.

2022-05-24 Thread GitBox
SaintBacchus commented on PR #9725: URL: https://github.com/apache/incubator-doris/pull/9725#issuecomment-1135500847 @stalary In the lastest commit I separate the interface `getProfile(queryId)` into two parts of `getProfileContent` and `getProfileBuilder`. Since if we want to store th