yiguolei commented on code in PR #9754: URL: https://github.com/apache/incubator-doris/pull/9754#discussion_r881062007
########## fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java: ########## @@ -61,10 +61,19 @@ public class ColumnDef { public static class DefaultValue { public boolean isSet; public String value; + // only used for datetime column type + public boolean isCurrentTimestamp; public DefaultValue(boolean isSet, String value) { this.isSet = isSet; this.value = value; + this.isCurrentTimestamp = false; Review Comment: Do not use boolean current_timestamp here. Use a expr to save it. Actually, currentTimestamp is function "now". we may add other default value types. Expr is more normal because it could stand for any functions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org