Re: [PR] api/ui: add specifyvlan to network response [cloudstack]

2025-01-22 Thread via GitHub
codecov[bot] commented on PR #10236: URL: https://github.com/apache/cloudstack/pull/10236#issuecomment-2606673352 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10236?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[PR] Decrypt zone, cluster, storage details for configuration values [cloudstack]

2025-01-22 Thread via GitHub
harikrishna-patnala opened a new pull request, #10237: URL: https://github.com/apache/cloudstack/pull/10237 ### Description This PR addresses the issue #9891 extending the PR https://github.com/apache/cloudstack/pull/9088 which decrypts the configuration values in the details tables

Re: [I] Autoscale VMs do not follow ScaleDown Rules after a Node Failure [cloudstack]

2025-01-22 Thread via GitHub
DaanHoogland commented on issue #9336: URL: https://github.com/apache/cloudstack/issues/9336#issuecomment-2606824171 @btzq , I've not been able to reproduce this reliably with the caveat that it might temporarily exceed the number of max VMs. But in all my experiments it normalises again. S

Re: [PR] api,ui: fix empty source cidr value for firewall rule [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10208: URL: https://github.com/apache/cloudstack/pull/10208#issuecomment-2606932339 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] api,ui: fix empty source cidr value for firewall rule [cloudstack]

2025-01-22 Thread via GitHub
shwstppr commented on PR #10208: URL: https://github.com/apache/cloudstack/pull/10208#issuecomment-2606929230 @abh1sar API was allowing empty cidr as it takes List as input, ``` (qaserver) 🐱 > create firewallrule cidrlist= protocol=tcp ipaddressid=e7314c68-c570-42c5-939e-e61f5b30cb4b s

Re: [PR] CKS: use --delete-emptydir-data instead of deprecated --delete-local-data [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10234: URL: https://github.com/apache/cloudstack/pull/10234#issuecomment-2606675461 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Allow delete account only once it is disabled. Extra checks in UI. [cloudstack]

2025-01-22 Thread via GitHub
abh1sar commented on code in PR #10232: URL: https://github.com/apache/cloudstack/pull/10232#discussion_r1925031221 ## server/src/main/java/com/cloud/user/AccountManagerImpl.java: ## @@ -850,6 +850,10 @@ protected boolean lockAccount(long accountId) { public boolean deleteA

Re: [PR] Allow delete account only once it is disabled. Extra checks in UI. [cloudstack]

2025-01-22 Thread via GitHub
weizhouapache commented on code in PR #10232: URL: https://github.com/apache/cloudstack/pull/10232#discussion_r1925096091 ## server/src/main/java/com/cloud/user/AccountManagerImpl.java: ## @@ -850,6 +850,10 @@ protected boolean lockAccount(long accountId) { public boolean d

Re: [PR] ui: fix passing vlan while creating vpc tier [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10239: URL: https://github.com/apache/cloudstack/pull/10239#issuecomment-2607068996 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10239 (QA-JID-520) -- This is an automated message from the Apache Git Service. To respon

Re: [PR] Fix local storage deletion cases [cloudstack]

2025-01-22 Thread via GitHub
harikrishna-patnala commented on code in PR #10231: URL: https://github.com/apache/cloudstack/pull/10231#discussion_r1925209654 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtDeleteStoragePoolCommandWrapper.java: ## @@ -39,6 +47,34 @@ p

Re: [PR] Fix local storage deletion cases [cloudstack]

2025-01-22 Thread via GitHub
harikrishna-patnala commented on PR #10231: URL: https://github.com/apache/cloudstack/pull/10231#issuecomment-2607073438 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

(cloudstack) branch 4.19 updated: server: Fix host CPU number (#10218)

2025-01-22 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.19 by this push: new 09f154796a2 server: Fix host CPU number (#10218) 0

Re: [PR] server: Fix host CPU number [cloudstack]

2025-01-22 Thread via GitHub
DaanHoogland merged PR #10218: URL: https://github.com/apache/cloudstack/pull/10218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

Re: [PR] server: fix scale vm with same disk offering id [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10235: URL: https://github.com/apache/cloudstack/pull/10235#issuecomment-2607416684 @weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respon

Re: [PR] Improve listing of HA and non-HA hosts when ha.tag setting is defined and hosts have multiple tags along with ha tag [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10240: URL: https://github.com/apache/cloudstack/pull/10240#issuecomment-2607469723 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] server: apply network ACL even if there is no network ACLs in the ACL list (#9374) [cloudstack]

2025-01-22 Thread via GitHub
weizhouapache commented on PR #10241: URL: https://github.com/apache/cloudstack/pull/10241#issuecomment-2607478709 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[PR] server: apply network ACL even if there is no network ACLs in the ACL list (#9374) [cloudstack]

2025-01-22 Thread via GitHub
weizhouapache opened a new pull request, #10241: URL: https://github.com/apache/cloudstack/pull/10241 ### Description This PR re-applies #9374 ### Types of changes - [ ] Breaking change (fix or feature that would cau

Re: [PR] server: apply network ACL even if there is no network ACLs in the ACL list (#9374) [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10241: URL: https://github.com/apache/cloudstack/pull/10241#issuecomment-2607484925 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progr

Re: [PR] server: apply network ACL even if there is no network ACLs in the ACL list (#9374) [cloudstack]

2025-01-22 Thread via GitHub
codecov[bot] commented on PR #10241: URL: https://github.com/apache/cloudstack/pull/10241#issuecomment-2607497883 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10241?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

Re: [I] Unable to delete failed VM snapshot [cloudstack]

2025-01-22 Thread via GitHub
harikrishna-patnala closed issue #9369: Unable to delete failed VM snapshot URL: https://github.com/apache/cloudstack/issues/9369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] server: fix scale vm with same disk offering id [cloudstack]

2025-01-22 Thread via GitHub
borisstoyanov commented on PR #10235: URL: https://github.com/apache/cloudstack/pull/10235#issuecomment-2606964956 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] server: fix scale vm with same disk offering id [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10235: URL: https://github.com/apache/cloudstack/pull/10235#issuecomment-2606967656 @borisstoyanov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progr

(cloudstack) branch healthcheck-4.19 updated (1f21d0f531c -> 4747283d992)

2025-01-22 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch healthcheck-4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git omit 1f21d0f531c DO NOT MERGE add d053bb97ecf Fix to allow actions on the network if it belongs to a proj

Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2025-01-22 Thread via GitHub
DaanHoogland commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2606976926 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Allow delete account only once it is disabled. Extra checks in UI. [cloudstack]

2025-01-22 Thread via GitHub
DaanHoogland commented on PR #10232: URL: https://github.com/apache/cloudstack/pull/10232#issuecomment-2606979079 @abh1sar ,can you rebase on 4.19, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2606980426 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [I] Unable to delete failed VM snapshot [cloudstack]

2025-01-22 Thread via GitHub
harikrishna-patnala commented on issue #9369: URL: https://github.com/apache/cloudstack/issues/9369#issuecomment-2606972781 I'm closing the issue as I could not reproduce it. Please feel free to reopen if this issue reproduces again. -- This is an automated message from the Apache Git Se

(cloudstack) branch healthcheck-4.19 updated (4747283d992 -> 3f668a23abb)

2025-01-22 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch healthcheck-4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git discard 4747283d992 DO NOT MERGE add b186272f687 kvm: add SCSI controllers based on the number of virtio-SCS

Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2025-01-22 Thread via GitHub
DaanHoogland commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2607220584 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2607224489 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [I] 2FA is enabled even if User fails to verify with TOTP code [cloudstack]

2025-01-22 Thread via GitHub
DaanHoogland commented on issue #9308: URL: https://github.com/apache/cloudstack/issues/9308#issuecomment-2607237911 @scottsignal , closing based on @shwstppr 's findings, please reopen or create a new issue if this perists after upgrading to 4.19.1 or above -- This is an automated messag

Re: [I] Data Disks get unavailable when VM is shut down [cloudstack]

2025-01-22 Thread via GitHub
weizhouapache closed issue #7490: Data Disks get unavailable when VM is shut down URL: https://github.com/apache/cloudstack/issues/7490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Added displaynetwork option in filters for listnetwork only for admin [cloudstack]

2025-01-22 Thread via GitHub
DaanHoogland commented on PR #10209: URL: https://github.com/apache/cloudstack/pull/10209#issuecomment-2607242441 > Code LGTM but for such networks opened from other than listview it would still return 404. Others can advise. Maybe in future we improve this API parameter which somehow allow

Re: [PR] kvm: add SCSI controllers based on the number of virtio-SCSI disks [cloudstack]

2025-01-22 Thread via GitHub
weizhouapache commented on PR #9823: URL: https://github.com/apache/cloudstack/pull/9823#issuecomment-2607245509 > the usage error is failed to download iso, which is not related. the life-cyle ones are intermitted errors thanks @vladimirpetrov @DaanHoogland -- This is an automate

Re: [PR] Added displaynetwork option in filters for listnetwork only for admin [cloudstack]

2025-01-22 Thread via GitHub
DaanHoogland commented on PR #10209: URL: https://github.com/apache/cloudstack/pull/10209#issuecomment-2607243663 @harikrishna-patnala do you want to polish this more now or merge and postpone further enhancements? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Decrypt zone, cluster, storage details for configuration values [cloudstack]

2025-01-22 Thread via GitHub
DaanHoogland commented on PR #10237: URL: https://github.com/apache/cloudstack/pull/10237#issuecomment-2607639556 Did some more research, @harikrishna-patnala . at least these changes are needed as well (still looking) ``` diff --git a/engine/schema/src/main/java/com/cloud/dc/Clus

Re: [PR] Fix local storage deletion cases [cloudstack]

2025-01-22 Thread via GitHub
DaanHoogland commented on PR #10231: URL: https://github.com/apache/cloudstack/pull/10231#issuecomment-2607642446 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix local storage deletion cases [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10231: URL: https://github.com/apache/cloudstack/pull/10231#issuecomment-2607644337 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond

Re: [PR] server: apply network ACL even if there is no network ACLs in the ACL list (#9374) [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10241: URL: https://github.com/apache/cloudstack/pull/10241#issuecomment-2607664191 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] List default network offerings when multiple physical networks for guest traffic type exists [cloudstack]

2025-01-22 Thread via GitHub
weizhouapache commented on PR #10222: URL: https://github.com/apache/cloudstack/pull/10222#issuecomment-2607668100 @DaanHoogland Actually there are only 5 default shared network offerings will be listed. ``` mysql> select id,unique_name from network_offerings where `default`=1 a

Re: [PR] List default network offerings when multiple physical networks for guest traffic type exists [cloudstack]

2025-01-22 Thread via GitHub
Pearl1594 commented on PR #10222: URL: https://github.com/apache/cloudstack/pull/10222#issuecomment-2607651790 @DaanHoogland I am not sure what copyDefaultOfferings() is supposed to do. CloudStack forces a tag for any additional physical (guest) network added. Which should not render the de

(cloudstack-documentation) branch 4.19 updated: Fix Adding a zone documentation (#472)

2025-01-22 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git The following commit(s) were added to refs/heads/4.19 by this push: new e3fda2f Fix Adding a zone documenta

[PR] api/ui: add specifyvlan to network response [cloudstack]

2025-01-22 Thread via GitHub
weizhouapache opened a new pull request, #10236: URL: https://github.com/apache/cloudstack/pull/10236 ### Description This PR fixes ### Types of changes - [ ] Breaking change (fix or feature that would cause existing

Re: [I] Unable to migrate VM between new host and older hosts , running same versions [cloudstack]

2025-01-22 Thread via GitHub
abh1sar commented on issue #9768: URL: https://github.com/apache/cloudstack/issues/9768#issuecomment-2606790448 Hi @hmadra Any update on this? > [@hmadra](https://github.com/hmadra) what's the output of command `stat -fc %T /sys/fs/cgroup/` ? > > also, what's the error mess

Re: [PR] kvm: add SCSI controllers based on the number of virtio-SCSI disks [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #9823: URL: https://github.com/apache/cloudstack/pull/9823#issuecomment-2607055945 [SF] Trillian test result (tid-12158) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 46520 seconds Marvin logs: https://github.com/

Re: [PR] Decrypt zone, cluster, storage details for configuration values [cloudstack]

2025-01-22 Thread via GitHub
DaanHoogland commented on PR #10237: URL: https://github.com/apache/cloudstack/pull/10237#issuecomment-2607056737 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Decrypt zone, cluster, storage details for configuration values [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10237: URL: https://github.com/apache/cloudstack/pull/10237#issuecomment-2607062153 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2025-01-22 Thread via GitHub
sonarqubecloud[bot] commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2607687141 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://s

Re: [PR] List default network offerings when multiple physical networks for guest traffic type exists [cloudstack]

2025-01-22 Thread via GitHub
Pearl1594 commented on PR #10222: URL: https://github.com/apache/cloudstack/pull/10222#issuecomment-2607668695 > @Pearl1594 thanks for the update I think the default shared network offerings will be listed, that's good > > Can you test the creation of shared networks with > >

Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2607716226 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] api,ui: fix empty source cidr value for firewall rule [cloudstack]

2025-01-22 Thread via GitHub
shwstppr commented on code in PR #10208: URL: https://github.com/apache/cloudstack/pull/10208#discussion_r1925267671 ## api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java: ## @@ -103,14 +105,13 @@ public String getProtocol() { @Ov

Re: [PR] api,ui: fix empty source cidr value for firewall rule [cloudstack]

2025-01-22 Thread via GitHub
shwstppr commented on code in PR #10208: URL: https://github.com/apache/cloudstack/pull/10208#discussion_r1925270112 ## api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java: ## @@ -103,14 +105,13 @@ public String getProtocol() { @Ov

Re: [PR] kvm: add SCSI controllers based on the number of virtio-SCSI disks [cloudstack]

2025-01-22 Thread via GitHub
DaanHoogland commented on PR #9823: URL: https://github.com/apache/cloudstack/pull/9823#issuecomment-2607186252 the usage error is failed to download iso, which is not related. the life-cyle ones are intermitted errors -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Fix local storage deletion cases [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10231: URL: https://github.com/apache/cloudstack/pull/10231#issuecomment-2607185667 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] kvm: add SCSI controllers based on the number of virtio-SCSI disks [cloudstack]

2025-01-22 Thread via GitHub
DaanHoogland merged PR #9823: URL: https://github.com/apache/cloudstack/pull/9823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

Re: [PR] Support virtio-blk root disk controller [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10229: URL: https://github.com/apache/cloudstack/pull/10229#issuecomment-2607191986 [SF] Trillian test result (tid-12159) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 44051 seconds Marvin logs: https://github.co

Re: [PR] Decrypt zone, cluster, storage details for configuration values [cloudstack]

2025-01-22 Thread via GitHub
DaanHoogland commented on PR #10237: URL: https://github.com/apache/cloudstack/pull/10237#issuecomment-2607212392 no idea how these are related, @harikrishna-patnala but the build consistently fails :( : ``` 13:14:15 [ERROR] Errors: 13:14:15 [ERROR] SecurityGroupManagerImplTest.C

Re: [PR] Fix local storage deletion cases [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10231: URL: https://github.com/apache/cloudstack/pull/10231#issuecomment-2607614608 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] ui: fix passing vlan while creating vpc tier [cloudstack]

2025-01-22 Thread via GitHub
shwstppr opened a new pull request, #10239: URL: https://github.com/apache/cloudstack/pull/10239 ### Description Currently VLAN was not getting added to API call when offering has specifyVlan as true ### Types of changes - [ ] Breaking change (fix or feature that would c

Re: [PR] ui: fix passing vlan while creating vpc tier [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10239: URL: https://github.com/apache/cloudstack/pull/10239#issuecomment-2607032035 @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respo

Re: [PR] ui: fix passing vlan while creating vpc tier [cloudstack]

2025-01-22 Thread via GitHub
DaanHoogland commented on PR #10239: URL: https://github.com/apache/cloudstack/pull/10239#issuecomment-2607029682 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] ui: fix passing vlan while creating vpc tier [cloudstack]

2025-01-22 Thread via GitHub
codecov[bot] commented on PR #10239: URL: https://github.com/apache/cloudstack/pull/10239#issuecomment-2607040157 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

Re: [PR] list disk offerings by tags [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10228: URL: https://github.com/apache/cloudstack/pull/10228#issuecomment-2607079669 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] api,ui: fix empty source cidr value for firewall rule [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10208: URL: https://github.com/apache/cloudstack/pull/10208#issuecomment-2607087850 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2025-01-22 Thread via GitHub
sonarqubecloud[bot] commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2607097110 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://s

Re: [I] Network rate on VPC tier network offering are ignored [cloudstack]

2025-01-22 Thread via GitHub
shwstppr commented on issue #9763: URL: https://github.com/apache/cloudstack/issues/9763#issuecomment-2607105387 @rajujith I tested this with a 4.19 env and I can see network rate is taken from the network offering. I used offering with network rate as 350 ``` (localcloud) 🐱 > list

Re: [PR] Fix local storage deletion cases [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10231: URL: https://github.com/apache/cloudstack/pull/10231#issuecomment-2607075503 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2607116796 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Decrypt zone, cluster, storage details for configuration values [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10237: URL: https://github.com/apache/cloudstack/pull/10237#issuecomment-2607116797 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

(cloudstack) branch healthcheck-4.19 updated (3f668a23abb -> ca472393aec)

2025-01-22 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch healthcheck-4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git discard 3f668a23abb DO NOT MERGE add 09f154796a2 server: Fix host CPU number (#10218) add 1e59f5cd0cd ui

Re: [PR] List default network offerings when multiple physical networks for guest traffic type exists [cloudstack]

2025-01-22 Thread via GitHub
DaanHoogland commented on PR #10222: URL: https://github.com/apache/cloudstack/pull/10222#issuecomment-2607538635 @Pearl1594 @weizhouapache , I know I am a bit of a functional hork, but I really think no offerings should be shown if the tags do not match, for any type of network. For any ph

Re: [PR] Allow counters to be created with same name, provider and source as a deleted one [cloudstack]

2025-01-22 Thread via GitHub
sonarqubecloud[bot] commented on PR #10223: URL: https://github.com/apache/cloudstack/pull/10223#issuecomment-2607556534 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https:/

Re: [PR] Allow counters to be created with same name, provider and source as a deleted one [cloudstack]

2025-01-22 Thread via GitHub
DaanHoogland commented on code in PR #10223: URL: https://github.com/apache/cloudstack/pull/10223#discussion_r1925536402 ## engine/schema/src/main/resources/META-INF/db/schema-41910to41920.sql: ## @@ -22,5 +22,20 @@ -- Add last_id to the volumes table CALL `cloud`.`IDEMPOTENT_

Re: [I] [API] Incorrect listing of VMs with previous NICs on networks [cloudstack]

2025-01-22 Thread via GitHub
DaanHoogland commented on issue #10188: URL: https://github.com/apache/cloudstack/issues/10188#issuecomment-2606735695 fixed in #10204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [I] [API] Incorrect listing of VMs with previous NICs on networks [cloudstack]

2025-01-22 Thread via GitHub
DaanHoogland closed issue #10188: [API] Incorrect listing of VMs with previous NICs on networks URL: https://github.com/apache/cloudstack/issues/10188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Decrypt zone, cluster, storage details for configuration values [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10237: URL: https://github.com/apache/cloudstack/pull/10237#issuecomment-2606733448 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] server: fix scale vm with same disk offering id [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10235: URL: https://github.com/apache/cloudstack/pull/10235#issuecomment-2607116790 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] api,ui: fix empty source cidr value for firewall rule [cloudstack]

2025-01-22 Thread via GitHub
weizhouapache commented on code in PR #10208: URL: https://github.com/apache/cloudstack/pull/10208#discussion_r1925242694 ## api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java: ## @@ -103,14 +105,13 @@ public String getProtocol() {

Re: [I] Cloudstack doesn't check availability of Secondary Storage [cloudstack]

2025-01-22 Thread via GitHub
vishesh92 commented on issue #9730: URL: https://github.com/apache/cloudstack/issues/9730#issuecomment-2607129158 @top-secrett I was able to reproduce the scenario by removing the SSVM and then deleting the snapshot. This resulted in snapshot not getting deleted from the storage. In this ca

Re: [I] 2FA is enabled even if User fails to verify with TOTP code [cloudstack]

2025-01-22 Thread via GitHub
shwstppr commented on issue #9308: URL: https://github.com/apache/cloudstack/issues/9308#issuecomment-2607140588 @scottsignal cc @harikrishna-patnala @borisstoyanov @kiranchavala @vladimirpetrov I've tested this with 4.19.1.3 and could not reproduce it. It must have been solved by https:/

(cloudstack) branch list-default-offerings updated (ae061d80529 -> d4b721e9b71)

2025-01-22 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch list-default-offerings in repository https://gitbox.apache.org/repos/asf/cloudstack.git from ae061d80529 List default network offerings when multiple physical networks for guest traffic

Re: [PR] List default network offerings when multiple physical networks for guest traffic type exists [cloudstack]

2025-01-22 Thread via GitHub
weizhouapache commented on PR #10222: URL: https://github.com/apache/cloudstack/pull/10222#issuecomment-2607513955 @Pearl1594 thanks for the update I think the default shared network offerings will be listed, that's good Can you test the creation of shared networks with - def

Re: [PR] ui: fix passing vlan while creating vpc tier [cloudstack]

2025-01-22 Thread via GitHub
DaanHoogland merged PR #10239: URL: https://github.com/apache/cloudstack/pull/10239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

(cloudstack) branch 4.19 updated: ui: fix passing vlan while creating vpc tier (#10239)

2025-01-22 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.19 by this push: new 1e59f5cd0cd ui: fix passing vlan while creating vp

Re: [PR] Decrypt zone, cluster, storage details for configuration values [cloudstack]

2025-01-22 Thread via GitHub
codecov[bot] commented on PR #10237: URL: https://github.com/apache/cloudstack/pull/10237#issuecomment-2606746046 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10237?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

(cloudstack) branch 4.19 updated: Fix to allow actions on the network if it belongs to a project (#9550)

2025-01-22 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.19 by this push: new d053bb97ecf Fix to allow actions on the network

Re: [PR] CKS: use --delete-emptydir-data instead of deprecated --delete-local-data [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10234: URL: https://github.com/apache/cloudstack/pull/10234#issuecomment-2606683170 @weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respon

Re: [I] VM cross cluster migration not working [cloudstack]

2025-01-22 Thread via GitHub
weizhouapache commented on issue #10078: URL: https://github.com/apache/cloudstack/issues/10078#issuecomment-2606680174 @ahmedali6 I am able to reproduce the issue ![Image](https://github.com/user-attachments/assets/127910be-0c18-43ff-b540-9434ee0d95f7) I will work on the f

Re: [PR] Decrypt zone, cluster, storage details for configuration values [cloudstack]

2025-01-22 Thread via GitHub
harikrishna-patnala commented on PR #10237: URL: https://github.com/apache/cloudstack/pull/10237#issuecomment-2606729632 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Decrypt zone, cluster, storage details for configuration values [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10237: URL: https://github.com/apache/cloudstack/pull/10237#issuecomment-2606866947 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2606873481 [SF] Trillian test result (tid-12155) Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9 Total time taken: 65736 seconds Marvin logs: https://github.com/

Re: [PR] server: fix scale vm with same disk offering id [cloudstack]

2025-01-22 Thread via GitHub
weizhouapache commented on PR #10235: URL: https://github.com/apache/cloudstack/pull/10235#issuecomment-2607414902 thanks @borisstoyanov if there is no smoke test failures, let's merge @blueorangutan test -- This is an automated message from the Apache Git Service. To respon

(cloudstack) branch fix-create-counters-dup updated (fdb9a717b99 -> 7a1e54d3154)

2025-01-22 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch fix-create-counters-dup in repository https://gitbox.apache.org/repos/asf/cloudstack.git from fdb9a717b99 fix api response add 7a1e54d3154 drop unique key only if it exists No new r

Re: [PR] Allow counters to be created with same name, provider and source as a deleted one [cloudstack]

2025-01-22 Thread via GitHub
weizhouapache commented on code in PR #10223: URL: https://github.com/apache/cloudstack/pull/10223#discussion_r1925433477 ## engine/schema/src/main/resources/META-INF/db/schema-41910to41920.sql: ## @@ -22,5 +22,20 @@ -- Add last_id to the volumes table CALL `cloud`.`IDEMPOTENT

Re: [PR] CKS: use --delete-emptydir-data instead of deprecated --delete-local-data [cloudstack]

2025-01-22 Thread via GitHub
weizhouapache commented on PR #10234: URL: https://github.com/apache/cloudstack/pull/10234#issuecomment-2606682110 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] list disk offerings by tags [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10228: URL: https://github.com/apache/cloudstack/pull/10228#issuecomment-2606845146 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Improve listing of HA and non-HA hosts when ha.tag setting is defined and hosts have multiple tags along with ha tag [cloudstack]

2025-01-22 Thread via GitHub
sureshanaparti commented on PR #10240: URL: https://github.com/apache/cloudstack/pull/10240#issuecomment-2607329531 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Improve listing of HA and non-HA hosts when ha.tag setting is defined and hosts have multiple tags along with ha tag [cloudstack]

2025-01-22 Thread via GitHub
blueorangutan commented on PR #10240: URL: https://github.com/apache/cloudstack/pull/10240#issuecomment-2607330784 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make prog

[PR] Improve listing of HA and non-HA hosts when ha.tag setting is defined and hosts have multiple tags along with ha tag [cloudstack]

2025-01-22 Thread via GitHub
sureshanaparti opened a new pull request, #10240: URL: https://github.com/apache/cloudstack/pull/10240 ### Description This PR improves listing of HA and non-HA hosts when ha.tag setting is defined and hosts have multiple tags along with ha tag. Fixes #10070

Re: [PR] Improve listing of HA and non-HA hosts when ha.tag setting is defined and hosts have multiple tags along with ha tag [cloudstack]

2025-01-22 Thread via GitHub
codecov[bot] commented on PR #10240: URL: https://github.com/apache/cloudstack/pull/10240#issuecomment-2607345484 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10240?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

  1   2   >