Re: [I] GUI - search instance always give the first VM name and GUI is very slow [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud commented on issue #7910: URL: https://github.com/apache/cloudstack/issues/7910#issuecomment-2164717218 Fixed in https://github.com/apache/cloudstack/pull/9198 pl re-reopen if you still have issues, thanks. -- This is an automated message from the Apache Git Service. To re

Re: [I] DNS service not working for System VMs on a fresh new install Cloudstack [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud commented on issue #7473: URL: https://github.com/apache/cloudstack/issues/7473#issuecomment-2164722838 @bradsmin can you review the comments and advise? Have you also tried @li-liwen 's workaround to disable ufw (or firewalld). -- This is an automated message from the Ap

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-06-13 Thread via GitHub
weizhouapache commented on PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-2164723505 > The failures are due to a host being in connecting state, which has not to do with the SSVM, so I consider them unrelated. a side-note, I have faced the issue frequen

Re: [PR] add to cpu speed parameter a description of the cgroup2 case [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud merged PR #9191: URL: https://github.com/apache/cloudstack/pull/9191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [I] CPU speed in compute offering is not a MHz speed when using KVM and libvirt. [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud closed issue #6743: CPU speed in compute offering is not a MHz speed when using KVM and libvirt. URL: https://github.com/apache/cloudstack/issues/6743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

(cloudstack) branch 4.19 updated: api: add to cpu speed parameter a description of the cgroup2 case (#9191)

2024-06-13 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.19 by this push: new b3c3f917186 api: add to cpu speed parameter a des

Re: [I] CPU speed in compute offering is not a MHz speed when using KVM and libvirt. [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud commented on issue #6743: URL: https://github.com/apache/cloudstack/issues/6743#issuecomment-2164741093 Fixed by updating API doc via https://github.com/apache/cloudstack/pull/9191 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Fix error message if specific host does not have capacity [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud commented on PR #9218: URL: https://github.com/apache/cloudstack/pull/9218#issuecomment-2164746052 Marvin/simulator smoketests are enough, as it's largely error/presentation change. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] Fix error message if specific host does not have capacity [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud merged PR #9218: URL: https://github.com/apache/cloudstack/pull/9218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

(cloudstack) branch 4.19 updated: Fix error message if specific host does not have capacity (#9218)

2024-06-13 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.19 by this push: new 517cddcb15c Fix error message if specific host do

Re: [I] Irritating error message when host does not have free memory [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud commented on issue #8077: URL: https://github.com/apache/cloudstack/issues/8077#issuecomment-2164750490 Fixed by https://github.com/apache/cloudstack/pull/9218 to have more meaning message. please re-open for further discussions, thanks for submitting the issue. -- This i

Re: [I] VSAN Storage Policy Question [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud closed issue #8914: VSAN Storage Policy Question URL: https://github.com/apache/cloudstack/issues/8914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [I] VSAN Storage Policy Question [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud commented on issue #8914: URL: https://github.com/apache/cloudstack/issues/8914#issuecomment-2164754341 Fixed by https://github.com/apache/cloudstack/pull/9203 pl re-open if it needs further discussion, thanks for reporting the issue. -- This is an automated message from t

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

2024-06-13 Thread via GitHub
sureshanaparti commented on code in PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#discussion_r1637677947 ## engine/userdata/src/main/java/org/apache/cloudstack/userdata/UserDataManagerImpl.java: ## @@ -90,49 +90,54 @@ public String concatenateUserData(String user

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

2024-06-13 Thread via GitHub
sureshanaparti commented on code in PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#discussion_r1637677947 ## engine/userdata/src/main/java/org/apache/cloudstack/userdata/UserDataManagerImpl.java: ## @@ -90,49 +90,54 @@ public String concatenateUserData(String user

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

2024-06-13 Thread via GitHub
sureshanaparti commented on code in PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#discussion_r1637678897 ## engine/userdata/src/main/java/org/apache/cloudstack/userdata/UserDataManagerImpl.java: ## @@ -90,49 +90,54 @@ public String concatenateUserData(String user

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

2024-06-13 Thread via GitHub
sureshanaparti commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2164771976 > @JoaoJandre can you check the changes on your remarks? @JoaoJandre pls check your remarks. thanks. -- This is an automated message from the Apache Git Service. To resp

(cloudstack) branch fix-unit-test-failure created (now dc0d57b543a)

2024-06-13 Thread vishesh
This is an automated email from the ASF dual-hosted git repository. vishesh pushed a change to branch fix-unit-test-failure in repository https://gitbox.apache.org/repos/asf/cloudstack.git at dc0d57b543a Fix unit test failure This branch includes the following new commits: new dc0d5

(cloudstack) 01/01: Fix unit test failure

2024-06-13 Thread vishesh
This is an automated email from the ASF dual-hosted git repository. vishesh pushed a commit to branch fix-unit-test-failure in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit dc0d57b543a91ac9e1a79f32f4883d4d8007b359 Author: Vishesh AuthorDate: Thu Jun 13 12:47:36 2024 +0530

[PR] kvm: Present the UUID of the VM as serial through smbios information [cloudstack]

2024-06-13 Thread via GitHub
wido opened a new pull request, #9236: URL: https://github.com/apache/cloudstack/pull/9236 ### Description This PR makes sure a KVM VM gets the UUID of the VM as a static serialnumber through smbios. More information: https://libvirt.org/formatdomain.html#smbios-system-informa

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

2024-06-13 Thread via GitHub
sureshanaparti commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2164788919 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[PR] ui: fix dashboard retrievals based on permissions [cloudstack]

2024-06-13 Thread via GitHub
shwstppr opened a new pull request, #9237: URL: https://github.com/apache/cloudstack/pull/9237 ### Description Fixes #9233 Retrieves and shows dashboard details if they are allowed ### Types of changes - [ ] Breaking change (fix or feature that would cause existing

Re: [PR] server: event for HA vm start [cloudstack]

2024-06-13 Thread via GitHub
DaanHoogland commented on code in PR #9202: URL: https://github.com/apache/cloudstack/pull/9202#discussion_r1637682201 ## services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxy.java: ## @@ -1,3 +1,4 @@ + Review Comment: ```suggestion ``` -- Th

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2164797796 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

[PR] Fix unit test failure in LibvirtConvertInstanceCommandWrapperTest [cloudstack]

2024-06-13 Thread via GitHub
vishesh92 opened a new pull request, #9238: URL: https://github.com/apache/cloudstack/pull/9238 ### Description This PR fixes a unit test failure in LibvirtConvertInstanceCommandWrapperTest. Before this patch, `testGetUnmanagedInstanceDisks` calls the `getNfsStoragePoolHostAnd

Re: [PR] Fix unit test failure in LibvirtConvertInstanceCommandWrapperTest [cloudstack]

2024-06-13 Thread via GitHub
vishesh92 commented on PR #9238: URL: https://github.com/apache/cloudstack/pull/9238#issuecomment-2164800394 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [I] KVM host with GPU not showing GPU utilisation in Dashboard [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud commented on issue #7492: URL: https://github.com/apache/cloudstack/issues/7492#issuecomment-2164802153 This is unsupported for KVM hosts with GPUs, this only works with XenServer for now; while there are discussions, this can only be addressed when CloudStack will have GPU

Re: [PR] Fix unit test failure in LibvirtConvertInstanceCommandWrapperTest [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9238: URL: https://github.com/apache/cloudstack/pull/9238#issuecomment-2164805331 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] server: event for HA vm start [cloudstack]

2024-06-13 Thread via GitHub
shwstppr commented on PR #9202: URL: https://github.com/apache/cloudstack/pull/9202#issuecomment-2164808690 @DaanHoogland separate methods are called allow publishing of events of different types. Initially, I did the same. Other way to allow publishing of correct events could be manually

Re: [PR] server: event for HA vm start [cloudstack]

2024-06-13 Thread via GitHub
shwstppr commented on PR #9202: URL: https://github.com/apache/cloudstack/pull/9202#issuecomment-2164809768 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] ui: fix dashboard retrievals based on permissions [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud commented on PR #9237: URL: https://github.com/apache/cloudstack/pull/9237#issuecomment-2164812199 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] ui: fix dashboard retrievals based on permissions [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9237: URL: https://github.com/apache/cloudstack/pull/9237#issuecomment-2164812882 @rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Fix unit test failure in LibvirtConvertInstanceCommandWrapperTest [cloudstack]

2024-06-13 Thread via GitHub
codecov[bot] commented on PR #9238: URL: https://github.com/apache/cloudstack/pull/9238#issuecomment-2164816382 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9238?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] server: event for HA vm start [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9202: URL: https://github.com/apache/cloudstack/pull/9202#issuecomment-2164812940 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] kvm: Present the UUID of the VM as serial through smbios information [cloudstack]

2024-06-13 Thread via GitHub
codecov[bot] commented on PR #9236: URL: https://github.com/apache/cloudstack/pull/9236#issuecomment-2164813714 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9236?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] ui: fix dashboard retrievals based on permissions [cloudstack]

2024-06-13 Thread via GitHub
codecov[bot] commented on PR #9237: URL: https://github.com/apache/cloudstack/pull/9237#issuecomment-2164828502 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9237?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2164831630 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9914 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[PR] Fix snapshot deletion on template creation failure [cloudstack]

2024-06-13 Thread via GitHub
harikrishna-patnala opened a new pull request, #9239: URL: https://github.com/apache/cloudstack/pull/9239 ### Description This PR addresses an issue as part of #8946 The issue I've observed is not while taking the snapshot but while creating the template from the snapshot (sta

Re: [PR] kvm: Present the UUID of the VM as serial through smbios information [cloudstack]

2024-06-13 Thread via GitHub
wido commented on PR #9236: URL: https://github.com/apache/cloudstack/pull/9236#issuecomment-2164854857 > @wido code lgtm > > I am curious what the serial number would be . Same as uuid or other string ? It will be the UUID presented as the serialnumber -- This is an automat

(cloudstack) branch 4.19 updated (517cddcb15c -> 2fef0a32bc8)

2024-06-13 Thread kiranchavala
This is an automated email from the ASF dual-hosted git repository. kiranchavala pushed a change to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 517cddcb15c Fix error message if specific host does not have capacity (#9218) add 2fef0a32bc8 cks: fix l

Re: [PR] cks: fix list apis response count [cloudstack]

2024-06-13 Thread via GitHub
kiranchavala merged PR #8701: URL: https://github.com/apache/cloudstack/pull/8701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

Re: [I] Failed Volume Snapshot shows State as BackedUp [cloudstack]

2024-06-13 Thread via GitHub
harikrishna-patnala commented on issue #8946: URL: https://github.com/apache/cloudstack/issues/8946#issuecomment-2164862435 @nischalnischal2020 please check the newly created PR #9239 to address an issue which I've observed while checking your issue here. The issue I've observed is no

Re: [PR] ui: fix dashboard retrievals based on permissions [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9237: URL: https://github.com/apache/cloudstack/pull/9237#issuecomment-2164863932 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9237 (QA-JID-375) -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] linstor: Support VM-Instance Disk snapshots [cloudstack]

2024-06-13 Thread via GitHub
sureshanaparti commented on PR #8796: URL: https://github.com/apache/cloudstack/pull/8796#issuecomment-2164863966 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Fix snapshot deletion on template creation failure [cloudstack]

2024-06-13 Thread via GitHub
harikrishna-patnala commented on PR #9239: URL: https://github.com/apache/cloudstack/pull/9239#issuecomment-2164864618 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] linstor: Support VM-Instance Disk snapshots [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #8796: URL: https://github.com/apache/cloudstack/pull/8796#issuecomment-2164865134 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] Fix snapshot deletion on template creation failure [cloudstack]

2024-06-13 Thread via GitHub
harikrishna-patnala commented on PR #9239: URL: https://github.com/apache/cloudstack/pull/9239#issuecomment-2164869141 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] linstor: ui show Server and resource-group fields with custom protocol [cloudstack]

2024-06-13 Thread via GitHub
sureshanaparti commented on PR #9138: URL: https://github.com/apache/cloudstack/pull/9138#issuecomment-2164872836 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

2024-06-13 Thread via GitHub
harikrishna-patnala commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2164874285 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] linstor: ui show Server and resource-group fields with custom protocol [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9138: URL: https://github.com/apache/cloudstack/pull/9138#issuecomment-2164874059 @sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respo

Re: [PR] Fix snapshot deletion on template creation failure [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9239: URL: https://github.com/apache/cloudstack/pull/9239#issuecomment-2164874139 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make p

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2164881899 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make p

Re: [PR] server: simplify role change validation [cloudstack]

2024-06-13 Thread via GitHub
shwstppr commented on PR #9173: URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2164885064 @DaanHoogland @rohityadavcloud Thanks for the review but I'm not sure if we agree on the behaviour which is why this is still in draft. I will try to summarise impact of this chang

Re: [PR] Fix snapshot deletion on template creation failure [cloudstack]

2024-06-13 Thread via GitHub
codecov[bot] commented on PR #9239: URL: https://github.com/apache/cloudstack/pull/9239#issuecomment-2164891779 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [I] Public - IP's cannot add firewall rules with static nat with guest VM [cloudstack]

2024-06-13 Thread via GitHub
weizhouapache commented on issue #8816: URL: https://github.com/apache/cloudstack/issues/8816#issuecomment-2164899951 there is a new feature request: #8863 if you are interested, please keep an eye on it -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [I] Creating Guest Network: unable to choose Network Offering. This for all L2,Shared and Isolated networks [cloudstack]

2024-06-13 Thread via GitHub
weizhouapache commented on issue #9193: URL: https://github.com/apache/cloudstack/issues/9193#issuecomment-2164915812 > If I specify the zone id then I am not seeing the offerings but if I don't, then I can. ![cmk-list](https://private-user-images.githubusercontent.com/11226482/339243280-fa

Re: [PR] engine-orchestration: expunge destroyed system vm volume [cloudstack]

2024-06-13 Thread via GitHub
DaanHoogland merged PR #9197: URL: https://github.com/apache/cloudstack/pull/9197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

(cloudstack) branch 4.19 updated: engine-orchestration: expunge destroyed system vm volume (#9197)

2024-06-13 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.19 by this push: new abbc61c01ec engine-orchestration: expunge destroye

Re: [I] System vm's volumes should be expunged when a primary storage is set in Maintenance Mode [cloudstack]

2024-06-13 Thread via GitHub
DaanHoogland closed issue #8450: System vm's volumes should be expunged when a primary storage is set in Maintenance Mode URL: https://github.com/apache/cloudstack/issues/8450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] System vm's volumes should be expunged when a primary storage is set in Maintenance Mode [cloudstack]

2024-06-13 Thread via GitHub
DaanHoogland commented on issue #8450: URL: https://github.com/apache/cloudstack/issues/8450#issuecomment-2164919684 fixed by #9197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] linstor: ui show Server and resource-group fields with custom protocol [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9138: URL: https://github.com/apache/cloudstack/pull/9138#issuecomment-2164921848 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9138 (QA-JID-376) -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] cks: fix events [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9070: URL: https://github.com/apache/cloudstack/pull/9070#issuecomment-2164940137 [SF] Trillian test result (tid-10426) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43413 seconds Marvin logs: https://github.co

Re: [PR] server: event for HA vm start [cloudstack]

2024-06-13 Thread via GitHub
DaanHoogland commented on PR #9202: URL: https://github.com/apache/cloudstack/pull/9202#issuecomment-2164942867 > @DaanHoogland separate methods are called allow publishing of events of different types. Initially, I did the same. Other way to allow publishing of correct events could be manu

Re: [PR] server: event for HA vm start [cloudstack]

2024-06-13 Thread via GitHub
shwstppr commented on PR #9202: URL: https://github.com/apache/cloudstack/pull/9202#issuecomment-2164951242 oh. I thought you meant using a single method. That can be changed. I based the on the existing methods in the service, eg: https://github.com/apache/cloudstack/pull/9202/files#diff-9

Re: [I] Race condition when automatically assigning IPs to VMs [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud commented on issue #7907: URL: https://github.com/apache/cloudstack/issues/7907#issuecomment-2164968776 It seems we may have two PRs for this @sureshanaparti @DaanHoogland @weizhouapache @abh1sar and others -- This is an automated message from the Apache Git Service. To r

(cloudstack) branch 4.19 updated: ui: fix dashboard retrievals based on permissions (#9237)

2024-06-13 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.19 by this push: new 19e9020c9bb ui: fix dashboard retrievals based on

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2164993799 Requesting re-review as code has changed a bit @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [I] Race condition when automatically assigning IPs to VMs [cloudstack]

2024-06-13 Thread via GitHub
DaanHoogland commented on issue #7907: URL: https://github.com/apache/cloudstack/issues/7907#issuecomment-2164996879 > It seems we may have two PRs for this @sureshanaparti @DaanHoogland @weizhouapache @abh1sar and others I see only @abh1sar 's @rohityadavcloud . Can you point out the

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2164998307 @rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. T

Re: [PR] server: event for HA vm start [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9202: URL: https://github.com/apache/cloudstack/pull/9202#issuecomment-2165000218 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9917 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] protect against missing service offering [cloudstack]

2024-06-13 Thread via GitHub
vladimirpetrov commented on PR #9235: URL: https://github.com/apache/cloudstack/pull/9235#issuecomment-2165009059 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [I] Ui improvements to OAuth Configuration [cloudstack]

2024-06-13 Thread via GitHub
abh1sar commented on issue #8501: URL: https://github.com/apache/cloudstack/issues/8501#issuecomment-2165010999 Confirmed with Kiran that Issue 2 might not be a valid issue. So will provide the fix for Issue 1 only. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] protect against missing service offering [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9235: URL: https://github.com/apache/cloudstack/pull/9235#issuecomment-2165011428 @vladimirpetrov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] server: simplify role change validation [cloudstack]

2024-06-13 Thread via GitHub
shwstppr commented on PR #9173: URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2165011801 > > I would expect a Domain Admin to promote a user up to their own level. > I feel this shouldn't be allowed. It should be done by account with higher privileges, ROOT

[PR] Add action button to enable/disable Oauth provider [cloudstack]

2024-06-13 Thread via GitHub
abh1sar opened a new pull request, #9242: URL: https://github.com/apache/cloudstack/pull/9242 ### Description Fixes: https://github.com/apache/cloudstack/issues/8501 This PR fixes Issue 1 of https://github.com/apache/cloudstack/issues/8501

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2165029016 My 2-cents - we shouldn't break the design; migration to any storage shouldn't break linked-clone VMs. Nor any templates should be allowed to be removed which has any VMs (or V

[PR] vmware: do not tear down vm disks if deploy-as-is vm has vm snapshots [cloudstack]

2024-06-13 Thread via GitHub
weizhouapache opened a new pull request, #9243: URL: https://github.com/apache/cloudstack/pull/9243 ### Description This PR fixes #9180 ### Types of changes - [ ] Breaking change (fix or feature that would cause exi

Re: [PR] assertion improvement on cluster DRS [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2165049590 [SF] Trillian test result (tid-10422) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a9 Total time taken: 65623 seconds Marvin logs: https://github.c

[PR] test: fix test/integration/smoke/test_register_userdata.py which caused networks not to be deleted [cloudstack]

2024-06-13 Thread via GitHub
weizhouapache opened a new pull request, #9244: URL: https://github.com/apache/cloudstack/pull/9244 ### Description This PR fixes part of #8586 by moving the test under new domain/account instead of ROOT account

Re: [I] Dashboard items are shown even when permission set to Deny [cloudstack]

2024-06-13 Thread via GitHub
DaanHoogland closed issue #9233: Dashboard items are shown even when permission set to Deny URL: https://github.com/apache/cloudstack/issues/9233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] ui: fix dashboard retrievals based on permissions [cloudstack]

2024-06-13 Thread via GitHub
DaanHoogland merged PR #9237: URL: https://github.com/apache/cloudstack/pull/9237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[I] Users have the permission to create featured templates [cloudstack]

2024-06-13 Thread via GitHub
TadiosAbebe opened a new issue, #9241: URL: https://github.com/apache/cloudstack/issues/9241 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ Template ~~~ # CLOUDSTACK VERSION ~~~ 4.19 ~~~ # CONFIGURATION

Re: [I] Dashboard items are shown even when permission set to Deny [cloudstack]

2024-06-13 Thread via GitHub
DaanHoogland commented on issue #9233: URL: https://github.com/apache/cloudstack/issues/9233#issuecomment-2164973654 fixed in #9237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [I] Users have the permission to create featured templates [cloudstack]

2024-06-13 Thread via GitHub
boring-cyborg[bot] commented on issue #9241: URL: https://github.com/apache/cloudstack/issues/9241#issuecomment-2164978229 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Fix for race when automatically assigning IP to Vms [cloudstack]

2024-06-13 Thread via GitHub
codecov[bot] commented on PR #9240: URL: https://github.com/apache/cloudstack/pull/9240#issuecomment-2164981893 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9240?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] server: simplify role change validation [cloudstack]

2024-06-13 Thread via GitHub
DaanHoogland commented on PR #9173: URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2164985302 Thanks @shwstppr > * Domain-admins (if allowed based on API permission) can promote or demote an account to roles lower than domain-admin level. _They won't be able to make

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2164992200 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9915 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] server: event for HA vm start [cloudstack]

2024-06-13 Thread via GitHub
DaanHoogland commented on PR #9202: URL: https://github.com/apache/cloudstack/pull/9202#issuecomment-2164993834 > oh. I thought you meant using a single method. That can be changed. I based the on the existing methods in the service, eg: https://github.com/apache/cloudstack/pull/9202/files#

Re: [PR] Fix unit test failure in LibvirtConvertInstanceCommandWrapperTest [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9238: URL: https://github.com/apache/cloudstack/pull/9238#issuecomment-2165000219 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9916 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] linstor: Support VM-Instance Disk snapshots [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #8796: URL: https://github.com/apache/cloudstack/pull/8796#issuecomment-2165004227 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9918 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

(cloudstack) branch main updated: fix build error LibvirtGetVolumeStatCommandWrapper

2024-06-13 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new cb48202b348 fix build error LibvirtGetVolumeSta

Re: [PR] Add action button to enable/disable Oauth provider [cloudstack]

2024-06-13 Thread via GitHub
codecov[bot] commented on PR #9242: URL: https://github.com/apache/cloudstack/pull/9242#issuecomment-2165037043 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9242?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] Fix for race when automatically assigning IP to Vms [cloudstack]

2024-06-13 Thread via GitHub
abh1sar opened a new pull request, #9240: URL: https://github.com/apache/cloudstack/pull/9240 ### Description Fixes https://github.com/apache/cloudstack/issues/7907 This PR fixes the issue where two VMs can be assigned the same IP if they are created at the same time. `Netwo

Re: [PR] vmware: do not tear down vm disks if deploy-as-is vm has vm snapshots [cloudstack]

2024-06-13 Thread via GitHub
weizhouapache commented on PR #9243: URL: https://github.com/apache/cloudstack/pull/9243#issuecomment-2165049190 @nvazquez @harikrishna-patnala I have no idea why the data disks are tear down when start a deploy-as-is vm. Anyway, this change seems to be working. -- This is an au

Re: [PR] vmware: do not tear down vm disks if deploy-as-is vm has vm snapshots [cloudstack]

2024-06-13 Thread via GitHub
weizhouapache commented on PR #9243: URL: https://github.com/apache/cloudstack/pull/9243#issuecomment-2165046874 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] test: fix test/integration/smoke/test_register_userdata.py which caused networks not to be deleted [cloudstack]

2024-06-13 Thread via GitHub
weizhouapache commented on PR #9244: URL: https://github.com/apache/cloudstack/pull/9244#issuecomment-2165061451 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] test: fix test/integration/smoke/test_register_userdata.py which caused networks not to be deleted [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9244: URL: https://github.com/apache/cloudstack/pull/9244#issuecomment-2165063327 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

Re: [PR] vmware: do not tear down vm disks if deploy-as-is vm has vm snapshots [cloudstack]

2024-06-13 Thread via GitHub
codecov[bot] commented on PR #9243: URL: https://github.com/apache/cloudstack/pull/9243#issuecomment-2165064446 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9243?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] server: event for HA vm start [cloudstack]

2024-06-13 Thread via GitHub
shwstppr commented on PR #9202: URL: https://github.com/apache/cloudstack/pull/9202#issuecomment-2165069877 yes, currently it won't benefit. Will try to explore a generic interface like BaseVmManager in the coming weeks -- This is an automated message from the Apache Git Service. To respo

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2165068663 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9920 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

  1   2   3   4   >