harikrishna-patnala opened a new pull request, #9239: URL: https://github.com/apache/cloudstack/pull/9239
### Description This PR addresses an issue as part of #8946 The issue I've observed is not while taking the snapshot but while creating the template from the snapshot (stack trace also refers the same). I could not reproduce the original issue of failed snapshot showing as backedup state rather than error (it might have already fixed after 4.17.2), but I saw another serious issue. The issue is whenever a snapshot is used to create a template or volume and if there is failure in backing up the snapshot to the secondary store and as part of handling that failure MS is deleting the snapshot in primary storage itself. 1. Create a snapshot of a volume (set snapshot.backup.to.secondary = False) 2. Create a template from that snapshot 3. As part of the creation, MS first tries to backup the snapshot to the secondary storage 4. I've made it fail 5. MS recognized the failure and as part of failure it is deleting the snapshot on the primary storage (also marking the snapshot_store_ref entry for primary store role as "Destroyed") Here in this PR, the fix is to handle this case of not deleting the snapshot on primary storage. <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] build/CI #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> First lets check the successful scenario 1. Create a snapshot of a volume (set snapshot.backup.to.secondary = False) 2. Create a template from that snapshot 3. As part of the creation, MS first tries to backup the snapshot to the secondary storage 4. One new entry in the snapshot_store_ref table will be seen for store_role "Image" in "creating" state 5. After the successful creation of template, this entry will be deleted. Now the failure scenario 1. Create a snapshot of a volume (set snapshot.backup.to.secondary = False) 2. Create a template from that snapshot 3. As part of the creation, MS first tries to backup the snapshot to the secondary storage 4. One new entry in the snapshot_store_ref table will be seen for store_role "Image" in "creating" state 5. Make the backup operation fail (I've played with the debugger to fail the operation) 6. Observe the snapshot_store_ref table, this entry will be deleted and also keeps the existing entry for store_role "Primary" as "Ready" state. (Previously this row was marked as "Destroyed") -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
