[GitHub] [cloudstack] blueorangutan commented on pull request #4362: Match template tags with host tag for vm deployment

blueorangutan commented on pull request #4362: URL: https://github.com/apache/cloudstack/pull/4362#issuecomment-902478606 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack] kricud commented on issue #5347: Cannot delete volume in Destroy state not attached to Instance

kricud commented on issue #5347: URL: https://github.com/apache/cloudstack/issues/5347#issuecomment-902479007 @weizhouapache no There as some dinosaurs in list from 2014/15 ![Screenshot 2021-08-20 095808](https://user-images.githubusercontent.com/30048481/130193293-2b20c094-a29d-4470-

[GitHub] [cloudstack] weizhouapache commented on issue #5347: Cannot delete volume in Destroy state not attached to Instance

weizhouapache commented on issue #5347: URL: https://github.com/apache/cloudstack/issues/5347#issuecomment-902487335 @kricud this looks like not normal states. are you able to find some logs when the vms (for example id=30613) were destroyed ? we can fix the bug in future rele

[GitHub] [cloudstack] Pearl1594 commented on pull request #5337: Bypass empty string check for username and password

Pearl1594 commented on pull request #5337: URL: https://github.com/apache/cloudstack/pull/5337#issuecomment-902488378 > > We could do that @weizhouapache - However, my understanding is, if a null / empty uname / password is provided as part of any API args - the corresponding APIs logic wo

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4646: Add global settings for VM migration flags

DaanHoogland commented on a change in pull request #4646: URL: https://github.com/apache/cloudstack/pull/4646#discussion_r692728307 ## File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java ## @@ -422,6 +426,13 @@ "Indica

[GitHub] [cloudstack] blueorangutan commented on pull request #5157: UI: Support to upload resource icons

blueorangutan commented on pull request #5157: URL: https://github.com/apache/cloudstack/pull/5157#issuecomment-902493734 Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 943 -- This is an automated message

[GitHub] [cloudstack] DaanHoogland commented on pull request #3804: Display capability info in listNetwork response

DaanHoogland commented on pull request #3804: URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-902494217 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response

blueorangutan commented on pull request #3804: URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-902494645 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack] DaanHoogland commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks

DaanHoogland commented on pull request #4741: URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-902498232 @shwstppr are you satisfied with this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4646: Add global settings for VM migration flags

weizhouapache commented on a change in pull request #4646: URL: https://github.com/apache/cloudstack/pull/4646#discussion_r692737718 ## File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java ## @@ -422,6 +426,13 @@ "Indic

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #1257: [VMware DRS] Adding new host to DRS cluster does not participate in load balancing.

DaanHoogland commented on a change in pull request #1257: URL: https://github.com/apache/cloudstack/pull/1257#discussion_r692738225 ## File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HostMO.java ## @@ -1156,6 +1194,41 @@ public String getNetworkName(String n

[GitHub] [cloudstack] blueorangutan commented on pull request #4362: Match template tags with host tag for vm deployment

blueorangutan commented on pull request #4362: URL: https://github.com/apache/cloudstack/pull/4362#issuecomment-902501716 Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 946 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #4259: Reserve memory for host

blueorangutan commented on pull request #4259: URL: https://github.com/apache/cloudstack/pull/4259#issuecomment-902501715 Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 945 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #5201: [HEALTH] 4.16 Health Checks - Please don't merge

blueorangutan commented on pull request #5201: URL: https://github.com/apache/cloudstack/pull/5201#issuecomment-902501714 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 944 -- This is an automated message from t

[GitHub] [cloudstack] DaanHoogland commented on issue #4902: Destroy VM should detach the volumes from VM and recover VM should not try to attach the volumes again

DaanHoogland commented on issue #4902: URL: https://github.com/apache/cloudstack/issues/4902#issuecomment-902504878 Agree with everybody, or at least @PaulAngus , @weizhouapache and @nvazquez in their discussion above. @nvazquez you trigger a bit of a 'bear on the road'; if multiple `ROOT

[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response

blueorangutan commented on pull request #3804: URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-902509880 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 947 -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] DaanHoogland commented on pull request #4200: Allow domain admins to create offering without mentioning domainid

DaanHoogland commented on pull request #4200: URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-902513544 @weizhouapache clear except, > @rhtyd See my reply inline: > > > @DaanHoogland I suppose either some arguments to answer the concerns - security or billing

[GitHub] [cloudstack] DaanHoogland commented on pull request #5324: Improve Travis CI build Performance

DaanHoogland commented on pull request #5324: URL: https://github.com/apache/cloudstack/pull/5324#issuecomment-902515110 I think https://app.travis-ci.com/github/apache/cloudstack/jobs/532528584 proves @rhtyd 's point @YunLemon . See the last line in the output. -- This is an automated m

[GitHub] [cloudstack] weizhouapache opened a new pull request #5348: security group: fix component test test_multiple_nic_support.py failures

weizhouapache opened a new pull request #5348: URL: https://github.com/apache/cloudstack/pull/5348 ### Description This PR fixes component test failure with test_multiple_nic_support.py, in advanced zone with security groups.

[GitHub] [cloudstack] weizhouapache commented on pull request #5201: [HEALTH] 4.16 Health Checks - Please don't merge

weizhouapache commented on pull request #5201: URL: https://github.com/apache/cloudstack/pull/5201#issuecomment-902518292 @blueorangutan test suse15 kvm-suse15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [cloudstack] DaanHoogland commented on pull request #5341: remove doubles before save

DaanHoogland commented on pull request #5341: URL: https://github.com/apache/cloudstack/pull/5341#issuecomment-902518454 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [cloudstack] blueorangutan commented on pull request #5201: [HEALTH] 4.16 Health Checks - Please don't merge

blueorangutan commented on pull request #5201: URL: https://github.com/apache/cloudstack/pull/5201#issuecomment-902519059 @weizhouapache a Trillian-Jenkins test job (suse15 mgmt + kvm-suse15) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] shwstppr commented on pull request #5307: Filter disk / service offerings by domain at DB level

shwstppr commented on pull request #5307: URL: https://github.com/apache/cloudstack/pull/5307#issuecomment-902519244 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] blueorangutan commented on pull request #5341: remove doubles before save

blueorangutan commented on pull request #5341: URL: https://github.com/apache/cloudstack/pull/5341#issuecomment-902519044 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #5307: Filter disk / service offerings by domain at DB level

blueorangutan commented on pull request #5307: URL: https://github.com/apache/cloudstack/pull/5307#issuecomment-902519653 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5216: Support for new Feature: Clone a Virtual Machine (#4818)

DaanHoogland commented on a change in pull request #5216: URL: https://github.com/apache/cloudstack/pull/5216#discussion_r692764573 ## File path: api/src/main/java/com/cloud/storage/Snapshot.java ## @@ -26,7 +26,7 @@ public interface Snapshot extends ControlledEntity, Identi

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5216: Support for new Feature: Clone a Virtual Machine (#4818)

DaanHoogland commented on a change in pull request #5216: URL: https://github.com/apache/cloudstack/pull/5216#discussion_r692765756 ## File path: api/src/main/java/org/apache/cloudstack/api/command/user/vm/CloneVMCmd.java ## @@ -0,0 +1,169 @@ +package org.apache.cloudstack.api

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5216: Support for new Feature: Clone a Virtual Machine (#4818)

DaanHoogland commented on a change in pull request #5216: URL: https://github.com/apache/cloudstack/pull/5216#discussion_r692766471 ## File path: api/src/main/java/org/apache/cloudstack/api/command/user/vm/CloneVMCmd.java ## @@ -0,0 +1,193 @@ +package org.apache.cloudstack.api

[GitHub] [cloudstack] rhtyd commented on issue #3025: VPC Router Corruption when working with large number of networks containing instances with public IP addresses

rhtyd commented on issue #3025: URL: https://github.com/apache/cloudstack/issues/3025#issuecomment-902528313 @weizhouapache out of curiousity, did you try reproducing this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5216: Support for new Feature: Clone a Virtual Machine (#4818)

DaanHoogland commented on a change in pull request #5216: URL: https://github.com/apache/cloudstack/pull/5216#discussion_r692766471 ## File path: api/src/main/java/org/apache/cloudstack/api/command/user/vm/CloneVMCmd.java ## @@ -0,0 +1,193 @@ +package org.apache.cloudstack.api

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5216: Support for new Feature: Clone a Virtual Machine (#4818)

DaanHoogland commented on a change in pull request #5216: URL: https://github.com/apache/cloudstack/pull/5216#discussion_r692770925 ## File path: api/src/main/java/org/apache/cloudstack/api/command/user/vm/CloneVMCmd.java ## @@ -0,0 +1,193 @@ +package org.apache.cloudstack.api

[GitHub] [cloudstack] blueorangutan commented on pull request #5307: Filter disk / service offerings by domain at DB level

blueorangutan commented on pull request #5307: URL: https://github.com/apache/cloudstack/pull/5307#issuecomment-902534944 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 948 -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] weizhouapache commented on pull request #5348: security group: fix component test test_multiple_nic_support.py failures

weizhouapache commented on pull request #5348: URL: https://github.com/apache/cloudstack/pull/5348#issuecomment-902535772 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack] blueorangutan commented on pull request #5348: security group: fix component test test_multiple_nic_support.py failures

blueorangutan commented on pull request #5348: URL: https://github.com/apache/cloudstack/pull/5348#issuecomment-902535976 @weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] davidjumani commented on pull request #5307: Filter disk / service offerings by domain at DB level

davidjumani commented on pull request #5307: URL: https://github.com/apache/cloudstack/pull/5307#issuecomment-902537576 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #5307: Filter disk / service offerings by domain at DB level

blueorangutan commented on pull request #5307: URL: https://github.com/apache/cloudstack/pull/5307#issuecomment-902537701 @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] weizhouapache commented on pull request #4200: Allow domain admins to create offering without mentioning domainid

weizhouapache commented on pull request #4200: URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-902538321 > @weizhouapache clear except, > > > @rhtyd See my reply inline: > > > @DaanHoogland I suppose either some arguments to answer the concerns - security or billi

[GitHub] [cloudstack] davidjumani commented on pull request #5307: Filter disk / service offerings by domain at DB level

davidjumani commented on pull request #5307: URL: https://github.com/apache/cloudstack/pull/5307#issuecomment-902539890 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #5307: Filter disk / service offerings by domain at DB level

blueorangutan commented on pull request #5307: URL: https://github.com/apache/cloudstack/pull/5307#issuecomment-902540025 @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5216: Support for new Feature: Clone a Virtual Machine (#4818)

DaanHoogland commented on a change in pull request #5216: URL: https://github.com/apache/cloudstack/pull/5216#discussion_r692775212 ## File path: test/integration/smoke/test_vm_life_cycle.py ## @@ -1991,3 +1990,135 @@ def test_01_vapps_vm_cycle(self): cmd = destroy

[GitHub] [cloudstack] PaulAngus commented on pull request #4200: Allow domain admins to create offering without mentioning domainid

PaulAngus commented on pull request #4200: URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-902543977 What is the scope of this PR? the conversation seems to have moved in multiple directions. It seems like this should be separate threads, probably of separate PRs. +

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5216: Support for new Feature: Clone a Virtual Machine (#4818)

DaanHoogland commented on a change in pull request #5216: URL: https://github.com/apache/cloudstack/pull/5216#discussion_r692788328 ## File path: test/integration/smoke/test_vm_life_cycle.py ## @@ -631,7 +631,7 @@ def test_08_migrate_vm(self): if self.hypervisor.lower(

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5216: Support for new Feature: Clone a Virtual Machine (#4818)

DaanHoogland commented on a change in pull request #5216: URL: https://github.com/apache/cloudstack/pull/5216#discussion_r692788940 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -49,7 +50,53 @@ import javax.xml.parsers.DocumentBuilder; import ja

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5216: Support for new Feature: Clone a Virtual Machine (#4818)

DaanHoogland commented on a change in pull request #5216: URL: https://github.com/apache/cloudstack/pull/5216#discussion_r692791458 ## File path: api/src/main/java/org/apache/cloudstack/api/command/user/vm/CloneVMCmd.java ## @@ -0,0 +1,193 @@ +package org.apache.cloudstack.api

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5216: Support for new Feature: Clone a Virtual Machine (#4818)

DaanHoogland commented on a change in pull request #5216: URL: https://github.com/apache/cloudstack/pull/5216#discussion_r692791800 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -4509,6 +4518,245 @@ protected String validateUserData(String userDat

[GitHub] [cloudstack] vladimirpetrov commented on pull request #5157: UI: Support to upload resource icons

vladimirpetrov commented on pull request #5157: URL: https://github.com/apache/cloudstack/pull/5157#issuecomment-902550470 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5216: Support for new Feature: Clone a Virtual Machine (#4818)

DaanHoogland commented on a change in pull request #5216: URL: https://github.com/apache/cloudstack/pull/5216#discussion_r692792394 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -5494,6 +5742,82 @@ public UserVm createVirtualMachine(DeployVMCmd cm

[GitHub] [cloudstack] blueorangutan commented on pull request #5157: UI: Support to upload resource icons

blueorangutan commented on pull request #5157: URL: https://github.com/apache/cloudstack/pull/5157#issuecomment-902551319 @vladimirpetrov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Servic

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5216: Support for new Feature: Clone a Virtual Machine (#4818)

DaanHoogland commented on a change in pull request #5216: URL: https://github.com/apache/cloudstack/pull/5216#discussion_r692793605 ## File path: server/src/main/java/com/cloud/template/TemplateManagerImpl.java ## @@ -1742,6 +1744,272 @@ public void doInTransactionWithoutResul

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5216: Support for new Feature: Clone a Virtual Machine (#4818)

DaanHoogland commented on a change in pull request #5216: URL: https://github.com/apache/cloudstack/pull/5216#discussion_r692794263 ## File path: server/src/main/java/com/cloud/template/TemplateManagerImpl.java ## @@ -1742,6 +1744,272 @@ public void doInTransactionWithoutResul

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5216: Support for new Feature: Clone a Virtual Machine (#4818)

DaanHoogland commented on a change in pull request #5216: URL: https://github.com/apache/cloudstack/pull/5216#discussion_r692794577 ## File path: server/src/main/java/com/cloud/template/TemplateManagerImpl.java ## @@ -1742,6 +1744,272 @@ public void doInTransactionWithoutResul

[GitHub] [cloudstack] weizhouapache commented on issue #3025: VPC Router Corruption when working with large number of networks containing instances with public IP addresses

weizhouapache commented on issue #3025: URL: https://github.com/apache/cloudstack/issues/3025#issuecomment-902553875 @rhtyd no. I wrote 4 component tests in pr #4484 which cover many cases and verify their expected results. The cases are more complicated than what @dubauski desc

[GitHub] [cloudstack] DaanHoogland commented on pull request #5216: Support for new Feature: Clone a Virtual Machine (#4818)

DaanHoogland commented on pull request #5216: URL: https://github.com/apache/cloudstack/pull/5216#issuecomment-902555234 @atrocitytheme I like the premise and most of your implementation. Two worries: 1. your methods in `SnapshotManagerImpl` and in `UserVmManagerImpl` are rather long, C

[GitHub] [cloudstack] DaanHoogland commented on pull request #4878: Support vm dynamic scaling with kvm

DaanHoogland commented on pull request #4878: URL: https://github.com/apache/cloudstack/pull/4878#issuecomment-902556566 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [cloudstack] blueorangutan commented on pull request #4878: Support vm dynamic scaling with kvm

blueorangutan commented on pull request #4878: URL: https://github.com/apache/cloudstack/pull/4878#issuecomment-902556963 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack] weizhouapache closed pull request #5319: vr: reload dnsmasq when start vms

weizhouapache closed pull request #5319: URL: https://github.com/apache/cloudstack/pull/5319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [cloudstack] blueorangutan commented on pull request #5348: security group: fix component test test_multiple_nic_support.py failures

blueorangutan commented on pull request #5348: URL: https://github.com/apache/cloudstack/pull/5348#issuecomment-902563023 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 949 -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5331: vr: cleanup files in /var/cache/cloud/processed every day

DaanHoogland commented on a change in pull request #5331: URL: https://github.com/apache/cloudstack/pull/5331#discussion_r692805836 ## File path: systemvm/debian/etc/cron.daily/clean_cloud_processed_files ## @@ -0,0 +1,22 @@ +#!/bin/bash Review comment: license header n

[GitHub] [cloudstack] weizhouapache commented on pull request #4200: Allow domain admins to create offering without mentioning domainid

weizhouapache commented on pull request #4200: URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-902567828 > What is the scope of this PR? the conversation seems to have moved in multiple directions. It seems like this should be separate threads, probably of separate PRs.

[GitHub] [cloudstack] weizhouapache commented on pull request #4200: Allow domain admins to create offering without mentioning domainid

weizhouapache commented on pull request #4200: URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-902568511 > Thanks for fixing the conflicts @ravening. > > ## Here are my two cents: > From what I understood, the main discussion has been due to confusion around the s

[GitHub] [cloudstack] blueorangutan commented on pull request #5307: Filter disk / service offerings by domain at DB level

blueorangutan commented on pull request #5307: URL: https://github.com/apache/cloudstack/pull/5307#issuecomment-902568675 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian. SL-JID 951 -- This is an automated message from the Apache Git Servic

[GitHub] [cloudstack] weizhouapache commented on pull request #5337: Bypass empty string check for username and password

weizhouapache commented on pull request #5337: URL: https://github.com/apache/cloudstack/pull/5337#issuecomment-902569198 @Pearl1594 should we check if username/password are null when hypervisor is not vmware ? -- This is an automated message from the Apache Git Service. To respon

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5337: Bypass empty string check for username and password

weizhouapache commented on a change in pull request #5337: URL: https://github.com/apache/cloudstack/pull/5337#discussion_r692813167 ## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/host/AddHostCmd.java ## @@ -54,7 +54,7 @@ @Parameter(name = ApiCons

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5331: vr: cleanup files in /var/cache/cloud/processed every day

weizhouapache commented on a change in pull request #5331: URL: https://github.com/apache/cloudstack/pull/5331#discussion_r692814069 ## File path: systemvm/debian/etc/cron.daily/clean_cloud_processed_files ## @@ -0,0 +1,22 @@ +#!/bin/bash Review comment: @DaanHoogland g

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5331: vr: cleanup files in /var/cache/cloud/processed every day

weizhouapache commented on a change in pull request #5331: URL: https://github.com/apache/cloudstack/pull/5331#discussion_r692815358 ## File path: systemvm/debian/etc/cron.daily/clean_cloud_processed_files ## @@ -0,0 +1,22 @@ +#!/bin/bash Review comment: @DaanHoogland d

[GitHub] [cloudstack] weizhouapache commented on pull request #5348: security group: fix component test test_multiple_nic_support.py failures

weizhouapache commented on pull request #5348: URL: https://github.com/apache/cloudstack/pull/5348#issuecomment-902572506 test with advanced zone is not needed actually. @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [cloudstack] blueorangutan commented on pull request #5348: security group: fix component test test_multiple_nic_support.py failures

blueorangutan commented on pull request #5348: URL: https://github.com/apache/cloudstack/pull/5348#issuecomment-902572793 @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service

[GitHub] [cloudstack] blueorangutan commented on pull request #4878: Support vm dynamic scaling with kvm

blueorangutan commented on pull request #4878: URL: https://github.com/apache/cloudstack/pull/4878#issuecomment-902577108 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 952 -- This is an automated message from t

[GitHub] [cloudstack] rhtyd commented on a change in pull request #5345: UI - VM - hide button take vm volume snapshot for Destroyed state

rhtyd commented on a change in pull request #5345: URL: https://github.com/apache/cloudstack/pull/5345#discussion_r692829677 ## File path: ui/src/config/section/compute.js ## @@ -181,6 +181,10 @@ export default { docHelp: 'adminguide/virtual_machines.html#virtual-ma

[GitHub] [cloudstack] rhtyd commented on issue #5235: Minimum required IP range for a single ZONE

rhtyd commented on issue #5235: URL: https://github.com/apache/cloudstack/issues/5235#issuecomment-902589850 @tampler the minimum public IP range to get CloudStack up and running depends on the type of the zone, and your use-cases/workloads. Only you can answer that. For a typical adv zone

[GitHub] [cloudstack] rhtyd commented on issue #5234: Choose between Public or VPN based IPs for KVM VMs

rhtyd commented on issue #5234: URL: https://github.com/apache/cloudstack/issues/5234#issuecomment-902592293 @tampler trying to access your user-VMs by their private IPs via OpenVPN on KVM host itself where VMs are running is breaking network isolation (assuming you're using VLANs and it i

[GitHub] [cloudstack] blueorangutan commented on pull request #5348: security group: fix component test test_multiple_nic_support.py failures

blueorangutan commented on pull request #5348: URL: https://github.com/apache/cloudstack/pull/5348#issuecomment-902598772 Trillian Build Failed (tid-1734) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack] Pearl1594 commented on pull request #5346: test: Fix travis failure - test_outofbandmanagement.py

Pearl1594 commented on pull request #5346: URL: https://github.com/apache/cloudstack/pull/5346#issuecomment-902599735 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [cloudstack] blueorangutan commented on pull request #5346: test: Fix travis failure - test_outofbandmanagement.py

blueorangutan commented on pull request #5346: URL: https://github.com/apache/cloudstack/pull/5346#issuecomment-902600092 @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] vladimirpetrov commented on pull request #5157: UI: Support to upload resource icons

vladimirpetrov commented on pull request #5157: URL: https://github.com/apache/cloudstack/pull/5157#issuecomment-902601734 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] PaulAngus commented on pull request #4200: Allow domain admins to create offering without mentioning domainid

PaulAngus commented on pull request #4200: URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-902601973 > there is another example, when create a shared network by root admin (networks are more important than service offerings, right ?), acltype and domain/account are optiona

[GitHub] [cloudstack] blueorangutan commented on pull request #5157: UI: Support to upload resource icons

blueorangutan commented on pull request #5157: URL: https://github.com/apache/cloudstack/pull/5157#issuecomment-902602113 @vladimirpetrov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4362: Match template tags with host tag for vm deployment

DaanHoogland commented on a change in pull request #4362: URL: https://github.com/apache/cloudstack/pull/4362#discussion_r692848847 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java ## @@ -3672,6 +3676,10 @@ else if (!template.isPublicTemplate() && c

[GitHub] [cloudstack] DaanHoogland commented on pull request #4259: Reserve memory for host

DaanHoogland commented on pull request #4259: URL: https://github.com/apache/cloudstack/pull/4259#issuecomment-902604652 not sure what happened , but both travis and blueorangutan fail to build @ravening -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [cloudstack] DaanHoogland commented on pull request #3804: Display capability info in listNetwork response

DaanHoogland commented on pull request #3804: URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-902604854 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response

blueorangutan commented on pull request #3804: URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-902604959 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] weizhouapache commented on pull request #4200: Allow domain admins to create offering without mentioning domainid

weizhouapache commented on pull request #4200: URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-902608970 > > there is another example, when create a shared network by root admin (networks are more important than service offerings, right ?), acltype and domain/account are o

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5307: Filter disk / service offerings by domain at DB level

DaanHoogland commented on a change in pull request #5307: URL: https://github.com/apache/cloudstack/pull/5307#discussion_r692853931 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java ## @@ -346,14 +345,17 @@ private DiskOfferingJoinDao _diskOfferi

[GitHub] [cloudstack] davidjumani commented on a change in pull request #5307: Filter disk / service offerings by domain at DB level

davidjumani commented on a change in pull request #5307: URL: https://github.com/apache/cloudstack/pull/5307#discussion_r692856802 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java ## @@ -346,14 +345,17 @@ private DiskOfferingJoinDao _diskOfferin

[GitHub] [cloudstack] DaanHoogland commented on pull request #4878: Support vm dynamic scaling with kvm

DaanHoogland commented on pull request #4878: URL: https://github.com/apache/cloudstack/pull/4878#issuecomment-902611837 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [cloudstack] blueorangutan commented on pull request #4878: Support vm dynamic scaling with kvm

blueorangutan commented on pull request #4878: URL: https://github.com/apache/cloudstack/pull/4878#issuecomment-902612005 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] DaanHoogland merged pull request #5346: test: Fix travis failure - test_outofbandmanagement.py

DaanHoogland merged pull request #5346: URL: https://github.com/apache/cloudstack/pull/5346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [cloudstack] rhtyd commented on pull request #5346: test: Fix travis failure - test_outofbandmanagement.py

rhtyd commented on pull request #5346: URL: https://github.com/apache/cloudstack/pull/5346#issuecomment-902612965 @Pearl1594 should this be ported to 4.15? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[cloudstack] branch main updated (ee01522 -> 25206e4)

This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from ee01522 Allow users to update volume name (#4618) add 25206e4 test: Frix travis failure - test_outofbandmanage

[GitHub] [cloudstack] rhtyd commented on pull request #5348: security group: fix component test test_multiple_nic_support.py failures

rhtyd commented on pull request #5348: URL: https://github.com/apache/cloudstack/pull/5348#issuecomment-902613645 Trillian does not run SG tests, we can merge based on Wei's test results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [cloudstack] DaanHoogland commented on pull request #4200: Allow domain admins to create offering without mentioning domainid

DaanHoogland commented on pull request #4200: URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-902615322 @PaulAngus @weizhouapache , as all other discussion is resolved I think that the way to go is to put this behind a global or domain setting, and let the operator decide.

[GitHub] [cloudstack] weizhouapache commented on pull request #5337: Bypass empty string check for username and password

weizhouapache commented on pull request #5337: URL: https://github.com/apache/cloudstack/pull/5337#issuecomment-902615666 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cloudstack] weizhouapache commented on pull request #5337: Bypass empty string check for username and password

weizhouapache commented on pull request #5337: URL: https://github.com/apache/cloudstack/pull/5337#issuecomment-902615869 @Pearl1594 @rhtyd should we fix it in 4.15.2.0 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [cloudstack] blueorangutan commented on pull request #5337: Bypass empty string check for username and password

blueorangutan commented on pull request #5337: URL: https://github.com/apache/cloudstack/pull/5337#issuecomment-902615875 @weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5307: Filter disk / service offerings by domain at DB level

DaanHoogland commented on a change in pull request #5307: URL: https://github.com/apache/cloudstack/pull/5307#discussion_r692863034 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java ## @@ -346,14 +345,17 @@ private DiskOfferingJoinDao _diskOfferi

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5348: security group: fix component test test_multiple_nic_support.py failures

DaanHoogland commented on a change in pull request #5348: URL: https://github.com/apache/cloudstack/pull/5348#discussion_r692864682 ## File path: test/integration/component/test_multiple_nic_support.py ## @@ -224,7 +224,7 @@ def setUpClass(cls): cls.virtual

[GitHub] [cloudstack] Pearl1594 commented on pull request #5346: test: Fix travis failure - test_outofbandmanagement.py

Pearl1594 commented on pull request #5346: URL: https://github.com/apache/cloudstack/pull/5346#issuecomment-902619952 This was an issue only on main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] Pearl1594 edited a comment on pull request #5346: test: Fix travis failure - test_outofbandmanagement.py

Pearl1594 edited a comment on pull request #5346: URL: https://github.com/apache/cloudstack/pull/5346#issuecomment-902619952 This was an issue only on main @rhtyd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [cloudstack] DaanHoogland commented on pull request #5348: security group: fix component test test_multiple_nic_support.py failures

DaanHoogland commented on pull request #5348: URL: https://github.com/apache/cloudstack/pull/5348#issuecomment-902620188 just to clarify @weizhouapache , I suppose you created a advanced zone with security groups and ran the test-file against that? kind of asking also to let you cons

[GitHub] [cloudstack] PaulAngus commented on pull request #4200: Allow domain admins to create offering without mentioning domainid

PaulAngus commented on pull request #4200: URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-902620414 > domain admin can only create service offering which are visible for accounts under his domain > limited impaction (in domain admin's domain v.s. whole platform)

  1   2   3   >