DaanHoogland commented on a change in pull request #5348:
URL: https://github.com/apache/cloudstack/pull/5348#discussion_r692864682



##########
File path: test/integration/component/test_multiple_nic_support.py
##########
@@ -224,7 +224,7 @@ def setUpClass(cls):
                     cls.virtual_machine1.default_network_id = nic.networkid
                     break
         except Exception as e:
-            cls.fail("Exception while deploying virtual machine: %s" % e)
+            cls.fail("Exception while deploying virtual machine: %s" % (e))

Review comment:
       ```suggestion
               cls.fail(f"Exception while deploying virtual machine: {e}")
   ```
   not necessary but nice ;)

##########
File path: test/integration/component/test_multiple_nic_support.py
##########
@@ -243,7 +243,7 @@ def setUpClass(cls):
                     cls.virtual_machine2.default_network_id = nic.networkid
                     break
         except Exception as e:
-            cls.fail("Exception while deploying virtual machine: %s" % e)
+            cls.fail("Exception while deploying virtual machine: %s" % (e))

Review comment:
       ```suggestion
               cls.fail(f"Exception while deploying virtual machine: {e}")
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to