[GitHub] [cloudstack] DaanHoogland commented on issue #3770: UI: JOB does not complete when you create a template from snapshot

2019-12-17 Thread GitBox
DaanHoogland commented on issue #3770: UI: JOB does not complete when you create a template from snapshot URL: https://github.com/apache/cloudstack/issues/3770#issuecomment-566433570 I think this is a more generic issue where jobs finish but the notification drop-down still shows them as r

[GitHub] [cloudstack] anuragaw commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-17 Thread GitBox
anuragaw commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-566434701 @blueorangutan package This is an autom

[GitHub] [cloudstack] blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-17 Thread GitBox
blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-566435017 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] borisstoyanov commented on issue #3769: README: that time of the year!

2019-12-17 Thread GitBox
borisstoyanov commented on issue #3769: README: that time of the year! URL: https://github.com/apache/cloudstack/pull/3769#issuecomment-566435272 +1! happy holidays guys, wish you all the best in the new year! This is an auto

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358658816 ## File path: ui/scripts/sharedFunctions.js ## @@ -1208,17 +1208,21 @@ cloudStack.validate = { cloudStack.preF

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358659837 ## File path: utils/src/main/java/com/cloud/utils/http/downloader/DirectTemplateDownloaderImpl.java ## @@ -0,0 +

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358659903 ## File path: utils/src/main/java/com/cloud/utils/http/downloader/HttpDirectTemplateDownloader.java ## @@ -0,0 +

[GitHub] [cloudstack] blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-17 Thread GitBox
blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-566441119 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-476 --

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358661101 ## File path: utils/src/main/java/com/cloud/utils/http/downloader/HttpDirectTemplateDownloader.java ## @@ -0,0 +

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358661913 ## File path: engine/schema/src/main/java/com/cloud/upgrade/OfficialSystemVMTemplate.java ## @@ -0,0 +1,101 @@ +

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358662497 ## File path: engine/storage/src/main/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java ##

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358663237 ## File path: server/src/main/java/com/cloud/storage/download/managementserver/system/SystemTemplateDownloader.java #

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358663003 ## File path: server/src/main/java/com/cloud/storage/download/managementserver/system/HttpSystemTemplateDownloader.java #

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358663124 ## File path: server/src/main/java/com/cloud/storage/download/managementserver/system/SystemTemplateDownloader.java #

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358665974 ## File path: server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java ## @@ -330,8 +345,8 @@ priv

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358666059 ## File path: server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java ## @@ -602,11 +617,13 @@ pu

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358665305 ## File path: server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java ## @@ -211,8 +219,14 @@ pri

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358664540 ## File path: server/src/main/java/com/cloud/storage/mount/NfsMountManager.java ## @@ -0,0 +1,203 @@ +// Licensed

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358665127 ## File path: server/src/main/java/com/cloud/storage/secondary/NfsMountCapacityChecker.java ## @@ -0,0 +1,69 @@

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358664607 ## File path: server/src/main/java/com/cloud/storage/secondary/CapacityChecker.java ## @@ -0,0 +1,35 @@ +// Lice

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358667589 ## File path: core/src/main/java/com/cloud/agent/api/routing/SetMonitorServiceCommand.java ###

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358676303 ## File path: plugins/ca/root-ca/pom.xml ## @@ -43,5 +43,10 @@ cloud-framework-ca ${pro

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358676582 ## File path: server/src/main/java/com/cloud/storage/mount/NfsMountManager.java ## @@ -0,0 +1,203 @@ +// Licensed

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358676757 ## File path: ui/config.js ## @@ -17,6 +17,7 @@ // Define custom options configurable by admins for UI cloudS

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358676673 ## File path: test/integration/smoke/test_templates.py ## @@ -1354,3 +1353,5 @@ def test_03_deploy_vm_wrong_check

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358677443 ## File path: api/src/main/java/org/apache/cloudstack/api/response/GetSystemVMTemplateDefaultURLResponse.java ##

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358677525 ## File path: api/src/main/java/org/apache/cloudstack/api/response/SeedSystemVMTemplateResponse.java ## @@ -0,0

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358677347 ## File path: api/src/main/java/org/apache/cloudstack/api/response/ActivateSystemVMTemplateResponse.java ## @@ -

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358679982 ## File path: core/src/main/java/com/cloud/agent/resource/virtualnetwork/facade/AbstractConfigI

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358682093 ## File path: core/src/main/java/com/cloud/agent/resource/virtualnetwork/VRScripts.java ##

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358682235 ## File path: core/src/main/java/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-17 Thread GitBox
DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#discussion_r358684873 ## File path: server/src/main/java/org/apache/cloudstack/diagnostics/Diagn

[GitHub] [cloudstack] GabrielBrascher merged pull request #3738: Load Average for KVM

2019-12-17 Thread GitBox
GabrielBrascher merged pull request #3738: Load Average for KVM URL: https://github.com/apache/cloudstack/pull/3738 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [cloudstack] GabrielBrascher commented on issue #3738: Load Average for KVM

2019-12-17 Thread GitBox
GabrielBrascher commented on issue #3738: Load Average for KVM URL: https://github.com/apache/cloudstack/pull/3738#issuecomment-566461477 Looking good to merge. Merging it considering that all checks have passed, we have 4 LGTMs, a couple of manual tests, and the packaging results are ok

[cloudstack] branch master updated (da62cec -> 2e8c069)

2019-12-17 Thread gabriel
This is an automated email from the ASF dual-hosted git repository. gabriel pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from da62cec README: that time of the year! 🎄 (#3769) add 2e8c069 Load Average for KVM (#3738) No new revisio

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358692438 ## File path: core/src/main/java/com/cloud/agent/resource/virtualnetwork/facade/AbstractCon

[GitHub] [cloudstack] Spaceman1984 commented on issue #3755: Added zone check for attach iso

2019-12-17 Thread GitBox
Spaceman1984 commented on issue #3755: Added zone check for attach iso URL: https://github.com/apache/cloudstack/pull/3755#issuecomment-566468616 Rebased to 4.13 This is an automated message from the Apache Git Service. To res

[GitHub] [cloudstack] blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-17 Thread GitBox
blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-566469270 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] anuragaw commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-17 Thread GitBox
anuragaw commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-566469035 @blueorangutan package This is an autom

[GitHub] [cloudstack] DaanHoogland commented on issue #3755: Added zone check for attach iso

2019-12-17 Thread GitBox
DaanHoogland commented on issue #3755: Added zone check for attach iso URL: https://github.com/apache/cloudstack/pull/3755#issuecomment-566470080 @blueorangutan package This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on issue #3755: Added zone check for attach iso

2019-12-17 Thread GitBox
blueorangutan commented on issue #3755: Added zone check for attach iso URL: https://github.com/apache/cloudstack/pull/3755#issuecomment-566470433 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack] Spaceman1984 commented on issue #3765: Promiscuous vm reject

2019-12-17 Thread GitBox
Spaceman1984 commented on issue #3765: Promiscuous vm reject URL: https://github.com/apache/cloudstack/pull/3765#issuecomment-566471730 Rebased to 4.13 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [cloudstack] DaanHoogland commented on issue #3765: Promiscuous vm reject

2019-12-17 Thread GitBox
DaanHoogland commented on issue #3765: Promiscuous vm reject URL: https://github.com/apache/cloudstack/pull/3765#issuecomment-566474674 @blueorangutan package This is an automated message from the Apache Git Service. To respon

[GitHub] [cloudstack] blueorangutan commented on issue #3765: Promiscuous vm reject

2019-12-17 Thread GitBox
blueorangutan commented on issue #3765: Promiscuous vm reject URL: https://github.com/apache/cloudstack/pull/3765#issuecomment-566474947 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] bwsw commented on issue #3751: Add iscsi as secondary storage

2019-12-17 Thread GitBox
bwsw commented on issue #3751: Add iscsi as secondary storage URL: https://github.com/apache/cloudstack/issues/3751#issuecomment-566477178 Why one needs that if one can use Ceph RBD or S3 (Minio) or even Gluster with minor hacks? I don't think block device is an easy way to use as a SS, be

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358708486 ## File path: core/src/main/java/com/cloud/agent/resource/virtualnetwork/facade/AbstractConfigI

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358708732 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358708732 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358709278 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManager.java

[GitHub] [cloudstack] blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-17 Thread GitBox
blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-566479761 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-477 --

[GitHub] [cloudstack] blueorangutan commented on issue #3755: Added zone check for attach iso

2019-12-17 Thread GitBox
blueorangutan commented on issue #3755: Added zone check for attach iso URL: https://github.com/apache/cloudstack/pull/3755#issuecomment-566481831 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-478 This is an automated messa

[GitHub] [cloudstack] blueorangutan commented on issue #3765: Promiscuous vm reject

2019-12-17 Thread GitBox
blueorangutan commented on issue #3765: Promiscuous vm reject URL: https://github.com/apache/cloudstack/pull/3765#issuecomment-566484784 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-479 This is an automated message from th

[GitHub] [cloudstack] svenvogel commented on issue #3737: Add missing HA config keys

2019-12-17 Thread GitBox
svenvogel commented on issue #3737: Add missing HA config keys URL: https://github.com/apache/cloudstack/pull/3737#issuecomment-566486833 @weizhouapache should be ready to merge? This is an automated message from the Apache Gi

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358730435 ## File path: core/src/main/java/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358730520 ## File path: core/src/main/java/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358731768 ## File path: engine/schema/src/main/java/com/cloud/network/dao/RouterHealthCheckResultDao.java

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358732178 ## File path: engine/schema/src/main/java/com/cloud/network/dao/RouterHealthCheckResultVO.java

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358740910 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358742018 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358742417 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358742618 ## File path: core/src/main/java/com/cloud/agent/resource/virtualnetwork/facade/SetMonitorServi

[GitHub] [cloudstack] pavanaravapalli closed pull request #3643: WIP: UEFI Support on CloudStack

2019-12-17 Thread GitBox
pavanaravapalli closed pull request #3643: WIP: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3643 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [cloudstack] pavanaravapalli commented on issue #3643: WIP: UEFI Support on CloudStack

2019-12-17 Thread GitBox
pavanaravapalli commented on issue #3643: WIP: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3643#issuecomment-566515206 Closing this PR Since forked branch is been obsoleted, re-opened another PR #3638 for the same.

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358783155 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358788785 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358788702 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358788785 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.

[GitHub] [cloudstack] borisstoyanov commented on issue #3755: Added zone check for attach iso

2019-12-17 Thread GitBox
borisstoyanov commented on issue #3755: Added zone check for attach iso URL: https://github.com/apache/cloudstack/pull/3755#issuecomment-566541963 @blueorangutan package This is an automated message from the Apache Git Service

[GitHub] [cloudstack] blueorangutan commented on issue #3755: Added zone check for attach iso

2019-12-17 Thread GitBox
blueorangutan commented on issue #3755: Added zone check for attach iso URL: https://github.com/apache/cloudstack/pull/3755#issuecomment-566542120 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358792853 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358793537 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358793792 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.

[GitHub] [cloudstack] svenvogel commented on issue #3737: Add missing HA config keys

2019-12-17 Thread GitBox
svenvogel commented on issue #3737: Add missing HA config keys URL: https://github.com/apache/cloudstack/pull/3737#issuecomment-566562566 3 LTGM and tested in our environment. Merge into Master. This is an automated message fr

[GitHub] [cloudstack] svenvogel merged pull request #3737: Add missing HA config keys

2019-12-17 Thread GitBox
svenvogel merged pull request #3737: Add missing HA config keys URL: https://github.com/apache/cloudstack/pull/3737 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[cloudstack] branch master updated (2e8c069 -> 16527f1)

2019-12-17 Thread svogel
This is an automated email from the ASF dual-hosted git repository. svogel pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 2e8c069 Load Average for KVM (#3738) add 16527f1 Add missing HA config keys (#3737) No new revisions were

[GitHub] [cloudstack] svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt

2019-12-17 Thread GitBox
svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-566563730 4 LGTM, checks passed tested in different environments CentOS and Ubuntu.

[GitHub] [cloudstack] andrijapanicsb commented on issue #3186: Add possibility to set KVM MTU size for all NIC

2019-12-17 Thread GitBox
andrijapanicsb commented on issue #3186: Add possibility to set KVM MTU size for all NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-566563338 I agree with @GabrielBrascher, I've seen some nasty issues with MTU not being in place correctly. I do want an opinion

[GitHub] [cloudstack] svenvogel merged pull request #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt

2019-12-17 Thread GitBox
svenvogel merged pull request #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371 This is an automated message from the Apache G

[cloudstack] branch master updated (16527f1 -> a0efbf9)

2019-12-17 Thread svogel
This is an automated email from the ASF dual-hosted git repository. svogel pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 16527f1 Add missing HA config keys (#3737) add a0efbf9 Fix virtual template size for managed storage for K

[GitHub] [cloudstack] andrijapanicsb opened a new pull request #3771: Revert "Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt"

2019-12-17 Thread GitBox
andrijapanicsb opened a new pull request #3771: Revert "Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt" URL: https://github.com/apache/cloudstack/pull/3771 Reverts apache/cloudstack#3371 -

[cloudstack] 01/01: Revert "Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt (#3371)"

2019-12-17 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a commit to branch revert-3371-template_rewrite in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 08be29a753cbdadac17d23b4fa86e3c011b0c21a Author: Andrija Panic <45762285+andrijapani...@u

[GitHub] [cloudstack] andrijapanicsb commented on issue #3771: Revert "Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt"

2019-12-17 Thread GitBox
andrijapanicsb commented on issue #3771: Revert "Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt" URL: https://github.com/apache/cloudstack/pull/3771#issuecomment-566564830 Revert This

[cloudstack] branch revert-3371-template_rewrite created (now 08be29a)

2019-12-17 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch revert-3371-template_rewrite in repository https://gitbox.apache.org/repos/asf/cloudstack.git. at 08be29a Revert "Fix virtual template size for managed storage for KVM / refactor cl

[GitHub] [cloudstack] andrijapanicsb merged pull request #3771: Revert "Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt"

2019-12-17 Thread GitBox
andrijapanicsb merged pull request #3771: Revert "Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt" URL: https://github.com/apache/cloudstack/pull/3771 This is an automated message fro

[cloudstack] branch master updated (a0efbf9 -> e319c8b)

2019-12-17 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from a0efbf9 Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt (#3371)

[GitHub] [cloudstack] andrijapanicsb commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt

2019-12-17 Thread GitBox
andrijapanicsb commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-566565399 Apologies @svenvogel , I have reverted this PR/merge - since tests have NOT complete

[GitHub] [cloudstack] andrijapanicsb commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt

2019-12-17 Thread GitBox
andrijapanicsb commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-566566974 @blueorangutan test

[GitHub] [cloudstack] blueorangutan commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt

2019-12-17 Thread GitBox
blueorangutan commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-566567277 @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kick

[GitHub] [cloudstack] pavanaravapalli commented on issue #3638: UEFI Support on CloudStack

2019-12-17 Thread GitBox
pavanaravapalli commented on issue #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#issuecomment-566568818 @sureshanaparti, review comments addressed as suggested This is an automated messa

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #3638: UEFI Support on CloudStack

2019-12-17 Thread GitBox
sureshanaparti commented on a change in pull request #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#discussion_r358759670 ## File path: api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java ## @@ -257,12 +280,3

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #3638: UEFI Support on CloudStack

2019-12-17 Thread GitBox
sureshanaparti commented on a change in pull request #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#discussion_r356214213 ## File path: server/src/main/java/com/cloud/hypervisor/HypervisorGuruBase.java ## @@ -166,6 +166,11 @@ protecte

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #3638: UEFI Support on CloudStack

2019-12-17 Thread GitBox
sureshanaparti commented on a change in pull request #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#discussion_r356211331 ## File path: server/src/main/java/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java ## @@ -112,6 +

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #3638: UEFI Support on CloudStack

2019-12-17 Thread GitBox
sureshanaparti commented on a change in pull request #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#discussion_r356213475 ## File path: server/src/main/java/com/cloud/deploy/FirstFitPlanner.java ## @@ -218,6 +230,20 @@ public int comp

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #3638: UEFI Support on CloudStack

2019-12-17 Thread GitBox
sureshanaparti commented on a change in pull request #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#discussion_r356214635 ## File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java ## @@ -1183,6 +1187,16 @@ private

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #3638: UEFI Support on CloudStack

2019-12-17 Thread GitBox
sureshanaparti commented on a change in pull request #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#discussion_r358759269 ## File path: api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java ## @@ -245,6 +252,22

[GitHub] [cloudstack] pavanaravapalli commented on a change in pull request #3638: UEFI Support on CloudStack

2019-12-17 Thread GitBox
pavanaravapalli commented on a change in pull request #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#discussion_r358830755 ## File path: server/src/main/java/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java ## @@ -112,6

[GitHub] [cloudstack] pavanaravapalli commented on issue #3638: UEFI Support on CloudStack

2019-12-17 Thread GitBox
pavanaravapalli commented on issue #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#issuecomment-566572740 @nathanejohnson @nvazquez @rhtyd Please review. This is an automated message from

[GitHub] [cloudstack] svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all NIC

2019-12-17 Thread GitBox
svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-566575607 @GabrielBrascher @andrijapanicsb sure we can put it on-hold and work in progress. at the moment there are no resources to get the t

[cloudstack] branch revert-3771-revert-3371-template_rewrite created (now cf493b6)

2019-12-17 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch revert-3771-revert-3371-template_rewrite in repository https://gitbox.apache.org/repos/asf/cloudstack.git. at cf493b6 Revert "Revert "Fix virtual template size for managed storage f

[cloudstack] 01/01: Revert "Revert "Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt (#3371)" (#3771)"

2019-12-17 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a commit to branch revert-3771-revert-3371-template_rewrite in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit cf493b60d2252edd7c2020ea2a4b7dd115834964 Author: Andrija Panic <45762285+andr

  1   2   >