[GitHub] 1m2c3t4 commented on a change in pull request #3143: Fix some LGTM alerts

2019-01-24 Thread GitBox
1m2c3t4 commented on a change in pull request #3143: Fix some LGTM alerts URL: https://github.com/apache/cloudstack/pull/3143#discussion_r250513108 ## File path: api/src/main/java/com/cloud/deploy/DeployDestination.java ## @@ -78,6 +78,10 @@ public int hashCode() { @

[GitHub] 1m2c3t4 commented on a change in pull request #3143: Fix some LGTM alerts

2019-01-24 Thread GitBox
1m2c3t4 commented on a change in pull request #3143: Fix some LGTM alerts URL: https://github.com/apache/cloudstack/pull/3143#discussion_r250513335 ## File path: api/src/main/java/com/cloud/deploy/DeployDestination.java ## @@ -78,6 +78,10 @@ public int hashCode() { @

[GitHub] rhtyd commented on issue #3127: Improve System VM startup and memory usage [4.11]

2019-01-24 Thread GitBox
rhtyd commented on issue #3127: Improve System VM startup and memory usage [4.11] URL: https://github.com/apache/cloudstack/pull/3127#issuecomment-457131134 Note: Debian 9.7 has been released, build will fail due to incorrect iso url. https://www.debian.org/News/2019/20190123

[GitHub] rhtyd commented on issue #3139: packaging: management default file cleanup

2019-01-24 Thread GitBox
rhtyd commented on issue #3139: packaging: management default file cleanup URL: https://github.com/apache/cloudstack/pull/3139#issuecomment-457136751 @GabrielBrascher removed the label. I'll investigate and may send another PR (perhaps a doc PR) on how to disable/configure TLS versions. Tur

[GitHub] blueorangutan commented on issue #3139: packaging: management default file cleanup

2019-01-24 Thread GitBox
blueorangutan commented on issue #3139: packaging: management default file cleanup URL: https://github.com/apache/cloudstack/pull/3139#issuecomment-457137156 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] blueorangutan commented on issue #3139: packaging: management default file cleanup

2019-01-24 Thread GitBox
blueorangutan commented on issue #3139: packaging: management default file cleanup URL: https://github.com/apache/cloudstack/pull/3139#issuecomment-457144631 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2562 This is an au

[GitHub] wido commented on a change in pull request #3127: Improve System VM startup and memory usage [4.11]

2019-01-24 Thread GitBox
wido commented on a change in pull request #3127: Improve System VM startup and memory usage [4.11] URL: https://github.com/apache/cloudstack/pull/3127#discussion_r250552812 ## File path: systemvm/debian/etc/cron.hourly/clear_cache ## @@ -0,0 +1,8 @@ +#!/bin/bash + +# clea

[GitHub] wido commented on a change in pull request #3127: Improve System VM startup and memory usage [4.11]

2019-01-24 Thread GitBox
wido commented on a change in pull request #3127: Improve System VM startup and memory usage [4.11] URL: https://github.com/apache/cloudstack/pull/3127#discussion_r250552526 ## File path: systemvm/debian/etc/cron.daily/clear_cache ## @@ -0,0 +1,5 @@ +#!/bin/bash + +# clear

[GitHub] wido commented on a change in pull request #3127: Improve System VM startup and memory usage [4.11]

2019-01-24 Thread GitBox
wido commented on a change in pull request #3127: Improve System VM startup and memory usage [4.11] URL: https://github.com/apache/cloudstack/pull/3127#discussion_r250553250 ## File path: systemvm/debian/opt/cloud/bin/setup/secstorage.sh ## @@ -19,14 +19,14 @@ . /opt/clou

[GitHub] wido commented on issue #3126: Improve System VM startup and memory usage

2019-01-24 Thread GitBox
wido commented on issue #3126: Improve System VM startup and memory usage URL: https://github.com/apache/cloudstack/pull/3126#issuecomment-457153486 See my comments here: #3127 I would not touch those sysctl settings T

[GitHub] rhtyd commented on issue #3139: packaging: management default file cleanup

2019-01-24 Thread GitBox
rhtyd commented on issue #3139: packaging: management default file cleanup URL: https://github.com/apache/cloudstack/pull/3139#issuecomment-457182406 @blueorangutan test This is an automated message from the Apache Git Service

[GitHub] blueorangutan commented on issue #3139: packaging: management default file cleanup

2019-01-24 Thread GitBox
blueorangutan commented on issue #3139: packaging: management default file cleanup URL: https://github.com/apache/cloudstack/pull/3139#issuecomment-457182522 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] bwsw commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an account

2019-01-24 Thread GitBox
bwsw commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an account URL: https://github.com/apache/cloudstack/pull/3058#issuecomment-457192042 @GabrielBrascher Hi, Gabriel, you have mentioned this PR as a problematic. It has got two LGTM. Please, comment on what do you want

[GitHub] wido commented on issue #3057: Security Grouping is broken with VXLAN on KVM

2019-01-24 Thread GitBox
wido commented on issue #3057: Security Grouping is broken with VXLAN on KVM URL: https://github.com/apache/cloudstack/issues/3057#issuecomment-457194126 I think that PR #3113 fixed this. Closing this one. This is an au

[GitHub] wido closed issue #3057: Security Grouping is broken with VXLAN on KVM

2019-01-24 Thread GitBox
wido closed issue #3057: Security Grouping is broken with VXLAN on KVM URL: https://github.com/apache/cloudstack/issues/3057 This is an automated message from the Apache Git Service. To respond to the message, please log on G

[GitHub] GabrielBrascher commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an account

2019-01-24 Thread GitBox
GabrielBrascher commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an account URL: https://github.com/apache/cloudstack/pull/3058#issuecomment-457197389 @bwsw this one is looking good indeed, I must have dropped this PR on the wrong list. Just to mention, independent

[GitHub] blueorangutan commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an account

2019-01-24 Thread GitBox
blueorangutan commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an account URL: https://github.com/apache/cloudstack/pull/3058#issuecomment-457197539 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] GabrielBrascher commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an account

2019-01-24 Thread GitBox
GabrielBrascher commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an account URL: https://github.com/apache/cloudstack/pull/3058#issuecomment-457197524 @blueorangutan package This is an automated message from

[GitHub] GabrielBrascher commented on a change in pull request #3058: CLOUDSTACK-3049: update dynamic role for an account

2019-01-24 Thread GitBox
GabrielBrascher commented on a change in pull request #3058: CLOUDSTACK-3049: update dynamic role for an account URL: https://github.com/apache/cloudstack/pull/3058#discussion_r250608689 ## File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java ## @@ -1712,

[GitHub] bwsw commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an account

2019-01-24 Thread GitBox
bwsw commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an account URL: https://github.com/apache/cloudstack/pull/3058#issuecomment-457209718 @GabrielBrascher Sounds great. This is an automated message from th

[GitHub] blueorangutan commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an account

2019-01-24 Thread GitBox
blueorangutan commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an account URL: https://github.com/apache/cloudstack/pull/3058#issuecomment-457205858 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2563 This

[GitHub] GabrielBrascher commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an account

2019-01-24 Thread GitBox
GabrielBrascher commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an account URL: https://github.com/apache/cloudstack/pull/3058#issuecomment-457211655 @blueorangutan test This is an automated message from th

[GitHub] blueorangutan commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an account

2019-01-24 Thread GitBox
blueorangutan commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an account URL: https://github.com/apache/cloudstack/pull/3058#issuecomment-457211817 @GabrielBrascher a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -

[GitHub] GabrielBrascher commented on issue #3133: feature: add libvirt / qemu io bursting

2019-01-24 Thread GitBox
GabrielBrascher commented on issue #3133: feature: add libvirt / qemu io bursting URL: https://github.com/apache/cloudstack/pull/3133#issuecomment-457215526 @nathanejohnson this PR is very welcome for the 4.12 release :+1: Can you please fix the conflicts and address the reviews? Thank

[GitHub] GabrielBrascher commented on a change in pull request #3133: feature: add libvirt / qemu io bursting

2019-01-24 Thread GitBox
GabrielBrascher commented on a change in pull request #3133: feature: add libvirt / qemu io bursting URL: https://github.com/apache/cloudstack/pull/3133#discussion_r250628726 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java ##

[GitHub] GabrielBrascher commented on a change in pull request #3133: feature: add libvirt / qemu io bursting

2019-01-24 Thread GitBox
GabrielBrascher commented on a change in pull request #3133: feature: add libvirt / qemu io bursting URL: https://github.com/apache/cloudstack/pull/3133#discussion_r250628726 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java ##

[GitHub] blueorangutan commented on issue #2848: Vmware offline migration

2019-01-24 Thread GitBox
blueorangutan commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-457278872 Trillian test result (tid-3342) Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34194 seconds Marvin logs

[GitHub] andrijapanicsb commented on issue #2583: CPU cores per socket setting not functional

2019-01-24 Thread GitBox
andrijapanicsb commented on issue #2583: CPU cores per socket setting not functional URL: https://github.com/apache/cloudstack/issues/2583#issuecomment-457312738 Still exists for 4.11.2 with XCP-NG 7.4 - parameter is ignored, and it's always 4 sockets.

[GitHub] blueorangutan commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an account

2019-01-24 Thread GitBox
blueorangutan commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an account URL: https://github.com/apache/cloudstack/pull/3058#issuecomment-457343857 Trillian test result (tid-3344) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken

[GitHub] 1m2c3t4 commented on issue #3143: Fix some LGTM alerts

2019-01-24 Thread GitBox
1m2c3t4 commented on issue #3143: Fix some LGTM alerts URL: https://github.com/apache/cloudstack/pull/3143#issuecomment-457367378 Thanks for the reviews @GabrielBrascher @DaanHoogland @rafaelweingartner This is an automated m

[GitHub] falcon78921 commented on issue #3137: Integrating Ceph Status into CloudStack Dashboard

2019-01-24 Thread GitBox
falcon78921 commented on issue #3137: Integrating Ceph Status into CloudStack Dashboard URL: https://github.com/apache/cloudstack/issues/3137#issuecomment-457378766 Yeah, you could see this as "re-inventing the wheel". However, if users use both CloudStack and Ceph, you're giving them a mo

[cloudstack] branch master updated: kvm: Properly report available memory to Management Server (#2795)

2019-01-24 Thread gabriel
This is an automated email from the ASF dual-hosted git repository. gabriel pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new c496c84 kvm: Properly report available mem

[GitHub] GabrielBrascher merged pull request #2795: kvm: Properly report available memory to Management Server

2019-01-24 Thread GitBox
GabrielBrascher merged pull request #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795 This is an automated message from the Apache Git Service. To respond t

[GitHub] GabrielBrascher merged pull request #3143: Fix some LGTM alerts

2019-01-24 Thread GitBox
GabrielBrascher merged pull request #3143: Fix some LGTM alerts URL: https://github.com/apache/cloudstack/pull/3143 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[cloudstack] branch master updated: Fix some LGTM alerts (#3143)

2019-01-24 Thread gabriel
This is an automated email from the ASF dual-hosted git repository. gabriel pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 97ddd8d Fix some LGTM alerts (#3143) 97ddd

[GitHub] blueorangutan commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules

2019-01-24 Thread GitBox
blueorangutan commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-457381437 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] GabrielBrascher commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules

2019-01-24 Thread GitBox
GabrielBrascher commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-457381392 @blueorangutan package This is an automated

[GitHub] GabrielBrascher commented on issue #3041: Decision making logic of which Secondary storage to be used

2019-01-24 Thread GitBox
GabrielBrascher commented on issue #3041: Decision making logic of which Secondary storage to be used URL: https://github.com/apache/cloudstack/issues/3041#issuecomment-457384157 @dhlaluku any update on this one? This is an a

[GitHub] nathanejohnson commented on a change in pull request #3133: feature: add libvirt / qemu io bursting

2019-01-24 Thread GitBox
nathanejohnson commented on a change in pull request #3133: feature: add libvirt / qemu io bursting URL: https://github.com/apache/cloudstack/pull/3133#discussion_r250807261 ## File path: api/src/main/java/org/apache/cloudstack/api/response/DiskOfferingResponse.java ## @@

[GitHub] blueorangutan commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules

2019-01-24 Thread GitBox
blueorangutan commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-457388283 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2564 -

[GitHub] nathanejohnson commented on a change in pull request #3133: feature: add libvirt / qemu io bursting

2019-01-24 Thread GitBox
nathanejohnson commented on a change in pull request #3133: feature: add libvirt / qemu io bursting URL: https://github.com/apache/cloudstack/pull/3133#discussion_r250810531 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResour

[GitHub] blueorangutan commented on issue #3139: packaging: management default file cleanup

2019-01-24 Thread GitBox
blueorangutan commented on issue #3139: packaging: management default file cleanup URL: https://github.com/apache/cloudstack/pull/3139#issuecomment-457395787 Trillian test result (tid-3343) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 36813 s

[GitHub] nathanejohnson commented on issue #3133: feature: add libvirt / qemu io bursting

2019-01-24 Thread GitBox
nathanejohnson commented on issue #3133: feature: add libvirt / qemu io bursting URL: https://github.com/apache/cloudstack/pull/3133#issuecomment-457401730 @GabrielBrascher @rafaelweingartner sorry this has taken so long to get back to, I've been transitioning to a new laptop and getting e

[GitHub] nathanejohnson commented on issue #3133: feature: add libvirt / qemu io bursting

2019-01-24 Thread GitBox
nathanejohnson commented on issue #3133: feature: add libvirt / qemu io bursting URL: https://github.com/apache/cloudstack/pull/3133#issuecomment-457402065 @mike-tutkowski still very keen to get your input on the point raised above, I would not want to break any of your functionality if thi

[GitHub] GabrielBrascher commented on issue #3133: feature: add libvirt / qemu io bursting

2019-01-24 Thread GitBox
GabrielBrascher commented on issue #3133: feature: add libvirt / qemu io bursting URL: https://github.com/apache/cloudstack/pull/3133#issuecomment-457410026 @blueorangutan package This is an automated message from the Apache

[GitHub] blueorangutan commented on issue #3133: feature: add libvirt / qemu io bursting

2019-01-24 Thread GitBox
blueorangutan commented on issue #3133: feature: add libvirt / qemu io bursting URL: https://github.com/apache/cloudstack/pull/3133#issuecomment-457410184 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] blueorangutan commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules

2019-01-24 Thread GitBox
blueorangutan commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-457411187 @GabrielBrascher a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -

[GitHub] GabrielBrascher commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules

2019-01-24 Thread GitBox
GabrielBrascher commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-457411161 @blueorangutan test This is an automated mes

[GitHub] blueorangutan commented on issue #3133: feature: add libvirt / qemu io bursting

2019-01-24 Thread GitBox
blueorangutan commented on issue #3133: feature: add libvirt / qemu io bursting URL: https://github.com/apache/cloudstack/pull/3133#issuecomment-457415252 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2565 This is an automa

[GitHub] rafaelweingartner commented on issue #3133: feature: add libvirt / qemu io bursting

2019-01-24 Thread GitBox
rafaelweingartner commented on issue #3133: feature: add libvirt / qemu io bursting URL: https://github.com/apache/cloudstack/pull/3133#issuecomment-457416071 Thanks for the reply @nathanejohnson. I do understand that we need to find a balance, but the only way to do it is talking/d

[GitHub] GabrielBrascher commented on issue #3133: feature: add libvirt / qemu io bursting

2019-01-24 Thread GitBox
GabrielBrascher commented on issue #3133: feature: add libvirt / qemu io bursting URL: https://github.com/apache/cloudstack/pull/3133#issuecomment-457417679 @blueorangutan test This is an automated message from the Apache Git

[GitHub] blueorangutan commented on issue #3133: feature: add libvirt / qemu io bursting

2019-01-24 Thread GitBox
blueorangutan commented on issue #3133: feature: add libvirt / qemu io bursting URL: https://github.com/apache/cloudstack/pull/3133#issuecomment-457417928 @GabrielBrascher a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --