nathanejohnson commented on a change in pull request #3133: feature: add
libvirt / qemu io bursting
URL: https://github.com/apache/cloudstack/pull/3133#discussion_r250810531
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -2390,15 +2390,40 @@ public int compare(final DiskTO arg0, final DiskTO
arg1) {
if (volumeObjectTO.getBytesReadRate() != null &&
volumeObjectTO.getBytesReadRate() > 0) {
Review comment:
I can break this out into a method, but the functionality here should
already be covered by the tests I added to the LibvirtVMDefTest.java. What
what a test look like that actually adds value here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
