Re: [PR] ui: improve sort utility for metrics [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud merged PR #9247: URL: https://github.com/apache/cloudstack/pull/9247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] ui: improve sort utility for metrics [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9247: URL: https://github.com/apache/cloudstack/pull/9247#issuecomment-2165550751 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9247 (QA-JID-378) -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] ui: improve sort utility for metrics [cloudstack]

2024-06-13 Thread via GitHub
codecov[bot] commented on PR #9247: URL: https://github.com/apache/cloudstack/pull/9247#issuecomment-2165531829 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9247?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] ui: improve sort utility for metrics [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9247: URL: https://github.com/apache/cloudstack/pull/9247#issuecomment-2165515803 @rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To resp

Re: [PR] ui: improve sort utility for metrics [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud commented on PR #9247: URL: https://github.com/apache/cloudstack/pull/9247#issuecomment-2165514363 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[PR] ui: improve sort utility for metrics [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud opened a new pull request, #9247: URL: https://github.com/apache/cloudstack/pull/9247 This improves the UI sorting utility to check for metrics data and sort after cleaning the string data. Fixes #8663 ### Types of changes - [ ] Breaking change (fix or fe

Re: [PR] ui: improve sort utility for metrics [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud commented on code in PR #9247: URL: https://github.com/apache/cloudstack/pull/9247#discussion_r1638121463 ## ui/src/utils/sort.js: ## @@ -23,13 +23,19 @@ function filterNumber (value) { } function stringComparator (a, b) { - return a.toString().localeCompare