rohityadavcloud commented on code in PR #9247:
URL: https://github.com/apache/cloudstack/pull/9247#discussion_r1638121463


##########
ui/src/utils/sort.js:
##########
@@ -23,13 +23,19 @@ function filterNumber (value) {
 }
 
 function stringComparator (a, b) {
-  return a.toString().localeCompare(b.toString())
+  return a.toString().localeCompare(b.toString(), undefined, { numeric: true })

Review Comment:
   FYI - this would also consider for cases where there is numeric string data 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to