Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2167362209 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9940 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2167336373 Merged based on GHA smoketests and build tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud merged PR #9124: URL: https://github.com/apache/cloudstack/pull/9124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-06-13 Thread via GitHub
blueorangutan commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2167260600 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-06-13 Thread via GitHub
shwstppr commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2167259557 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-06-13 Thread via GitHub
shwstppr commented on code in PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#discussion_r1639297424 ## server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java: ## @@ -2042,10 +2042,6 @@ private UserVmResponse importKvmInstance(ImportVmCmd cmd)

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-06-13 Thread via GitHub
sureshanaparti commented on code in PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#discussion_r1638364400 ## server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java: ## @@ -2042,10 +2042,6 @@ private UserVmResponse importKvmInstance(ImportVmCmd

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2162560251 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9888 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2162378625 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-06-12 Thread via GitHub
shwstppr commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2162376923 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-06-11 Thread via GitHub
github-actions[bot] commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2160713203 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-06-03 Thread via GitHub
blueorangutan commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2146275015 [SF] Trillian test result (tid-10328) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 52345 seconds Marvin logs: https://github.co

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-06-03 Thread via GitHub
blueorangutan commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2144545200 @shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respo

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-06-03 Thread via GitHub
shwstppr commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2144543707 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-06-02 Thread via GitHub
blueorangutan commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2144412793 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9759 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-06-02 Thread via GitHub
blueorangutan commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2144328396 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-06-02 Thread via GitHub
shwstppr commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2144327091 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-05-28 Thread via GitHub
andrijapanicsb commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2134833196 @vishesh92 no - those are used later during importVm API to connect via ssh etc. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-05-28 Thread via GitHub
vishesh92 commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2134760444 @shwstppr Do we need any changes in the UI for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-05-28 Thread via GitHub
weizhouapache commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2134753716 > @shwstppr as the parameters are not used, should these also be removed from the `Cmd` class? currently vms are listed by virsh command (endpoint is the remote server)

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-05-28 Thread via GitHub
DaanHoogland commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2134687699 @shwstppr as the parameters are not used, should these also be removed from the `Cmd` class? -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-05-24 Thread via GitHub
blueorangutan commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2129634403 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9701 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-05-24 Thread via GitHub
blueorangutan commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2129494029 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-05-24 Thread via GitHub
shwstppr commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2129490988 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-05-24 Thread via GitHub
codecov[bot] commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2129392463 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9124?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-05-24 Thread via GitHub
shwstppr opened a new pull request, #9124: URL: https://github.com/apache/cloudstack/pull/9124 ### Description Fixes #8414 ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking cha