sureshanaparti commented on code in PR #9124:
URL: https://github.com/apache/cloudstack/pull/9124#discussion_r1638364400


##########
server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java:
##########
@@ -2042,10 +2042,6 @@ private UserVmResponse importKvmInstance(ImportVmCmd 
cmd) {
 
         UnmanagedInstanceTO unmanagedInstanceTO = null;
         if (ImportSource.EXTERNAL == importSource) {
-            if (StringUtils.isBlank(cmd.getUsername())) {
-                throw new InvalidParameterValueException("Username need to be 
provided.");
-            }
-

Review Comment:
   @shwstppr username & password are required/mandatory for importing instances 
from remote host, these are needed to copy the remote disks. 
   
    username & password are not required when listing remote instances.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to