DaanHoogland merged PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cl
jbampton commented on PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-2223063029
Hey @JoaoJandre yes you are correct.
I have been working on spelling fixes for a while now and have a couple of
PRs in progress with spell fixes.
--
This is an automated mess
JoaoJandre commented on PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-994493
If I understood correctly, the `.github/linters/codespell.txt` file has a
list of misspelled words that were found within the project and that are going
to be ignored by codespell,
github-actions[bot] commented on PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-2219997435
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
jbampton commented on PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-2213959538
Hey @DaanHoogland the list of words in `.github/linters/codespell.txt` will
need fixing in other PRs in future.
Basically codespell ignores those words when it runs the spell c
DaanHoogland commented on code in PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#discussion_r1668165195
##
.github/linters/codespell.txt:
##
@@ -52,6 +52,7 @@ authenciation
authenitcation
authenitication
availiability
+avialable
Review Comment:
shouldn't be
blueorangutan commented on PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-2213007425
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
blueorangutan commented on PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-2212873573
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
jbampton commented on PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-2212872570
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
jbampton commented on code in PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#discussion_r1617247947
##
.pre-commit-config.yaml:
##
@@ -61,6 +61,14 @@ repos:
- id: trailing-whitespace
files: \.(in|java|md|py|rb|sh|vue|yaml|yml)$
args: [--ma
DaanHoogland commented on code in PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#discussion_r1617168284
##
.github/linters/codespell.txt:
##
@@ -0,0 +1,649 @@
+accouns
+acess
+acheived
+acount
+activ
+actuall
+acuiring
+acumulate
+addes
+additionals
+addreess
+add
github-actions[bot] commented on PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-2134573595
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
blueorangutan commented on PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-2125941284
[SF] Trillian test result (tid-10244)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52031 seconds
Marvin logs:
https://github.co
blueorangutan commented on PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-2124188681
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7)
has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To r
DaanHoogland commented on PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-2124187604
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
blueorangutan commented on PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-2118996014
[SF] Trillian Build Failed (tid-10215)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
blueorangutan commented on PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-2118991189
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7)
has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To r
DaanHoogland commented on PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-2118991032
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
blueorangutan commented on PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-2106424307
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-2106401193
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
jbampton commented on PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-2106401073
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
DaanHoogland commented on PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-1801872544
@jbampton , there is a bunch of PRs going on with "polish" in the name. I
think this is a bit related to some of that work, And I think we should not
exclude any folders. It might
jbampton commented on PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-1801860769
Hey @DaanHoogland yes we need to review `codespell.txt`.It does have
lots of spelling mistakes.
We can also exclude files/folders from spell checking if needed.
DaanHoogland commented on PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-1801821365
looks good @jbampton . Should we consider the contents of codespell.txt as a
list of nouns to review/improve?
--
This is an automated message from the Apache Git Service.
To res
codecov[bot] commented on PR #8197:
URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-1801811459
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8197?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
jbampton opened a new pull request, #8197:
URL: https://github.com/apache/cloudstack/pull/8197
### Description
This PR adds `codespell` to our pre-commit hooks.
The words in `codespell.txt` are ignored and this file has basically been
created by running:
`codespell . | c
26 matches
Mail list logo
