JoaoJandre merged PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@clou
JoaoJandre commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2473585990
Tested:
1. Template creation from snapshot;
2. Taking multiple snapshots at once;
3. Removing a primary-storage;
4. Attaching and Detaching ISOs;
All operations suc
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2469472977
[SF] Trillian test result (tid-11773)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 45212 seconds
Marvin logs:
https://github.com/
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2468176642
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been
kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond t
DaanHoogland commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2468172649
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
rp- commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2468074373
@DaanHoogland can you start tests here, I would want to see if they succeed
now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2465621412
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2465515623
@rp- a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
--
T
rp- commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2465514165
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
DaanHoogland commented on code in PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#discussion_r1834513706
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##
@@ -637,6 +639,39 @@ public KVMPhysicalDisk getPhysical
DaanHoogland commented on code in PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#discussion_r1834512936
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##
@@ -637,6 +639,39 @@ public KVMPhysicalDisk getPhysical
rp- commented on code in PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#discussion_r1834510439
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##
@@ -637,6 +639,39 @@ public KVMPhysicalDisk getPhysicalDisk(Stri
rp- commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2464895494
@JoaoJandre This seem to work in my tests now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
rp- commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2464894736
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
rp- commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2464834363
> @JoaoJandre
> We could keep the ref-count for the secondary storage only. The
`com.cloud.hypervisor.kvm.storage.KVMStoragePoolManager#createStoragePool(java.lang.String,
java.lang.St
JoaoJandre commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2464841153
> > @JoaoJandre
> > We could keep the ref-count for the secondary storage only. The
`com.cloud.hypervisor.kvm.storage.KVMStoragePoolManager#createStoragePool(java.lang.String,
ja
JoaoJandre commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2464801937
> @JoaoJandre So yeah, this doesn't really work with primary storage NFS
(maybe others handled with libvirt too). Currently `ModifyStoragePool` would
call `createStoragePool`, but n
rp- commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2464754584
@JoaoJandre
So yeah, this doesn't really work with primary storage NFS (maybe others
handled with libvirt).
Currently `ModifyStoragePool` would call `createStoragePool`, but not
dele
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2463769868
[SF] Trillian test result (tid-11765)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 49600 seconds
Marvin logs:
https://github.com/
JoaoJandre commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2463029743
> @rp- did you test your solution with adding and removing primary storages?
My fear is that we might have many references to a primary storage and when
trying to delete it AC
JoaoJandre commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2463025057
@rp- did you test your solution with adding and removing primary storages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2462298351
@DaanHoogland [SL] unsupported parameters provided. Supported mgmt server os
are: `ol8, ol9, debian12, rocky8, alma9, suse15, centos7, centos6, alma8,
ubuntu18, ubuntu22, ubuntu2
DaanHoogland commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2462394137
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2462395749
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been
kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond t
DaanHoogland commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2462294943
> @blueorangutan test
The blue ape won't listen to you if you tell it to run tests @rp- (to
prevent our lab getting to full we keep control on regression test runs). Other
rp- commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2462325210
No it didn't tell me, but I was guessing that I don't have the "rights" to
do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rp- commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2459062417
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2458989661
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2458898890
@rp- a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
--
T
rp- commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2458895618
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
DaanHoogland commented on code in PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#discussion_r1770880307
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##
@@ -637,6 +639,39 @@ public KVMPhysicalDisk getPhysical
DaanHoogland commented on code in PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#discussion_r1770880307
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##
@@ -637,6 +639,39 @@ public KVMPhysicalDisk getPhysical
JoaoJandre commented on code in PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#discussion_r1768562494
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##
@@ -637,6 +639,39 @@ public KVMPhysicalDisk getPhysicalDi
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2359350746
[SF] Trillian test result (tid-11507)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 44477 seconds
Marvin logs:
https://github.com/
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2357716295
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been
kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond t
DaanHoogland commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2357714240
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
rp- commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2356569708
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2356476943
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2356371763
@rp- a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
--
T
rp- commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-235636
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
rp- commented on code in PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#discussion_r1762595557
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##
@@ -637,6 +638,38 @@ public KVMPhysicalDisk getPhysicalDisk(Stri
DaanHoogland commented on code in PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#discussion_r1762515483
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##
@@ -637,6 +638,38 @@ public KVMPhysicalDisk getPhysical
rp- commented on code in PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#discussion_r1762507176
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##
@@ -637,6 +638,38 @@ public KVMPhysicalDisk getPhysicalDisk(Stri
rp- commented on code in PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#discussion_r1762496731
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##
@@ -637,6 +638,38 @@ public KVMPhysicalDisk getPhysicalDisk(Stri
DaanHoogland commented on code in PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#discussion_r1760878307
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##
@@ -637,6 +638,38 @@ public KVMPhysicalDisk getPhysical
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2344752231
[SF] Trillian test result (tid-11452)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 43615 seconds
Marvin logs:
https://github.com/
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2343054777
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been
kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond t
DaanHoogland commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2343052791
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
DaanHoogland commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2343052277
ah, no, i don´t have those. I'll run again without the teardown step and
have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
rp- commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2343029482
I see exceptions like this:
```
2024-09-06 16:25:57,620 DEBUG [c.c.a.t.Request]
(AgentManager-Handler-13:null) (logid:) Seq 1-8334192585425814054: Processing:
{ Ans: , MgmtId: 32986
DaanHoogland commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2342997781
> Are there more logs to this "needs access to storage pool"? Or is this
another problem?
sorry @rp- , missing context here. If you are referring to the smoke tests,
the do
rp- commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2342986829
Are there more logs to this "needs access to storage pool"?
Or is this another problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2334952161
[SF] Trillian test result (tid-11408)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 44373 seconds
Marvin logs:
https://github.com/
DaanHoogland commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2333638244
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2333612697
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
DaanHoogland commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-274110
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2331066617
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been
kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond t
DaanHoogland commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2330820890
> I guess the failed packaging is nothing related to this PR?
```
11:02:25 [ERROR] Failures:
11:02:25 [ERROR]
VMSchedulerImplTest.testScheduleNextJobScheduleCurrent
rp- commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2330698256
I guess the failed packaging is nothing related to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2328413232
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 10950
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2326248276
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2326240139
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It
will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep
you posted as I make progr
rohityadavcloud commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2326237042
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2285716492
[SF] Trillian test result (tid-11065)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 47025 seconds
Marvin logs:
https://github.com/
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2284727250
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been
kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond t
DaanHoogland commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2284724657
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2284393048
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
blueorangutan commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2284256788
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress
DaanHoogland commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2284250880
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
rp- commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2284044472
> clgtm, you do have a good test scenario for this, do you @rp- ? Or is it
only intermitted (i.e. not automatable)
I'm not sure it is easy to reproducible automate that, as it is a
codecov[bot] commented on PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2273127702
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9498?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
rp- opened a new pull request, #9498:
URL: https://github.com/apache/cloudstack/pull/9498
### Description
If a storage pool is used by e.g. 2 concurrent snapshot->template actions,
if the first action finished it removed the netfs mount point for the other
action.
Now the storage
72 matches
Mail list logo
