JoaoJandre commented on PR #9498: URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2464841153
> > @JoaoJandre > > We could keep the ref-count for the secondary storage only. The `com.cloud.hypervisor.kvm.storage.KVMStoragePoolManager#createStoragePool(java.lang.String, java.lang.String, int, java.lang.String, java.lang.String, com.cloud.storage.Storage.StoragePoolType, java.util.Map<java.lang.String,java.lang.String>, boolean)` already takes a parameter to determine if the pool is primary or not, we could pass it to `com.cloud.hypervisor.kvm.storage.LibvirtStorageAdaptor#createStoragePool` to determine if we should keep the ref-count or not. > > And on delete? only check if the uuid is part of the refcount map? @rp- Yeah, if it is not part of the map, we assume that it can be deleted. If it is, we check the refcount. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
