Re: [PR] kvm: fix disk controller for secure boot vm [cloudstack]

2025-05-12 Thread via GitHub
blueorangutan commented on PR #10213: URL: https://github.com/apache/cloudstack/pull/10213#issuecomment-2872642961 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] kvm: fix disk controller for secure boot vm [cloudstack]

2025-05-12 Thread via GitHub
blueorangutan commented on PR #10213: URL: https://github.com/apache/cloudstack/pull/10213#issuecomment-2872387115 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] kvm: fix disk controller for secure boot vm [cloudstack]

2025-05-12 Thread via GitHub
shwstppr commented on PR #10213: URL: https://github.com/apache/cloudstack/pull/10213#issuecomment-2872384241 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] kvm: fix disk controller for secure boot vm [cloudstack]

2025-04-24 Thread via GitHub
blueorangutan commented on PR #10213: URL: https://github.com/apache/cloudstack/pull/10213#issuecomment-2827241355 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] kvm: fix disk controller for secure boot vm [cloudstack]

2025-04-24 Thread via GitHub
blueorangutan commented on PR #10213: URL: https://github.com/apache/cloudstack/pull/10213#issuecomment-2827024528 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progr

Re: [PR] kvm: fix disk controller for secure boot vm [cloudstack]

2025-04-24 Thread via GitHub
weizhouapache commented on PR #10213: URL: https://github.com/apache/cloudstack/pull/10213#issuecomment-2827018374 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] kvm: fix disk controller for secure boot vm [cloudstack]

2025-04-24 Thread via GitHub
blueorangutan commented on PR #10213: URL: https://github.com/apache/cloudstack/pull/10213#issuecomment-2827003383 Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 13161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] kvm: fix disk controller for secure boot vm [cloudstack]

2025-04-24 Thread via GitHub
blueorangutan commented on PR #10213: URL: https://github.com/apache/cloudstack/pull/10213#issuecomment-2826786153 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] kvm: fix disk controller for secure boot vm [cloudstack]

2025-04-24 Thread via GitHub
shwstppr commented on PR #10213: URL: https://github.com/apache/cloudstack/pull/10213#issuecomment-2826781577 @pavanaravapalli @weizhouapache cc @rajujith @vladimirpetrov I've made the behaviour configurable using VM (or template) detail. User/operator can add a VM/template detail - win.ski

Re: [PR] kvm: fix disk controller for secure boot vm [cloudstack]

2025-04-24 Thread via GitHub
github-actions[bot] commented on PR #10213: URL: https://github.com/apache/cloudstack/pull/10213#issuecomment-2826731728 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache

Re: [PR] kvm: fix disk controller for secure boot vm [cloudstack]

2025-01-20 Thread via GitHub
pavanaravapalli commented on code in PR #10213: URL: https://github.com/apache/cloudstack/pull/10213#discussion_r1922711472 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java: ## @@ -3149,11 +3149,7 @@ public int compare(fina

Re: [PR] kvm: fix disk controller for secure boot vm [cloudstack]

2025-01-20 Thread via GitHub
pavanaravapalli commented on code in PR #10213: URL: https://github.com/apache/cloudstack/pull/10213#discussion_r1922711472 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java: ## @@ -3149,11 +3149,7 @@ public int compare(fina

Re: [PR] kvm: fix disk controller for secure boot vm [cloudstack]

2025-01-20 Thread via GitHub
pavanaravapalli commented on code in PR #10213: URL: https://github.com/apache/cloudstack/pull/10213#discussion_r1922711472 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java: ## @@ -3149,11 +3149,7 @@ public int compare(fina

Re: [PR] kvm: fix disk controller for secure boot vm [cloudstack]

2025-01-20 Thread via GitHub
weizhouapache commented on code in PR #10213: URL: https://github.com/apache/cloudstack/pull/10213#discussion_r192223 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java: ## @@ -3149,11 +3149,7 @@ public int compare(final

Re: [PR] kvm: fix disk controller for secure boot vm [cloudstack]

2025-01-20 Thread via GitHub
blueorangutan commented on PR #10213: URL: https://github.com/apache/cloudstack/pull/10213#issuecomment-2602214492 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] kvm: fix disk controller for secure boot vm [cloudstack]

2025-01-20 Thread via GitHub
codecov[bot] commented on PR #10213: URL: https://github.com/apache/cloudstack/pull/10213#issuecomment-2602181550 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10213?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

Re: [PR] kvm: fix disk controller for secure boot vm [cloudstack]

2025-01-20 Thread via GitHub
blueorangutan commented on PR #10213: URL: https://github.com/apache/cloudstack/pull/10213#issuecomment-2602082075 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] kvm: fix disk controller for secure boot vm [cloudstack]

2025-01-20 Thread via GitHub
shwstppr commented on PR #10213: URL: https://github.com/apache/cloudstack/pull/10213#issuecomment-2602077290 This would fix the issue but not sure if could cause the issue of disks not being identified when virtio drivers are not installed. Maybe we can add some documentation. ping @pavana

[PR] kvm: fix disk controller for secure boot vm [cloudstack]

2025-01-20 Thread via GitHub
shwstppr opened a new pull request, #10213: URL: https://github.com/apache/cloudstack/pull/10213 ### Description Fixes #9460 ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking c