weizhouapache commented on code in PR #10213:
URL: https://github.com/apache/cloudstack/pull/10213#discussion_r1922333323
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -3149,11 +3149,7 @@ public int compare(final DiskTO arg0, final DiskTO arg1)
{
if (volume.getType() == Volume.Type.DATADISK &&
!(isWindowsTemplate && isUefiEnabled)) {
disk.defFileBasedDisk(physicalDisk.getPath(), devId,
diskBusTypeData, DiskDef.DiskFmtType.QCOW2);
} else {
- if (isSecureBoot) {
- disk.defFileBasedDisk(physicalDisk.getPath(),
devId, DiskDef.DiskFmtType.QCOW2, isWindowsTemplate);
- } else {
- disk.defFileBasedDisk(physicalDisk.getPath(),
devId, diskBusType, DiskDef.DiskFmtType.QCOW2);
- }
+ disk.defFileBasedDisk(physicalDisk.getPath(), devId,
diskBusType, DiskDef.DiskFmtType.QCOW2);
Review Comment:
for DATADISK, should it use `diskBusTypeData` instead ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
