Re: [PR] add compute offering details in UI [cloudstack]

2024-02-08 Thread via GitHub
rohityadavcloud merged PR #8563: URL: https://github.com/apache/cloudstack/pull/8563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] add compute offering details in UI [cloudstack]

2024-01-25 Thread via GitHub
JoaoJandre commented on PR #8563: URL: https://github.com/apache/cloudstack/pull/8563#issuecomment-1910339953 > @JoaoJandre don't see why this wouldn't work on 4.18.2 as welll. Let me know if you want me to backport. As 4.18.2 is aimed at bugfixes/security patches, I don't think that

Re: [PR] add compute offering details in UI [cloudstack]

2024-01-24 Thread via GitHub
blueorangutan commented on PR #8563: URL: https://github.com/apache/cloudstack/pull/8563#issuecomment-1908360086 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8563 (QA-JID-269) -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] add compute offering details in UI [cloudstack]

2024-01-24 Thread via GitHub
DaanHoogland commented on PR #8563: URL: https://github.com/apache/cloudstack/pull/8563#issuecomment-1908331471 @JoaoJandre don't see why this wouldn't work on 4.18.2 as welll. Let me know if you want me to backport. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] add compute offering details in UI [cloudstack]

2024-01-24 Thread via GitHub
blueorangutan commented on PR #8563: URL: https://github.com/apache/cloudstack/pull/8563#issuecomment-1908330873 @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] add compute offering details in UI [cloudstack]

2024-01-24 Thread via GitHub
DaanHoogland commented on PR #8563: URL: https://github.com/apache/cloudstack/pull/8563#issuecomment-1908330034 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] add compute offering details in UI [cloudstack]

2024-01-24 Thread via GitHub
Pearl1594 commented on code in PR #8563: URL: https://github.com/apache/cloudstack/pull/8563#discussion_r1465030956 ## ui/src/components/view/DetailsTab.vue: ## @@ -91,6 +91,18 @@ + +{{ dataResource.serviceofferingd

Re: [PR] add compute offering details in UI [cloudstack]

2024-01-24 Thread via GitHub
DaanHoogland commented on PR #8563: URL: https://github.com/apache/cloudstack/pull/8563#issuecomment-1908270132 :-1: from myself, the titles are visible when the fields are empty. That needs to be remedied. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] add compute offering details in UI [cloudstack]

2024-01-24 Thread via GitHub
codecov[bot] commented on PR #8563: URL: https://github.com/apache/cloudstack/pull/8563#issuecomment-1908227301 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] add compute offering details in UI [cloudstack]

2024-01-24 Thread via GitHub
DaanHoogland commented on PR #8563: URL: https://github.com/apache/cloudstack/pull/8563#issuecomment-1908207676 @Pearl1594 I implemented your design but I feel I need to generalise it a bit more. Any advice appreciated. -- This is an automated message from the Apache Git Service. To respo

[PR] add compute offering details in UI [cloudstack]

2024-01-24 Thread via GitHub
DaanHoogland opened a new pull request, #8563: URL: https://github.com/apache/cloudstack/pull/8563 ### Description This PR... Fixes: #8537 ### Types of changes - [ ] Breaking change (fix or feature that would cause existi