Pearl1594 commented on code in PR #8563:
URL: https://github.com/apache/cloudstack/pull/8563#discussion_r1465030956
##########
ui/src/components/view/DetailsTab.vue:
##########
@@ -91,6 +91,18 @@
</span>
</div>
</div>
+ <div v-else-if="$route.meta.name === 'computeoffering' && item ===
'mincpunumber' && dataResource.serviceofferingdetails">
+ {{ dataResource.serviceofferingdetails.mincpunumber }}
+ </div>
+ <div v-else-if="$route.meta.name === 'computeoffering' && item ===
'maxcpunumber' && dataResource.serviceofferingdetails">
+ {{ dataResource.serviceofferingdetails.maxcpunumber }}
+ </div>
+ <div v-else-if="$route.meta.name === 'computeoffering' && item ===
'minmemory' && dataResource.serviceofferingdetails">
+ {{ dataResource.serviceofferingdetails.minmemory }}
+ </div>
+ <div v-else-if="$route.meta.name === 'computeoffering' && item ===
'maxmemory' && dataResource.serviceofferingdetails">
+ {{ dataResource.serviceofferingdetails.maxmemory }}
+ </div>
Review Comment:
Could be reduced to
```suggestion
<div v-else-if="$route.meta.name === 'computeoffering' &&
nestedDetails.includes(item)">
{{ dataResource.serviceofferingdetails[item] }}
</div>
```
##########
ui/src/config/section/offering.js:
##########
@@ -47,6 +47,22 @@ export default {
store.getters.apis.createServiceOffering.params.filter(x => x.name
=== 'rootdisksize').length > 0) {
fields.splice(12, 0, 'rootdisksize')
}
+ if (store.getters.apis.createServiceOffering &&
+ store.getters.apis.createServiceOffering.params.filter(x => x.name
=== 'mincpunumber').length > 0) {
+ fields.push('mincpunumber')
+ }
+ if (store.getters.apis.createServiceOffering &&
+ store.getters.apis.createServiceOffering.params.filter(x => x.name
=== 'maxcpunumber').length > 0) {
+ fields.push('maxcpunumber')
+ }
+ if (store.getters.apis.createServiceOffering &&
+ store.getters.apis.createServiceOffering.params.filter(x => x.name
=== 'minmemory').length > 0) {
+ fields.push('minmemory')
+ }
+ if (store.getters.apis.createServiceOffering &&
+ store.getters.apis.createServiceOffering.params.filter(x => x.name
=== 'maxmemory').length > 0) {
+ fields.push('maxmemory')
+ }
Review Comment:
```suggestion
const detailFields = ['minmemory', 'maxmemory', 'mincpunumber',
'maxcpunumber']
for (const field of detailFields) {
if (store.getters.apis.createServiceOffering &&
store.getters.apis.createServiceOffering.params.filter(x =>
field === x.name).length > 0) {
fields.push(field)
}
}
```
##########
ui/src/components/view/DetailsTab.vue:
##########
@@ -37,7 +37,7 @@
size="small"
:dataSource="fetchDetails()">
<template #renderItem="{item}">
- <a-list-item v-if="item in dataResource &&
!customDisplayItems.includes(item)">
+ <a-list-item v-if="item in dataResource &&
!customDisplayItems.includes(item) || offeringDetails.includes(item)">
Review Comment:
```suggestion
<<a-list-item v-if="(item in dataResource &&
!customDisplayItems.includes(item)) || (nestedDetails.includes(item) &&
dataResource.serviceofferingdetails)">
```
To prevent the header to be listed in offerings that don't have these params
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
