Re: [PR] StorPool: fix of delete snapshot [cloudstack]

2024-11-04 Thread via GitHub
JoaoJandre merged PR #9855: URL: https://github.com/apache/cloudstack/pull/9855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@clou

Re: [PR] StorPool: fix of delete snapshot [cloudstack]

2024-11-01 Thread via GitHub
blueorangutan commented on PR #9855: URL: https://github.com/apache/cloudstack/pull/9855#issuecomment-2452849016 [SF] Trillian test result (tid-11733) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 53361 seconds Marvin logs: https://github.com/

Re: [PR] StorPool: fix of delete snapshot [cloudstack]

2024-10-30 Thread via GitHub
slavkap commented on code in PR #9855: URL: https://github.com/apache/cloudstack/pull/9855#discussion_r1822667046 ## plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/snapshot/StorPoolSnapshotStrategy.java: ## @@ -117,10 +116,11 @@ public boolean delete

Re: [PR] StorPool: fix of delete snapshot [cloudstack]

2024-10-30 Thread via GitHub
sureshanaparti commented on code in PR #9855: URL: https://github.com/apache/cloudstack/pull/9855#discussion_r1822475183 ## plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/snapshot/StorPoolSnapshotStrategy.java: ## @@ -117,10 +116,11 @@ public boolean

Re: [PR] StorPool: fix of delete snapshot [cloudstack]

2024-10-29 Thread via GitHub
blueorangutan commented on PR #9855: URL: https://github.com/apache/cloudstack/pull/9855#issuecomment-2444699747 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] StorPool: fix of delete snapshot [cloudstack]

2024-10-29 Thread via GitHub
DaanHoogland commented on PR #9855: URL: https://github.com/apache/cloudstack/pull/9855#issuecomment-2444693741 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] StorPool: fix of delete snapshot [cloudstack]

2024-10-29 Thread via GitHub
blueorangutan commented on PR #9855: URL: https://github.com/apache/cloudstack/pull/9855#issuecomment-2444645838 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] StorPool: fix of delete snapshot [cloudstack]

2024-10-29 Thread via GitHub
JoaoJandre commented on PR #9855: URL: https://github.com/apache/cloudstack/pull/9855#issuecomment-215156 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] StorPool: fix of delete snapshot [cloudstack]

2024-10-29 Thread via GitHub
blueorangutan commented on PR #9855: URL: https://github.com/apache/cloudstack/pull/9855#issuecomment-216753 @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] StorPool: fix of delete snapshot [cloudstack]

2024-10-28 Thread via GitHub
slavkap commented on code in PR #9855: URL: https://github.com/apache/cloudstack/pull/9855#discussion_r1819380312 ## plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/snapshot/StorPoolSnapshotStrategy.java: ## @@ -16,11 +16,19 @@ // under the License.

Re: [PR] StorPool: fix of delete snapshot [cloudstack]

2024-10-28 Thread via GitHub
DaanHoogland commented on code in PR #9855: URL: https://github.com/apache/cloudstack/pull/9855#discussion_r1819338247 ## plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/snapshot/StorPoolSnapshotStrategy.java: ## @@ -16,11 +16,19 @@ // under the Lice

Re: [PR] StorPool: fix of delete snapshot [cloudstack]

2024-10-25 Thread via GitHub
slavkap commented on PR #9855: URL: https://github.com/apache/cloudstack/pull/9855#issuecomment-2438260511 > > Hi @JoaoJandre, is it possible for this to get in 4.20 because it is a bug in the main and RC2? > > Hello @slavkap, sure, since we are waiting other fixes to have the RC3, we

Re: [PR] StorPool: fix of delete snapshot [cloudstack]

2024-10-25 Thread via GitHub
JoaoJandre commented on PR #9855: URL: https://github.com/apache/cloudstack/pull/9855#issuecomment-2437684907 > Hi @JoaoJandre, is it possible for this to get in 4.20 because it is a bug in the main and RC2? Hello @slavkap, sure, since we are waiting other fixes to have the RC3, we c

Re: [PR] StorPool: fix of delete snapshot [cloudstack]

2024-10-25 Thread via GitHub
JoaoJandre commented on code in PR #9855: URL: https://github.com/apache/cloudstack/pull/9855#discussion_r1816616222 ## plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/snapshot/StorPoolSnapshotStrategy.java: ## @@ -129,15 +128,22 @@ public boolean del

Re: [PR] StorPool: fix of delete snapshot [cloudstack]

2024-10-25 Thread via GitHub
slavkap commented on PR #9855: URL: https://github.com/apache/cloudstack/pull/9855#issuecomment-2437659863 Hi @JoaoJandre, is it possible for this to get in 4.20 because it is a bug in the main? -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] StorPool: fix of delete snapshot [cloudstack]

2024-10-25 Thread via GitHub
codecov[bot] commented on PR #9855: URL: https://github.com/apache/cloudstack/pull/9855#issuecomment-2437341915 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9855?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] StorPool: fix of delete snapshot [cloudstack]

2024-10-25 Thread via GitHub
slavkap opened a new pull request, #9855: URL: https://github.com/apache/cloudstack/pull/9855 ### Description This PR fixes the deletion of StorPool snapshots. When a snapshot is deleted, it isn't marked in the DB as such, so when listing the snapshots, the already deleted ones show