Re: [PR] NSX: Make LB service selectable in network offering [cloudstack]

2024-01-16 Thread via GitHub
Pearl1594 merged PR #8512: URL: https://github.com/apache/cloudstack/pull/8512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloud

Re: [PR] NSX: Make LB service selectable in network offering [cloudstack]

2024-01-16 Thread via GitHub
blueorangutan commented on PR #8512: URL: https://github.com/apache/cloudstack/pull/8512#issuecomment-1893919373 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8336 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] NSX: Make LB service selectable in network offering [cloudstack]

2024-01-16 Thread via GitHub
blueorangutan commented on PR #8512: URL: https://github.com/apache/cloudstack/pull/8512#issuecomment-1893733211 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] NSX: Make LB service selectable in network offering [cloudstack]

2024-01-16 Thread via GitHub
nvazquez commented on PR #8512: URL: https://github.com/apache/cloudstack/pull/8512#issuecomment-1893730378 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] NSX: Make LB service selectable in network offering [cloudstack]

2024-01-16 Thread via GitHub
Pearl1594 commented on code in PR #8512: URL: https://github.com/apache/cloudstack/pull/8512#discussion_r1453377047 ## api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java: ## @@ -154,6 +154,12 @@ public class CreateNetworkOfferingCmd e

Re: [PR] NSX: Make LB service selectable in network offering [cloudstack]

2024-01-16 Thread via GitHub
nvazquez commented on code in PR #8512: URL: https://github.com/apache/cloudstack/pull/8512#discussion_r1453364912 ## ui/src/views/offering/AddVpcOffering.vue: ## @@ -76,10 +76,20 @@ + Review Comment: Commented row #

Re: [PR] NSX: Make LB service selectable in network offering [cloudstack]

2024-01-15 Thread via GitHub
sureshanaparti commented on code in PR #8512: URL: https://github.com/apache/cloudstack/pull/8512#discussion_r1452919369 ## api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java: ## @@ -154,6 +154,12 @@ public class CreateNetworkOffering

Re: [PR] NSX: Make LB service selectable in network offering [cloudstack]

2024-01-15 Thread via GitHub
blueorangutan commented on PR #8512: URL: https://github.com/apache/cloudstack/pull/8512#issuecomment-1892941848 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8325 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] NSX: Make LB service selectable in network offering [cloudstack]

2024-01-15 Thread via GitHub
blueorangutan commented on PR #8512: URL: https://github.com/apache/cloudstack/pull/8512#issuecomment-1892900035 @Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] NSX: Make LB service selectable in network offering [cloudstack]

2024-01-15 Thread via GitHub
Pearl1594 commented on PR #8512: URL: https://github.com/apache/cloudstack/pull/8512#issuecomment-1892899692 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] NSX: Make LB service selectable in network offering [cloudstack]

2024-01-15 Thread via GitHub
codecov[bot] commented on PR #8512: URL: https://github.com/apache/cloudstack/pull/8512#issuecomment-1892895960 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8512?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

[PR] NSX: Make LB service selectable in network offering [cloudstack]

2024-01-15 Thread via GitHub
Pearl1594 opened a new pull request, #8512: URL: https://github.com/apache/cloudstack/pull/8512 ### Description This PR... ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionali