nvazquez commented on code in PR #8512:
URL: https://github.com/apache/cloudstack/pull/8512#discussion_r1453364912


##########
ui/src/views/offering/AddVpcOffering.vue:
##########
@@ -76,10 +76,20 @@
               <a-switch v-model:checked="form.fornsx" @change="val => { 
handleForNsxChange(val) }" />
             </a-form-item>
           </a-col>
+          <!-- <a-row :gutter="1" v-if="forNsx"> -->

Review Comment:
   Commented row



##########
api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java:
##########
@@ -294,6 +302,10 @@ public String getNsxMode() {
         return nsxMode;
     }
 
+    public Boolean getNsxSupportsLbService() {

Review Comment:
   I think we can simplify the usages of this method by making it return a 
boolen instead of Boolean



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to