Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

DaanHoogland merged PR #9209: URL: https://github.com/apache/cloudstack/pull/9209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

blueorangutan commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-216870 [SF] Trillian test result (tid-10442) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47866 seconds Marvin logs: https://github.co

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

blueorangutan commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2167322511 @harikrishna-patnala a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Servic

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

harikrishna-patnala commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2167320313 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

blueorangutan commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2165726678 [SF] Trillian test result (tid-10433) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 617 seconds Marvin logs: https://github.com/

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

blueorangutan commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2165626651 @kiranchavala a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

kiranchavala commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2165625559 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

blueorangutan commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2165201825 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9923 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

blueorangutan commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2165231355 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make p

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

blueorangutan commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2165365604 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9926 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

harikrishna-patnala commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2165225189 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

blueorangutan commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2165116963 @kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

kiranchavala commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2165114826 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

blueorangutan commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2165068663 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9920 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

blueorangutan commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2164881899 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make p

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

harikrishna-patnala commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2164874285 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

harikrishna-patnala commented on code in PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#discussion_r1636277636 ## engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java: ## @@ -2794,6 +2799,16 @@ public void checkAndRepairV

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

blueorangutan commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2162732256 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9893 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

sureshanaparti commented on code in PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#discussion_r1636140359 ## engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java: ## @@ -2794,6 +2799,16 @@ public void checkAndRepairVolume

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

blueorangutan commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2162546259 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make p

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

harikrishna-patnala commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2162542862 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

blueorangutan commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2162259625 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make p

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

harikrishna-patnala commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2162257510 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

harikrishna-patnala commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2162254011 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

harikrishna-patnala commented on code in PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#discussion_r1635907580 ## server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java: ## @@ -2235,6 +2236,12 @@ private void setNewIopsLimits(VolumeVO volume, DiskOfferi

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

harikrishna-patnala commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2162241741 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

sureshanaparti commented on code in PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#discussion_r1635814568 ## server/src/main/java/com/cloud/vm/UserVmManagerImpl.java: ## @@ -2120,7 +2120,7 @@ protected void validateDiskOfferingChecks(ServiceOfferingVO currentServ

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

sureshanaparti commented on code in PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#discussion_r1635815152 ## server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java: ## @@ -2235,6 +2236,12 @@ private void setNewIopsLimits(VolumeVO volume, DiskOfferingVO

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

sureshanaparti commented on code in PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#discussion_r1635814568 ## server/src/main/java/com/cloud/vm/UserVmManagerImpl.java: ## @@ -2120,7 +2120,7 @@ protected void validateDiskOfferingChecks(ServiceOfferingVO currentServ

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

blueorangutan commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2159876619 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9856 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

codecov[bot] commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2159811824 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9209?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

blueorangutan commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2159805539 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make p

[PR] Add volume encryption checks during the disk offering change [cloudstack]

harikrishna-patnala opened a new pull request, #9209: URL: https://github.com/apache/cloudstack/pull/9209 ### Description This PR fixes the issue #9190 Encryption type change is not allowed for the root volume during the scaleVM and upgradeVM operations. Same check should be m

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

harikrishna-patnala commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2159803810 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s