sureshanaparti commented on code in PR #9209:
URL: https://github.com/apache/cloudstack/pull/9209#discussion_r1635814568
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -2120,7 +2120,7 @@ protected void
validateDiskOfferingChecks(ServiceOfferingVO currentServiceOfferi
DiskOfferingVO newRootDiskOffering =
_diskOfferingDao.findById(newServiceOffering.getDiskOfferingId());
if (currentRootDiskOffering.getEncrypt() !=
newRootDiskOffering.getEncrypt()) {
- throw new InvalidParameterValueException("Cannot change volume
encryption type via service offering change");
+ throw new InvalidParameterValueException("Cannot change the
encryption type of a volume, please check the selected compute offering");
Review Comment:
use method `volumeService.validateChangeDiskOffering(...)` - will be single
point for validation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
