Re: [PR] Add support for network data in Config Drive [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #9329: URL: https://github.com/apache/cloudstack/pull/9329#issuecomment-2294528650 [SF] Trillian test result (tid-11091) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 57487 seconds Marvin logs: https://github.com/

Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2294511183 [SF] Trillian test result (tid-11090) Environment: xcpng82 (x2), Advanced Networking with Mgmt server a9 Total time taken: 63180 seconds Marvin logs: https://github.com/b

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2294510468 [SF] Trillian test result (tid-11094) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 52183 seconds Marvin logs: https://github.com/

Re: [PR] Fix `deleteAccount` API to prevent deletion of the caller [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #8743: URL: https://github.com/apache/cloudstack/pull/8743#issuecomment-2294456415 [SF] Trillian test result (tid-11093) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 48843 seconds Marvin logs: https://github.com/

Re: [PR] linstor: Improve copyPhysicalDisk performance [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #9417: URL: https://github.com/apache/cloudstack/pull/9417#issuecomment-2294425469 [SF] Trillian test result (tid-11092) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 47016 seconds Marvin logs: https://github.com/

Re: [PR] Fix NPE when sending copy command to least busy SSVM [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #9125: URL: https://github.com/apache/cloudstack/pull/9125#issuecomment-2294410651 [LL]Trillian test result (tid-6967) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 51941 seconds Marvin logs: https://github.com/

Re: [PR] Fix usage volume size after resizing [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #9459: URL: https://github.com/apache/cloudstack/pull/9459#issuecomment-2294344974 [SF] Trillian test result (tid-11086) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 53564 seconds Marvin logs: https://github.com/

Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2294255700 [SF] Trillian test result (tid-11089) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 47592 seconds Marvin logs: https://github.

Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2294225049 [SF] Trillian test result (tid-11087) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 46550 seconds Marvin logs: https://github.com/

Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #9316: URL: https://github.com/apache/cloudstack/pull/9316#issuecomment-2294149177 [SF] Trillian test result (tid-11082) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 53650 seconds Marvin logs: https://github.com/

Re: [PR] Enhance the `listAffinityGroups` API by adding the dedicated resources related to an affinity group [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #9188: URL: https://github.com/apache/cloudstack/pull/9188#issuecomment-2293906603 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] KVM incremental snapshot feature [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#issuecomment-2293839674 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Enhance the `listAffinityGroups` API by adding the dedicated resources related to an affinity group [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #9188: URL: https://github.com/apache/cloudstack/pull/9188#issuecomment-2293807956 @bernardodemarco a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progr

Re: [PR] Enhance the `listAffinityGroups` API by adding the dedicated resources related to an affinity group [cloudstack]

2024-08-16 Thread via GitHub
bernardodemarco commented on PR #9188: URL: https://github.com/apache/cloudstack/pull/9188#issuecomment-2293806029 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] KVM incremental snapshot feature [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#issuecomment-2293736061 @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] KVM incremental snapshot feature [cloudstack]

2024-08-16 Thread via GitHub
JoaoJandre commented on PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#issuecomment-2293735442 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Add logs to `LibvirtComputingResource`'s metrics collection process [cloudstack]

2024-08-16 Thread via GitHub
winterhazel commented on PR #8511: URL: https://github.com/apache/cloudstack/pull/8511#issuecomment-2293609158 @DaanHoogland could we rerun the CI here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] NSX Integration fixes [cloudstack]

2024-08-16 Thread via GitHub
Pearl1594 commented on PR #8906: URL: https://github.com/apache/cloudstack/pull/8906#issuecomment-2293602668 @nvazquez this is good to be reviewed and merged - I have added the fix for the test failures wrt host affinity - not sure why it was failing on this PR - its unrelated to the change

(cloudstack-www) branch main updated (5b0034f0b -> f63bbf798)

2024-08-16 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from 5b0034f0b center button add a230558e3 add a billing integrations tab (#226) add f63bbf798 linkage and wh

(cloudstack-www) branch staging-site updated: linkage and whitespace fixes in events (#227)

2024-08-16 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch staging-site in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git The following commit(s) were added to refs/heads/staging-site by this push: new f63bbf798 linkage and whitespa

Re: [PR] KVM incremental snapshot feature [cloudstack]

2024-08-16 Thread via GitHub
winterhazel commented on PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#issuecomment-2293559468 > Hi @JoaoJandr Any impact to backup/restore operations on previous (full backup) and incremental (latest backups when the incremental snapshots enabled (using config provided) aft

[I] Error while trying to create a volume from the snapshot that sometimes result in snapshot loss [cloudstack]

2024-08-16 Thread via GitHub
winterhazel opened a new issue, #9538: URL: https://github.com/apache/cloudstack/issues/9538 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ KVM, Volume Snapshot ~~~ # CLOUDSTACK VERSION ~~~ 4.19.1.0 ~~~ # CONFI

Re: [PR] Download Volume Snapshots [cloudstack]

2024-08-16 Thread via GitHub
JoaoJandre commented on PR #8878: URL: https://github.com/apache/cloudstack/pull/8878#issuecomment-2293542435 @DaanHoogland could we run the CI here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] UI: Notify users when upgrades are available or restart is required [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #7610: URL: https://github.com/apache/cloudstack/pull/7610#issuecomment-2293523978 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

(cloudstack-www) branch staging-site updated: add a billing integrations tab (#226)

2024-08-16 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch staging-site in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git The following commit(s) were added to refs/heads/staging-site by this push: new a230558e3 add a billing integr

Re: [PR] KVM incremental snapshot feature [cloudstack]

2024-08-16 Thread via GitHub
JoaoJandre commented on code in PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#discussion_r1719814697 ## engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java: ## @@ -574,6 +580,11 @@ public VolumeInfo createVolumeFr

Re: [PR] KVM incremental snapshot feature [cloudstack]

2024-08-16 Thread via GitHub
JoaoJandre commented on code in PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#discussion_r1719805764 ## server/src/main/java/com/cloud/storage/snapshot/SnapshotManager.java: ## @@ -58,6 +54,12 @@ public interface SnapshotManager extends Configurable { publ

Re: [PR] KVM incremental snapshot feature [cloudstack]

2024-08-16 Thread via GitHub
JoaoJandre commented on code in PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#discussion_r1719803666 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: ## @@ -1849,6 +1858,488 @@ public Answer createSnapshot(final

Re: [PR] UI: Notify users when upgrades are available or restart is required [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #7610: URL: https://github.com/apache/cloudstack/pull/7610#issuecomment-2293412798 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] UI: Notify users when upgrades are available or restart is required [cloudstack]

2024-08-16 Thread via GitHub
vishesh92 commented on PR #7610: URL: https://github.com/apache/cloudstack/pull/7610#issuecomment-2293410787 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-08-16 Thread via GitHub
FelipeM525 commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2293332316 @weizhouapache could you run tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] UI: Show applied search filters [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #9520: URL: https://github.com/apache/cloudstack/pull/9520#issuecomment-2293274249 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-423) -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] UI: Show applied search filters [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #9520: URL: https://github.com/apache/cloudstack/pull/9520#issuecomment-2293250862 @vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] UI: Show applied search filters [cloudstack]

2024-08-16 Thread via GitHub
vishesh92 commented on PR #9520: URL: https://github.com/apache/cloudstack/pull/9520#issuecomment-2293249084 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] UI: Show applied search filters [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #9520: URL: https://github.com/apache/cloudstack/pull/9520#issuecomment-2293206788 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-422) -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2293204849 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

2024-08-16 Thread via GitHub
DaanHoogland commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2293202682 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] UI: Show applied search filters [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #9520: URL: https://github.com/apache/cloudstack/pull/9520#issuecomment-2293181299 @vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] UI: Show applied search filters [cloudstack]

2024-08-16 Thread via GitHub
vishesh92 commented on PR #9520: URL: https://github.com/apache/cloudstack/pull/9520#issuecomment-2293180504 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2293173684 [LL] Trillian Build Failed (tid-6968) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2293169672 @DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] Fix `deleteAccount` API to prevent deletion of the caller [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #8743: URL: https://github.com/apache/cloudstack/pull/8743#issuecomment-2293169696 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

2024-08-16 Thread via GitHub
DaanHoogland commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2293167667 @blueorangutan LLtest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix `deleteAccount` API to prevent deletion of the caller [cloudstack]

2024-08-16 Thread via GitHub
DaanHoogland commented on PR #8743: URL: https://github.com/apache/cloudstack/pull/8743#issuecomment-2293166854 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Add support for network data in Config Drive [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #9329: URL: https://github.com/apache/cloudstack/pull/9329#issuecomment-2293134893 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] UI: Show applied search filters [cloudstack]

2024-08-16 Thread via GitHub
sureshanaparti commented on PR #9520: URL: https://github.com/apache/cloudstack/pull/9520#issuecomment-2293099377 **Search message not in sync with filters =>** https://github.com/user-attachments/assets/bc473818-7a8b-403a-a124-1d229f5ae172";> could not find account admin in dom

Re: [PR] UI: Show applied search filters [cloudstack]

2024-08-16 Thread via GitHub
sureshanaparti commented on code in PR #9520: URL: https://github.com/apache/cloudstack/pull/9520#discussion_r1719544437 ## ui/src/components/view/SearchFilter.vue: ## @@ -0,0 +1,619 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licens

Re: [PR] KVM incremental snapshot feature [cloudstack]

2024-08-16 Thread via GitHub
sureshanaparti commented on PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#issuecomment-2293072369 Hi @JoaoJandr Any impact to backup/restore operations on previous (full backup) and incremental (latest backups when the incremental snapshots enabled (using config provided) af

Re: [PR] KVM incremental snapshot feature [cloudstack]

2024-08-16 Thread via GitHub
sureshanaparti commented on code in PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#discussion_r1719525913 ## server/src/main/java/com/cloud/storage/snapshot/SnapshotManager.java: ## @@ -58,6 +54,12 @@ public interface SnapshotManager extends Configurable {

Re: [PR] KVM incremental snapshot feature [cloudstack]

2024-08-16 Thread via GitHub
sureshanaparti commented on code in PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#discussion_r1719525913 ## server/src/main/java/com/cloud/storage/snapshot/SnapshotManager.java: ## @@ -58,6 +54,12 @@ public interface SnapshotManager extends Configurable {

Re: [PR] KVM incremental snapshot feature [cloudstack]

2024-08-16 Thread via GitHub
sureshanaparti commented on code in PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#discussion_r1719518417 ## agent/src/main/java/com/cloud/agent/properties/AgentProperties.java: ## @@ -810,6 +810,16 @@ public Property getWorkers() { */ public static fin

Re: [PR] UI: Show applied search filters [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #9520: URL: https://github.com/apache/cloudstack/pull/9520#issuecomment-2293034910 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-421) -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Add support for network data in Config Drive [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #9329: URL: https://github.com/apache/cloudstack/pull/9329#issuecomment-2293017623 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Add support for network data in Config Drive [cloudstack]

2024-08-16 Thread via GitHub
vishesh92 commented on PR #9329: URL: https://github.com/apache/cloudstack/pull/9329#issuecomment-2293016067 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] UI: Show applied search filters [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #9520: URL: https://github.com/apache/cloudstack/pull/9520#issuecomment-2293011124 @vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Storage Filesystem as a First Class Feature [cloudstack]

2024-08-16 Thread via GitHub
github-actions[bot] commented on PR #9208: URL: https://github.com/apache/cloudstack/pull/9208#issuecomment-2293009872 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [PR] Enhance the `listAffinityGroups` API by adding the dedicated resources related to an affinity group [cloudstack]

2024-08-16 Thread via GitHub
github-actions[bot] commented on PR #9188: URL: https://github.com/apache/cloudstack/pull/9188#issuecomment-2293009819 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [PR] UI: Notify users when upgrades are available or restart is required [cloudstack]

2024-08-16 Thread via GitHub
github-actions[bot] commented on PR #7610: URL: https://github.com/apache/cloudstack/pull/7610#issuecomment-2293009787 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [PR] UI: Show applied search filters [cloudstack]

2024-08-16 Thread via GitHub
vishesh92 commented on PR #9520: URL: https://github.com/apache/cloudstack/pull/9520#issuecomment-2293009798 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2293000446 [SF] Trillian Build Failed (tid-11088) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Fix NPE when sending copy command to least busy SSVM [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #9125: URL: https://github.com/apache/cloudstack/pull/9125#issuecomment-2292998643 @DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] Fix NPE when sending copy command to least busy SSVM [cloudstack]

2024-08-16 Thread via GitHub
DaanHoogland commented on PR #9125: URL: https://github.com/apache/cloudstack/pull/9125#issuecomment-2292996142 @blueorangutan LLtest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Api keypair restructure [cloudstack]

2024-08-16 Thread via GitHub
DaanHoogland commented on PR #9504: URL: https://github.com/apache/cloudstack/pull/9504#issuecomment-2292994074 > It would make sense to be able to delete a keypair by name, we would just need to block users from creating multiple API keypairs with the same name. Well, I think a uniqu

Re: [PR] NSX Integration fixes [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #8906: URL: https://github.com/apache/cloudstack/pull/8906#issuecomment-2292994931 [SF] Trillian test result (tid-11081) Environment: xcpng82 (x2), Advanced Networking with Mgmt server a9 Total time taken: 67275 seconds Marvin logs: https://github.com/b

Re: [PR] Allow deploy of VRs on dedicated resources [cloudstack]

2024-08-16 Thread via GitHub
DaanHoogland commented on code in PR #9531: URL: https://github.com/apache/cloudstack/pull/9531#discussion_r1719469109 ## engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDao.java: ## @@ -24,8 +24,13 @@ import com.cloud.utils.Pair; import com.cloud.utils.Ternary; im

Re: [I] Invalid local primary storage can be created [cloudstack]

2024-08-16 Thread via GitHub
DaanHoogland commented on issue #9536: URL: https://github.com/apache/cloudstack/issues/9536#issuecomment-2292970512 @rajujith , I don't think this is a bug. It is operator responsibility to make sure the path is there and they may plan their order of actions at will. Restricting this seems

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2292967071 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Fix `deleteAccount` API to prevent deletion of the caller [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #8743: URL: https://github.com/apache/cloudstack/pull/8743#issuecomment-2292967069 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2024-08-16 Thread via GitHub
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2292950462 @DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke

Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2024-08-16 Thread via GitHub
DaanHoogland commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2292947919 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] adding KVM primary disk for a host is not possible from UI [cloudstack]

2024-08-16 Thread via GitHub
dredknight commented on issue #9533: URL: https://github.com/apache/cloudstack/issues/9533#issuecomment-2292942091 Thank you @rajujith! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi